| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 04:01 |
|---|---|---|
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix intermittent Redfish firmware update failures with BMC validation https://review.opendev.org/c/openstack/ironic/+/960230 | 04:17 |
| rpittau | good morning ironic! o/ | 07:20 |
| opendevreview | Merged openstack/bifrost master: Add support for Rocky Linux 10 image download https://review.opendev.org/c/openstack/bifrost/+/962575 | 09:48 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:21 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:23 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:30 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:38 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:43 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:45 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Make cache_firmware_components more resilient during upgrades https://review.opendev.org/c/openstack/ironic/+/960711 | 10:47 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix power sync timeouts after BMC firmware update https://review.opendev.org/c/openstack/ironic/+/962560 | 10:47 |
| alegacy_ | Could someone spare a couple of minutes to point out what I'm missing here. The openstack-tox-pep8 job is reported as failed on this change (https://review.opendev.org/c/openstack/ironic/+/962493) but for the life of me I can't see anything related to my change. | 11:46 |
| alegacy_ | All errors seems like they are pre-existing, and I get those same errors when I run "tox -e pep8" locally with or without any of my changes. | 11:46 |
| alegacy_ | ...including if I run "tox -epep8" on some of my previous changes that passed on Zuul jobs | 11:47 |
| iurygregory | alegacy_, checking | 12:11 |
| iurygregory | let me try to run locally with and without or patch | 12:11 |
| opendevreview | Pierre Riteau proposed openstack/bifrost stable/2025.2: Add support for Rocky Linux 10 image download https://review.opendev.org/c/openstack/bifrost/+/962926 | 12:14 |
| alegacy_ | iurygregory: thanks... even if I run "tox -epep8" off of master I get what looks like those same errors. | 12:15 |
| iurygregory | I'm updating my venv to 3.12 | 12:16 |
| iurygregory | I was using 3.11 :X | 12:16 |
| rpittau | alegacy_: I'm not getting any error with pep8 running locally on master, while I'm getting errors running with your patch | 12:35 |
| rpittau | the errors are related to bandit, I think you need to revisit some choices in your patch based on the bandit output | 12:35 |
| alegacy_ | rpittau: thanks. that's strange... the pre-commit run doesn't flag anything and the tox pep8 reports a bunch of these with or without my change: "Issue: [B108:hardcoded_tmp_directory] Probable insecure usage of temp file/directory" | 12:37 |
| rpittau | alegacy_: that's a bandit error, you need to change the code based on that | 12:38 |
| alegacy_ | rpittau: ... I get those same errors on master! :-) | 12:40 |
| rpittau | alegacy_: not me, you probably need to rebuild your venv or runn tox with the recreate flag | 12:41 |
| alegacy_ | rpittau: tried with --recreate, tried with removing the ".tox" directory... no change. re-cloned the repo and it is happy now on master! must have been some garbage somewhere. | 12:51 |
| rpittau | good :) | 12:52 |
| alegacy_ | rpittau: thank you | 12:52 |
| rpittau | np! | 12:52 |
| TheJulia | good morning | 13:12 |
| TheJulia | updated hacking/flake8 rules? | 13:12 |
| alegacy_ | TheJulia: no, no changes to any of the rules... still not sure what I've done to cause it to complain about a bunch of unrelated code. | 13:27 |
| TheJulia | sorry, having to write a primer for some folks who seem to be unwilling to do a little research and read a few links I've sent them :( | 13:32 |
| alegacy_ | ok, i think I got it fixed. | 13:39 |
| alegacy_ | it would seem my IDE took some liberties in where it put some of my test files and put some under tests/unit instead of ironic/tests/unit. Not sure why that happen, but after having moved the files to where they should have been pep8/bandit is now passing. | 13:40 |
| alegacy_ | ... Fridays! | 13:40 |
| TheJulia | okay, whut?! | 13:49 |
| * TheJulia returns from writing a primer which shouldn't have been necessary | 13:50 | |
| TheJulia | okay, not able to reproduce locally, whew | 13:52 |
| rpittau | alegacy_: "my IDE took some liberties" sounds scary :D | 13:52 |
| TheJulia | I was worried there for a minute | 13:52 |
| TheJulia | alegacy_: did you take away it's bag of cookies? :) | 13:52 |
| rpittau | lol | 13:52 |
| alegacy_ | I give it all the cookies it wants. I'm not sure it turned on me! | 14:02 |
| alegacy_ | *not sure why...* | 14:02 |
| TheJulia | step away from the ide! :) | 14:02 |
| TheJulia | Surely, there are some IDE wranglers... someplace | 14:03 |
| iurygregory | forgot to reply here, running pep8 on master with py3.12.3 is green =) | 14:10 |
| alegacy_ | iurygregory: thanks! | 14:12 |
| TheJulia | dtantsur: so I think we could just include simple-init. It looks like I never got cloud-init running in ci and it looks like tossed a change up to uninstall it at one point. I remember I did some testing and it worked but I guess we reached consensus not to deal with it or the risk?! | 14:16 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Replace storyboard by launchpad https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/961932 | 14:17 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-tempest-plugin master: Remove useless cover target https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/962940 | 14:43 |
| iurygregory | anyone here is able to find the dell page for the drivers of PowerEdge XR8720t ? | 14:44 |
| iurygregory | I could only find XR8620t | 14:44 |
| opendevreview | Mathieu Parent proposed openstack/ironic-python-agent-builder master: Wait up to 30 seconds for config drive https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/962673 | 15:09 |
| TheJulia | i've added the dhcp-less topic to the etherpad since it seems some discussion is required. | 15:14 |
| opendevreview | Mathieu Parent proposed openstack/ironic-python-agent-builder master: Wait up to 30 seconds for config drive https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/962673 | 15:50 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: disable multi-n-cpu on ironic multinode job https://review.opendev.org/c/openstack/ironic/+/962980 | 15:54 |
| opendevreview | Merged openstack/networking-generic-switch master: Drop ineffective ignore_base_python https://review.opendev.org/c/openstack/networking-generic-switch/+/962796 | 15:55 |
| opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Detect device configuration errors on Dell Force10 and OS10 https://review.opendev.org/c/openstack/networking-generic-switch/+/868318 | 16:22 |
| opendevreview | Merged openstack/sushy master: Add comprehensive PCIe device support to Sushy https://review.opendev.org/c/openstack/sushy/+/961982 | 16:57 |
| TheJulia | JayF: I feel like a lot of the concern on https://review.opendev.org/c/openstack/ironic-python-agent/+/962591 is just the sheer size | 17:17 |
| JayF | well it's a case where | 17:17 |
| JayF | the bugged behavior is more like, not what we intended | 17:17 |
| JayF | rather than WRONG WRONG WRONG | 17:17 |
| JayF | so I feel it may be an unexpected kinda change to backport | 17:18 |
| JayF | regardless of the # of lines | 17:18 |
| JayF | this is the sorta thing I have trouble calling a "bug" tbh, because IDK if it's our bug if we don't have enough guardrails to deal with [random hardware or OS thing we couldn't think of] | 17:18 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2025.1: Allow multiple HTTP redirects for image source https://review.opendev.org/c/openstack/ironic/+/962993 | 17:19 |
| TheJulia | I guess they are led in there through the chance of a keyerror | 17:20 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent-builder master: ci: Remove ironic-inspector related ci job https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/962997 | 17:23 |
| opendevreview | Merged openstack/ironic stable/2025.2: Allow multiple HTTP redirects for image source https://review.opendev.org/c/openstack/ironic/+/962869 | 17:24 |
| opendevreview | Julia Kreger proposed openstack/ironic master: ci: remove tinyipa job alias usage https://review.opendev.org/c/openstack/ironic/+/963001 | 17:45 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: disable multi-n-cpu on ironic multinode job https://review.opendev.org/c/openstack/ironic/+/962980 | 17:52 |
| opendevreview | Merged openstack/ironic master: Drop explicit description about default values https://review.opendev.org/c/openstack/ironic/+/962690 | 18:24 |
| opendevreview | Merged openstack/ironic master: Docs: play down the role of is_root_volume in RAID https://review.opendev.org/c/openstack/ironic/+/962670 | 18:24 |
| iurygregory | TheJulia, slack is down for you? | 19:12 |
| TheJulia | Quite possible | 19:14 |
| TheJulia | Seems like it instantly to out of memory tooo | 19:14 |
| TheJulia | its working now here | 19:19 |
| iurygregory | yeah, it's working again | 19:32 |
| opendevreview | Merged openstack/ironic stable/2024.1: Increase memory allocation for ironic-base https://review.opendev.org/c/openstack/ironic/+/962725 | 19:43 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!