| opendevreview | Merged openstack/ironic master: Enable fake-graphical console for all hardware types https://review.opendev.org/c/openstack/ironic/+/963151 | 00:31 |
|---|---|---|
| cardoe | Well I totally expected to see some failures but I didn’t. | 01:51 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/958316 | 03:39 |
| Abhi123 | Good morning ironic ! | 04:54 |
| rpittau | good morning ironic! o/ | 07:05 |
| himani | good afternoon, ironic!! | 07:11 |
| Ayo[m] | Good morning ironic :) | 08:32 |
| janders | good morning Ironic o/ | 09:48 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/965248 | 09:51 |
| rpittau | hey when someone has a moment can I get a quick review on https://review.opendev.org/c/openstack/bifrost/+/964752 ? we need that to migrate out of tinyipa | 09:52 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/963670 | 09:59 |
| opendevreview | Merged openstack/ironic-specs master: Update standalone networking initial conditions https://review.opendev.org/c/openstack/ironic-specs/+/960550 | 10:25 |
| *** himani is now known as himani-sahu | 10:49 | |
| opendevreview | Verification of a change to openstack/ironic master failed: api: Add schema for inspection rules API (requests) https://review.opendev.org/c/openstack/ironic/+/954039 | 10:51 |
| opendevreview | Merged openstack/ironic master: Add generic redfish compatible vendor name https://review.opendev.org/c/openstack/ironic/+/964877 | 11:16 |
| opendevreview | Merged openstack/ironic master: Increase default sync_power_state_interval https://review.opendev.org/c/openstack/ironic/+/961554 | 11:28 |
| opendevreview | Merged openstack/ironic master: Remove bespoke logic for handling redirects while validating URLs https://review.opendev.org/c/openstack/ironic/+/963485 | 11:28 |
| opendevreview | Merged openstack/ironic master: Fixes for console containers functional testing https://review.opendev.org/c/openstack/ironic/+/963323 | 11:28 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2025.2: Remove bespoke logic for handling redirects while validating URLs https://review.opendev.org/c/openstack/ironic/+/966027 | 11:45 |
| iurygregory | good morning ironic | 11:55 |
| opendevreview | Merged openstack/networking-generic-switch master: fix: segment binding level for VLAN support https://review.opendev.org/c/openstack/networking-generic-switch/+/965948 | 11:57 |
| opendevreview | Merged openstack/ironic-python-agent stable/2025.2: Fix skip block devices for RAID arrays https://review.opendev.org/c/openstack/ironic-python-agent/+/962591 | 12:13 |
| opendevreview | Merged openstack/ironic-python-agent master: Fix for matching hints with lists of strings https://review.opendev.org/c/openstack/ironic-python-agent/+/965797 | 12:13 |
| opendevreview | Morten Stephansen proposed openstack/ironic-python-agent stable/2025.2: Fix for matching hints with lists of strings https://review.opendev.org/c/openstack/ironic-python-agent/+/966031 | 12:26 |
| opendevreview | Morten Stephansen proposed openstack/ironic-python-agent stable/2025.1: Fix for matching hints with lists of strings https://review.opendev.org/c/openstack/ironic-python-agent/+/966032 | 12:30 |
| opendevreview | Morten Stephansen proposed openstack/ironic-python-agent master: Implement functionality for the is_root_volume RAID config https://review.opendev.org/c/openstack/ironic-python-agent/+/963200 | 13:06 |
| opendevreview | Morten Stephansen proposed openstack/ironic-python-agent master: Implement functionality for the is_root_volume RAID config https://review.opendev.org/c/openstack/ironic-python-agent/+/963200 | 13:11 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Use cirros 0.6.1 as default cirros version https://review.opendev.org/c/openstack/bifrost/+/932175 | 13:35 |
| alegacy | JayF: clif: TheJulia: so far most serious comments on my reviews are 1) size, and 2) naming of the network interface. | 14:01 |
| alegacy | For 1), if I split it into 3 chunks (rpc service, network driver, switch driver) would that alleviate some concern? | 14:01 |
| alegacy | For 2) the rational behind using the word "experimental" in the driver name was to allow for dropping it without support if/when we formalize the API away from port.extra | 14:01 |
| alegacy | I'm not tied to the name (standalone-experimental)... maybe just "ironic", or "ironic-rpc"... i'm open to suggestions. #namingisfun | 14:02 |
| dtantsur | alegacy: for (1), that's what we usually do to make it manageable, unless there is way to split it into a more simple feature followed by additions of extras. | 14:02 |
| opendevreview | Merged openstack/ironic master: api: Add schema for inspection rules API (requests) https://review.opendev.org/c/openstack/ironic/+/954039 | 14:03 |
| alegacy | dtantsur: thanks, ok... i'll split into those 3 unless there is a better suggestion. The service will still be large, i'll look for a way to split it one more time. | 14:06 |
| opendevreview | Milan Fencik proposed openstack/sushy master: Handle missing storage controller mode attribute https://review.opendev.org/c/openstack/sushy/+/966072 | 14:10 |
| TheJulia | good morning | 14:12 |
| dtantsur | morning TheJulia | 14:12 |
| clif | from a reviewer's persepective: 10k lines of change represents a huge time commitment | 14:28 |
| clif | to properly review, and honestly I'm going to get tired halfway through and start to rush and skip over things | 14:29 |
| clif | the more chunk-able the better | 14:29 |
| TheJulia | ++ | 14:32 |
| opendevreview | cid proposed openstack/ironic-prometheus-exporter master: Restore `entity_id` label in Redfish/iDRAC metrics https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/966082 | 15:02 |
| cardoe | Did my email reply to the sushy thread ever hit the list? | 15:41 |
| cardoe | clif: so the weird thing is I expect https://review.opendev.org/c/openstack/ironic/+/965985 to fail cause now there's extra data there. | 15:42 |
| cardoe | ah no there's not. we never refresh the portgroup from the DB in the tests so null == null still | 15:43 |
| JayF | sounds like a good reason to update those teses | 15:43 |
| JayF | **tests | 15:43 |
| * JayF pokes john garbutt downstream again to test https://review.opendev.org/c/openstack/ironic/+/964502 (glance checksum bugfix) | 16:35 | |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: 2026.1 Ironic work items https://review.opendev.org/c/openstack/ironic-specs/+/965865 | 16:40 |
| JayF | please also review https://review.opendev.org/c/openstack/ironic-specs/+/965249 | 16:40 |
| TheJulia | JayF: did you see my comments by chance? | 17:21 |
| TheJulia | cardoe: I don't think I've seen a post from you on the ML, at least one hasn't made it past gmail. Did you check the archive? | 17:22 |
| TheJulia | JayF: w/r/t the checksum | 17:22 |
| cardoe | Yeah I didn't see it there either | 17:22 |
| JayF | it matched my findings | 17:27 |
| JayF | and seemed non-actionable? | 17:27 |
| JayF | unless I misunderstood | 17:28 |
| TheJulia | I guess its a regression of the sdk compared with the client library that it doesn't support checksumming downloads with more advanced algos. | 17:31 |
| JayF | I agree | 17:41 |
| JayF | but I don't think that changes the shape of the ironic fix in the interim | 17:41 |
| TheJulia | no, definitely not | 17:42 |
| JayF | if you want me to go back up to openstacksdk, I can look into that | 17:42 |
| TheJulia | nah, not asking you to, just wondering if we have enough consensus to raise a bug there | 17:42 |
| JayF | probably | 17:43 |
| JayF | I'll own that | 17:43 |
| TheJulia | k, thanks | 17:46 |
| TheJulia | cardoe: I feel like https://bugs.launchpad.net/ironic/+bug/2130667 begins to set some of the groundwork for internalizing the support into ironic so you can drop your debug log to message bus to automation logic, that being said I could have sworn I've looked at a machine and saw nvme specific settings exposed. It feels like you might have stumbled upon such, but if we can get more clarity out there then it might be | 18:56 |
| TheJulia | easier to collaborate on that. | 18:56 |
| cardoe | Absolutely. | 18:57 |
| cardoe | I'll be honest bandwidth wise right now I wanna try and steer this VXLAN stuff and then James has thrown my network stuff for a loop cause he's wanting me to just let him use cinder inside of his hypervisor. | 18:58 |
| cardoe | I was actually wondering if maybe I should instead aim to add my docs and ML2 mechanism driver to networking-baremetal ? | 18:58 |
| cardoe | Instead of neutron proper | 18:58 |
| cardoe | I'd really like it in neutron proper because it makes them aware of the use case. | 18:59 |
| TheJulia | cardoe: so, on the nova side, it looks like we quite literally just need to have nqn as an option off the field? am I groking that right? | 19:14 |
| cardoe | Yep. | 19:14 |
| cardoe | I'm actually working on a set of patches to nova and cinder for that. | 19:14 |
| TheJulia | fair, I just want to get enough notes in place so we can go back to storage stuff and not be starting from ground level again | 19:15 |
| cardoe | I discussed it with the cinder folks that there's a lot of hardcoded magical strings that are dict keys which makes all this hard to nail down. | 19:15 |
| TheJulia | on the nova side, it looks like we could only load an initial nqn... but ironic could always sync the rest later | 19:15 |
| TheJulia | which might be totally okay | 19:15 |
| cardoe | They no longer have cinder-lib so I'm defining them in os-brick and changing os-brick to use those. Then we'll use the defines in nova. | 19:15 |
| TheJulia | so just loop through a list of contstants instead from the library and let that sync, perhaps? | 19:16 |
| cardoe | From a fast approach, absolutely.... we could just send along nqn or host_nqn? | 19:16 |
| cardoe | Well some backends need host_nqn and some need nqn | 19:16 |
| TheJulia | list provided by os-brick :) | 19:16 |
| TheJulia | exactly | 19:16 |
| TheJulia | we just look for both values? | 19:16 |
| TheJulia | or so, the code pattern does it | 19:17 |
| cardoe | Well we have to set both. | 19:17 |
| cardoe | My small nova patch locally just sets initiator, nqn, and host_nqn to the same value | 19:17 |
| TheJulia | so two lists, translation mappings and actual mappings | 19:17 |
| cardoe | I've made a bug for cinder that they need to use constants and have their backends use the constants instead of free form. | 19:18 |
| TheJulia | and then the nova code could just loop/translate as necessary from lists and get the specific labels gone from the code | 19:18 |
| TheJulia | at least, nova.virt.ironic code | 19:18 |
| TheJulia | anyway, sounds like your chasing on that path, and I can see if James is deploying whole hypervisors it makes sense to let the software do the needful, vxlan networking definitely seems higher up on my priority list | 19:19 |
| cardoe | You want me to dump my notes in that bug? | 19:19 |
| cardoe | So we can collaborate. | 19:20 |
| TheJulia | regarding your mech driver and all, I looked this morning and didn't see anything. I can get they might be... hesitant to engage on the physical front but progress is better than no progress and if we need to drop it into the netowrking-baremetal plugin, I could be good with that too | 19:20 |
| TheJulia | by all means | 19:20 |
| *** mnaser[m] is now known as mnaser | 20:46 | |
| cardoe | Man. These tests don’t want to fail. I don’t like it. | 20:54 |
| cardoe | clif: I dunno. It’s awkward that the only enforcement point is in the RPC and nothing at the lower object level. | 20:59 |
| * TheJulia feels like a packet got lost in the woods | 21:13 | |
| clif | that means my changes are perfect ;) | 21:30 |
| clif | cardoe: so you're worried about a portgroup and its constiuent ports not having the same physical_network because there's not lower-level enforcement beyond rpc? | 21:31 |
| clif | I'm happy to put up a patch with something along those lines if you let me know at what level the enforcement should take place | 21:32 |
| cardoe | eh just chasing my tail with the tests there's only one place where things can get broken right now and that's in ironic/drivers/modules/inspector/hooks/physical_network.py | 21:39 |
| cardoe | Otherwise its just all in the tests making all kinds of mock/fake data. Like not real portgroup objects or things like that. | 21:40 |
| cardoe | So at this point nothing is really broken. When I added the physical_network is sent in the binding:profile to Neutron, I read the physical_network from the portgroup. As you had commented on my patch. But no test ever sets the physical_network on a portgroup. They always use the value of the first port on the portgroup. So my test failed. And I keep poking places thinking aha this will fail. And it doesn't fail. | 21:43 |
| TheJulia | cardoe: wouldn't it just make sense to update the base test mock data used for tests to represent it as such. That is the only way to really get it across a swath of tests aside from explicitly creating tests or a class of tests as that being the starting state. | 22:01 |
| opendevreview | Steve Baker proposed openstack/ironic master: Improve logging when console unit doesn't start https://review.opendev.org/c/openstack/ironic/+/963324 | 22:07 |
| opendevreview | Steve Baker proposed openstack/ironic master: Replace Chrome/Selenium console with Firefox extension https://review.opendev.org/c/openstack/ironic/+/961434 | 22:07 |
| opendevreview | Steve Baker proposed openstack/ironic master: Switch graphical console image to ubuntu by default https://review.opendev.org/c/openstack/ironic/+/964201 | 22:07 |
| opendevreview | Steve Baker proposed openstack/ironic master: Add a kubernetes provider for console container https://review.opendev.org/c/openstack/ironic/+/962242 | 22:07 |
| opendevreview | Merged openstack/ironic master: docs: cover what happens if someone changes iscsi passwords https://review.opendev.org/c/openstack/ironic/+/963442 | 22:33 |
| cardoe | TheJulia: there's not really a common spot like this function https://opendev.org/openstack/ironic/src/commit/9305e273a886a793a397d7244daa09ff0174dda4/ironic/tests/unit/drivers/modules/network/test_common.py#L304 | 22:37 |
| cardoe | It's fine. Like I said. It's not really impacting anything. | 22:37 |
| cardoe | The only place it can break today is in the inspection hook. | 22:37 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: ensure that portgroup physical_network is updated for tests https://review.opendev.org/c/openstack/ironic/+/965985 | 22:39 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: pass along physical_network to neutron from the baremetal port https://review.opendev.org/c/openstack/ironic/+/964570 | 22:39 |
| TheJulia | cardoe: well, it really depends on the test, but I'd change obj_utils.create_test_portgroup | 23:42 |
| cardoe | I did in the first patch | 23:42 |
| cardoe | The issue is port groups are created without a physical_network all over the place and then ports are created referencing the portgroup with a physical_network | 23:42 |
| cardoe | There we go. Now it failed how I expected it to. | 23:53 |
| TheJulia | okay, that is making more sense then | 23:58 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!