| opendevreview | Merged openstack/bifrost stable/2025.2: [stable only] increase test VM mem size https://review.opendev.org/c/openstack/bifrost/+/964752 | 00:08 |
|---|---|---|
| opendevreview | Merged openstack/bifrost master: verify creation of test VMs during testenv setup https://review.opendev.org/c/openstack/bifrost/+/964485 | 00:08 |
| opendevreview | Merged openstack/ironic master: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/965248 | 00:29 |
| alegacy | JayF: ya, that's probably best since gutting it will create a big delta between patchsets which may be confusing. I'll do that before I upload the new series. | 00:56 |
| opendevreview | Verification of a change to openstack/ironic master failed: Add IPMI address validation to node validation https://review.opendev.org/c/openstack/ironic/+/964451 | 04:33 |
| opendevreview | Verification of a change to openstack/ironic master failed: Add IPMI address validation to node validation https://review.opendev.org/c/openstack/ironic/+/964451 | 05:57 |
| janders | good morning Ironic o/ | 07:56 |
| rpittau | TheJulia, JayF, dtantsur the real reason why we neglected the bullseye job in ipa-builder is because it has python 3.9 by default, I remember we mentioned it long time ago :) | 07:58 |
| rpittau | do we want to try and use a more recent python version as we do for CS9 ? not sure it's worth the effort honestly considering that bullseye EOL date was a year ago | 07:58 |
| rpittau | I'd rather abandon bullseye and move to current stable "trixie", keeping compatibility with bookworm as stable-1 | 07:58 |
| rpittau | and uh.... good morning ironic! o/ | 07:58 |
| dtantsur | I concur, it's probably time to drop it (that's pity we could not deprecate it properly) | 07:59 |
| rpittau | indeed, I forgot completely about that :/ | 08:04 |
| dtantsur | We need some sort of a deprecation schedule for IPA-builder and bifrost | 08:05 |
| rpittau | yep | 08:44 |
| opendevreview | Merged openstack/ironic master: Add IPMI address validation to node validation https://review.opendev.org/c/openstack/ironic/+/964451 | 08:45 |
| opendevreview | nidhi proposed openstack/ironic master: Add PCIe function fields to redfish inspection https://review.opendev.org/c/openstack/ironic/+/963179 | 09:03 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Remove tinyipa support https://review.opendev.org/c/openstack/bifrost/+/964404 | 09:37 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Do not build Debian Bullseye image anymore https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966204 | 10:03 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based ipa ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 10:13 |
| opendevreview | nidhi proposed openstack/ironic master: Add PCIe function fields to redfish inspection https://review.opendev.org/c/openstack/ironic/+/963179 | 10:51 |
| opendevreview | Merged openstack/ironic-prometheus-exporter unmaintained/2024.1: Update .gitreview for unmaintained/2024.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/965696 | 11:13 |
| opendevreview | Merged openstack/bifrost unmaintained/2024.1: Update .gitreview for unmaintained/2024.1 https://review.opendev.org/c/openstack/bifrost/+/965662 | 11:42 |
| opendevreview | nidhi proposed openstack/ironic master: Add PCIe function fields to redfish inspection https://review.opendev.org/c/openstack/ironic/+/963179 | 12:51 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Do not build Debian Bullseye image anymore https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966204 | 13:32 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based ipa ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 13:33 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Do not build Debian Bullseye image anymore https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966204 | 13:36 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based ipa ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 13:37 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Fix storing inventory and plugin data in Swift https://review.opendev.org/c/openstack/ironic/+/966259 | 13:37 |
| kubajj | ^ another bug I have introduced a couple of years ago, sorry | 13:39 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based IPA ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 13:40 |
| kubajj | btw, is nobody else storing inspection data in Swift? | 13:45 |
| opendevreview | nidhi proposed openstack/ironic master: Add PCIe function fields to redfish inspection https://review.opendev.org/c/openstack/ironic/+/963179 | 14:02 |
| TheJulia | rpittau: Yeah, time to drop then | 14:12 |
| iurygregory | good morning ironic | 14:22 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Make sure [cors] allowed_origin accepts a list value https://review.opendev.org/c/openstack/ironic/+/966271 | 14:25 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Make sure [cors] allowed_origin accepts a list value https://review.opendev.org/c/openstack/ironic/+/966271 | 14:26 |
| rpittau | great, we're using 2025.1 instead of 2025.2 in the bifrost upgrade jobs mgrrrrr | 15:05 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: [CI] upgrade from 2025.2 https://review.opendev.org/c/openstack/bifrost/+/966283 | 15:11 |
| rpittau | some please review when you got a moment, thanks! ^ | 15:11 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Remove tinyipa support https://review.opendev.org/c/openstack/bifrost/+/964404 | 15:12 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Do not build Debian Bullseye image anymore https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966204 | 15:16 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based IPA ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 15:16 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/963670 | 15:28 |
| JayF | https://review.opendev.org/c/openstack/metalsmith/+/965736 does anyone on our end care about um/2024.1 metalsmith? | 15:44 |
| JayF | if not we should probably get it retired to handed off to um team | 15:44 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/2025.2: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/966290 | 15:52 |
| cardoe | kubajj: I'm not storing inspection in swift. Just in the ironic DB. | 15:52 |
| dtantsur | alegacy: btw, I've just had an enormous success asking Claude to turn really messy 4 commits into 2 nicely deliniated ones. I'm quite sure it can be used to split a large commit along a certain line. | 15:53 |
| JayF | claude is really, really good at stuff you can give examples for too. Like implementing existing interfaces and the like. | 15:54 |
| JayF | I cannot get it to understand how to write a consistent import statement ever, but I guess I need something to do too :P | 15:54 |
| dtantsur | yeah, it took it a while today to sort Go imports :D | 15:54 |
| dtantsur | but I'm really happy that I did not have to refactor the commits myself | 15:55 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Fix storing inventory and plugin data in Swift https://review.opendev.org/c/openstack/ironic/+/966259 | 15:58 |
| JayF | https://review.opendev.org/c/openstack/ironic-python-agent/+/966031 IPA Backport that is simple and could use +2A | 15:59 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/2025.1: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/966294 | 16:00 |
| kubajj | cardoe: isn't the DB massive then? (Our inspection data is roughly 6x as big as the DB) | 16:00 |
| JayF | I'm landing https://review.opendev.org/c/openstack/ironic-specs/+/965865 (work items + new template). Happy to do follow-ups but we need to get our PTG information published. | 16:00 |
| rpittau | thanks for taking care of that JayF :) | 16:01 |
| JayF | I also emailed ptg@ with a photo and count | 16:01 |
| JayF | I'll email about the PTG content once it publishes, then I'm going to record a video summary of the work items post to likely go up on youtube next week | 16:01 |
| JayF | BTW if at least one other -approver would comment on the ML with a +1 to our core team changes that'd be appreciated | 16:04 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/2024.2: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/966295 | 16:04 |
| zigo | Am I right that "openstack baremetal node create" would go in here: | 16:05 |
| zigo | https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L2977 | 16:05 |
| zigo | If so, how can I tell that I'm in a "node create" request when I'm there? | 16:05 |
| JayF | This is the most XY question ever asked; what's your high level goal? :D | 16:05 |
| JayF | https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L2890 POST to /v1/nodes is always a node create | 16:06 |
| zigo | Oh, thanks ! :) | 16:06 |
| JayF | https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L3123 patch is for update | 16:06 |
| JayF | what is your goal though? | 16:06 |
| JayF | that's a weirdly oriented question | 16:07 |
| zigo | JayF: I want to transform the api.request.rpcapi.get_topic_for() into a api.request.rpcapi.get_topics_for() (ie: with an s) so that it would iterate on all nodes of the conductor group so it would create the Grub PXE config on all conductor of the group, just like we discussed ... | 16:07 |
| JayF | Ah. Hmm. That's not how I would've expected that to be oriented, but I haven't thought much about this so :) | 16:07 |
| zigo | :) | 16:07 |
| JayF | If that's really the solution, it's certainly going to be less code than the paths I was thinking | 16:08 |
| zigo | If I'm right, the code is searching for the conductor that the node is attached to, to send RPC call to the correct, topic, right? | 16:08 |
| JayF | I'd have to look in real detail. The real reason I'd be surprised to see it there is that often the conductor handles the meat of the requests | 16:09 |
| JayF | so I assumed it'd be something like a conductor<>conductor RPC calls to fan them out | 16:09 |
| JayF | but if you can do it in that layer, maybe that's OK? | 16:09 |
| zigo | Got no clue ... :) | 16:09 |
| JayF | so I think that's more a precursor to making an RPC call | 16:09 |
| zigo | First time I'm really trying to contribute to Ironic. | 16:09 |
| JayF | I don't think we have any modeling for "make an RPC call for each" but IMBW | 16:10 |
| zigo | Do you know where's located the code that recieves the create_node on the conductor side? | 16:10 |
| zigo | You must be right that it should be doing more than just the PXE stuff, and that my approach must be wrong. | 16:11 |
| JayF | conductor/rpcapi.py conductor/manager.py | 16:11 |
| zigo | Thanks. | 16:11 |
| JayF | the usual pattern is rpcapi is where the rpc api calls are | 16:11 |
| JayF | manager is usually the actual code that gets executed | 16:12 |
| JayF | I'm trying to think if we have any endpoints currently which would ping all the conductors | 16:12 |
| JayF | and I don't think we do | 16:12 |
| zigo | I'll contribute it... :P | 16:12 |
| zigo | Oh, there's a def create_node() in the manager indeed ! :) | 16:12 |
| opendevreview | Merged openstack/ironic master: Apply naming standards to Ironic install guide sections https://review.opendev.org/c/openstack/ironic/+/964486 | 16:13 |
| opendevreview | Merged openstack/ironic-specs master: Add work items template, including maint checklist https://review.opendev.org/c/openstack/ironic-specs/+/965249 | 16:15 |
| zigo | JayF: I suppose what I should look at is in ironic/objects/node.py then? | 16:17 |
| zigo | Or that's just the db side of things? | 16:18 |
| zigo | (it looks like it) | 16:18 |
| JayF | I don't know how this would be done | 16:18 |
| zigo | Sorry to ask dumb question, but it's hard to dive in ... | 16:18 |
| JayF | and won't without significant digging | 16:18 |
| zigo | I'll dig myself then, thanks. | 16:18 |
| JayF | but conductor manager is more likely to be the right layer | 16:18 |
| opendevreview | Merged openstack/ironic-specs master: 2026.1 Ironic work items https://review.opendev.org/c/openstack/ironic-specs/+/965865 | 16:23 |
| opendevreview | Merged openstack/sushy stable/2025.2: Check required credentials in a detailed way https://review.opendev.org/c/openstack/sushy/+/964871 | 16:38 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/963670 | 17:00 |
| gmaan | is this job renamed/removed ironic-tempest-bios-ipmi-direct-tinyipa | 17:31 |
| gmaan | we used to run this on tempest and devstack gate to avoid any breaking change for ironic | 17:31 |
| gmaan | but I see it is not running and i cannot find its definition | 17:31 |
| gmaan | yeah, done in https://review.opendev.org/c/openstack/ironic/+/950192/12/zuul.d/ironic-jobs.yaml | 17:37 |
| gmaan | I think zuul should give some error or warning about jobs usage so that renaming/removal can be more known than just ignore to run the job if not found | 17:37 |
| * dtantsur agrees | 17:37 | |
| gmaan | I just checked today tempest gate and found no ironic job running and it could go unnotice for long | 17:38 |
| gmaan | anyways, I will update tempest/devstack gate with new job name | 17:38 |
| opendevreview | Verification of a change to openstack/sushy stable/2025.1 failed: Check required credentials in a detailed way https://review.opendev.org/c/openstack/sushy/+/964872 | 17:40 |
| opendevreview | Merged openstack/ironic stable/2025.2: Remove bespoke logic for handling redirects while validating URLs https://review.opendev.org/c/openstack/ironic/+/966027 | 17:42 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: Add 2026.1 workitems to index https://review.opendev.org/c/openstack/ironic-specs/+/966322 | 17:49 |
| JayF | ^ is trivial, I accidentally an index on that ptg work items | 17:52 |
| TheJulia | gmaan: dtantsur: it used to but that changed maybe 2 years ago in the zuul config validation code | 18:10 |
| JayF | gmaan: That explains how a neutron change in devstack broke us unexpectedly last cycle. Thank you for that \o/ | 18:17 |
| TheJulia | Come to think of it, I think we've checked with codesearch as well on whole job removals and it didn't pop up. Guess zuul erroring would actually kind of be more preferable. :\ | 18:19 |
| gmaan | yeah, I think at least if it should be zuul error if any of the jobs is missed to run due to any reason. ignoring those jobs to run and gate result as pass is false result | 18:21 |
| alegacy | TheJulia: Jayf isn't keen on the "standalone-experimental" network interface name. The others are named noop, flat and neutron. How about just "ironic" or "ironic-standalone" since this is an Ironic alternative to the Neutron-based version of networking? I'm open to suggestions. | 18:44 |
| TheJulia | I was thinking standalone originally, or maybe "ironic" could be simple enough | 18:45 |
| JayF | just ironic is nice, or something like "mercury" | 18:45 |
| TheJulia | heh, that would be more confusing most likely | 18:45 |
| JayF | if the service name is ironic-networking | 18:50 |
| JayF | calling it ironic-networking is also on the board | 18:50 |
| JayF | I'll note my primary beef with "standalone-experimental" is the "-experimental" as putting a temporal state into an operator/config/api facing string seems not awesome | 18:50 |
| TheJulia | yeah, I concur with that and I would have preferred something simpler/shorter out of the box. I don't think it was me who demanded -experimental either | 18:51 |
| alegacy | that was my suggestion because there was a worry about being able to delete this driver and move to a newer version once we firmed up the API without going thru deprecation. | 18:52 |
| alegacy | "ironic" is simple. I like it. | 18:52 |
| TheJulia | I think the rest API primitives and all are what remains to be figured out | 18:53 |
| TheJulia | and that will likely just keep a fall back to the old value locations as time moves on | 18:53 |
| alegacy | "ironic-networking" is also a good choice. | 18:54 |
| TheJulia | "internal" | 18:54 |
| alegacy | JayF: Do you have a favorite? I think my picks (in order) are: "internal", "ironic-networking", "ironic" | 18:59 |
| JayF | oooooh internal | 19:02 |
| JayF | I like ironic-networking, I think | 19:03 |
| JayF | it's the most clear and you can easily document it | 19:03 |
| JayF | making it the same name as the service should IMO remove a decoder ring | 19:03 |
| JayF | but to be clear: if any of those were the original name, I don't make the review comment :) | 19:03 |
| alegacy | ok, how about "ironic-networking" as a winner. | 19:07 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 19:08 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 19:15 |
| cardoe | https://github.com/dell/iDRAC-Redfish-Scripting/blob/master/Redfish%20Python/DeviceFirmwareMultipartUploadREDFISH.py is completely generic. Has anyone played around with adding a "push" version of firmware uploading? | 19:22 |
| TheJulia | I know janders has been trying to get it standardized | 19:24 |
| TheJulia | across vendors, that is | 19:24 |
| cardoe | zigo, JayF: So we're gonna make the grub config on all conductor nodes... are we then gonna generate the custom ISO for virtual-media on all of the conductor nodes? | 20:39 |
| zigo | cardoe: No, that's not the idea. The idea is: when one doesn't control DHCP, and we still want HA, then one may setup 2 conductors in a single conductor group, with a VIP. In such environment, we want the Grub config to be written on both nodes, every time, so PXE can be done on any of the 2 nodes, anytime. | 20:41 |
| zigo | Though I've spent hours this afternoon reading Ironic code, and couldn't figure out where to change it... :( | 20:42 |
| JayF | Yeah, I don't think you need a small change, this is an entirely new concept, that's what I was trying to point at earlier | 21:01 |
| cardoe | zigo: so essentially when we PXE boot like boot.ipxe it would be on all the conductors | 21:25 |
| TheJulia | Its a change in the driver code which launches a new task on the remote conductor | 21:40 |
| TheJulia | some of the building blocks are there | 21:41 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: local_link_connection inspection hook does not fail on missing port https://review.opendev.org/c/openstack/ironic/+/966373 | 22:16 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: local_link_connection inspection hook does not fail on missing port https://review.opendev.org/c/openstack/ironic/+/966373 | 22:17 |
| cardoe | okay great I can now sit down to start working on what I wanted to do first thing this morning... hmm what time is it? 4:46pm. | 22:46 |
| TheJulia | ... I know this feeling | 22:48 |
| JayF | I thoguht I had hit that point, then realized I have a giant (OSS but not OpenStack) PR to review :( | 22:48 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!