| opendevreview | Steve Baker proposed openstack/ironic master: OciImageService detect bootc image https://review.opendev.org/c/openstack/ironic/+/966760 | 02:57 |
|---|---|---|
| opendevreview | Steve Baker proposed openstack/ironic master: Swap to bootc deploy interface for bootc images https://review.opendev.org/c/openstack/ironic/+/966761 | 02:57 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: pass along physical_network to neutron from the baremetal port https://review.opendev.org/c/openstack/ironic/+/964570 | 06:36 |
| opendevreview | Merged openstack/ironic stable/2024.2: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/959221 | 06:55 |
| opendevreview | Merged openstack/ironic bugfix/28.0: Memoize calls to bcrypt.checkpw https://review.opendev.org/c/openstack/ironic/+/959220 | 06:56 |
| opendevreview | Merged openstack/ironic master: Filter null NIC firmware versions from cache https://review.opendev.org/c/openstack/ironic/+/966567 | 07:23 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 07:34 |
| janders | good morning Ironic o/ | 07:34 |
| rpittau | good morning ironic! o/ | 08:00 |
| rpittau | TheJulia: I was out yesterday, not sure if you've done anything yet for debian arm64 job, I'll check today, there were also other jobs I was looking at | 08:06 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Wait up to 30 seconds for config drive https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/962673 | 08:21 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/966294 | 08:22 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 09:13 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 09:21 |
| opendevreview | cid proposed openstack/ironic stable/2025.2: Filter null NIC firmware versions from cache https://review.opendev.org/c/openstack/ironic/+/966773 | 09:34 |
| rpittau | mmm python 3.10 shenanighans in ipa, anyone looked at that? | 09:50 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: [WIP] Remove tinyipa support and switch to debian IPA https://review.opendev.org/c/openstack/bifrost/+/964404 | 09:57 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based IPA ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 10:07 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/11.1: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/966774 | 10:11 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/11.0: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/966775 | 10:15 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent stable/2025.1: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/966776 | 10:19 |
| rpittau | TheJulia: debian-arm64 was on bullseye, this moved it to bookworm https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966204, so we should be fine now | 10:30 |
| rpittau | if anyone has a moment please rview https://review.opendev.org/c/openstack/python-ironicclient/+/955102 I'd like to include it in the upcoming ironicclient release | 10:31 |
| opendevreview | Merged openstack/python-ironicclient master: Replace CLA with DCO https://review.opendev.org/c/openstack/python-ironicclient/+/956327 | 10:39 |
| opendevreview | Massimiliano Favaro-Bedford proposed openstack/ironic stable/2025.1: Fix : AsRockRack Management via Redfish https://review.opendev.org/c/openstack/ironic/+/966779 | 10:55 |
| opendevreview | Merged openstack/ironic-python-agent-builder unmaintained/2024.1: stable/2024.1: disable un-needed CI jobs https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966762 | 10:56 |
| opendevreview | Massimiliano Favaro-Bedford proposed openstack/ironic stable/2025.1: Add generic redfish compatible vendor name https://review.opendev.org/c/openstack/ironic/+/966781 | 11:06 |
| opendevreview | cid proposed openstack/ironic master: Drop xinetd/tftpd on CentOS 9 https://review.opendev.org/c/openstack/ironic/+/964449 | 11:18 |
| cid | rpittau, I think the parent change of #955102 in the ironic repo will need to land first. Currently in merge conflicts. | 11:33 |
| cid | I will be updating it this afternoon | 11:34 |
| rpittau | mm yeah | 11:34 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/966294 | 11:39 |
| opendevreview | cid proposed openstack/ironic master: Add node.instance_name https://review.opendev.org/c/openstack/ironic/+/952790 | 12:33 |
| opendevreview | cid proposed openstack/ironic master: Add node.instance_name https://review.opendev.org/c/openstack/ironic/+/952790 | 12:43 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: cs10 - remove excess intel firmware https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/965984 | 12:49 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 13:07 |
| opendevreview | Doug Goldstein proposed openstack/ironic-python-agent-builder stable/2025.2: Wait up to 30 seconds for config drive https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966822 | 13:30 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent stable/2025.1: Test advertised ip reachability before assigning it https://review.opendev.org/c/openstack/ironic-python-agent/+/966776 | 13:56 |
| cardoe | so uh cid... I was gonna try and help with https://review.opendev.org/c/openstack/ironic/+/966773 but when I saw expected MagicMock.get().get().get().get().get() and actual was one less or more.... I closed that browser window as fast as I could. | 14:20 |
| cid | :D. What change could that be. | 14:25 |
| cid | Lol, you mean the CI failure. I'm just seeing that now. | 14:28 |
| * cid It's on my todo to checkout before EOD | 14:29 | |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: Handle HTTP 400 and 409 race condition in Redfish power operations https://review.opendev.org/c/openstack/ironic/+/966294 | 14:31 |
| janders | JayF brief update on iRMC deprecation: I made some good progress with downstream discussions about it, it looks like we're nearly good to proceed pending final confirmation. I got Claude to draft the deprecation change ready to go, before I push it I believe yourself and dtantsur need to sync on metal3 side of it | 14:48 |
| dtantsur | JayF: I'd prefer some heads-up for Metal3 before the complete removal. Does not have to be a full OpenStack cycle, it can be an intermediate release. | 14:49 |
| -opendevstatus- NOTICE: Zuul job log URLs for storage.*.cloud.ovh.net are temporarily returning an access denied/payment required error, but the provider has been engaged and is working to correct it | 14:49 | |
| opendevreview | Clif Houck proposed openstack/ironic master: Trait Based Networking Filter Expression Parsing and Base Models https://review.opendev.org/c/openstack/ironic/+/961498 | 15:03 |
| opendevreview | Clif Houck proposed openstack/ironic master: Configuration file for Trait Based Networking https://review.opendev.org/c/openstack/ironic/+/962598 | 15:03 |
| opendevreview | Clif Houck proposed openstack/ironic master: Generate network plan based on trait based networking config https://review.opendev.org/c/openstack/ironic/+/964895 | 15:03 |
| opendevreview | Clif Houck proposed openstack/ironic master: Trait Based Networking Simulator https://review.opendev.org/c/openstack/ironic/+/966202 | 15:03 |
| clif | Reworked these commits to be more self-contained. There were several base model changes introduced while working on configuration file and network plan commits which I've pushed back down into the base models commit. | 15:05 |
| clif | Going to address any review comments shortly. | 15:06 |
| rpittau | dtantsur: did I miss something about Metal3? | 15:09 |
| dtantsur | rpittau: deprecating the iRMC driver | 15:09 |
| dtantsur | we need to do it now that FJ refused to fix it basically. ideally before Ironic just removes the code :) | 15:10 |
| JayF | dtantsur: sounds like janders has volunteered to do the driving on the iRMC deprecation so I'll just hope you both chat about things and I can just watch magic happen :D | 15:22 |
| dtantsur | works for me :D | 15:24 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 15:33 |
| TheJulia | dtantsur: partly why I just pushed on them via email. Upstream really has no choice. :) | 15:43 |
| TheJulia | Also, good morning! | 15:43 |
| * dtantsur nods | 15:43 | |
| dtantsur | and good morning TheJulia | 15:43 |
| rpittau | right | 15:43 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Deprecate iRMC hardware type and interfaces https://review.opendev.org/c/openstack/ironic/+/966879 | 15:52 |
| TheJulia | rpittau: w/r/t bookworm, yeah, I finally put it all together yesterday in my head while waiting for the change to recheck | 15:53 |
| janders | ^^ my first depreciation so feedback welcome - please be patient with me :) | 15:53 |
| janders | s/deprecation/depreciation :) | 15:53 |
| rpittau | janders: we'll just blame Claude :D | 15:54 |
| janders | I was thinking the same | 15:54 |
| janders | one of his first deprecations, too, after all | 15:54 |
| rpittau | janders: mmmm so you're just updating an existing reno, I think we should have a new one | 15:56 |
| janders | +1 | 15:56 |
| janders | blaming Claude | 15:56 |
| rpittau | of course :) | 15:56 |
| janders | he'll fix it real quick too | 15:56 |
| JayF | claude won't fix it unless you tell it how to make a reno :P | 15:58 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Deprecate iRMC hardware type and interfaces https://review.opendev.org/c/openstack/ironic/+/966879 | 16:01 |
| TheJulia | janders: two items on that, commented :) | 16:01 |
| TheJulia | JayF: claude actually suggested a reno on a change for me recently, in correct format and context and all | 16:01 |
| TheJulia | JayF: without me asking, I was blown away. | 16:02 |
| JayF | without a CLAUDE.md? | 16:02 |
| JayF | a CLAUDE.md telling it to, 100% matches my experience. In a bare repo :-O | 16:02 |
| TheJulia | yes, without a claude.md file | 16:02 |
| opendevreview | Verification of a change to openstack/ironic unmaintained/2024.1 failed: Update .gitreview for unmaintained/2024.1 https://review.opendev.org/c/openstack/ironic/+/965730 | 16:02 |
| TheJulia | it knew it was openstack and it knew openstack practice, clearly. | 16:02 |
| JayF | nice | 16:11 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Deprecate iRMC hardware type and interfaces https://review.opendev.org/c/openstack/ironic/+/966879 | 16:13 |
| janders | ^ second iteration, hopefully Claude fixed his shortcomings properly | 16:13 |
| kubajj | Was there a reason not to provide scripts for inspector data migration? (Asking cause I just created one for swift-swift migration and am wondering if we should share it somewhere - although it is very simple :D ) | 16:30 |
| dtantsur | kubajj: no reason other than nobody has done it | 16:31 |
| TheJulia | I think we largely viewed is as ephemeral data and didn't see a reason from that, I don't think we would push back/resist/reject a script | 16:31 |
| kubajj | tbh, I am also not sure why we store it (it is used by our hardware team to verify deliveries at enrolment time, but not after), but I will try to clean up the script and share | 16:32 |
| opendevreview | Merged openstack/networking-baremetal unmaintained/2024.1: Update .gitreview for unmaintained/2024.1 https://review.opendev.org/c/openstack/networking-baremetal/+/965739 | 16:48 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Nit: Fix typo in Migrating from ironic-inspector https://review.opendev.org/c/openstack/ironic/+/966897 | 16:49 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 17:03 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Add a script to copy inspection data between Swift buckets https://review.opendev.org/c/openstack/ironic/+/966899 | 17:15 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 18:13 |
| TheJulia | hmm, centos images didn't quite reduce in the size I expected | 18:29 |
| * TheJulia lets curiosity drive for a little bit | 18:29 | |
| JayF | cid and I are talking about his IPA typing change. | 18:54 |
| JayF | I assume there's no baseline objection to this based on PTG discussion | 18:54 |
| JayF | is there another core who wants to join the party and help with quick review/landing of those changes since otherwise they will be in rebase hell forever? | 18:55 |
| TheJulia | umm... could you link to the thing your talking about | 19:14 |
| TheJulia | that way we can focus context without knowing the thing already | 19:14 |
| JayF | https://review.opendev.org/c/openstack/ironic-python-agent/+/958333 | 19:22 |
| cardoe | Seems good to me. How far back in Python versions you wanna support? | 19:27 |
| TheJulia | fix incoming for ipa-b for firmware removal, my firmware cleanup didn't quite do everything I expected. :) | 19:48 |
| JayF | cardoe: https://governance.openstack.org/tc/reference/runtimes/2026.1.html#python you tell me (literally, you told me as a TC member :P ) | 19:49 |
| TheJulia | No objection, I'm happy to review that item and land it, just realize the changes themselves and and all ultimately conflicts so we just need do the needful. | 19:49 |
| JayF | yeah, my main objective in priming the pump here is to just make sure CID doesn't rebase that forever | 19:50 |
| cardoe | JayF: Python 2.7 for LIFE | 19:50 |
| JayF | and that he has someone other than me to lean on for a fast merge (and giving space for angry disapprovals here before that rebase /merge happens) | 19:50 |
| JayF | cardoe: If that's the punishment, I plead NOT GUILTY | 19:50 |
| cardoe | Well I only ask because the syntax is the pre Python 3.9/3.10 syntax | 19:50 |
| JayF | we have to test in python 3.10 | 19:51 |
| JayF | so if there's better syntax to use, provide is as code review feedback :) | 19:51 |
| cardoe | Oh that's a big diff. | 19:51 |
| JayF | hopefully cid is lurking since we just got done with our 1:1 | 19:51 |
| cardoe | But this is the same convo I had with dtantsur about sushy | 19:51 |
| JayF | cardoe: that's the idea, we need to line up folks so it can merge quickly because if someone sneezes we'll have a merge conflict | 19:51 |
| * cid nods in the background. | 19:52 | |
| cardoe | Cause I enabled ruff to auto-format | 19:52 |
| cardoe | And except for the whole OpenStack import first party / third party slight variance. | 19:52 |
| cardoe | ruff can do the format from Python 3.9 forward. | 19:53 |
| cardoe | And then we can just automate updates | 19:53 |
| JayF | sounds like you have review opinions and care | 19:53 |
| cardoe | Well I just want machines to do this and not humans. | 19:53 |
| JayF | I hereby deem you type fixing buddy extraordinaire | 19:53 |
| cardoe | anyway... ty.List[str] is < Python 3.9 syntax | 19:54 |
| cardoe | Merge it as is. | 19:56 |
| cardoe | It's proposed to be removed in 3.18 | 19:57 |
| cardoe | So there's time. | 19:57 |
| JayF | I mean, it needs a big rebase | 19:59 |
| JayF | so if you have feedback give it (directly to cid, I'm going to go take care of something else now :D ) | 19:59 |
| JayF | It's worth noting: this is a pilot for Ironic directly | 19:59 |
| JayF | so if you want it that way in IRonic, pitch it for IPA now | 20:00 |
| cardoe | Personally I would just adopt ruff | 20:00 |
| cardoe | Set the minimum supported Python version and call it a day. | 20:00 |
| cardoe | The only time I deal with types on non-OpenStack Python code now days is when pyright (which generates the types) cannot figure it out or when the generated type is Sequence | Dict | Tuple | Object | Callable and I'm like woah that's not right | 20:02 |
| cardoe | mypy --strict pre-commit or bust | 20:02 |
| cardoe | cid: just rebase what ya got and I'll +2 it. | 20:03 |
| cid | Yeah, feedback are welcome on the patch. I am planning a rebase once we've got momentum going on that patch again. | 20:03 |
| cid | I'm also curious how the ruff implementation will work | 20:04 |
| cardoe | So ruff just has the same kind of syntax stuff like pyupgrade has. | 20:06 |
| cardoe | So like for sushy I used pyright to generate the inferred types as .pyi stub files. I fed that into monkeytype which applied those types to the sushy code base but in a messy syntax then set the minimum Python version to 3.9 in pyproject.toml and let ruff clean up the rest. | 20:09 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add Redfish health status monitoring and synchronization https://review.opendev.org/c/openstack/ironic/+/966946 | 20:10 |
| cardoe | What I'm getting at is... you don't have to rebase anything. Just start from scratch and run 3 commands. | 20:10 |
| cardoe | And then check everything with mypy --strict | 20:10 |
| janders | ^^ first stab at health checking, client patch to follow. Early version to facilitate own testing. | 20:10 |
| cid | cardoe. Interesting! 3 commands to achieving the same goal >>>. | 20:12 |
| cid | I guess I will see how that will work, feel free to push that patch as well. | 20:12 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent-builder master: Fix firmware cleanup - more. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966950 | 20:12 |
| TheJulia | Okay, say goodbye to like 70MB in the centos10 ipa images. | 20:13 |
| TheJulia | gah, tabs | 20:14 |
| cardoe | cid: just trying to save you some time. | 20:15 |
| cardoe | cid: https://github.com/Instagram/MonkeyType don't pip install it. Install it from git. | 20:15 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent-builder master: Fix firmware cleanup - more. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966950 | 20:15 |
| opendevreview | Jacob Anders proposed openstack/python-ironicclient master: [WIP] Add support for node health status fields https://review.opendev.org/c/openstack/python-ironicclient/+/966954 | 20:17 |
| cid | +++ | 20:18 |
| TheJulia | rpittau: I've posted change 966950 which should re-tool firmware cleanup and drop the centos image sizes. It will likely reduce the debian sizes as well, fwiw. for centos9, the actual reduction is only like 1MB as opposed to the 69 mb reduction of centos10 which really just demonstrates the underlying style/layout structure changes have on IPA images in general and our cleanup patterning | 20:26 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add Redfish health status monitoring and synchronization https://review.opendev.org/c/openstack/ironic/+/966946 | 20:33 |
| cardoe | cid: erm my bad wrong order.. mypy ships the stub generator... I ran it through pyright at the end to validate with another tool. | 20:36 |
| cardoe | stubgen -> monkeytype -> myright | 20:37 |
| cardoe | JayF: you there? | 20:37 |
| cardoe | clif: or you? | 20:39 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add Redfish health status monitoring and synchronization https://review.opendev.org/c/openstack/ironic/+/966946 | 20:45 |
| opendevreview | Jacob Anders proposed openstack/python-ironicclient master: [WIP] Add support for node health status field https://review.opendev.org/c/openstack/python-ironicclient/+/966954 | 20:45 |
| opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Build and publish updated debian images https://review.opendev.org/c/openstack/ironic-python-agent/+/966513 | 20:51 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add Redfish health status monitoring and synchronization https://review.opendev.org/c/openstack/ironic/+/966946 | 21:05 |
| janders | ^ early days but starting to work: https://paste.openstack.org/show/b4eewCnINtzNn5GzCfTn/ | 21:08 |
| JayF | cardoe: sup? | 21:08 |
| janders | does anyone know a good way of "breaking" hardware in software for the purpose of triggering a redfish health alert? :) | 21:09 |
| * JayF hands janders a collection of physical media glued together in the shape of a hammer | 21:11 | |
| janders | :) | 21:11 |
| clif | cardoe: I'm afk to pick up kids, will be back online in about 30-45 min | 21:31 |
| cardoe | alright no worries. | 21:31 |
| cardoe | Just wanted to setup when you and JayF might be free to do a sync | 21:31 |
| JayF | My calendar is relatively clear tomorrow after about 10:00 a.m. Pacific | 21:37 |
| JayF | Generally, I just need warning though because I don't always keep chat apps up these days when I'm trying to focus on something | 21:37 |
| * TheJulia lights the forge and takes the stack of physical media to make "ServerHammer 5000" | 22:01 | |
| clif | I'm mostly clear tomorrow too | 22:19 |
| opendevreview | Clif Houck proposed openstack/ironic master: Trait Based Networking Filter Expression Parsing and Base Models https://review.opendev.org/c/openstack/ironic/+/961498 | 23:06 |
| opendevreview | Clif Houck proposed openstack/ironic master: Configuration file for Trait Based Networking https://review.opendev.org/c/openstack/ironic/+/962598 | 23:06 |
| opendevreview | Clif Houck proposed openstack/ironic master: Generate network plan based on trait based networking config https://review.opendev.org/c/openstack/ironic/+/964895 | 23:06 |
| opendevreview | Clif Houck proposed openstack/ironic master: Trait Based Networking Simulator https://review.opendev.org/c/openstack/ironic/+/966202 | 23:06 |
| opendevreview | Verification of a change to openstack/ironic master failed: Nit: Fix typo in Migrating from ironic-inspector https://review.opendev.org/c/openstack/ironic/+/966897 | 23:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!