| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.1: Allow dib build to remove firmware in a structure. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967446 | 00:53 |
|---|---|---|
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.1: Fix firmware cleanup - more. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967447 | 01:22 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.2: Fix firmware cleanup - more. https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967444 | 01:22 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.2: cs10 - remove excess intel firmware https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967438 | 01:22 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.1: Add Mellanox Spectrum to firmware to remove list https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967450 | 01:22 |
| TheJulia | Regarding the simple init by default discussion at the ptg: https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966192 | 01:22 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.1: Add additional firmware images which are not needed https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967451 | 01:27 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2025.1: Exclude unnecessary firmewares https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/967452 | 01:27 |
| TheJulia | cardoe: I approved two small backports on ipa for 2025.2 and 2025.1 which should clear cause the artifact to be updated on tarballs.o.o once done | 01:33 |
| opendevreview | Verification of a change to openstack/ironic-python-agent stable/2025.2 failed: Fix RuntimeError when stopping heartbeater in rescue mode https://review.opendev.org/c/openstack/ironic-python-agent/+/967353 | 03:14 |
| cardoe | ^ 502 downloading CentOS 9 | 03:36 |
| opendevreview | Merged openstack/ironic-python-agent stable/2025.1: Fix RuntimeError when stopping heartbeater in rescue mode https://review.opendev.org/c/openstack/ironic-python-agent/+/967355 | 03:49 |
| opendevreview | Steve Baker proposed openstack/ironic master: OciImageService detect bootc image https://review.opendev.org/c/openstack/ironic/+/966760 | 03:51 |
| opendevreview | Steve Baker proposed openstack/ironic master: Swap to bootc deploy interface for bootc images https://review.opendev.org/c/openstack/ironic/+/966761 | 03:51 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Drop remaining inspector job https://review.opendev.org/c/openstack/ironic/+/967397 | 05:11 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 05:53 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Drop remaining inspector job https://review.opendev.org/c/openstack/ironic/+/967397 | 06:09 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove inspector inspect interface https://review.opendev.org/c/openstack/ironic/+/967476 | 06:09 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove inspector inspect interface https://review.opendev.org/c/openstack/ironic/+/967476 | 06:13 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove inspector inspect interface https://review.opendev.org/c/openstack/ironic/+/967476 | 06:18 |
| opendevreview | Merged openstack/ironic-python-agent stable/2025.2: Fix RuntimeError when stopping heartbeater in rescue mode https://review.opendev.org/c/openstack/ironic-python-agent/+/967353 | 06:26 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Add hardware health monitoring via management interface https://review.opendev.org/c/openstack/ironic/+/966946 | 06:28 |
| janders | JayF I'm starting 4 wk PTO today, so trying to push all the patch revisions. Getting code off my laptop, will try respond to comments a bit later. Thanks for your feedback, very helpful. | 06:29 |
| janders | (w/r/t ^^) | 06:29 |
| opendevreview | cid proposed openstack/ironic stable/2025.2: Make cache_firmware_components more resilient during upgrades https://review.opendev.org/c/openstack/ironic/+/967485 | 07:40 |
| cid | So, this ^^ needs to be backported first before this can merge: https://review.opendev.org/c/openstack/ironic/+/966773 | 07:41 |
| opendevreview | cid proposed openstack/ironic master: Remove iLO/iLO5 driver https://review.opendev.org/c/openstack/ironic/+/965009 | 07:50 |
| rpittau | good morning ironic! o/ | 07:57 |
| rpittau | TheJulia, cardoe , 2024.2 will go unmaintained on April 2nd | 07:59 |
| rpittau | I couldn't wrap up my head around the disk issues in uefi jobs, hope you had more luck | 08:00 |
| opendevreview | cid proposed openstack/ironic master: Remove iLO/iLO5 driver https://review.opendev.org/c/openstack/ironic/+/965009 | 08:10 |
| opendevreview | cid proposed openstack/bifrost master: ILO driver retirement https://review.opendev.org/c/openstack/bifrost/+/965177 | 08:35 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove inspector inspect interface https://review.opendev.org/c/openstack/ironic/+/967476 | 08:38 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove inspector inspect interface https://review.opendev.org/c/openstack/ironic/+/967476 | 08:40 |
| opendevreview | cid proposed openstack/ironic master: Clear image cache on deployment failure https://review.opendev.org/c/openstack/ironic/+/957613 | 08:52 |
| opendevreview | Massimiliano Favaro-Bedford proposed openstack/ironic stable/2025.2: Add generic redfish compatible vendor name https://review.opendev.org/c/openstack/ironic/+/967498 | 09:49 |
| opendevreview | cid proposed openstack/networking-baremetal master: Add conductor group sharding support https://review.opendev.org/c/openstack/networking-baremetal/+/948432 | 10:12 |
| opendevreview | cid proposed openstack/ironic master: Clear image cache on deployment failure https://review.opendev.org/c/openstack/ironic/+/957613 | 10:24 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-tempest-plugin master: Deprecate options for ironic-inspector tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/967514 | 11:47 |
| dtantsur | Looks like the dibipa job is permafailing on bifrost, anyone has an idea? https://zuul.opendev.org/t/openstack/builds?job_name=bifrost-integration-dibipa-debian-centos-10&project=openstack/bifrost | 11:54 |
| *** dmellado4 is now known as dmellado | 12:44 | |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Drop remaining inspector job https://review.opendev.org/c/openstack/ironic/+/967397 | 12:58 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Remove inspector inspect interface https://review.opendev.org/c/openstack/ironic/+/967476 | 12:59 |
| tkajinam | wondering if anyone from the core has a minute to abandon https://review.opendev.org/c/openstack/ironic/+/906080 ? | 13:01 |
| dtantsur | done | 13:02 |
| opendevreview | nidhi proposed openstack/sushy master: Add complete LLDP fields to Port.Ethernet.LLDPReceive per DMTF Redfish v1.12.0 https://review.opendev.org/c/openstack/sushy/+/966616 | 13:04 |
| dtantsur | rpittau: "LookupAgentIPError: Error finding IP for Ironic Agent: Agent could not find a valid IP address." also in the bifrost CI | 13:22 |
| dtantsur | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_40c/openstack/40cb21af30934b449cd81651a79376fb/logs/testvm1_console.log | 13:22 |
| dtantsur | rpittau: and now it occured to me that you're not using the valid port in https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/agent.py#L318-L319 | 13:23 |
| dtantsur | no idea how we all missed that, but this is why it fails both in bifrost and OCP | 13:24 |
| dtantsur | just stop extracting the host name, use the full URL? | 13:24 |
| tkajinam | dtantsur, thanks ! | 13:24 |
| rpittau | Oh gosh! | 13:27 |
| rpittau | Thanks dtantsur let me put together a patch if you're not doing it already | 13:28 |
| dtantsur | On a meeting, so please go ahead | 13:28 |
| rpittau | Ack | 13:28 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Fix API URL reachability test to use full URL with port https://review.opendev.org/c/openstack/ironic-python-agent/+/967535 | 13:47 |
| opendevreview | Massimiliano Favaro-Bedford proposed openstack/ironic stable/2025.2: Fix : AsRockRack Management via Redfish https://review.opendev.org/c/openstack/ironic/+/967537 | 13:59 |
| opendevreview | Pierre Riteau proposed openstack/ironic master: docs: Fix typos and a wrong URL https://review.opendev.org/c/openstack/ironic/+/967560 | 14:02 |
| opendevreview | Massimiliano Favaro-Bedford proposed openstack/ironic stable/2025.2: Add generic redfish compatible vendor name https://review.opendev.org/c/openstack/ironic/+/967498 | 14:09 |
| TheJulia | Good morning | 14:21 |
| rpittau | hey TheJulia :) | 14:26 |
| iurygregory | good morning o/ | 14:28 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Fix API URL reachability test to use full URL with port https://review.opendev.org/c/openstack/ironic-python-agent/+/967535 | 14:50 |
| opendevreview | Takashi Kajinami proposed openstack/python-ironicclient master: Remove deprecated option https://review.opendev.org/c/openstack/python-ironicclient/+/967564 | 14:51 |
| clif | Where exactly would it be appropriate to load a configuration file when starting the conductor? ironic/common/service.py: prepare_service? ironic/command/conductor.py? ironic/conductor/manager.py: Somewhere in ConductorManager.__init__? | 14:54 |
| dtantsur | clif: depends. If it's specific to a hardware interface, in its __init__. ConductorManager.init_host is a good place for truly global thi8ngs. | 14:56 |
| clif | this would be loading traits for determining networking operations at provision time | 14:57 |
| clif | Why is there a BaseConductorManager and a ConductorManager? Seems like only ConductorManager derivces from BaseConductorManager? | 14:58 |
| dtantsur | clif: are these trais applicable to all network interfaces or only some? | 14:59 |
| clif | Does BaseConductorManager conform to some interface? | 14:59 |
| dtantsur | BaseConductorManager is simply for code organization because manager.py is too large | 14:59 |
| clif | dtantsur: it would apply to instances that have these traits defined on their instance info | 14:59 |
| dtantsur | clif: regardless of their network_interface? so for standalone too? | 15:00 |
| clif | uhh probably? I think this would be useful regardless of the underlying network driver but I'm not totally certain | 15:00 |
| dtantsur | This is something to decide. If it's absolutely independent of Nova/Neutron, init_host could be the right place. If it's more of a Neutron thing, then probably called from all neutron-related network interfaces (separately) | 15:01 |
| dtantsur | Maybe another way to decide it is: where will the actual code to use this file live? | 15:03 |
| clif | mostly under ironic/common/trait_based_networking/ | 15:04 |
| dtantsur | Right, but what will call it? | 15:04 |
| clif | it will be called when hooking up the network to a newly provisioned instance | 15:04 |
| clif | to generate the list of networking operations/actions to take | 15:04 |
| clif | and then apply those actions | 15:05 |
| dtantsur | I mean, if you're going to use the new feature here https://opendev.org/openstack/ironic/src/commit/d1ad78f8274bfb48d127945eb4f1bd41ed4cd699/ironic/drivers/modules/network/common.py or here https://opendev.org/openstack/ironic/src/commit/d1ad78f8274bfb48d127945eb4f1bd41ed4cd699/ironic/common/neutron.py | 15:05 |
| dtantsur | it may be a reason to put it into the corresponding network interfaces | 15:05 |
| clif | yea | 15:06 |
| dtantsur | If it's universal and also applicable to standalone cases, maybe we're back to init_host | 15:06 |
| dtantsur | I'm not very familiar with the feature you're working on, so I cannot provide better guidance | 15:07 |
| dtantsur | TheJulia or JayF might | 15:07 |
| clif | yea I was about ask for their input | 15:07 |
| clif | well the spec states that it is only expected to work with neutron for now | 15:09 |
| clif | but could be extended in the future | 15:09 |
| clif | https://opendev.org/openstack/ironic-specs/blame/branch/master/specs/approved/trait-based-port-scheduling.rst#L150 | 15:11 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Skip BMC detection in IPA for out-of-band management https://review.opendev.org/c/openstack/ironic/+/967166 | 15:29 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Skip BMC detection when using out-of-band management https://review.opendev.org/c/openstack/ironic-python-agent/+/967167 | 15:46 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: WIP add an OCI artifact registry https://review.opendev.org/c/openstack/bifrost/+/961388 | 15:53 |
| cardoe | TheJulia: so I know you said you'd sit down with the spec for https://review.opendev.org/c/openstack/sushy/+/966616 which I would appreciate. With that change we're able on _SPECIFIC_ hardware to craft an inspection which we can do everything out of band to enroll new nodes. dtantsur I'll poke you as well because this would be part of what we'd want to scan for out of band on the regular. | 15:53 |
| * dtantsur +2 | 15:55 | |
| JayF | clif: I agree with what dtantsur is saying -- it's about where it hooks in. If it's hooking in at a network_interface level, it should be instantiated with the network_interface. I suspect that may be the case but I'm not 100% sure about vif_attach | 15:58 |
| cardoe | dtantsur: another one I'd like to get your review on... https://review.opendev.org/c/openstack/ironic/+/963179 | 16:15 |
| dtantsur | cardoe: I'd rather have the field names standard between IPA and this one | 16:17 |
| cardoe | Me too | 16:17 |
| cardoe | That's why I'm working on standardizing them in another change. | 16:17 |
| cardoe | I'm gonna say that IPA is wrong for PCI though | 16:18 |
| dtantsur | Sure, but this change is already diverging quite a bit | 16:18 |
| cardoe | The only divergent change in the field names is "device_id" vs "product_id" | 16:18 |
| dtantsur | device_class vs class | 16:18 |
| dtantsur | revision_id vs revision | 16:18 |
| dtantsur | subsystem_* is missing (but we can add it, that's not a problem) | 16:19 |
| cardoe | okay I'll give ya device_class vs class and revision_id vs revision | 16:19 |
| cardoe | But product_id is wrong in IPA | 16:19 |
| cardoe | It's device_id in every other PCI related tool out there. | 16:19 |
| dtantsur | I concur, but then we need to go through the deprecation path on the IPA side. And maybe provide a compatibility value in your new implementation too, just to avoid confusion. | 16:20 |
| dtantsur | I'm also wondering about model vs product_name in the system vendor.. | 16:20 |
| cardoe | So my plan wasn't to depreciate anything just yet. | 16:20 |
| cardoe | I moved parts of the IPA doc into the Ironic docs previously which called out the top-level keys. | 16:21 |
| cardoe | The WIP doc change goes further and calls out the rough shape of each of the keys. It does say that other fields can exist. | 16:21 |
| cardoe | Maybe over the holidays I can finish that up. | 16:23 |
| cardoe | I've also got a patch to Ironic that loads the inventory and normalizes the keys to the documented ones. | 16:23 |
| cardoe | My thought is we can then say in-tree inspection hooks should only use documented fields. | 16:24 |
| cardoe | I want to look at how ?? (maybe cid?) did the jsonschema stuff and maybe use that to validate what gets posted? | 16:24 |
| dtantsur | Sure, but we cannot change the fields in the same step | 16:24 |
| cardoe | So the inventory shouldn't be edited by the inspection hooks right? | 16:25 |
| cardoe | So just before the hooks get called I was normalizing the fields. | 16:25 |
| cardoe | Between 2024.1 -> 2025.2 we renamed a few fields along the way and have had crashers in inspection hooks. | 16:26 |
| dtantsur | yeah, ideally the hooks should leave inventory alone and only modify plugin_data | 16:26 |
| * dtantsur jumps on a meeting, sorry | 16:26 | |
| cardoe | So I'm modifying the inventory before passing it to the hooks inside of conductor | 16:26 |
| cardoe | Cause we've renamed fields in IPA over the last 18 months | 16:27 |
| * cid is a little lost. | 16:31 | |
| cid | cardoe, is the ongoing discussion around this patch? https://review.opendev.org/c/openstack/ironic/+/963179 | 16:31 |
| cardoe | yeah but branching out from that to where I'm trying to document and normalize the names inside of ironic | 16:31 |
| cardoe | Cause forever ironic has treated it as a bag of bytes but then certain code paths rely on data to be in there at specific keys for specific things that blow up | 16:32 |
| cardoe | So just trying to capture that and then end up putting a check on the upload from the IPA endpoint that the right fields are there | 16:32 |
| cid | Yeah, I just took a look. | 16:45 |
| cid | I think your approach works fwiw. Accept both legacy and canonical an dwhen the former is provided, normalize and log a warning. That's good path to deprecation. | 16:45 |
| *** dmellado0 is now known as dmellado | 16:48 | |
| opendevreview | Merged openstack/ironic stable/2025.2: Make cache_firmware_components more resilient during upgrades https://review.opendev.org/c/openstack/ironic/+/967485 | 17:00 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: fix: local_link_connection inspection hook does not fail on missing port https://review.opendev.org/c/openstack/ironic/+/966684 | 17:06 |
| opendevreview | cid proposed openstack/ironic stable/2025.2: Filter null NIC firmware versions from cache https://review.opendev.org/c/openstack/ironic/+/966773 | 17:09 |
| opendevreview | Merged openstack/ironic master: Add a `noop` deploy interface https://review.opendev.org/c/openstack/ironic/+/964448 | 17:21 |
| opendevreview | Merged openstack/ironic master: docs: Fix typos and a wrong URL https://review.opendev.org/c/openstack/ironic/+/967560 | 17:21 |
| opendevreview | cid proposed openstack/ironic master: Follow-up: Document `noop` deploy interface https://review.opendev.org/c/openstack/ironic/+/967586 | 17:22 |
| opendevreview | Merged openstack/ironic stable/2025.2: Fix : AsRockRack Management via Redfish https://review.opendev.org/c/openstack/ironic/+/967537 | 17:43 |
| opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Implement functionality for the is_root_volume RAID config https://review.opendev.org/c/openstack/ironic-python-agent/+/963200 | 17:48 |
| opendevreview | Verification of a change to openstack/ironic master failed: Update devstack guides to raise RAM requirement https://review.opendev.org/c/openstack/ironic/+/967087 | 18:07 |
| TheJulia | cardoe: I figure that, just wanted to compare and understand. | 18:30 |
| TheJulia | cardoe: fyi, the 2025.1 stock image is now 100mb smaller | 18:42 |
| TheJulia | rpittau: oh, I was thinking 2024.1, which did just recently swap over | 18:43 |
| rpittau | Ok, yeah, that's gone :) | 18:55 |
| opendevreview | Merged openstack/ironic-python-agent master: Implement functionality for the is_root_volume RAID config https://review.opendev.org/c/openstack/ironic-python-agent/+/963200 | 19:28 |
| opendevreview | Merged openstack/ironic stable/2025.1: fix: local_link_connection inspection hook does not fail on missing port https://review.opendev.org/c/openstack/ironic/+/966684 | 19:51 |
| opendevreview | Verification of a change to openstack/ironic-python-agent-builder master failed: Add simple-init by default https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966192 | 22:36 |
| opendevreview | Nahian Pathan proposed openstack/ironic master: Reduce API calls when collecting sensor data with redfish https://review.opendev.org/c/openstack/ironic/+/955484 | 22:58 |
| opendevreview | Merged openstack/sushy master: Add complete LLDP fields to Port.Ethernet.LLDPReceive per DMTF Redfish v1.12.0 https://review.opendev.org/c/openstack/sushy/+/966616 | 23:02 |
| opendevreview | Nahian Pathan proposed openstack/ironic master: Reduce API calls when collecting sensor data with redfish https://review.opendev.org/c/openstack/ironic/+/955484 | 23:06 |
| opendevreview | Merged openstack/ironic master: Add node.instance_name https://review.opendev.org/c/openstack/ironic/+/952790 | 23:27 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Use Debian Trixie for debian based IPA ramdisks https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/966253 | 23:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!