| opendevreview | cid proposed openstack/ironic master: `is-empty` inspection rule to handle missing field https://review.opendev.org/c/openstack/ironic/+/968999 | 00:32 |
|---|---|---|
| *** hroy_ is now known as hroy | 02:37 | |
| rpittau | good morning ironic! o/ | 08:18 |
| Ayo[m] | Good morning ironic:) | 08:52 |
| Ayo[m] | Hi there rpittau :) | 08:52 |
| rpittau | Ayo[m]: hi! :) | 08:53 |
| rpittau | Ayo[m] I'm replying to your email now | 08:53 |
| Ayo[m] | Well received rpittau | 09:14 |
| Ayo[m] | Thank you for your time | 09:14 |
| opendevreview | Abhishek Bongale proposed openstack/networking-generic-switch master: clean up codespell jobs https://review.opendev.org/c/openstack/networking-generic-switch/+/969243 | 13:25 |
| opendevreview | cid proposed openstack/ironic master: Drop xinetd/tftpd on CentOS 9 https://review.opendev.org/c/openstack/ironic/+/964449 | 13:49 |
| opendevreview | cid proposed openstack/ironic master: Trivial: Fix typo in documentation https://review.opendev.org/c/openstack/ironic/+/969245 | 13:50 |
| TheJulia | good morning | 14:30 |
| cardoe | so it looks like I turned off enforcement in master of E127 for over-indention of % formatted strings accidentally | 14:40 |
| cardoe | JayF noticed it reviewing https://review.opendev.org/c/openstack/ironic/+/969120 | 14:42 |
| TheJulia | Interesting! | 14:43 |
| cardoe | So its because ruff devs expect that folks have moved away from % format. Which they by default will convert the syntax. So they never added the check. | 14:48 |
| cardoe | So I can re-enable flake8 to run that check. | 15:09 |
| cardoe | We can also decide to reformat the code and let ruff auto-format always. | 15:09 |
| cardoe | We can set the target Python version as 3.7 so we can backport as far as possible. | 15:09 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2025.2: fix: ensure that the bootloader path exists https://review.opendev.org/c/openstack/ironic/+/969120 | 15:12 |
| opendevreview | cid proposed openstack/ironic master: Redfish VirtualMedia NFS and SMB/CIFS Support https://review.opendev.org/c/openstack/ironic/+/958505 | 15:30 |
| opendevreview | Merged openstack/ironic master: Trivial: Fix typo in documentation https://review.opendev.org/c/openstack/ironic/+/969245 | 15:49 |
| TheJulia | seems like auto-reformatting might be a way to go although we would need to be super careful in such a review | 15:50 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Make post-firmware-update reboot conditional on component https://review.opendev.org/c/openstack/ironic/+/966344 | 16:19 |
| cardoe | Are we removing the tinyipa jobs? | 16:53 |
| cardoe | oh we just renamed them to take tinyipa out of the name | 16:54 |
| TheJulia | well, renaming them, I think they've already been changed | 17:02 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add an option to fallback to HTTP https://review.opendev.org/c/openstack/ironic/+/969277 | 17:22 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: WIP: upload and use the OCI image https://review.opendev.org/c/openstack/bifrost/+/968417 | 17:29 |
| cardoe | dtantsur: I don't understand your review on https://review.opendev.org/c/openstack/ironic/+/968246 I'm not changing at all the wording or the message from what you committed. The change is to indent it differently to ensure the proper cleanup happens. | 17:51 |
| dtantsur | ah, yeah, it was not quite correct before too.. | 17:52 |
| cardoe | You've got 3 path variables involved and display 2 of them. | 17:53 |
| TheJulia | clearly, we need longer variable names | 17:53 |
| TheJulia | :) | 17:54 |
| cardoe | I had a branch to un-wind all this but threw in the towel after like 90 minutes with Claude. | 17:54 |
| dtantsur | You're not the first, I'm afraid.. | 17:54 |
| dtantsur | :) | 17:54 |
| cardoe | And to answer your question where the OSError is coming from... yes... deep inside of _fetch() | 17:55 |
| cardoe | If the periodic job to clean up fires while a download is happening, it will delete the tmp file that is being downloaded to. So once the download completes and we move to the os.link(), the file is gone. | 17:55 |
| dtantsur | Eeeek, that should not be happening | 17:56 |
| cardoe | the cleanup doesn't respect the locks | 17:56 |
| cardoe | If you need to convert file formats and oslo.utils reports a size large enough to trigger a cleanup... it'll delete your downloaded file. | 17:57 |
| dtantsur | My my, image cache was one of my first assignments on the project, whole 11 years ago https://opendev.org/openstack/ironic/commit/fb771158d0c7b3876e09808b9897f9d64a9fdcf4 :D | 17:57 |
| dtantsur | Please make sure this is filed as a bug, it definitely was not intended | 17:58 |
| cardoe | If you're crossing file system boundaries for the conversion (tmp in one place and master in another) it'll fail | 17:58 |
| cardoe | I think the issue is that we need to not have conversion be a magical step in the fetch process. | 17:59 |
| cardoe | But a deliberate step | 17:59 |
| dtantsur | The whole thing is worth a complete rewrite | 18:00 |
| dtantsur | Maybe somebody will celebrate 12 years of image cache by writing a new one? :D | 18:01 |
| TheJulia | I think the last time we discussed that... maybe 2-ish years ago, we talked about drinking. a lot. | 18:01 |
| dtantsur | as we usually do :) | 18:02 |
| cardoe | So anyway, my goal was to split up the messages a little bit to give folks a bread crumb where it went south. | 18:03 |
| cardoe | John Garbutt also saw something here recently and so the hope was with the two separate log statements maybe one of the two of us would see in prod where it fired. | 18:04 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Remove `reading_celsius` label from baremetal_temperature_status https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/969288 | 18:04 |
| cardoe | I think long term I'd want to have _fetch() just do the fetch and then we create a _convert_if_needed() and call it. | 18:04 |
| cardoe | On certain filesystems I can have it fail 100% of the time. Cause they'll order the files back by recently created inode so it'll choose to cleanup your downloaded file first. | 18:06 |
| TheJulia | certain filesystems being? | 18:10 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add an option to fallback to HTTP https://review.opendev.org/c/openstack/ironic/+/969277 | 18:17 |
| * JayF suspects NFS/CIFS | 18:20 | |
| cardoe | yeah it was NFS that I did it | 18:24 |
| cardoe | I'll make some bugs | 18:25 |
| dtantsur | if we don't have access to mtime, they yeah, probably | 18:25 |
| cardoe | At least I assume that PVC read-write-many was NFS on ceph | 18:25 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Ignore unstable label for metrics to avoid multiple Alerts https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/969288 | 18:39 |
| TheJulia | hmm... getting closer, need to get authentication deets in | 18:54 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: Upload a disk image to OCI https://review.opendev.org/c/openstack/bifrost/+/968416 | 19:21 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: WIP: upload and use the OCI image https://review.opendev.org/c/openstack/bifrost/+/968417 | 19:24 |
| * TheJulia hopes for success. | 19:38 | |
| opendevreview | Verification of a change to openstack/networking-generic-switch master failed: clean up codespell jobs https://review.opendev.org/c/openstack/networking-generic-switch/+/969243 | 20:27 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Debug oci authentication https://review.opendev.org/c/openstack/ironic/+/969314 | 20:44 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: WIP: upload and use the OCI image https://review.opendev.org/c/openstack/bifrost/+/968417 | 20:52 |
| TheJulia | hmm, I think I finally grok what dtantsur was complaining about authentication for the oci stuffs at one point. | 20:53 |
| TheJulia | It feels like there is a case one can fall into where it becomes unhappiness, which is not that surprising really | 21:09 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Separate states code from states constants https://review.opendev.org/c/openstack/ironic/+/969318 | 21:15 |
| TheJulia | technically, looks like there is a case where you are thought to end up in a basic auth path but really want to use bearer auth based token | 21:16 |
| opendevreview | Steve Baker proposed openstack/ironic master: Add a conductor liveness check utility script https://review.opendev.org/c/openstack/ironic/+/969320 | 21:22 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: Upload a disk image to OCI https://review.opendev.org/c/openstack/bifrost/+/968416 | 21:40 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: WIP: upload and use the OCI image https://review.opendev.org/c/openstack/bifrost/+/968417 | 21:40 |
| TheJulia | gaaaah | 21:40 |
| * TheJulia goes into town | 21:41 | |
| TheJulia | my frustration was oras, it appears | 21:44 |
| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: Add request logging for API requests https://review.opendev.org/c/openstack/ironic-python-agent/+/958307 | 22:05 |
| cardoe | TheJulia: orcas are just misunderstood animals! They're not killers! | 22:18 |
| stevebaker[m] | cardoe: no you're thinking of Orcas. I'm pretty sure she was referring to Pokémon Omega Ruby and Alpha Sapphire (ORAS) | 22:26 |
| cardoe | ah right you are. | 22:28 |
| cardoe | So trying to make these bugs against the image cache... Is there a reason we don't trust the virtual_size that gets returned by glance? I checked the code and it's using the same code we now use. | 22:32 |
| cardoe | The code comment says that glance returns a different value which I suspect was true when we didn't share the same oslo code. | 22:37 |
| cardoe | Honestly the glance code is pretty solid. | 22:44 |
| JayF | I suspect it's OK to change some of those assumptions there at this point, since we do share code for it now -- but make sure you're not checking in a place that could be post-conversion | 22:53 |
| opendevreview | Merged openstack/networking-generic-switch master: clean up codespell jobs https://review.opendev.org/c/openstack/networking-generic-switch/+/969243 | 23:08 |
| * TheJulia blinks | 23:09 | |
| TheJulia | Uhh, surelly Blahaj will have an answer later today | 23:09 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: WIP: Upload a disk image to OCI https://review.opendev.org/c/openstack/bifrost/+/968416 | 23:25 |
| opendevreview | Julia Kreger proposed openstack/bifrost master: WIP: upload and use the OCI image https://review.opendev.org/c/openstack/bifrost/+/968417 | 23:25 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!