| *** hroy_ is now known as hroy | 00:33 | |
| opendevreview | Steve Baker proposed openstack/ironic master: Swap to bootc deploy interface for bootc images https://review.opendev.org/c/openstack/ironic/+/966761 | 02:29 |
|---|---|---|
| *** darmach3 is now known as darmach | 04:26 | |
| opendevreview | cid proposed openstack/ironic-python-agent master: Add type annotations https://review.opendev.org/c/openstack/ironic-python-agent/+/958333 | 05:42 |
| rpittau | good morning ironic! o/ | 07:03 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-prometheus-exporter master: Update supported Python versions https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/969473 | 13:56 |
| rpittau | dtantsur: not sure I get your comment in https://review.opendev.org/c/openstack/bifrost/+/969886, which secure boot code is impacted by changing the default ipa to debian? | 14:15 |
| rpittau | we don't test secure boot in CI | 14:18 |
| rpittau | with debian as default it's probably easier to do that, better compatibility with the ubuntu hosts, but probably need a different patch if we want to implement that | 14:18 |
| dtantsur | rpittau: bifrost is not just CI | 15:09 |
| dtantsur | but now I see that it's a bit of a mess: we default the configuration to "efi_distro", which defaults to ansible_facts['distribution'] | 15:11 |
| dtantsur | so I guess mixed distributions won't work for secure boot (or for any virtual media?) | 15:11 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2024.2: fix: ensure that the bootloader path exists https://review.opendev.org/c/openstack/ironic/+/969123 | 15:37 |
| opendevreview | Doug Goldstein proposed openstack/ironic bugfix/33.0: fix: ensure that the bootloader path exists https://review.opendev.org/c/openstack/ironic/+/970270 | 15:39 |
| rpittau | yeah, it was just an observation, I was thinking out loud in case we want to start testing that | 15:40 |
| rpittau | and yes, it probably won't work with mixed distros | 15:40 |
| rpittau | it could be fixable by adding a new variable for the grub path | 15:41 |
| rpittau | multiple things coming out from this :D | 15:41 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: do not allow nested paths in loader_file_paths https://review.opendev.org/c/openstack/ironic/+/968419 | 15:43 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: remove sushy_oem_idrac usage https://review.opendev.org/c/openstack/ironic/+/970273 | 15:44 |
| dtantsur | alegacy_: to make sure you won't miss it: review.opendev.org/c/openstack/ironic/+/966468 will also land with a bunch of comments/questions to address | 16:07 |
| alegacy_ | dtantsur: got it... will try to address your latest comments today. | 16:37 |
| alegacy_ | i'll add fixes for those comments to a new commit at the end of the chain of patches. | 16:39 |
| dtantsur | yep | 16:41 |
| opendevreview | Marcus Furlong proposed openstack/sushy master: Don't require Boot and Actions for Systems https://review.opendev.org/c/openstack/sushy/+/967715 | 17:03 |
| opendevreview | Merged openstack/ironic master: Implement networking service RPC API methods https://review.opendev.org/c/openstack/ironic/+/966468 | 17:33 |
| opendevreview | Merged openstack/ironic-python-agent master: Add request logging for API requests https://review.opendev.org/c/openstack/ironic-python-agent/+/958307 | 18:29 |
| opendevreview | Merged openstack/ironic-prometheus-exporter master: Update supported Python versions https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/969473 | 18:34 |
| opendevreview | Merged openstack/ironic-prometheus-exporter master: Use removeprefix instead of replace in ironic.py https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/969475 | 18:53 |
| opendevreview | Verification of a change to openstack/ironic master failed: Add PCIe function fields to redfish inspection https://review.opendev.org/c/openstack/ironic/+/963179 | 19:47 |
| opendevreview | Merged openstack/ironic master: Add documentation regarding the is_root_volume RAID config https://review.opendev.org/c/openstack/ironic/+/969419 | 19:53 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/970004 is a pretty simple but important fix we should get in, needs another +2 | 20:01 |
| stevebaker[m] | done | 20:05 |
| JayF | cardoe: TheJulia: https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/970040 one of you might be a particularly good review for that | 21:02 |
| opendevreview | Merged openstack/ironic master: Trivial: Fix `instance_name` policy name https://review.opendev.org/c/openstack/ironic/+/970004 | 21:33 |
| opendevreview | Merged openstack/ironic bugfix/31.0: fix: ensure that the bootloader path exists https://review.opendev.org/c/openstack/ironic/+/969124 | 21:53 |
| opendevreview | Merged openstack/ironic bugfix/33.0: fix: ensure that the bootloader path exists https://review.opendev.org/c/openstack/ironic/+/970270 | 22:03 |
| cardoe | JayF: will do | 22:07 |
| cardoe | JayF: I had been looking at your state stuff. I'd love to add some type annotations to it. | 22:08 |
| cardoe | But otherwise its good | 22:08 |
| cardoe | ugh yeah I need to dig into that | 22:09 |
| JayF | I'm not adding type annotations to new code until either: 1) we have an agreement among cores to require it for all new changes or 2) we migrate the majority of code to use them | 22:10 |
| opendevreview | Merged openstack/ironic master: fix: do not allow nested paths in loader_file_paths https://review.opendev.org/c/openstack/ironic/+/968419 | 22:41 |
| cardoe | JayF: that's fair | 23:18 |
| cardoe | I use it just to make it easier to figure out what something is. | 23:18 |
| JayF | not trying to be a pain, just I think making things more inconsistent is not good | 23:18 |
| cardoe | No you're right. | 23:18 |
| JayF | I'm a little annoyed at how ... fiddly the IPA change cid is working on has been | 23:19 |
| JayF | I almost wonder if we need to write code for ruff to respect our import rules | 23:19 |
| cardoe | I only nudged clif on it cause he has a couple of places that took the ironic.db.Port or the ironic.object.Port or the his own Port or another Port that's in the code. | 23:19 |
| cardoe | And I couldn't make heads or tails of which object he was dealing with and when. | 23:19 |
| JayF | it's not fiddly because of anything he's doing, it's just clearly ruff is doing whatever works, and we need better than that | 23:19 |
| JayF | a lot of port-like-object representations in TBN, at least logically | 23:20 |
| cardoe | I'm not seeing a lot of import changes in cid's stuff when I reviewed it but I only got part of the way. | 23:21 |
| cardoe | The bigger change I saw was changing ' to " | 23:21 |
| JayF | I don't care about ' to " but if we can disable that it'd be more reviewable | 23:21 |
| JayF | go look at my comments on that change | 23:21 |
| cardoe | Which we could set the flag to allow either and the diff gets smaller. | 23:21 |
| JayF | lots of | 23:21 |
| JayF | we already have import X from Y | 23:21 |
| JayF | then ruff adds | 23:21 |
| JayF | import Y.X.Blah | 23:21 |
| JayF | or similar | 23:21 |
| JayF | as well as when it adds those imports, putting them in the wrong place | 23:22 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!