| JayF | NODE_FAILURE :( | 01:15 |
|---|---|---|
| opendevreview | Verification of a change to openstack/ironic master failed: Separate states code from states constants https://review.opendev.org/c/openstack/ironic/+/969318 | 02:30 |
| *** hroy_ is now known as hroy | 02:36 | |
| opendevreview | Merged openstack/ironic master: Separate states code from states constants https://review.opendev.org/c/openstack/ironic/+/969318 | 05:33 |
| rpittau | good morning ironic! o/ | 07:47 |
| opendevreview | nidhi proposed openstack/ironic master: Add Redfish LLDP data collection support to the Redfish inspection interface. https://review.opendev.org/c/openstack/ironic/+/967841 | 08:45 |
| opendevreview | nidhi proposed openstack/ironic master: Add Redfish LLDP data collection support to the Redfish inspection interface. https://review.opendev.org/c/openstack/ironic/+/967841 | 08:56 |
| opendevreview | Verification of a change to openstack/ironic master failed: `is-empty` inspection rule to handle missing field https://review.opendev.org/c/openstack/ironic/+/968999 | 09:56 |
| opendevreview | nidhi proposed openstack/ironic master: Add Redfish LLDP data collection support to the Redfish inspection interface. https://review.opendev.org/c/openstack/ironic/+/967841 | 10:14 |
| opendevreview | Merged openstack/ironic master: `is-empty` inspection rule to handle missing field https://review.opendev.org/c/openstack/ironic/+/968999 | 12:15 |
| opendevreview | nidhi proposed openstack/ironic master: Add Redfish LLDP data collection support to the Redfish inspection interface. https://review.opendev.org/c/openstack/ironic/+/967841 | 14:10 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-prometheus-exporter master: Fix handling of unknown metric keys in ironic parser https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/970627 | 14:16 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2025.1: fix: ensure that the bootloader path exists https://review.opendev.org/c/openstack/ironic/+/969122 | 14:17 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: remove sushy_oem_idrac usage https://review.opendev.org/c/openstack/ironic/+/970273 | 14:19 |
| cardoe | TheJulia: poke.. https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/942220 | 14:22 |
| cardoe | JayF: I'm not informed enough on https://review.opendev.org/c/openstack/ironic/+/957613 but it seems like you might be. cid is asking if we should abandon it? | 14:26 |
| cid | Yeah, so, it seems to me like it's a good to have, but I don't know how much necessary. The context that I'm trying to clear my backlog. | 14:28 |
| cid | So, I wanted to get opinions. | 14:28 |
| cid | Possibly, get it merged or abandoned | 14:29 |
| opendevreview | nidhi proposed openstack/ironic master: Add LLDP collect for DRAC Redfish inspection https://review.opendev.org/c/openstack/ironic/+/970630 | 14:33 |
| opendevreview | Merged openstack/ironic master: [api-ref] Fix api-ref to mention list port by cg https://review.opendev.org/c/openstack/ironic/+/970482 | 14:46 |
| opendevreview | nidhi proposed openstack/ironic master: Add LLDP collect for DRAC Redfish inspection https://review.opendev.org/c/openstack/ironic/+/970630 | 14:48 |
| opendevreview | Merged openstack/sushy master: Don't require Boot and Actions for Systems https://review.opendev.org/c/openstack/sushy/+/967715 | 15:07 |
| opendevreview | Verification of a change to openstack/ironic master failed: Move `check_image_size` to `deploy_utils` https://review.opendev.org/c/openstack/ironic/+/970181 | 15:15 |
| dtantsur | Actually, https://review.opendev.org/c/openstack/ironic/+/970450 does not look terrible from the first glance. We may do something useful with it. I'm not sure why Claude failed to fix its own unit test though.. | 15:36 |
| dtantsur | cid: if you want to take a look at some point ^^ | 15:36 |
| cid | Will check it out. tks | 15:37 |
| opendevreview | Verification of a change to openstack/ironic master failed: Trait Based Networking Simulator https://review.opendev.org/c/openstack/ironic/+/966202 | 15:45 |
| opendevreview | nidhi proposed openstack/ironic master: Add Redfish LLDP data collection support to the Redfish inspection interface. https://review.opendev.org/c/openstack/ironic/+/967841 | 16:21 |
| opendevreview | Merged openstack/networking-generic-switch master: Fix incorrect command when unplugging bond subports https://review.opendev.org/c/openstack/networking-generic-switch/+/959423 | 16:25 |
| cardoe | I love when my "recheck wow these logs are noisy... do it again" passes and merges | 16:26 |
| opendevreview | Verification of a change to openstack/ironic master failed: Move `check_image_size` to `deploy_utils` https://review.opendev.org/c/openstack/ironic/+/970181 | 16:27 |
| opendevreview | Verification of a change to openstack/ironic master failed: Trait Based Networking Simulator https://review.opendev.org/c/openstack/ironic/+/966202 | 16:33 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Replace remaining usage of policy.json https://review.opendev.org/c/openstack/ironic/+/970650 | 16:35 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Replace remaining usage of policy.json https://review.opendev.org/c/openstack/ironic/+/970650 | 16:44 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [PoC] Unedited AI dump: asynchronous Redfish client https://review.opendev.org/c/openstack/ironic/+/970450 | 17:48 |
| dtantsur | I think we're onto something with Claude here ^^^ | 17:48 |
| dtantsur | I've dropped the attempt to emulate the sushy's API and instead when for (my long dream of) a simple non-typed one | 17:49 |
| dtantsur | This is a working example of the API I came up with: https://paste.opendev.org/show/bGtAAes4Y5Kk0ZwVp034/ | 17:49 |
| dtantsur | I really like the simplicity of it, to be honest. And if we want to, we can eventually build an object-oriented API on top of it | 17:50 |
| opendevreview | Jay Faulkner proposed openstack/python-ironicclient master: Filter portgroups by shard https://review.opendev.org/c/openstack/python-ironicclient/+/970562 | 17:57 |
| jizaymes | good day. My 2025.2 ironic-conductor service keeps saying 'Forking too fast, sleeping'. I've enabled debug but it doesn't provide any info. Child 2954 exited with status 1 Forking too fast, sleeping | 18:03 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add note about file being copied over to Nova https://review.opendev.org/c/openstack/ironic/+/970662 | 18:10 |
| JayF | There is likely an associated error with the rapid crashing somewhere in there. | 18:10 |
| JayF | cardoe: is this similar to the issues you've seen in containers? | 18:10 |
| jizaymes | ok I see have now found an error on the logs of my container. No logs were present in my log file. mistakenly set vlan as a network type .. | 18:13 |
| jizaymes | thanks | 18:13 |
| jizaymes | . | 18:13 |
| JayF | Glad you got it figured out! | 18:18 |
| JayF | More glad it's not a bug :D | 18:18 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [PoC] Unedited AI dump: asynchronous Redfish client https://review.opendev.org/c/openstack/ironic/+/970450 | 18:50 |
| dtantsur | Folks, is it expected that `tox -epep8` does not report continuation line under-indented for visual indent [E128] [python/flake8]? | 18:52 |
| dtantsur | vim complains, but tox passes | 18:52 |
| opendevreview | Jonathan Davies proposed openstack/ironic-python-agent master: enable_vlan_interfaces: support identifying interfaces by MAC https://review.opendev.org/c/openstack/ironic-python-agent/+/955629 | 19:06 |
| cardoe | dtantsur: so yes. I realized that's my mistake. https://github.com/astral-sh/ruff/issues/2402 | 19:40 |
| cardoe | So I need to re-enable pycodestyle but just for those rules. | 19:40 |
| cardoe | So since we use hacking, its technically a flake8 plugin and when we switched to ruff we got rid of the flake8 rules. So hacking runs with the flake8 defaults. We were pinned back on an old version of flake8 and its dependencies which actually had a bug in one of the rules which resulted in ruff and hacking going back and forth in a circular loop. | 19:42 |
| cardoe | I couldn't get hacking to use a newer version and so I disabled it enforcing in 32bb6e3dff358fc73a43c1689f06392909481d30 | 19:43 |
| cardoe | ah. I made a patch to re-enable but it looks like it never got opened. | 19:47 |
| cardoe | https://github.com/astral-sh/ruff/pull/13585 is what we need to land and then we can re-disable it. | 19:47 |
| cardoe | Technically all the rest are pre-Python 3.7 syntax style. | 19:47 |
| cardoe | Even some in that pull request are pre-Python 3.7 style. | 19:48 |
| cardoe | That's one of the things about ruff. It won't do anything for pre-Python 3.7 style. | 19:48 |
| cardoe | We've got a lot of pre-Python 3.0 style even. | 19:49 |
| cardoe | There's actually a handful of hacking rules that are implemented in ruff now (and actually more correctly) | 19:51 |
| cardoe | hacking for example doesn't catch some issues with f-strings | 19:52 |
| cardoe | oh that's why I didn't submit the fix. | 19:58 |
| cardoe | https://www.irccloud.com/pastebin/xwZDKbU7/ | 19:58 |
| cardoe | If you use the extend-select option in [flake8] like you're suppose to. | 19:59 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Fix waiting config drive with the correct publisher id https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/970040 | 22:49 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!