| TheJulia | ugh | 00:09 |
|---|---|---|
| *** hroy_ is now known as hroy | 05:05 | |
| *** hroy_ is now known as hroy | 05:26 | |
| abongale | good morning ironic o/ | 09:46 |
| Continuity | Morning | 09:47 |
| Continuity | JayF: good news your CHUNK patch seems to have worked, with a chunk of 1MB went from 514 seconds to 40.03 seconds on a 25Gb image with CPU sitting at 25-50% (which while not idea... is better than the alternative) | 13:54 |
| TheJulia | good morning | 14:06 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [PoC] Unedited AI dump: asynchronous Redfish client https://review.opendev.org/c/openstack/ironic/+/970450 | 14:38 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [PoC] Unedited AI dump: demonstrate collecting sensors asynchronously https://review.opendev.org/c/openstack/ironic/+/970842 | 14:38 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: VXLAN networking https://review.opendev.org/c/openstack/ironic-specs/+/959401 | 15:05 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: report a better error in validate-interfaces https://review.opendev.org/c/openstack/ironic/+/972306 | 15:05 |
| cardoe | TheJulia: I'll give it a read shortly. | 15:06 |
| JayF | Continuity: I wonder if there's a sweet spot to be found by raising the chunk size even further | 15:15 |
| JayF | Also, please include that feedback in the Gerrit review if you haven't already | 15:15 |
| JayF | Like literally, I wonder if you reran that with 10 Meg chunks instead of one Meg chunks if we would see a similar speed up again | 15:28 |
| dtantsur | Ask the LLM of your choice :) | 15:29 |
| dtantsur | my vague impression is that 1M is the very minimum, and trying 4M/16M is a reasonable idea | 15:29 |
| Continuity | Ill add it to the review shortly | 15:30 |
| TheJulia | I'm a little skeptical but also it would really be reliant upon the underlying network performance at that point, i.e. how much of the data can really get housed in the socket before the socket is emptied. Requests will do some of that, but I *think* the code needs to ensure that it might not always get that amount in each iteration. I believe the requests docs highlight this because we ran into something along those | 15:40 |
| TheJulia | lines with IPA years ago. | 15:40 |
| JayF | I'll go dig for that doc, thanks for the pointer | 15:48 |
| JayF | I am convinced that if there's any further ground to be gained, it's minor compared to what we've already done. We already went from 210M iterations to 25k iterations for a 25GB file. | 15:55 |
| JayF | So I think https://review.opendev.org/c/openstack/ironic/+/964502 is good for review then | 15:56 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [PoC] Unedited AI dump: demonstrate collecting sensors asynchronously https://review.opendev.org/c/openstack/ironic/+/970842 | 16:09 |
| TheJulia | JayF: yeah, that is kind of what I'm thinking as well | 16:18 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Add retry logic for boot device changes during POST https://review.opendev.org/c/openstack/ironic/+/971150 | 16:53 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Add retry logic for boot device changes during POST https://review.opendev.org/c/openstack/ironic/+/971150 | 16:56 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Deferred Tasks https://review.opendev.org/c/openstack/ironic-specs/+/954612 | 17:05 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Deferred Tasks https://review.opendev.org/c/openstack/ironic-specs/+/954612 | 17:05 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: VXLAN networking https://review.opendev.org/c/openstack/ironic-specs/+/959401 | 17:13 |
| TheJulia | okay, that should fix the linting failure | 17:13 |
| TheJulia | cid: saw your comment on https://review.opendev.org/c/openstack/networking-baremetal/+/948432 and I've replied. | 17:38 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Improve image download performance https://review.opendev.org/c/openstack/ironic/+/964502 | 17:59 |
| cid | Happy new year Ironic, o/. | 18:21 |
| cid | tks, TheJulia, I will update microversion on the sdk | 18:21 |
| TheJulia | it looks like you you'll need to add an argument to be passed through as well | 18:21 |
| cid | Hmm, okay. I will take a look in a bit. | 18:24 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Silence loud logging when no NetworkAdapters https://review.opendev.org/c/openstack/ironic/+/972343 | 18:33 |
| opendevreview | Merged openstack/bifrost master: Remove ancient Python 3.6 tox test https://review.opendev.org/c/openstack/bifrost/+/956694 | 18:35 |
| opendevreview | Merged openstack/ironic master: Use common utility to wrap IPv6 address https://review.opendev.org/c/openstack/ironic/+/971590 | 19:18 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-prometheus-exporter master: Add project badge https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/972352 | 19:42 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-prometheus-exporter master: Add project badge https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/972352 | 19:43 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-python-agent master: Remove tags from README https://review.opendev.org/c/openstack/ironic-python-agent/+/972353 | 19:45 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Deferred Tasks https://review.opendev.org/c/openstack/ironic-specs/+/954612 | 19:46 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-python-agent master: Remove tags from README https://review.opendev.org/c/openstack/ironic-python-agent/+/972353 | 19:48 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-python-agent-builder master: Add project badge https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/972354 | 19:50 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-python-agent-builder master: Add project badge https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/972354 | 19:51 |
| iurygregory | <eyes> | 19:51 |
| iurygregory | project badge? .-. | 19:51 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-specs master: Remove tags from README https://review.opendev.org/c/openstack/ironic-specs/+/972355 | 19:53 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-specs master: Remove tags from README https://review.opendev.org/c/openstack/ironic-specs/+/972355 | 19:53 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-tempest-plugin master: Add project badge https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/972357 | 19:55 |
| opendevreview | Merged openstack/ironic bugfix/33.0: fix loading of built-in inspection rules https://review.opendev.org/c/openstack/ironic/+/971466 | 19:58 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-tempest-plugin master: Add project badge https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/972357 | 19:59 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-tempest-plugin master: Add project badge https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/972357 | 19:59 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-ui master: WIP/DNM: Node history support https://review.opendev.org/c/openstack/ironic-ui/+/962517 | 20:03 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-ui master: WIP/DNM: Node history support https://review.opendev.org/c/openstack/ironic-ui/+/962517 | 20:04 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-ui master: WIP/DNM: Node history support https://review.opendev.org/c/openstack/ironic-ui/+/962517 | 20:04 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-ui master: WIP/DNM: Node history support https://review.opendev.org/c/openstack/ironic-ui/+/962517 | 20:05 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-ui master: WIP/DNM: Node history support https://review.opendev.org/c/openstack/ironic-ui/+/962517 | 20:06 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-ui master: WIP/DNM: Node history support https://review.opendev.org/c/openstack/ironic-ui/+/962517 | 20:07 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent-builder master: re-enable simple-init by default https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/971330 | 20:09 |
| TheJulia | cardoe: would you scream in sadness if I were to take over https://review.opendev.org/c/openstack/networking-generic-switch/+/968377 ? | 20:11 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-python-agent-builder master: Add project badge https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/972354 | 20:15 |
| cardoe | TheJulia: please do | 20:21 |
| TheJulia | btw, I revised the spec again today, it now actually passes linting and all. That being said I'm still struggling with capturing words regarding the trunk configuraitons your doing, if you can provide more insight there and background that would be super helpful | 20:23 |
| opendevreview | Ivan Anfimov proposed openstack/ironic-tempest-plugin master: Add project badge https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/972357 | 20:32 |
| cardoe | gah launchpad never had a good way to format text... https://bugs.launchpad.net/ironic/+bug/2137596 | 21:39 |
| cardoe | TheJulia: yes. promise I will. | 21:39 |
| TheJulia | (sorry, not trying to be too persistent, but I tend to be in general) | 21:40 |
| * TheJulia twitches and glances back at claude doing its thing | 21:40 | |
| cardoe | No I appreciate it. I'm just having to get some hardware online and been trying to do it all nicely with Ironic | 21:42 |
| TheJulia | understand completely | 21:42 |
| cardoe | The code here hasn't changed since 2021 | 21:42 |
| TheJulia | using the idracified redfish, I'm semi-wondering if that might be the wrong redfish interface to use | 21:44 |
| cardoe | I made it a plain no-op wrapper a release or two ago. | 21:46 |
| cardoe | ironic/objects/bios.py has a call to a method that doesn't exist and seems to have not existed since 2021. | 21:46 |
| TheJulia | Err, that was what I was suspecting based upon that, but it seems super weird this hasn't been reported which makes me wonder... | 21:49 |
| cardoe | Exactly. I'm sitting here saying... "what am I doing wrong?" | 21:49 |
| TheJulia | I know Iury has done a bunch in that area too | 21:50 |
| TheJulia | but yeah | 21:50 |
| cardoe | e15440370cca1f1a998d3607910697c3129d040a is the commit that adds the code and its in there from that point | 21:51 |
| cardoe | Cause if I go back to then there's literally no method with that name. | 21:51 |
| cardoe | And there's an instance property that's being access as well that doesn't exist. | 21:52 |
| cardoe | I don't understand what that self.registry is | 22:02 |
| TheJulia | are you mid-upgrade? | 22:03 |
| TheJulia | like pinned vresion wise? | 22:03 |
| cardoe | running stable/2025.2 | 22:06 |
| TheJulia | but is a pin set? | 22:07 |
| TheJulia | that version code is confusing | 22:10 |
| TheJulia | I'd argue we could simplify it at this point | 22:11 |
| cardoe | ugh | 22:12 |
| cardoe | I found it. | 22:12 |
| cardoe | https://review.opendev.org/c/openstack/ironic-specs/+/774681 | 22:13 |
| cardoe | Up until version 8 of the spec there was a "registry" field that was going to be added to the DB model. | 22:13 |
| cardoe | It was gonna have a description of the field from the BIOS as a JSON blob. | 22:13 |
| cardoe | But dtantsur and Bob spoke and decided to drop it. | 22:13 |
| cardoe | version 13 of the spec is what's merged and approved. | 22:14 |
| TheJulia | it looks like an early verison it merged so it was added to rip it out | 22:14 |
| TheJulia | seems like, at this point, we're long past that window for keepign that and just drop it? | 22:14 |
| * TheJulia has made claude very sad by pouring cold water on it's perceptions | 22:15 | |
| cardoe | Yeah I'm looking and "openstack baremetal node bios setting list" has never worked for a box using redfish. | 22:16 |
| TheJulia | so if your sure that the registry and code and all is just excess, lets just drop it | 22:18 |
| TheJulia | Specifically, double checking OVO, it doesn't set a .registry object, but does set ._registry, I think its just unrelated. | 22:18 |
| cardoe | Is the entire function necessary? Does the default not do those? | 22:19 |
| cardoe | oh I see what it does nv, | 22:20 |
| TheJulia | heh | 22:20 |
| TheJulia | Yes, I'm kind of feeling like we could likely drop it sine we're out of the version window (really) | 22:21 |
| cardoe | It just sets the defaults if we're working with a new enough version so that you get some data back. | 22:24 |
| TheJulia | yup | 22:25 |
| TheJulia | you've got it, I need to run into town | 22:25 |
| TheJulia | I can review anything a little later | 22:25 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: bios fields could not be fetched via the API https://review.opendev.org/c/openstack/ironic/+/972413 | 22:38 |
| cardoe | I've had to grab some of iurygregory's patches too. | 22:38 |
| cardoe | Just trying to kick this hardware with Ironic doing all the lifting of firmware updates and BIOS settings. | 22:38 |
| cardoe | With a runbook too | 22:39 |
| cardoe | ^ and https://review.opendev.org/c/openstack/ironic/+/972306 are the two I'm gonna try and backport this wek. | 22:40 |
| opendevreview | Merged openstack/ironic-python-agent stable/2025.1: Fix for motherboards where efibootmgr returns UTF-8. https://review.opendev.org/c/openstack/ironic-python-agent/+/957909 | 23:18 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!