| TheJulia | cardoe: w/r/t port reconcilliation to ensure switch ports get toggled as it relates to ovn chassis. It sort of looks like, at least at a glance, that your creating a network port on the tenant networking to represent the attachment. wouldn't it be, at least structurally better to keep that out of view of the user but just do enough so the backend binds it. I guess a "fake" network is maybe where my brain is heading into, | 00:44 |
|---|---|---|
| TheJulia | which doesn't actually do anything but serve as a cross-reference point? | 00:44 |
| TheJulia | and the record keeper of those attachments | 00:44 |
| cardoe | So we create a network in the “service” project. The reason is that ports must be attached to a network. | 01:02 |
| cardoe | We in theory could use that network to allow the network nodes to communicate for HA purposes. | 01:03 |
| cardoe | The other shortcoming here with the port->trunk->subport model is that there’s no way to indicate if you want that top level port to be the access VLAN or if you don’t want access configured. | 01:04 |
| opendevreview | Steve Baker proposed openstack/ironic-tempest-plugin master: Add graphical console validate to basic ops scenario https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/963643 | 01:08 |
| TheJulia | Ahh, yeah, that makes more sense. I guess I wasn’t thinking about the network really working . I guess you really can’t say flat me a port and then go “give me a sub port” | 01:46 |
| TheJulia | Bake a network that is independent for controller purposes, then plug the matching vlan on back side. One network per OVN node or chassi. Actually, a network per chassis group simplifies some logic | 01:49 |
| TheJulia | So you can do a tight reconcile | 01:49 |
| TheJulia | To discuss tomorrow, wife is glaring at me. | 01:50 |
| cardoe | We've done one per OVN node but I was thinking the same as one network per chassis group as well. | 02:15 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: feat: skip invalid mac addr interfaces in redfish inspect add speed https://review.opendev.org/c/openstack/ironic/+/973283 | 02:21 |
| cardoe | If folks would have a look at https://review.opendev.org/q/hashtag:ironic-week-prio+status:open tomorrow. I've tried to curate the list to things that seem ready nor nearly ready with another patch landing. | 02:23 |
| opendevreview | Steve Baker proposed openstack/ironic master: OciImageService detect bootc image https://review.opendev.org/c/openstack/ironic/+/966760 | 02:33 |
| opendevreview | Steve Baker proposed openstack/ironic master: Add an autodetect deploy interface https://review.opendev.org/c/openstack/ironic/+/973187 | 02:33 |
| opendevreview | Steve Baker proposed openstack/ironic master: Replace ironic-tempest-bios-ipmi-direct with -autodetect https://review.opendev.org/c/openstack/ironic/+/974260 | 02:33 |
| opendevreview | Rico Lin proposed openstack/ironic master: Set columns in bios_settings table to bigint https://review.opendev.org/c/openstack/ironic/+/968348 | 02:40 |
| opendevreview | cid proposed openstack/ironic master: Minimum version bump https://review.opendev.org/c/openstack/ironic/+/974321 | 07:20 |
| rpittau | good morning ironic! happy friday! o/ | 07:26 |
| janders | hey rpittau o/ | 07:55 |
| janders | folks, if anyone has time I am after second +2 for the monitoring patch: https://review.opendev.org/c/openstack/ironic/+/966946 | 08:26 |
| janders | would be awesome to get it merged before it needs another rebase (I've done ~10 already) | 08:26 |
| janders | client and SDK are good to go too: https://review.opendev.org/c/openstack/python-ironicclient/+/967055 https://review.opendev.org/c/openstack/openstacksdk/+/973264. Client had +2 before but also needed rebase / minor changes | 08:27 |
| janders | CC kubajj JayF stevebaker[m] since they reviewed these previously | 08:27 |
| janders | thanks and apologies for the noise | 08:28 |
| rpittau | janders: I'm reading it now :) | 08:46 |
| janders | rpittau thank you! :) | 08:46 |
| kubajj | janders: is zuul going to remove its -1 once the change for ironic merges? | 09:10 |
| kubajj | (or do you have to recheck, for example) | 09:10 |
| janders | kubajj just ran recheck | 09:12 |
| janders | I suspect it had to do with merge conflicts | 09:12 |
| janders | SDK change also depends on API patch but didn't get the -1 | 09:12 |
| kubajj | janders: ok, will finish the review | 09:13 |
| janders | kubajj thank you! | 09:13 |
| janders | I saw similar behavior with firmware update chain during CI problems - first-in-chain patch passed reviews but was permafailing in CI due to CI issue and other patches in chain got minus votes due to this | 09:14 |
| janders | don't think unmerged "base" change should V-1 "depenent" change but I sense it was to do with the merge conflict - if anyone knows for certain I'd be curious to know the mechanism too | 09:15 |
| janders | no merge conflicts (for now) so reruns should be OK | 09:15 |
| opendevreview | Merged openstack/ironic master: Add hardware health monitoring via management interface https://review.opendev.org/c/openstack/ironic/+/966946 | 10:15 |
| janders | ^ \o/ long time in the making | 12:22 |
| janders | (966946) | 12:22 |
| cardoe | kubajj: if you’ve got some time today for some others in https://review.opendev.org/q/hashtag:ironic-week-prio+status:open | 12:51 |
| kubajj | cardoe: will try | 13:05 |
| rpittau | kubajj: metal3 related question (are you on slack btw?), is CERN still using https://github.com/metal3-io/ironic-hardware-inventory-recorder-image ? | 14:08 |
| TheJulia | good morning | 14:12 |
| TheJulia | brraaains | 14:14 |
| kubajj | rpittau: was not aware of the slack, but afaik, we do not have a metal3 deployment | 14:16 |
| rpittau | kubajj: yeah, but I remember Arne was using that container outside of metal3 | 14:17 |
| rpittau | hey TheJulia :) | 14:17 |
| kubajj | rpittau: I will check then | 14:18 |
| rpittau | kubajj: thanks :) | 14:18 |
| TheJulia | rpittau: he did for some add-hoc stuff if I am recalling the last time it was discussed | 14:45 |
| rpittau | ok, so no continuous usage? I remember the discussion, but since we plan to archive the repo, I don't want to break them :) | 14:46 |
| TheJulia | I doub't it | 14:54 |
| cardoe | TheJulia: would you have a gander at https://review.opendev.org/c/openstack/openstacksdk/+/973287 I'm gonna ask the SDK team to land that for the next release so that hopefully we can get the sharding bits completed for NGS | 15:00 |
| TheJulia | reviewed | 15:01 |
| TheJulia | LGTM, just no workflow button | 15:01 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Migrate database charset from UTF8MB3 to UTF8MB4 https://review.opendev.org/c/openstack/ironic/+/974430 | 15:03 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Migrate database charset from UTF8MB3 to UTF8MB4 https://review.opendev.org/c/openstack/ironic/+/974430 | 15:05 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-python-agent-builder master: Drop redundant basepython https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/974431 | 15:07 |
| TheJulia | I'm just going to ask if folks can take some time to look at https://review.opendev.org/c/openstack/ironic-specs/+/959401 it would be much appreciated. We're making really good progress and would love to actually feel like we can proceed with merging things like ml2 plugin capabilities and features | 15:07 |
| TheJulia | rpittau: are you thinking end of cycle for that change? | 15:13 |
| rpittau | TheJulia: yes, I just added a -1 workflow | 15:13 |
| rpittau | put it there so we have time for reviews | 15:14 |
| TheJulia | ack, yeah, that looks pretty good to me | 15:14 |
| TheJulia | we might want to clarify the release note a little bit more, around the downtime, specificaly it is while each table is locked for the alter table to rewrite the table | 15:14 |
| TheJulia | which can take time, quick for smaller operators, larger operators might take a little longer. | 15:15 |
| rpittau | yeah, makes sense | 15:15 |
| rpittau | on a different note, I'm plannig the bugfix cut and while on IPA we're pretty clear, I see we still have some ironic patches open, any one that we'd like to merge before the release? | 15:17 |
| rpittau | I was thinking this for example https://review.opendev.org/c/openstack/ironic/+/974317 | 15:17 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Migrate database charset from UTF8MB3 to UTF8MB4 https://review.opendev.org/c/openstack/ironic/+/974430 | 15:21 |
| TheJulia | Good update | 15:23 |
| rpittau | :) | 15:25 |
| rpittau | thanks for the review | 15:25 |
| TheJulia | so, how do I go about handing out "trust us... merge the vxlan spec" coffee cups? | 15:26 |
| rpittau | :D | 15:26 |
| TheJulia | I guess I'm excited since we have the base model attachment working | 15:32 |
| rpittau | I'm reading it now before closing for the weekend | 15:32 |
| TheJulia | cool cool | 15:33 |
| TheJulia | I'm wroking on trying to use up my pre-9am claude credits | 15:33 |
| TheJulia | Specifically the agent changes we refer to in that spec | 15:34 |
| rpittau | that spec is really pushing my limits of networking knowledge to the max | 15:36 |
| TheJulia | Yeah, it... is a LOT | 15:36 |
| TheJulia | but surprisingly simple once you context load it all | 15:36 |
| rpittau | really nice reading, I'm a bit concerned about the testing part, but I guess we have external tools besides CI that we can use, and we'll have chance during development to properly test the imeplementation | 15:43 |
| TheJulia | super easy and quick review: https://review.opendev.org/c/openstack/networking-generic-switch/+/973526 | 15:55 |
| TheJulia | rpittau: fwiw, I've already partially tested the mapping logic, its scarier than it sounds fwiw | 15:56 |
| TheJulia | err | 15:56 |
| TheJulia | it sound scarier than it really is | 15:56 |
| opendevreview | Merged openstack/ironic stable/2025.2: Fix introspection failure handling https://review.opendev.org/c/openstack/ironic/+/974069 | 16:02 |
| opendevreview | Merged openstack/ironic bugfix/33.0: fix redfish inspect system product name https://review.opendev.org/c/openstack/ironic/+/971488 | 16:02 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: devstack: Ignore error with file existing on restack https://review.opendev.org/c/openstack/networking-generic-switch/+/973310 | 16:21 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: WIP: l2vni plug case with Cisco NXOS https://review.opendev.org/c/openstack/networking-generic-switch/+/968377 | 16:21 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: WIP: Arista EOS and vendor neutral SONiC support for VXLAN attachments https://review.opendev.org/c/openstack/networking-generic-switch/+/972763 | 16:21 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: WIP: VXLAN: Add Junos, Cumulus NVUE, and denote Dell OS10 as unsupported https://review.opendev.org/c/openstack/networking-generic-switch/+/972764 | 16:21 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: WIP: OVS testing patch for 'vxlan' binding model https://review.opendev.org/c/openstack/networking-generic-switch/+/972765 | 16:21 |
| opendevreview | Merged openstack/ironic master: Minimum version bump https://review.opendev.org/c/openstack/ironic/+/974321 | 16:35 |
| opendevreview | Merged openstack/ironic master: OciImageService detect bootc image https://review.opendev.org/c/openstack/ironic/+/966760 | 16:43 |
| opendevreview | Merged openstack/ironic master: docs: refactor the inspection docs https://review.opendev.org/c/openstack/ironic/+/973971 | 16:43 |
| TheJulia | thinking outloud, we should likely double check some of our minimum versions and pull them forward | 16:44 |
| TheJulia | generally speaking | 16:44 |
| opendevreview | Merged openstack/ironic master: Refactor firmware update temp field handling https://review.opendev.org/c/openstack/ironic/+/974317 | 16:55 |
| cardoe | Yeah pretty sure we won't work with sqlalchemy 0.2 | 17:05 |
| TheJulia | no, no we will not | 17:06 |
| TheJulia | 1.9 at the oldest | 17:06 |
| cardoe | I was making a joke. | 17:06 |
| TheJulia | oh good | 17:06 |
| TheJulia | because I was making stories for the next sprint and hadn't looked yet | 17:07 |
| TheJulia | ooh, 1.4 | 17:07 |
| TheJulia | thats bad | 17:07 |
| JayF | ++ | 17:29 |
| TheJulia | so, 1.4 is actually right, it is where the 2.0 interface was introduced | 17:43 |
| kubajj | rpittau: Arne says, that we used to use it for live-inspection, we have it documented, but I have not used it myself ever | 17:49 |
| opendevreview | Merged openstack/networking-baremetal master: update pre-commit config to match ironic https://review.opendev.org/c/openstack/networking-baremetal/+/973979 | 17:51 |
| cardoe | well baremetal-l2vni seems to have done the right thing with my hardware | 17:53 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add ConfigLoader class to TBN and use it in TaskManager https://review.opendev.org/c/openstack/ironic/+/972495 | 17:55 |
| opendevreview | Clif Houck proposed openstack/ironic master: Integrate TBN with vif_attach https://review.opendev.org/c/openstack/ironic/+/973690 | 17:55 |
| opendevreview | Clif Houck proposed openstack/ironic master: WIP: Update TBN simulator for vif_attach planning https://review.opendev.org/c/openstack/ironic/+/973691 | 17:55 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add an ordering method for TBN traits https://review.opendev.org/c/openstack/ironic/+/974519 | 17:55 |
| opendevreview | Clif Houck proposed openstack/ironic master: Prevent multiple attach actions being generated for the same port https://review.opendev.org/c/openstack/ironic/+/974520 | 17:55 |
| opendevreview | Clif Houck proposed openstack/ironic master: Filter out already attached portlikes in plan_vif_attach https://review.opendev.org/c/openstack/ironic/+/974521 | 17:55 |
| clif | cardoe: idk if you've tried my patch at all but I found some issues that I've addressed ^^^ you probably want to try from the tip of my branch if you do | 17:56 |
| cardoe | I did run into some issues. | 17:56 |
| cardoe | I've actually got a change for you as well. | 17:56 |
| clif | haha, sorry :( | 17:56 |
| cardoe | Claude's working through it as we speak | 17:57 |
| cardoe | I'm changing your internal data structures. | 17:57 |
| clif | erg | 17:57 |
| clif | how so | 17:57 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily while we restart it onto new images after an update to the build toolchain | 18:01 | |
| opendevreview | Doug Goldstein proposed openstack/ironic master: convert trait based networking internal classes to dataclasses https://review.opendev.org/c/openstack/ironic/+/974524 | 18:03 |
| cardoe | clif: ^ like that | 18:03 |
| cardoe | So that's the first step I was going down to fixing what I hit. | 18:03 |
| clif | I like dataclasses, so I generally support this | 18:04 |
| clif | what did you hit? | 18:04 |
| cardoe | The objects are just storing some data fields without specifying what they really need to be. Nor do we limit the inputs in. Somewhere one of the **network or calls like that were resulting in one of the fields having the wrong data. | 18:05 |
| cardoe | So it could be something I screwed up in my configs but I figured if it was possible for me to load the data wrong we should tighten it up to enforce stuff harder | 18:06 |
| clif | agreed | 18:07 |
| cardoe | We'll see if that passes tests. | 18:07 |
| cardoe | I also changed tags from a list to a set cause it doesn't make sense to have the same tag repeated. | 18:07 |
| clif | makes sense | 18:07 |
| cardoe | Obviously not an important patch but I'm just trying to make APIs/interfaces where its impossible for the user/developer to use them wrong. | 18:12 |
| clif | well, if there *is* a bug that this solves it's important enough imo | 18:12 |
| clif | and I was about to +1 it but gerrit is momentarily down | 18:13 |
| opendevreview | Merged openstack/ironic master: [doc] Releasenote for iDRAC LLDP https://review.opendev.org/c/openstack/ironic/+/974366 | 18:17 |
| clif | cardoe: did you run into anything else? | 18:33 |
| cardoe | Well I didn't get to the underlying issue. | 18:44 |
| cardoe | I'll try your new stuff. | 18:44 |
| cardoe | yeah gerrit being down squirreled me cause I was gonna mention https://review.opendev.org/c/openstack/ironic/+/973557 is another thing I was doing to try and make it hard to use the APIs wrong | 18:56 |
| opendevreview | Merged openstack/bifrost master: Add the ability to override 'disable_boot_timeout' https://review.opendev.org/c/openstack/bifrost/+/973917 | 19:13 |
| rm_work[m] | JayF: any idea why it would take a long time to show a node within `openstack allocation candidate list` after it goes available in ironic? saw your name on some code around there so maybe you've got some idea what that might be | 19:24 |
| JayF | No idea at all. That's essentially a nova question moreso than an Ironic one. | 19:25 |
| rm_work[m] | hmm yeah i mean it's placement, but | 19:25 |
| rm_work[m] | wondered if you had worked in that area | 19:25 |
| rm_work[m] | guess not, i will poke nova folks | 19:25 |
| JayF | I've got zero code in placement, pretty close to zero code in nova outside nova.virt.ironic | 19:25 |
| rm_work[m] | hmmm | 19:25 |
| JayF | I tend to lean on John Garbutt for a lot of that stuff, but he's not around IRC so much anymore | 19:26 |
| *** gmaan is now known as gmaan_afk | 19:39 | |
| TheJulia | the tl;dr is the reconcile loop in progress needs to complete then some amount of time has to pass | 20:06 |
| TheJulia | stictly speaking, there is nothing really stopping us from publishing into placement, but there really hasn't been any push for that to be re-modeled | 20:08 |
| TheJulia | cardoe: I has my testvm cleaning on my test environment, through the upstream posted state of the l2vni driver, using the local port attachments, its on distinct vlan segment attached to the vm's ports, booted, running, attached in ovn to a geneve network, to a router with packets flowing to and frow | 20:20 |
| JayF | TheJulia laid down a gauntlet, I think I'm going to have to pick it up | 20:21 |
| JayF | maybe a good thing to discuss during ptg | 20:22 |
| JayF | (direct to placement) | 20:22 |
| TheJulia | We've discussed it before actually | 20:22 |
| TheJulia | just, lacking push to close that loop since most people are not jumping from enrolled in ironic to deployable via nova | 20:22 |
| TheJulia | and if you need to explicitly deploy metal, you can always just have ironic do it too | 20:23 |
| TheJulia | nova just does the vifs because it is kind | 20:23 |
| TheJulia | to clarify, not jumping by meaning "not willing to wait the 5-ish minutes at worst" | 20:27 |
| JayF | My main use case is twofold: 1) improving the failover story for nova-compute (right now an upgrade is guaranteed downtime of however long it takes a dormant nova-compute to get running again) and 2) reducing the lag time between a node exiting cleaning and being re-available to provision | 20:32 |
| JayF | I think directly updating placement would potentially have a positive impact in both cases, but I'm not 100% sure | 20:32 |
| TheJulia | It would allow the loop to be more of a lazy follow up | 20:42 |
| TheJulia | Which is a plus | 20:42 |
| JayF | primarily I realized that since we changes the nove-compute HA model | 20:42 |
| JayF | it's impossible to do an HA-as-everyone-else-means-it openstack upgrade with ironic | 20:42 |
| JayF | because you're guaranteed downtime no matter how you roll (yes you can shard to compartmentalize, but the value of that depends wildly on use case; it's not valuable to me) | 20:43 |
| TheJulia | Hmmm yeah, but truth be told, most folks take downtime on upgrades in some way/shape/form… even when they don’t need to because for the they are managing risk and set that expectation. | 20:44 |
| TheJulia | Knowing/understanding/modeling differences evolve from there | 20:45 |
| JayF | I am not speaking so much in the theoretical as I am in the "no really, this annoys my downstream so I wanna fix it" :D | 21:39 |
| JayF | but we also tend to heavily use rebuilds-in-place which makes it so compartmentalized failure ha doesn't fit our use cases | 21:39 |
| TheJulia | Fair enough! | 22:29 |
| opendevreview | Clif Houck proposed openstack/ironic master: Filter out already attached portlikes in plan_vif_attach https://review.opendev.org/c/openstack/ironic/+/974521 | 22:46 |
| opendevreview | Clif Houck proposed openstack/ironic master: WIP: Update TBN simulator for vif_attach planning https://review.opendev.org/c/openstack/ironic/+/973691 | 22:46 |
| opendevreview | Clif Houck proposed openstack/ironic master: Filter out NoMatch actions in _vif_attach_tbn https://review.opendev.org/c/openstack/ironic/+/974569 | 22:46 |
| clif | cardoe: more corrections if you're around, but I get its late friday afternoon | 22:46 |
| clif | I think I've handled the problematic cases that have sprung to mind so far | 22:48 |
| clif | ie, don't consider portlikes that are already attached, handle multiple actions per trait more correctly | 22:48 |
| TheJulia | last call for vxlan spec approvals | 22:50 |
| TheJulia | https://review.opendev.org/c/openstack/ironic-specs/+/959401 | 22:50 |
| JayF | I'm OK to do a post-merge review, I don't have the context to get it now | 23:00 |
| cardoe | I'm good with it now. I think we'll flesh it out as we learn some other bits. | 23:05 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: make inspection doc link better in the side menu https://review.opendev.org/c/openstack/ironic/+/974570 | 23:07 |
| cardoe | ^ that's another super boring one | 23:08 |
| cardoe | https://review.opendev.org/c/x/proliantutils/+/974571 with that I'm gonna throw in the towel | 23:20 |
| cardoe | Cause I hate every computer right now | 23:20 |
| TheJulia | ewww | 23:21 |
| * TheJulia gives cardoe the certificate of computer hate and the martini of a quiet chill weekend | 23:21 | |
| cardoe | I had asked him to submit it for a bit. That does fix ilo5 boxes. | 23:22 |
| TheJulia | there are a few things wrong with that library, and if it wasn't for redfish I would have forked it long ago | 23:23 |
| cardoe | I don't doubt it. | 23:25 |
| cardoe | That change allows me to smile and nod at the ilo5 hardware folks. I'd rather it be shared with the world. | 23:26 |
| TheJulia | ++ | 23:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!