| cardoe | That’s why I was asking what I can do. Not asking ya to do anything with it. You’re just the last person to merge something. | 00:15 |
|---|---|---|
| JayF | I emailed the team there | 00:18 |
| JayF | which AIUI was reassigned and maybe merged my patch as a courtesy? TBH I'm not sure I realized it ever merged, my downstream hard-forked this a while back | 00:18 |
| JayF | any saltiness about the issue mainly boils down to the logic being in a third party library that we don't hold the keys for and was not well maintained | 00:20 |
| JayF | but as usual, Dr Seuss and his red fish are saving the day :D | 00:20 |
| JayF | oh BTW; clif volunteered today to ensure we get a patch merged to retire shellinabox; we ran across a todo today to remove it this cycle (score) | 00:21 |
| rpittau | good morning ironic! o/ | 07:41 |
| dtantsur | cardoe: these are the people with ACL on proliantutils: https://review.opendev.org/admin/groups/70a7661dca62f34a214925d41655fd35c53a465c,members | 09:57 |
| cardoe | Ah. Thanks! | 11:53 |
| opendevreview | Allain Legacy proposed openstack/ironic master: Address remaining review comments for rpc methods https://review.opendev.org/c/openstack/ironic/+/971184 | 12:50 |
| opendevreview | Allain Legacy proposed openstack/ironic master: Add standalone networking service installation guide https://review.opendev.org/c/openstack/ironic/+/966471 | 12:50 |
| kubajj | hello everyone, this might be a stupid question, when I inspect hardware (after getting rid of inspector) is it the conductor telling IPA the commands to inspect the HW with or does IPA know them? (trying to debug some formatting in the inventory data) | 13:37 |
| dtantsur | kubajj: it's initiated by IPA based on kernel params | 13:38 |
| dtantsur | (we definitely lack some sort of a "how stuff works" documentation) | 13:38 |
| kubajj | dtantsur: ok, thanks | 13:39 |
| kubajj | dtantsur: my issue is that the cpu name in inventory data is "cpu_name": "Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz\n name: Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz" | 13:40 |
| kubajj | and then nova complains 😢 | 13:41 |
| kubajj | dtantsur: found some docs :D https://docs.openstack.org/ironic-python-agent/latest/admin/how_it_works.html#inspection (had to search by the kernel params name first) | 13:44 |
| dtantsur | heh, we're clearly parsing something incorrectly | 13:44 |
| kubajj | dtantsur: maybe, if I figure it out, I'll patch it | 13:48 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add a `reattach_networking` service step https://review.opendev.org/c/openstack/ironic/+/973413 | 14:25 |
| kubajj | dtantsur: sorry, it was a false alarm, mea culpa | 14:34 |
| dtantsur | Mmm? Now I'm curious :) | 14:35 |
| kubajj | It took me a while to figure out how the inspection works in IPA and I just couldn't find cpu_name anywhere in the repo - this is because we have a custom HW manager which adds some more functions and this one does some parsing incorrectly | 14:39 |
| dtantsur | Ahhh, I see. | 14:39 |
| kubajj | btw, I will implement the default inspect interface soon, should it just set the inspect_interface to the config param on new nodes? | 14:40 |
| dtantsur | kubajj: hmm, check how other defaults are implemented, it's very strange that inspect is not one of them | 14:40 |
| dtantsur | it's probably somewhere in driver_factory | 14:40 |
| kubajj | ok, will do | 14:40 |
| kubajj | dtantsur: do you know if `openstack baremetal introspection data save` command should still work after disabling inspector? | 15:32 |
| kubajj | (getting service unavailable) | 15:33 |
| kubajj | again, sorry to bother you, it change to inventory | 15:40 |
| dtantsur | kubajj: 'baremetal introspection' are all inspector-specific, yeah | 16:29 |
| dtantsur | 'node inventory save' is the right one | 16:29 |
| kubajj | dtantsur: Today is my lucky day, found another bug | 16:30 |
| dtantsur | \o/ | 16:30 |
| dtantsur | Honestly, sometimes I feel like I find bugs every time I dive into some feature. I guess it's just life. | 16:30 |
| kubajj | yeah, can't wait until this is done. Kinda wanna close the chapter of inspector and not have to think about it (my prod regions are still running Caracal because of this) | 16:31 |
| dtantsur | Oh, I hear you. I spent waaaay too much time on the new implementation, now folks spend way to much time on migrating to it :D | 16:32 |
| kubajj | ok, got it to work - is it normal that if I do `inventory save`, most of the double quotes are escaped? | 16:34 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Fix retrieval of inventory data from Swift https://review.opendev.org/c/openstack/ironic/+/975824 | 17:11 |
| clif | anyone run into this when trying to run unit tests on latest master locally? a bunch of unit tests under ironic/tests/unit/drivers/modules/network/ started failing with ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.network' entrypoint: ironic-networking. | 17:12 |
| clif | I believe my tree is clean but maybe I screwed something up | 17:12 |
| clif | I've also recreated tox env | 17:13 |
| clif | dang it must be my tree being unclean somehow, I cloned completely fresh and things passed | 17:29 |
| *** dmellado42 is now known as dmellado4 | 17:39 | |
| clif | There's a section in the docs about Node web console that seems to rely on shellinabox... is there an alternative to use there or does that mean Node web console is also abandonded by us? | 17:39 |
| clif | its located in docs/source/admin/console.rst:54 | 17:43 |
| dtantsur | kubajj: I haven't noticed that, it does not sound normal | 17:48 |
| dtantsur | clif: I had the same problem with console some time ago. I haven't dived into it, but there seems to be some difference with the CI in how drivers are loaded. | 17:48 |
| kubajj | dtantsur: I will try to debug the client tomorrow then | 17:49 |
| kubajj | https://www.irccloud.com/pastebin/he1Otkka/ | 17:50 |
| dtantsur | yeah, it's total nonsense, and it was not the case previously | 17:51 |
| dtantsur | I hope it's a client breakage and not API.... | 17:52 |
| JayF | clif: there's like a wheel or .wheelinfo or something like that | 17:58 |
| JayF | clif: some versions of setuptools leave crap around that can break tests | 17:58 |
| JayF | I've experienced that, it was always that there was an opcode cache hiding somewhere | 17:59 |
| opendevreview | cid proposed openstack/networking-baremetal master: Add conductor group sharding support https://review.opendev.org/c/openstack/networking-baremetal/+/948432 | 18:01 |
| cardoe | clif: node web console stuff is dead. The VNC stuff stevebaker[m] did is the only functional replacement. | 19:33 |
| clif | thanks, that helps | 19:59 |
| TheJulia | Packing up my laptop, I'll try to glance at things and maybe do some reviews from the hotel bar tomorrow night, but otherwise I'll be in ireland next week. | 21:05 |
| opendevreview | Clif Houck proposed openstack/ironic master: Remove shellinabox https://review.opendev.org/c/openstack/ironic/+/975864 | 21:17 |
| opendevreview | cid proposed openstack/ironic master: Redfish VirtualMedia NFS and SMB/CIFS Support https://review.opendev.org/c/openstack/ironic/+/958505 | 21:25 |
| opendevreview | Merged openstack/ironic master: Fast track shouldn't happen when firmware update is in progress https://review.opendev.org/c/openstack/ironic/+/974265 | 21:29 |
| cid | TheJulia, safe travels. | 21:48 |
| cid | TheJulia, cardoe, I updated -> https://review.opendev.org/c/openstack/networking-baremetal/+/948432 | 21:48 |
| rm_work[m] | So I'm considering writing a different inspector interface | 23:02 |
| rm_work[m] | https://github.com/openstack/ironic/tree/master/ironic/drivers/modules/inspector | 23:02 |
| rm_work[m] | that isn't "agent" / inband -- is that sane? The idea being instead of inspecting a live host it'd just get all the info it needs from our inventory management system | 23:02 |
| rm_work[m] | or is this a fool's errand and I'd be better off just writing a cron job to hit inventory management, generate an enrollment yaml, and run the standard node enroll flow | 23:04 |
| JayF | I question if having ironic "pull" the data in that situation is better than having it pushed in by the management software | 23:05 |
| JayF | because it's essentially a one-time sync, every second after that "inspection" the data will go outta sync from the source of truth | 23:06 |
| rm_work[m] | yeah I mean with an agent I think it WOULD have to be "receiving an event" from something, because that's the inspect architecture | 23:06 |
| JayF | so I'd approach it as event driven from the source of truth: something changes; force the API update in Ironic | 23:06 |
| JayF | but do it via a third party agent polling both or through integration with your internal CMDB | 23:06 |
| rm_work[m] | yeah right now it seems like it'd be simpler to just do a systemd timed service that checks CMDB, diffs against ironic, generates an enrollment yaml, and does the standard enroll | 23:07 |
| rm_work[m] | because honestly once a day even would be fine likely | 23:07 |
| rm_work[m] | trying to finagle this inspector autoenrollment thing to do out-of-band seems overcomplicated | 23:08 |
| rm_work[m] | but just wanted to make sure that is the way you see it too | 23:08 |
| rm_work[m] | (technically the ask of me was "see if we could make autoenrollment work") | 23:09 |
| JayF | I suspect the simplest answer will be "BYO-glue" | 23:12 |
| JayF | if your CMDB is in-house, having it event-driven instead of poll would be awesome | 23:12 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!