| TheJulia | cardoe: you around? | 00:03 |
|---|---|---|
| cardoe | Ish | 00:13 |
| TheJulia | I just approved https://review.opendev.org/c/openstack/ironic/+/977896 to fix the networking-* jobs, it should be good, but just just wanted to give someone a chance to scream "noooooo" | 00:18 |
| * cardoe inserts “I don’t believe you” meme | 00:47 | |
| TheJulia | well, the test patch got WAY further ;) | 00:47 |
| cardoe | So why do we still use save_and_reraise? | 01:07 |
| cardoe | I ask because that’s what makes Claude go crazy with the getattr. | 01:12 |
| TheJulia | That is a *really* good question | 01:15 |
| TheJulia | I think the answer is we over-used it | 01:15 |
| cardoe | Like we use it to do log logging calls in some places. | 01:36 |
| cardoe | uh yeah since Python 3.3 save_and_reraise_exception is baked in. All functionality of it. In a way that's much clearer. | 01:56 |
| cardoe | And makes Claude not go crazy. | 01:56 |
| *** mdfr6 is now known as mdfr | 01:58 | |
| cardoe | ugh. | 01:58 |
| cardoe | We do LOG.error("something: %s", err) where err is the exception | 01:59 |
| cardoe | But even worse... we do LOG.exception("something: %s", err) where err is the exception | 01:59 |
| opendevreview | Merged openstack/ironic master: Trivial: CI: fix conditional logic around vxlan/vlan/etc. https://review.opendev.org/c/openstack/ironic/+/977896 | 02:10 |
| opendevreview | Merged openstack/ironic master: Imported Translations from Zanata https://review.opendev.org/c/openstack/ironic/+/977566 | 02:10 |
| cardoe | ha | 02:11 |
| cardoe | TheJulia: you know how Claude won't get any more detailed than Exception? | 02:11 |
| cardoe | That's cause of save_and_reraise_exception() | 02:12 |
| TheJulia | Oh, you can, but yeah | 02:13 |
| cardoe | annnnnnnnnd that's my whole 5 hour window of usage... Opus 4.6 is a hungry hungry monster. | 02:13 |
| cardoe | I had it sit and think long and hard why its getting so many of these types wrong and putting in so many unnecessary guards. | 02:14 |
| cardoe | Like I looked at my BIOS settings patch and most of it was guards. | 02:14 |
| TheJulia | Heh | 02:33 |
| opendevreview | Verification of a change to openstack/ironic master failed: Remove verbose per-node debug logging from redfish sensor collection https://review.opendev.org/c/openstack/ironic/+/976767 | 02:59 |
| opendevreview | Merged openstack/ironic bugfix/34.0: fix: missing staticmethod decorator on inspection_rules func https://review.opendev.org/c/openstack/ironic/+/977880 | 03:22 |
| opendevreview | Merged openstack/ironic stable/2025.2: fix: missing staticmethod decorator on inspection_rules func https://review.opendev.org/c/openstack/ironic/+/977882 | 04:17 |
| *** mdfr8 is now known as mdfr | 04:26 | |
| janders | cardoe sync++. Back when we last discussed this I was focused on rebootless BIOS updates but that's kind of good enough so moving onto rebootless settings. (CC dtantsur) | 04:30 |
| cardoe | Well look at the patch I did. | 05:11 |
| cardoe | You cannot have them rebootless. | 05:11 |
| cardoe | I have them IPA-less. | 05:11 |
| rpittau | good morning ironic! o/ | 08:03 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: [DNM] TEST CI https://review.opendev.org/c/openstack/bifrost/+/977929 | 09:12 |
| opendevreview | Merged openstack/networking-baremetal master: Change tenant_network_types to project_network_types https://review.opendev.org/c/openstack/networking-baremetal/+/977836 | 09:23 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems https://review.opendev.org/c/openstack/ironic/+/977605 | 10:12 |
| rpittau | ci failure in bifrost is unfortunately confirmed | 11:21 |
| rpittau | we need to cap bcrypt for the time being | 11:21 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Cap bcrypt <5.0.0 for passlib compatibility https://review.opendev.org/c/openstack/bifrost/+/977955 | 12:57 |
| opendevreview | Merged openstack/ironic master: Change tenant_network_types to project_network_types https://review.opendev.org/c/openstack/ironic/+/977834 | 13:00 |
| opendevreview | Verification of a change to openstack/ironic master failed: Remove verbose per-node debug logging from redfish sensor collection https://review.opendev.org/c/openstack/ironic/+/976767 | 13:02 |
| janders | cardoe I had a look at https://review.opendev.org/c/openstack/ironic/+/977569, left some comments. It is a move in the right direction. Let us know if we can help in any way. | 13:56 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-prometheus-exporter master: Migrate ci jobs to noble https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/977966 | 14:07 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Cap bcrypt <5.0.0 for passlib compatibility https://review.opendev.org/c/openstack/bifrost/+/977955 | 14:10 |
| opendevreview | Julia Kreger proposed openstack/ironic master: ci: Fix multinode routing https://review.opendev.org/c/openstack/ironic/+/977969 | 14:25 |
| TheJulia | cardoe: okay, I also broke the classical multinode job as well (figures), so that should fix it. | 14:26 |
| TheJulia | or at least, make it so it passes. :( | 14:26 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Replace passlib with direct bcrypt for htpasswd generation https://review.opendev.org/c/openstack/bifrost/+/977955 | 15:24 |
| opendevreview | Julia Kreger proposed openstack/ironic master: ci: Fix multinode routing https://review.opendev.org/c/openstack/ironic/+/977969 | 15:29 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Add graphical console validate to basic ops scenario https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/963643 | 15:45 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Test graphical console novnc connection https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/963152 | 15:46 |
| opendevreview | Verification of a change to openstack/ironic master failed: Remove verbose per-node debug logging from redfish sensor collection https://review.opendev.org/c/openstack/ironic/+/976767 | 15:46 |
| TheJulia | a super quick reivew for any cores around: https://review.opendev.org/c/openstack/ironic/+/977969 | 15:49 |
| TheJulia | Anyone know anyone who has actually *used* speedstep? | 15:55 |
| TheJulia | asking because cardoe raised a question on the ptg etherpad and I'm going "oh, yes, and this too" | 15:55 |
| cardoe | speedstep? | 15:57 |
| TheJulia | Intel SpeedStep | 16:00 |
| TheJulia | if you don't know it, you likely have never touched it | 16:00 |
| JayF | I believe I've worked places that used it; but not via Ironic | 16:01 |
| JayF | I can't be 100% sure though | 16:01 |
| TheJulia | Intel's original idea was basically, be able to have three speed modes | 16:02 |
| JayF | I worked a place that had intel chips where we paid for performance X | 16:02 |
| JayF | later we paid a license and unlocked the CPUs to performance Y | 16:03 |
| TheJulia | So flavor "afterburner" -> "turbo'ed cpu" && "normal" -> "normal" && "slow instance" -> put the cpu in line with turtles and peanut butter which may never exclude 10W" | 16:03 |
| TheJulia | Yeah, similarly there was an attempt to bring more money to the vendors | 16:03 |
| TheJulia | since Intel making just the super fast chips and clocking them down via licensed settings is "easier" | 16:04 |
| TheJulia | as opposed for them to go and fab the slower chips | 16:04 |
| TheJulia | (Intel has been *super* vocal about this due to the increase in the number of CPUs in cars) | 16:05 |
| clif | I'm sorry about this but I wanted to clean up the tox -e docs target and tried to keep each logical step as a discrete commit... | 16:50 |
| opendevreview | Clif Houck proposed openstack/ironic master: Enable parallel processes in sphinx-build to speed up tox "docs" target https://review.opendev.org/c/openstack/ironic/+/976807 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Documentation for Trait Based Networking https://review.opendev.org/c/openstack/ironic/+/975686 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix tox doc target errors related to oslo_service backend exceptions https://review.opendev.org/c/openstack/ironic/+/977989 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix tox doc target complaining about missing oslo.reports https://review.opendev.org/c/openstack/ironic/+/977990 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix docstrings for trait-based-networking related code https://review.opendev.org/c/openstack/ironic/+/977991 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Mark our own sphinx doc extensions as parallel read safe https://review.opendev.org/c/openstack/ironic/+/977992 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Various docstring fixes https://review.opendev.org/c/openstack/ironic/+/977993 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add osprofiler.opts as an import https://review.opendev.org/c/openstack/ironic/+/977994 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Suppress autodoc warnings https://review.opendev.org/c/openstack/ironic/+/977995 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix documentation related build warnings throughout Ironic's docs https://review.opendev.org/c/openstack/ironic/+/977996 | 16:51 |
| opendevreview | Clif Houck proposed openstack/ironic master: Treat warnings as errors in sphinx-build for docs tox target https://review.opendev.org/c/openstack/ironic/+/977997 | 16:51 |
| clif | Those commits solve all existing errors or warnings emitted when running `tox -e docs` locally and then caps them off with a commit that treats warnings as errors from now on... | 16:52 |
| JayF | :-O | 16:52 |
| JayF | I'm here for it! | 16:53 |
| clif | and at the tippy top is some TBN docs | 16:53 |
| JayF | FWIW, i've gotten positive feedback from multiple different folks about the smaller commits being a nice thing | 16:53 |
| clif | a lot of those commits are very small so free review metrics juicing :) | 16:53 |
| JayF | review metrics are broken right now lol | 16:54 |
| JayF | or at least, not useful right now | 16:54 |
| clif | it was hard to untangle the other errors/warnings from new ones I was generating when working on TBN docs so I figured it was time to janitor them | 16:54 |
| JayF | +++ I'm on board | 16:54 |
| clif | oh yea there's also speed up commits | 16:55 |
| clif | goes from about a minute build to 15s build for me locally | 16:56 |
| JayF | clif: first -1 is here https://review.opendev.org/c/openstack/ironic/+/977994 | 17:01 |
| clif | dang, yea I hear you | 17:04 |
| clif | lmk when you've gone through them all and I'll do a revision pass | 17:04 |
| JayF | that's all I've got for the generic docs stuff, although I voted with the idea that CI would find most issues | 17:06 |
| clif | so trusting of the process | 17:07 |
| JayF | I also am going to look at the final rendered doc when CI is done | 17:10 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: vxlan: follow-up cisco nxos/substrate review feedback. https://review.opendev.org/c/openstack/networking-generic-switch/+/977999 | 17:16 |
| cardoe | TheJulia: ohhhh I do know that. | 17:23 |
| cardoe | Speedstep that is | 17:23 |
| TheJulia | cardoe: it floundered for a pile of reasons | 17:24 |
| JayF | Hey everyone, you may have seen anandkaranubc's patches in ironicclient -- he's an MLH Fellow working with GR-OSS this cohort to add type annotations. | 17:33 |
| anandkaranubc | Thanks Jay, and hi everyone! My absolute pleasure to be part of this awesome community. Looking forward to great things and lots of patches ahead haha. | 17:36 |
| cid | Welcome, anandkaranubc, o/ | 17:37 |
| TheJulia | Welcome anandkaranubc! | 17:45 |
| TheJulia | Oh joy, various vendors have entirely different styles of "show vlan <id>" output on sonic. | 17:45 |
| TheJulia | How... EVIL. | 17:45 |
| JayF | I wonder if it corrolates to the number of power rings collected. | 17:57 |
| TheJulia | Possibly. | 17:58 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Revert "Add graphical console validate to basic ops scenario" https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/978010 | 18:13 |
| TheJulia | stevebaker[m]: sorry ^^^ Need to revert it because we're breaking multiple jobs. https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ef6/openstack/ef607b54c49b49c694c05034bac95bc3/testr_results.html | 18:14 |
| TheJulia | So, hold off on approvals, https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/978010 fixes the ironic gate, but will need to go through check/run queues, ~4 hours | 18:17 |
| TheJulia | check and gate queues | 18:18 |
| TheJulia | which also means holding off on rechecks as well | 18:19 |
| opendevreview | Verification of a change to openstack/ironic master failed: ci: Fix multinode routing https://review.opendev.org/c/openstack/ironic/+/977969 | 18:42 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix tox doc target errors related to oslo_service backend exceptions https://review.opendev.org/c/openstack/ironic/+/977989 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix tox doc target complaining about missing oslo.reports https://review.opendev.org/c/openstack/ironic/+/977990 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix docstrings for trait-based-networking related code https://review.opendev.org/c/openstack/ironic/+/977991 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Mark our own sphinx doc extensions as parallel read safe https://review.opendev.org/c/openstack/ironic/+/977992 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Various docstring fixes https://review.opendev.org/c/openstack/ironic/+/977993 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add osprofiler.opts as an import https://review.opendev.org/c/openstack/ironic/+/977994 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Fix documentation related build warnings throughout Ironic's docs https://review.opendev.org/c/openstack/ironic/+/977996 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Treat warnings as errors in sphinx-build for docs tox target https://review.opendev.org/c/openstack/ironic/+/977997 | 19:00 |
| opendevreview | Clif Houck proposed openstack/ironic master: Documentation for Trait Based Networking https://review.opendev.org/c/openstack/ironic/+/975686 | 19:00 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: vxlan: Arista EOS and vendor neutral SONiC https://review.opendev.org/c/openstack/networking-generic-switch/+/972763 | 19:11 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: vxlan: Add Junos, Cumulus NVUE, and denote Dell OS10 as unsupported https://review.opendev.org/c/openstack/networking-generic-switch/+/972764 | 19:11 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: vxlan: OVS testing patch for 'vxlan' binding model https://review.opendev.org/c/openstack/networking-generic-switch/+/972765 | 19:11 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: docs: Reorder docs to be more sane https://review.opendev.org/c/openstack/networking-generic-switch/+/978015 | 19:11 |
| cardoe | So... I shouldn't push something if I wanna see the results huh? | 19:34 |
| TheJulia | you'll likely want to hold off 1.5 hours unless you need to get it off your plate sooner than that | 19:43 |
| * cardoe evil cackles. | 20:04 | |
| cardoe | I did make Ironic tests pass on macOS | 20:04 |
| cardoe | We've got a couple of glibc-isms. Stupidly that's the default Python behavior and actually documented. You have to read the NOTE block in their docs. | 20:07 |
| TheJulia | Rutro! | 20:27 |
| TheJulia | :) | 20:27 |
| cardoe | Actually no. I just re-read it when I was reading the Python doc cause I was gonna make a patch. | 20:28 |
| cardoe | We're wrong. We've got a glibc-ism. | 20:28 |
| cardoe | We ask for a SOCK_DGRAM with a TCP protocol. | 20:29 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: clean up exception handling so type hinting is correct https://review.opendev.org/c/openstack/ironic/+/978020 | 20:30 |
| * TheJulia blinks | 20:41 | |
| TheJulia | yeah, that is wrong | 20:41 |
| cardoe | only 6000 more type errors to go! | 20:53 |
| JayF | whoa, GLIBCism | 20:58 |
| JayF | we used to test under musl | 20:58 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Revert "Add graphical console validate to basic ops scenario" https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/978010 | 20:59 |
| TheJulia | Next fix rechecked | 21:11 |
| opendevreview | Verification of a change to openstack/ironic master failed: ci: Fix multinode routing https://review.opendev.org/c/openstack/ironic/+/977969 | 21:25 |
| opendevreview | Verification of a change to openstack/ironic master failed: Remove verbose per-node debug logging from redfish sensor collection https://review.opendev.org/c/openstack/ironic/+/976767 | 21:26 |
| cardoe | So did we start things too quickly or are things still broken? | 22:05 |
| TheJulia | We can start things, the mulitnode routing fix one is in the pipeline, <1 minute left until starting gate hopefully | 22:33 |
| TheJulia | those were from the arm job | 22:33 |
| TheJulia | zuul estimates 45 minutes. Cardoe, if there are changes in ironic itself, your likely good to recheck. I'll be rechecking networking-* stuff once the current change in the gate merges | 23:13 |
| cardoe | okay cool | 23:14 |
| cardoe | I rechecked, https://review.opendev.org/c/openstack/ironic/+/978020 which passed everything except tempest. | 23:14 |
| TheJulia | ok | 23:16 |
| opendevreview | Merged openstack/ironic master: ci: Fix multinode routing https://review.opendev.org/c/openstack/ironic/+/977969 | 23:52 |
| cardoe | https://review.opendev.org/c/openstack/nova/+/975588 that's kinda neat. We should have that for graceful shutdowns. | 23:54 |
| TheJulia | woot | 23:57 |
| TheJulia | Hmm, interesting | 23:59 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!