| opendevreview | Merged openstack/networking-baremetal master: Simplify conditional logging for link information https://review.opendev.org/c/openstack/networking-baremetal/+/981514 | 01:04 |
|---|---|---|
| opendevreview | Olamide Ojo proposed openstack/ironic master: Improve conceptual information in get_started file https://review.opendev.org/c/openstack/ironic/+/981853 | 04:07 |
| gtfrans2re | Hello dear mentors and fellow Outreachy applicants ! I'm Francois Gonothi Toure, nicknamed gtfrans2re, and this is an introduction upon joining Ironic's OpenStack IRC channel. Thank you for the onboarding. | 04:30 |
| opendevreview | Merged openstack/networking-baremetal master: Add segment_id to subport binding profiles https://review.opendev.org/c/openstack/networking-baremetal/+/981480 | 04:46 |
| opendevreview | Verification of a change to openstack/networking-baremetal master failed: Refactor to use guard clauses and early returns https://review.opendev.org/c/openstack/networking-baremetal/+/981479 | 04:47 |
| gtfrans2re | The ``git review -s`` command can't seem to work for me from the sandbox webpage (https://docs.opendev.org/opendev/infra-manual/latest/sandbox.html). Everything else worked out fine. Here the output that I keep getting : git review -s | 05:04 |
| gtfrans2re | ssh://gtfrans2re@review.openstack.org:29418/opendev/sandbox.git did not work. Description: gtfrans2re@review.openstack.org: Permission denied (publickey). | 05:04 |
| gtfrans2re | fatal: Could not read from remote repository. | 05:04 |
| gtfrans2re | Please make sure you have the correct access rights | 05:04 |
| gtfrans2re | and the repository exists. | 05:04 |
| gtfrans2re | Could not connect to gerrit. | 05:04 |
| gtfrans2re | Enter your gerrit username: Francois Gonothi Toure | 05:04 |
| gtfrans2re | Trying again with ssh://Francois Gonothi Toure@review.openstack.org:29418/opendev/sandbox.git | 05:04 |
| gtfrans2re | ssh://Francois Gonothi Toure@review.openstack.org:29418/opendev/sandbox.git did not work. Description: Francois Gonothi Toure@review.openstack.org: Permission denied (publickey). | 05:04 |
| gtfrans2re | fatal: Could not read from remote repository. | 05:04 |
| gtfrans2re | Please make sure you have the correct access rights | 05:04 |
| gtfrans2re | and the repository exists. | 05:04 |
| gtfrans2re | We don't know where your gerrit is. Please manually create a remote | 05:04 |
| gtfrans2re | named 'gerrit' and try again. | 05:04 |
| gtfrans2re | Could not connect to gerrit at ssh://Francois Gonothi Toure@review.openstack.org:29418/opendev/sandbox.git | 05:04 |
| gtfrans2re | Would you please help fix this? | 05:04 |
| JayitaPramanik[m] | gtfrans2re: is your ssh key linked to gerrit? may be need to do it manually. in gerrit settings > ssh key, ensure your public key is there | 05:39 |
| JayitaPramanik[m] | s/may be// | 06:35 |
| opendevreview | Kaifeng Wang proposed openstack/ironic-tempest-plugin master: Allow removing volume connectors on some states https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/981859 | 08:34 |
| abongale | good morning ironic o/ | 09:13 |
| opendevreview | Kaifeng Wang proposed openstack/ironic-tempest-plugin master: Allow removing volume connectors on some states https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/981859 | 10:37 |
| Priestess | @gtfrans2re: Have you been able to resolve the issue? | 11:20 |
| opendevreview | Harald Jensås proposed openstack/networking-baremetal master: Fix ha_chassis_group list access in trunk manager https://review.opendev.org/c/openstack/networking-baremetal/+/981515 | 11:28 |
| Pipscript | Hi everyone, my name is Barigbue Nbira. I'm an Outreachy applicant interested in the Ironic contribution tasks. Nice to meet you all. | 12:29 |
| Pipscript | I am a DevOps Engineer. | 12:30 |
| LizzyNjoroge | logs | 12:52 |
| LizzyNjoroge | logs | 12:52 |
| LizzyNjoroge | :logs | 12:53 |
| TheJulia | good morning | 13:25 |
| clif | gm o/ | 13:28 |
| TheJulia | I'm not sure how long I'll be around today, woke up feeling half decent, lets see how the day goes! | 13:29 |
| sonalisk | Hi, I am an Outreachy applicant. Can anyone guide me on suitable beginner-friendly issues to begin with? | 13:47 |
| comfortoyewole[m] | Welcome Sonalisk, these are the tasks the mentors instructed we start with | 13:51 |
| comfortoyewole[m] | https://docs.google.com/document/d/12SsPvSXdjNNw4C9IbkJGpW9qXwZYiZbENEgwgx815b4/edit?usp=sharing | 13:51 |
| sonalisk | Thank you for sharing the document, Comfortoyewole! | 13:58 |
| TheJulia | clif: fyi, I pre-stubbed an area into the slide deck for TBN | 14:09 |
| clif | thank you, sorry do you have a link to the slide deck? | 14:11 |
| clif | oh I found it in that email thread | 14:12 |
| TheJulia | cool, I was just about to switch computers to send it over :) | 14:12 |
| clif | and the amount of time expected to utilize? 3-5 minutes? | 14:13 |
| TheJulia | 3-5 minutes should be good target. | 14:16 |
| TheJulia | Part of me has wondered about sort of like canned Q&A questions we could ask each other | 14:24 |
| opendevreview | Merged openstack/networking-generic-switch master: Use segment_id for L2VNI cleanup https://review.opendev.org/c/openstack/networking-generic-switch/+/981509 | 14:30 |
| JayF | my focus today is on these slides/presentation for ironic | 14:34 |
| JayF | but I'll start with my bit in the actual-openinfra-live not the ironic-openinfra-live | 14:34 |
| TheJulia | k | 14:37 |
| cardoe | TheJulia: did you mention Nautobot at some point? | 14:39 |
| TheJulia | Semi-interested until you convinced me it was not worthwhile to build a direct integration because we can't really know for sure when done | 14:40 |
| cardoe | Fair. | 14:47 |
| cardoe | https://github.com/nautobot/nautobot/pull/8467 fwiw is where we're adding the L2VNI modeling. | 14:47 |
| cardoe | I've got a model in my head that I think we can use. | 14:48 |
| cardoe | And maybe it's bad/wrong. | 14:48 |
| TheJulia | cardoe: it feels like it could be quickly on a path to information overload, but does sort of seem to have to walk a line and on that side, its the needful | 14:57 |
| cardoe | So what I'm looking at is the event stream from OpenStack would update Nautobot. Nautobot with all of its config template and blah blah can generate the entire switch config. | 15:00 |
| cardoe | So if I lose a switch I can rebuild it quickly. | 15:00 |
| cardoe | I can also audit the switch for config drift. | 15:01 |
| cardoe | We've got other tooling and things today which is why I cannot use NGS for this. | 15:01 |
| cardoe | Looking to try and do it all with open source tooling and share the model. | 15:02 |
| -opendevstatus- NOTICE: Recent POST_FAILURE job results with no logs were due to upload errors in one of our providers, which has been temporarily disabled now so rechecking those should be safe | 15:04 | |
| TheJulia | cardoe: oh, yeah, absolutely, makes sense | 15:05 |
| hjensas | cardoe: replied on https://review.opendev.org/c/openstack/networking-baremetal/+/981657 - python requests is awesome. :) | 15:34 |
| TheJulia | It does have some useful features :) | 15:36 |
| JayF | URL length limits in GET requests are an annoyingly common pattern | 15:44 |
| TheJulia | ... I once had a firewall that if you did request inspection it tried to restrict URIs to 63 or 64 characters | 16:12 |
| JayF | that would break some large % of the internet now | 16:12 |
| TheJulia | yeeeah, the vendor went out of business in like 05 or 06 | 16:20 |
| anandkaranubc | cardoe: quick question. I’m planning to start type annotating the test code in `python-ironicclient`, and wanted guidance before setting a pattern across multiple files. In several tests (for example, in `test_events.py` where we do something like `self.mgr = events.EventManager(self.api)` with `self.api` being a `FakeAPI` instead of a `SessionClient`), we hit arg-type issues. Would you recommend using | 16:36 |
| anandkaranubc | `cast(http.SessionClient, self.api)` or keeping it as `self.api # type: ignore[arg-type]` in tests? I’d like to follow whatever is preferred consistently across the test suite. cc: JayF | 16:36 |
| JayF | cardoe: I asked anandkaranubc to direct that question here, my hunch is to get the value of type checking in tests we need to do the cast but I'm not 100% | 16:37 |
| cardoe | Personally for me in code bases I convert I use the cast. That way we enforce the API contract in all calls to match. | 16:42 |
| cardoe | I'll give you an example why. | 16:42 |
| cardoe | So let's say FakeAPI exposes an attribute "foo". So in your test you can touch it with "self.mgr.foo". You use that in the tests and all in well. | 16:43 |
| cardoe | 6 months later someone else comes along and needs to alter some behavior in EventManager and they're trying to get an idea of what they can use. They look at the tests and see "foo" and decide to use "foo" in the actual code base. | 16:44 |
| cardoe | They submit the patch and it passes tests and the reviewers miss the fact that "foo" isn't actually part of EventManager. It merges. And the actual users find the bug but not the tests. | 16:45 |
| cardoe | And I realize now replace all "EventManager" with "http.SessionClient" in my example above. | 16:46 |
| JayF | anandkaranubc: ^ | 16:46 |
| anandkaranubc | cardoe: Awesome thanks for the feedback! I will go by that then. | 16:48 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Soft power off before ejecting virtual media regardless of CONF.inspector.power_off https://review.opendev.org/c/openstack/ironic/+/981942 | 17:20 |
| opendevreview | Jason Paroly proposed openstack/sushy master: Fix unused variable warnings https://review.opendev.org/c/openstack/sushy/+/981967 | 18:25 |
| *** system625[m] is now known as OlamiposiTundeAjayi[m] | 18:46 | |
| Olamiposi | Hello everyone, I'm a bit confused on how to find issues to work on, can anyone guide me? | 18:55 |
| comfortoyewole[m] | Hi Olamiposi, these are the tasks the mentors instructed we start with | 18:57 |
| comfortoyewole[m] | https://docs.google.com/document/d/12SsPvSXdjNNw4C9IbkJGpW9qXwZYiZbENEgwgx815b4/edit?usp=sharing | 18:57 |
| OlamiposiTundeAjayi[m] | comfortoyewole[m]: Thank you very much | 19:00 |
| comfortoyewole[m] | <OlamiposiTundeAjayi[m]> "Thank you very much" <- You're welcome | 19:14 |
| opendevreview | Merged openstack/networking-baremetal master: Refactor to use guard clauses and early returns https://review.opendev.org/c/openstack/networking-baremetal/+/981479 | 20:00 |
| opendevreview | Victor proposed openstack/ironic master: Log node history on vif_attach and vif_detach failures https://review.opendev.org/c/openstack/ironic/+/981474 | 20:13 |
| opendevreview | Merged openstack/networking-baremetal master: Fix ha_chassis_group list access in trunk manager https://review.opendev.org/c/openstack/networking-baremetal/+/981515 | 22:21 |
| cardoe | Can I run a node through "verify" again? | 22:31 |
| cardoe | The clean step to set the BMC clock wants me to supply an ISO time string which is 100% going to be wrong by the time it makes it through the API and to the conductor. | 22:32 |
| cardoe | I'm also not able to make a nice runbook for folks to reset that back. | 22:33 |
| JayF | cardoe: anandkaranubc and I are going back and forth on solutions for https://review.opendev.org/c/openstack/python-ironicclient/+/981686/comment/15cfbfb7_bad53f0c/ | 22:35 |
| JayF | stephenfin: ^ | 22:35 |
| JayF | do you have any suggestions for how to do it cleaner? | 22:35 |
| JayF | The problem isn't quite shaped the same as https://github.com/openstack/nova/commit/c870873f7fbf0dec03a520f60423491cf9ecf64f because in ironicclient we're loading them up using stevedore | 22:36 |
| JayF | it feels like "I plug things into this interface" HAS to be a solved problem, right?! Does stevedore need code for this? | 22:36 |
| JayF | There has to be a better answer than # type[ignore-this-sucks] | 22:36 |
| cardoe | The nova thing is what we have to do in ironic/objects/__init__.py | 22:48 |
| cardoe | But you are right different shaped problem. | 22:49 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!