| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Enable mypy for `ironicclient/osc/command.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983350 | 06:13 |
|---|---|---|
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Centralize cliff parser type for OSC get_parser overrides https://review.opendev.org/c/openstack/python-ironicclient/+/983351 | 06:13 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/osc/v1/baremetal_runbook.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983352 | 06:13 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/osc/v1/baremetal_volume_target.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983355 | 06:13 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/osc/v1/baremetal_portgroup.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983357 | 06:13 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/osc/v1/baremetal_port.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983358 | 06:13 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/osc/v1/baremetal_node.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983359 | 06:13 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Pre-test typing cleanup https://review.opendev.org/c/openstack/python-ironicclient/+/983360 | 06:13 |
| opendevreview | Abhishek Bongale proposed openstack/ironic-tempest-plugin master: Add conditional graphical console validation https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/982077 | 08:13 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Accept bare "nic" as a valid firmware update component https://review.opendev.org/c/openstack/ironic/+/983683 | 09:24 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Refresh firmware versions in DB after update step completes https://review.opendev.org/c/openstack/ironic/+/983684 | 09:24 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Use NIC adapter path as SimpleUpdate Target for nic:<id> components https://review.opendev.org/c/openstack/ironic/+/983685 | 09:24 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Accept bare "nic" as a valid firmware update component https://review.opendev.org/c/openstack/ironic/+/983683 | 11:55 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Refresh firmware versions in DB after update step completes https://review.opendev.org/c/openstack/ironic/+/983684 | 11:55 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Use NIC adapter path as SimpleUpdate Target for nic:<id> components https://review.opendev.org/c/openstack/ironic/+/983685 | 11:55 |
| opendevreview | Abhishek Bongale proposed openstack/ironic-tempest-plugin master: Add conditional graphical console validation https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/982077 | 12:01 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Pre-test typing cleanup https://review.opendev.org/c/openstack/python-ironicclient/+/983360 | 12:05 |
| iurygregory | good morning ironic | 12:23 |
| opendevreview | Victor proposed openstack/ironic master: Truncate node history event to avoid DB column overflow https://review.opendev.org/c/openstack/ironic/+/981399 | 13:10 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: gracefully handle plugging the port for a test node https://review.opendev.org/c/openstack/ironic/+/983714 | 13:14 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: devstack: fix qrouter used in iptables calls https://review.opendev.org/c/openstack/ironic/+/983715 | 13:14 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: fix ip route call to be idempotent https://review.opendev.org/c/openstack/ironic/+/983716 | 13:14 |
| cardoe | I dislike system scope RBAC. :/ | 13:22 |
| TheJulia | I dislike the punt on the access model because some projects couldn't be bothered | 13:22 |
| TheJulia | which resulted in admin is admin everywhere which is the very bug the work started with | 13:23 |
| TheJulia | </rant> | 13:23 |
| cardoe | oh I agree with you. | 13:24 |
| cardoe | I dislike RBAC in OpenStack in general. | 13:24 |
| TheJulia | Oh good | 13:24 |
| cardoe | Maybe in our free time we'll fix it? | 13:24 |
| * TheJulia pushes the party float into the IRC channel | 13:25 | |
| * TheJulia jumps on it and goes laughs like a crazy person over the concept of "free time" | 13:25 | |
| TheJulia | Also! Good morning! | 13:25 |
| cardoe | TheJulia: btw those 3 patches above make my devstack happy | 13:33 |
| opendevreview | Merged openstack/python-ironicclient master: Enable mypy for `ironicclient/osc/command.py` https://review.opendev.org/c/openstack/python-ironicclient/+/983350 | 13:37 |
| TheJulia | cardoe: any chance of rev'ing https://review.opendev.org/c/openstack/ironic/+/983215 today? | 13:45 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Enforce TLS 1.2 minimum across all connections https://review.opendev.org/c/openstack/ironic-python-agent/+/982174 | 13:54 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Upgrade TLS certificates to P-384 curve with configurable support https://review.opendev.org/c/openstack/ironic-python-agent/+/982175 | 13:54 |
| cardoe | TheJulia: yes. working on it right now. | 13:55 |
| cardoe | I noticed via the CLI we cannot create a runbook that can set --disable-ramdisk | 13:55 |
| TheJulia | Sounds like a bug! | 14:03 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 14:19 |
| stephenfin | JayF: Is this dead code? https://opendev.org/openstack/ironic/src/branch/master/devstack/lib/ironic#L39-L42 | 14:20 |
| stephenfin | This release note suggests the pyghmi driver is no more https://opendev.org/openstack/ironic/src/branch/master/releasenotes/notes/remove-ipminative-driver-3367d25bbcc41fdc.yaml | 14:20 |
| stephenfin | and I can't spot any other references to it | 14:20 |
| JayF | Yes | 14:21 |
| JayF | Maybe a decade dead 😂 | 14:21 |
| cardoe | TheJulia: ^ so that switches to an online migration. I've locally added runbooks in 2026.1 and then switched to my branch and ran the DB migration and started up the API and conductor | 14:21 |
| stephenfin | Okay, thought so. Good for me to remove it? | 14:21 |
| opendevreview | Abhishek Bongale proposed openstack/ironic-tempest-plugin master: Add conditional graphical console validation https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/982077 | 14:21 |
| JayF | Please do | 14:21 |
| stephenfin | Context: We use GitHub mirrors in gophercloud, and that was the sole unmirrored repo | 14:21 |
| JayF | stephenfin: just for mine curiosity, how the hell did you run past this | 14:21 |
| JayF | Ahhhhhhh | 14:21 |
| cardoe | curl seems to interact with it just fine and then I ran the online migration and it works. | 14:21 |
| cardoe | I've validated things by dumping the DB. | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/ironic master: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983731 | 14:26 |
| opendevreview | Stephen Finucane proposed openstack/ironic stable/2026.1: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983732 | 14:27 |
| opendevreview | Stephen Finucane proposed openstack/ironic stable/2025.2: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983733 | 14:27 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: feat: add support for new runbook traits API https://review.opendev.org/c/openstack/python-ironicclient/+/983734 | 14:27 |
| opendevreview | Stephen Finucane proposed openstack/ironic stable/2025.1: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983735 | 14:28 |
| opendevreview | Stephen Finucane proposed openstack/ironic stable/2024.2: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983736 | 14:28 |
| stephenfin | JayF: done ^ | 14:28 |
| dtantsur | stephenfin: strictly speaking, pyghmi is also used by virtualbmc. but it's not a reason to install it from source. | 14:29 |
| cardoe | TheJulia: yeah I lost my whole OVN setup of devstack... not really sure how to even rebuild it. | 14:30 |
| cardoe | https://review.opendev.org/c/openstack/python-ironicclient/+/983734 is the client support for the runbook bits. | 14:31 |
| cardoe | JayF: if ya got some time today, I'd appreciate any feedback on https://review.opendev.org/c/openstack/ironic/+/983215 | 14:31 |
| JayF | I will not have time to review something of that beef this week | 14:36 |
| JayF | at least that's what I predict | 14:36 |
| cardoe | Appreciate the honesty. | 14:39 |
| JayF | those size of changes I like to take a closer more careful look, and I have less time this week (I took Monday off and plan to take Friday off -- my wife is on Spring Break) | 14:42 |
| JayF | I wish you didn't get "charged" for days off when they weren't actually restful. 5 hours in a car dealership and I think I lost 50 IQ points. | 14:42 |
| stephenfin | dtantsur: Thanks for the context. Is there any reason it's in the `x` namespace rather than `openstack`? | 14:43 |
| JayF | stephenfin: it's not an openstack project, just sorta adjacent | 14:43 |
| stephenfin | dtantsur: Also, do you want me to reword the commit message or is it Good Enough ™️? | 14:44 |
| JayF | stephenfin: the "white whale" of the IPMI-based Ironic drivers was having a native python driver ... pyghmi tried to be the library to do that with our ipminative, but we never got it good enough to not deadlock at scale | 14:44 |
| JayF | I suspect today we could get further, but thankfully IPMI is only used as a last resort now | 14:44 |
| dtantsur | stephenfin: probably not worth bothering (I've +2'ed already) | 14:45 |
| TheJulia | Yeah, also the maintainer of pyghmi is really focused on ipmi because of preferences for bit fielding as opposed to json and pyghmi really became super lenovo ipmi implementation specific as ipmi stuffs in general in terms of raw field values just fragmented | 14:46 |
| stephenfin | JayF: Ack, thanks for the context | 14:46 |
| cardoe | dtantsur: I'd appreciate your input on https://review.opendev.org/c/openstack/ironic/+/983215 if you have the time as well. | 14:57 |
| dtantsur | Uh oh, my queue is growing rapidly :) Sure | 15:00 |
| TheJulia | cardoe: LGTM | 15:06 |
| TheJulia | One comment on the migration, but *shrug* regardin git | 15:06 |
| opendevreview | Anishere Mariam proposed openstack/ironic master: Record deployment start in node history https://review.opendev.org/c/openstack/ironic/+/982555 | 15:19 |
| JayF | cid: you mind if I delegate some upstream-paperwork-administrivia stuff to you? Basically, we need to retire the virtualpdu repo. | 15:31 |
| JayF | I guess I'm happy for anyone in here to do it :) | 15:32 |
| JayF | TheJulia: cardoe: clif and I were going to do a dry run thru our slides later, if you have any review feedback for our slides getting them in now()ish is preferred | 15:36 |
| TheJulia | pulling them back up now | 15:36 |
| TheJulia | what time are y'all dry running? | 15:36 |
| TheJulia | oh shoot, I've reached impossible scheduling. | 15:37 |
| JayF | I had a manager once who didn't consider himself booked unless there were three overlapping | 15:37 |
| cardoe | I'll add some redfish stuff | 15:37 |
| JayF | TheJulia: scheduled for 10-1030 pst | 15:37 |
| JayF | *pdt | 15:37 |
| TheJulia | k, I can make that | 15:37 |
| cid | JayF, not at all. | 15:42 |
| JayF | stephenfin: https://review.opendev.org/c/openstack/python-ironicclient/+/983351/2#message-93b45009cca4543fecd0844999e226b46a2321a5 | 15:42 |
| cid | What will the process be? | 15:42 |
| cid | *like | 15:43 |
| JayF | cid: it's documented; the easiest way to figure it out will be to find an old governance commit doing it for another repository, and chasing the depends-on chains | 15:43 |
| stephenfin | JayF: yes, happy to merge as-is, hence no -1. I should have been more explicit, sorry | 15:43 |
| stephenfin | will leave a comment now | 15:43 |
| cid | ++, wilco | 15:45 |
| JayF | cid: https://docs.openstack.org/project-team-guide/repository.html#retiring-a-repository | 15:45 |
| cid | tks. makes it all the more easier :) | 15:46 |
| JayF | yeah there are lots of steps where you just have to wait for approval from e.g. TC members and the like | 15:49 |
| JayF | but it's straightforward even if slow | 15:49 |
| JayF | stephenfin: no problem, just wanted to make sure you were onboard and understood why we would value having it done this week instead of next/2 weeks | 15:51 |
| stephenfin | ack | 15:51 |
| TheJulia | The slides look solid to me | 15:52 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Pre-test typing cleanup https://review.opendev.org/c/openstack/python-ironicclient/+/983360 | 15:55 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: feat: add support for new runbook traits API https://review.opendev.org/c/openstack/python-ironicclient/+/983734 | 16:00 |
| cardoe | My wife says that when the time comes the AI overlords will take me out and keep her around cause I'm mean to AI. | 16:10 |
| dtantsur | My wife dislikes AI even more than me, so we're going together :D | 16:11 |
| cardoe | On what I just pushed for the client I told Claude "You review my changes critically so let me review yours. That's a bunch of AI slop. imports in a function? getattr() all over the place for guaranteed properties. Do better." | 16:11 |
| dtantsur | My gut feeling is that Claude deals somewhat better with more rigid compiled languages like Go | 16:12 |
| dtantsur | Python gives it too many options | 16:12 |
| cardoe | oh 100%. It's great with Rust. | 16:13 |
| dtantsur | Yeah, Rust is perfect for AI as long as you deny unsafe code on the lib.rs level :D | 16:14 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Pre-test typing cleanup https://review.opendev.org/c/openstack/python-ironicclient/+/983360 | 16:23 |
| opendevreview | Maksim Malchuk proposed openstack/ironic-python-agent stable/2024.2: Get rid of pkg_resources https://review.opendev.org/c/openstack/ironic-python-agent/+/983758 | 16:25 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: feat: add support for new runbook traits API https://review.opendev.org/c/openstack/python-ironicclient/+/983734 | 16:38 |
| opendevreview | Jay Faulkner proposed openstack/python-ironicclient master: Add typing to many `ironicclient/osc/v1/` modules https://review.opendev.org/c/openstack/python-ironicclient/+/983352 | 16:46 |
| opendevreview | Jay Faulkner proposed openstack/python-ironicclient master: Pre-test typing cleanup https://review.opendev.org/c/openstack/python-ironicclient/+/983360 | 16:46 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Migrate setup configuration to pyproject.toml https://review.opendev.org/c/openstack/python-ironicclient/+/981226 | 16:46 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Migrate coverage configuration to pyproject https://review.opendev.org/c/openstack/python-ironicclient/+/981227 | 16:46 |
| JayF | I rebgased a handful of Karan's changes together to make a minor PR feedback thing a bunch easier | 16:47 |
| JayF | https://review.opendev.org/c/openstack/python-ironicclient/+/983352/3 please apply a +2 to this if you can | 16:47 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 16:48 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 16:52 |
| TheJulia | cardoe: wow, your more brutal to claude than I. I just point it out that it is wasting time. | 16:57 |
| cardoe | It knows better. I've corrected it many times. I get meaner the more I have to correct you for the same thing. | 16:58 |
| cardoe | I've handled the feedback you had TheJulia on the runbook stuff. | 16:58 |
| JayF | TheJulia: https://us06web.zoom.us/j/87361258102?pwd=2aI9z2kMUH6XaFTw9EjDLHp5EgPdOu.1 | 16:58 |
| cardoe | Marek gave me some as well and kicked the tires some more in my devstack. | 16:58 |
| JayF | cardoe: TheJulia: I take a completely diff approach: claude isn't a human and doesn't get personified by me if I can help it. | 16:58 |
| TheJulia | I can join in a couple minutes, call is wrapping up | 16:58 |
| TheJulia | current call is wrapping up | 16:59 |
| JayF | one of my base rules in claude, both chatbot and code, is do not personify yourself and don't use flowery language | 16:59 |
| cardoe | JayF: they've actually said they use how mean people are as automatic feedback as to how it's performing. | 16:59 |
| JayF | Star Trek computer was never like "you're absolutely right Data" | 16:59 |
| cardoe | Rather than asking each session how did it do like it used to do. | 16:59 |
| JayF | cardoe: I don't think there are good lessons to learn about software development from Anthropic's advertised patterns. | 16:59 |
| JayF | cardoe: including using a f* index as a graph and NPS-proxy | 17:00 |
| cardoe | Gimme a feedback button | 17:00 |
| TheJulia | cardoe, join if you can | 17:04 |
| opendevreview | Victor proposed openstack/ironic master: Truncate node history event to avoid DB column overflow https://review.opendev.org/c/openstack/ironic/+/981399 | 17:18 |
| dtantsur | Unrelated runbooks question: anyone considered pre-loading runbooks from a YAML file on start-up? | 17:23 |
| TheJulia | we *did* have that idea early on, but tabled that for first pass | 17:25 |
| TheJulia | since the mvp really is the api surface | 17:26 |
| dtantsur | Right. We're past MVP, hence the question :) | 17:26 |
| TheJulia | DOOOOO IT | 17:26 |
| dtantsur | We might. We'll be looking at tuning cleaning per node in metal3 soon. | 17:26 |
| TheJulia | https://www.youtube.com/evanandkatelyn <-- see the "resin time" audio bit, we need a version for Ironic. | 17:27 |
| TheJulia | beep beep beep boop code it time? | 17:29 |
| cardoe | dtantsur: or ya use a sidecar or a post deploy Job or the shell-operator to upload runbooks to the API | 17:38 |
| dtantsur | Could be, but it's a whole bunch of complications | 17:39 |
| dtantsur | We may still make BMO just create runbooks it needs | 17:40 |
| cardoe | That's what we're doing since we're keeping our runbooks in GitOps and we don't have to restart anything to load new ones or make changes. | 17:41 |
| cardoe | Looking at devstack... I think we might want to use the noop driver more. | 17:43 |
| JayF | dtantsur: I guess I don't understand why, at some level, that wouldn't be support in the client like we do for uploading csvs of nodes | 17:48 |
| dtantsur | Maybe, but there is no CLI in my case | 17:49 |
| JayF | I'm just looking historically for parallels | 17:49 |
| JayF | if that makes sense | 17:49 |
| dtantsur | Right. We also have built-in inspection rules. | 17:49 |
| JayF | like asking the question "why wouldn't we also load $otherThing that way?" to see if it sorta works out some | 17:49 |
| JayF | ooooooh | 17:49 |
| JayF | bingo that's what I wanted | 17:49 |
| cardoe | I think built-in inspection rules is/was a mistake. | 17:50 |
| cardoe | I mean hell it didn't work at release and I spent a bunch of time fixing it. | 17:50 |
| dtantsur | This is regretful but it does not mean it's a bad idea | 17:51 |
| cardoe | The only reason I messed with it is because we don't use system=all for stuff and instead have a project with the nodes we want stuff to be associated with. And the API requires system=all. | 17:51 |
| cardoe | No. It's a bad idea. | 17:51 |
| dtantsur | Your case != my case :) | 17:51 |
| cardoe | The log files and troubleshooting for built-in inspection rules sucks. | 17:51 |
| cardoe | I band aided it as best as I could. | 17:52 |
| dtantsur | It's the same story as with runbooks: it provides a customized out-of-box experience | 17:52 |
| dtantsur | * with what I'm thinking about runbooks | 17:52 |
| cardoe | You literally have no ability to troubleshoot with built-in inspection hooks | 17:52 |
| dtantsur | How is it different from API-driven hooks? | 17:52 |
| cardoe | Right now when one fails on a box I made it log rule "0000-0000-0000001" (or however many digits for a UUID) failed. | 17:52 |
| cardoe | The docs tell you to query the API to look at the rule to understand the failure... built-in rules you cannot. | 17:54 |
| dtantsur | e.g. right now [conductor]automated_cleaning_runbook is tricky to use because you need to put a reference to an object that is not there | 17:54 |
| dtantsur | (and hope we don't have any start-up time verification of this option) | 17:54 |
| cardoe | dtantsur: yep. There's a bunch of funky stuff like that like the IPA image when using glance for example. | 17:54 |
| cardoe | Though I guess you can setup glance ahead of time. | 17:55 |
| dtantsur | Yep. I was the one who added support for image names as a band-aid for this problem. | 17:55 |
| cardoe | We gotta finish fixing the permissions problem so that names work again. | 17:55 |
| dtantsur | ugh | 17:55 |
| cardoe | https://bugs.launchpad.net/ironic/+bug/2132246 | 17:56 |
| cardoe | I partially fixed it to not blow up a release or two ago but never finished it. | 17:56 |
| dtantsur | For runbooks, I'm looking for a pretty simple thing: choose which cleaning mode to use per node. So having 3 built-in runbooks (no cleaning, metadata cleaning, hard cleaning) makes certain sense. | 17:57 |
| cardoe | Same thing here. | 17:58 |
| cardoe | I've got different hardware types though and some require different steps as well. | 17:58 |
| cardoe | I've started to segregate the class of hardware by different owner projects. | 17:59 |
| dtantsur | Interesting. Regretfully, we cannot use owners meaningfully because we don't have keystone | 18:00 |
| cardoe | I think that's an oversight on our part... we should still use that. | 18:01 |
| JayF | dtantsur: I've put a whole lot of brain power into thinking about how to make ironic compatible with other authorization/authentication systems and it's just really, really tough | 18:04 |
| JayF | If we were able to figure out a design we liked for that, I'd be on board | 18:05 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add note about file being copied over to Nova https://review.opendev.org/c/openstack/ironic/+/970662 | 18:08 |
| cardoe | JayF, dtantsur: I think your owner should be the ServiceAccount in k8s that metal3 is running stuff as. | 18:17 |
| *** dmellado4717 is now known as dmellado471 | 18:21 | |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 18:26 |
| cardoe | btw something in our alembic settings or imports or something don't set whatever is needed for oslo to think we don't use eventlet. | 18:26 |
| cardoe | I dunno what that magic is. | 18:26 |
| cardoe | oslo_concurrency/lockutils.py is what's importing eventlet | 18:27 |
| * TheJulia gets out a giant brain scrambling sign | 18:39 | |
| TheJulia | oh, for the migration? | 18:50 |
| TheJulia | (which shouldn't be forked and likely okay, but yeah...) | 18:50 |
| TheJulia | well, threaded | 18:50 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Migrate package metadata from setup.cfg to pyproject.toml https://review.opendev.org/c/openstack/ironic-python-agent/+/982864 | 19:14 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Update hacking to 7.0.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/982867 | 19:14 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Enforce TLS 1.2 minimum across all connections https://review.opendev.org/c/openstack/ironic-python-agent/+/982174 | 19:14 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Upgrade TLS certificates to P-384 curve with configurable support https://review.opendev.org/c/openstack/ironic-python-agent/+/982175 | 19:14 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Update auto-tls cert signing to SHA-512 https://review.opendev.org/c/openstack/ironic-python-agent/+/982173 | 19:19 |
| cardoe | JayF: we got openstack-exporter access yes? | 20:22 |
| JayF | Adam is an admin on the repo now, yes. We are looking for contributors and active contributors have a path to maintainership | 20:22 |
| rm_work | funny, that pinged me even though I know you don't mean me 😄 but it is relevant because we are using this now and I was just messing with building it | 20:29 |
| JayF | Adam McArthur is a part-time guy on my team trying to make openstack-exporter for prometheus (the non-openstack project) mainainted/active community again | 20:30 |
| JayF | so if you wanna get involved just ... go over there and do stuff :) | 20:30 |
| JayF | be nice to sharpz7 | 20:30 |
| JayF | we have a strongly vested interest in getting a diverse group of folks working on that project again | 20:30 |
| rm_work | yeah I need to figure out HOW we're using it, but I think we export to ... some other internal log ingestion tool | 20:32 |
| JayF | prometheus is the native | 20:32 |
| opendevreview | Merged openstack/python-ironicclient master: add node trait add/remove commands for consistent UX https://review.opendev.org/c/openstack/python-ironicclient/+/981805 | 20:35 |
| JayF | cardoe: sorry, I found time to -1 it :D https://review.opendev.org/c/openstack/ironic/+/983215/7#message-c9a28552722cad9be7361bed75d240a899083a8a | 20:48 |
| JayF | cardoe: I'll note for almost anyone else I would -1 (not nit:) the "making the schema more complex == you migrate the schema" comment, but I don't wanna corner you into migrating to a form you dislike :) | 20:49 |
| * cardoe side eyes JayF. | 20:49 | |
| cardoe | "make it smaller"... earlier feedback "combine it into one logical change" | 20:49 |
| cardoe | And then you tell me to convert the schema.. ;) | 20:51 |
| cardoe | I do have a follow on to convert the whole schema... I've not been rebasing it on top until this one is done | 20:51 |
| TheJulia | tbh, under 1500 lines for all together is pretty good | 20:52 |
| TheJulia | its when you start to exceed 2k and are fragments that things get more difficult | 20:53 |
| JayF | cardoe: I've had people on my team (clif) demonstrate to me through his work that I understnad stuff a lot better when it's broken up more, and I think I'm just having more awareness when my "brain context" starts filling up | 20:53 |
| JayF | clearly TheJulia has more ram than I do (I already knew that!) | 20:53 |
| TheJulia | its like 1800 lines where I'm ENOCONTEXT | 20:54 |
| cardoe | No I was side eyeing you cause you said break it up more (which the original series was) but then you tell me to also update to the new schema format. | 20:54 |
| JayF | both labelled with nit | 20:54 |
| JayF | which isn't me telling you to do a thing, it's me wistfully wishing it was better :D | 20:54 |
| JayF | I never ever expect all my nits to be fixed | 20:54 |
| JayF | if I care about it I ask for it to be fixed | 20:55 |
| cardoe | So I'll fix that race thing. But I'm gonna leave the schema commit as separate okay? | 20:55 |
| JayF | the three comments (vertically, when viewing the page) are why you got a -1, not the other stuff | 20:55 |
| cardoe | and the commit message I'll actually read. I'm sure I had claude write it when I merged the commits into 1. | 20:56 |
| JayF | the only things I need fixed to flip my vote are the race, the broken _lookup, and documenting (or finding a way to mitigate) the behavior change for older microversions who GET /v1/runbooks with new runbooks in place | 20:56 |
| cardoe | it does work btw.. using the new names with an old client | 20:57 |
| cardoe | cause we didn't do any checking client side and deferred it all server side. | 20:57 |
| JayF | it works for the official client, but we shouldn't assume there's no downstream integrations with some weird expectation or checking (maybe automation adding runbook.name to node.traits?) | 20:58 |
| JayF | especially since runbook name was basically guaranteed to evaluate as a custom trait string before... | 20:59 |
| cardoe | No doubt. I'll update it. | 21:01 |
| cardoe | fwiw, https://review.opendev.org/c/openstack/python-ironicclient/+/983734 is the client change | 21:02 |
| cardoe | I did introduce a check that I thought had been there from the get go to give users better feedback. | 21:02 |
| cardoe | I'm happy to split that out. | 21:02 |
| TheJulia | sigh, our code with time calls is seemingly now fragile in ipa :( | 21:02 |
| TheJulia | Might be a thing for another day | 21:02 |
| cardoe | TheJulia: time calls? | 21:03 |
| TheJulia | mocking time.sleep | 21:03 |
| cardoe | oh | 21:03 |
| TheJulia | and cover test behavior seems to be breaking | 21:03 |
| TheJulia | braincells to burn tomorrow | 21:06 |
| TheJulia | I'm going to head out shortly because there is a hockey game tonight | 21:06 |
| opendevreview | David Nwosu proposed openstack/ironic master: [WIP] Add global node history endpoint https://review.opendev.org/c/openstack/ironic/+/983144 | 21:37 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 21:38 |
| cardoe | JayF: fixed everything except for the thing I didn't understand. | 21:38 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 23:05 |
| opendevreview | Steve Baker proposed openstack/ironic-tempest-plugin master: Add conditional graphical console validation https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/982077 | 23:52 |
| opendevreview | Steve Baker proposed openstack/ironic-tempest-plugin master: DNM: Add debug logging for console_interface investigation https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/983129 | 23:53 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!