| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Enforce TLS 1.2 minimum across all connections https://review.opendev.org/c/openstack/ironic-python-agent/+/982174 | 00:00 |
|---|---|---|
| cardoe | That race can happen with client side patching that you described. | 00:09 |
| cardoe | I can post on gerrit. I just like asking here. | 00:18 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: ci: yet another test race https://review.opendev.org/c/openstack/ironic-python-agent/+/983948 | 00:40 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: runbooks: add traits support, description field, and v1.112 API https://review.opendev.org/c/openstack/ironic/+/983215 | 01:16 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Upgrade TLS certificates to P-384 curve with configurable support https://review.opendev.org/c/openstack/ironic-python-agent/+/982175 | 02:52 |
| TheJulia | ooh, getting there on giving the agent tls controls | 02:53 |
| cardoe | TLS controls? | 03:55 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Fix IPA boot during out-of-band service steps https://review.opendev.org/c/openstack/ironic/+/983010 | 07:28 |
| opendevreview | Pierre Riteau proposed openstack/networking-generic-switch stable/2026.1: Fix GenericSwitchNotSupported exceptions https://review.opendev.org/c/openstack/networking-generic-switch/+/983966 | 07:34 |
| opendevreview | Pierre Riteau proposed openstack/networking-generic-switch stable/2025.2: Fix GenericSwitchNotSupported exceptions https://review.opendev.org/c/openstack/networking-generic-switch/+/983968 | 07:35 |
| opendevreview | Pierre Riteau proposed openstack/networking-generic-switch stable/2025.1: Fix GenericSwitchNotSupported exceptions https://review.opendev.org/c/openstack/networking-generic-switch/+/983969 | 07:36 |
| opendevreview | Olamide Ojo proposed openstack/ironic master: Log when console properties are updated while console is active https://review.opendev.org/c/openstack/ironic/+/983981 | 08:10 |
| opendevreview | Pierre Riteau proposed openstack/networking-generic-switch stable/2025.2: Fix GenericSwitchNotSupported exceptions https://review.opendev.org/c/openstack/networking-generic-switch/+/983968 | 10:49 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Mock system and manager in test_update_bmc_no_immediate_reboot to avoid connecting to https://example.com https://review.opendev.org/c/openstack/ironic/+/984019 | 13:00 |
| TheJulia | cardoe: the ability to say "agent, your default config prohibits older tls versions, here use say only tls 1.3 | 13:22 |
| cardoe | Ah okay. | 13:30 |
| TheJulia | at least we're to "oh, I already have a patch to fix that race" errors in ipa | 13:36 |
| opendevreview | Julia Kreger proposed openstack/python-ironicclient master: Add typing to many `ironicclient/osc/v1/` modules https://review.opendev.org/c/openstack/python-ironicclient/+/983352 | 13:41 |
| TheJulia | just a rebase | 13:41 |
| opendevreview | Merged openstack/ironic-python-agent master: Migrate package metadata from setup.cfg to pyproject.toml https://review.opendev.org/c/openstack/ironic-python-agent/+/982864 | 14:49 |
| opendevreview | Merged openstack/ironic-python-agent master: Update hacking to 7.0.0 https://review.opendev.org/c/openstack/ironic-python-agent/+/982867 | 14:49 |
| stephenfin | dtantsur: (since you appear to have authored the original patch) jfyi there doesn't appear to be any api-ref docs for the reset_interfaces parameter of the nodes API. I'd to go read the API code to figure out what it was doing in SDK | 15:03 |
| dtantsur | my bad :) patches appreciated | 15:04 |
| opendevreview | David Nwosu proposed openstack/ironic master: Add project field to node history and record deployment transitions https://review.opendev.org/c/openstack/ironic/+/983349 | 15:22 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: ci: Fix the functional test job https://review.opendev.org/c/openstack/ironic-python-agent/+/984054 | 15:24 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Add functional test for TLS version enforcement https://review.opendev.org/c/openstack/ironic-python-agent/+/984055 | 15:24 |
| TheJulia | Okay, to a better place | 15:25 |
| cardoe | dtantsur: JayF's OOO today but I'd appreciate letting me know where ya want me to go with https://review.opendev.org/c/openstack/ironic/+/983215 but also reconciling it with what JayF wants. I'm also happy to fix stuff in a follow up. One of the things that folks have said is to keep changes small. So I've already got follow ups queued like changing the schema stuff to what stephenfin's started. | 16:24 |
| dtantsur | cardoe: I'm still not sure why the same case of two concurrent edits doesn't apply to steps (or many other things in Ironic).. but also, it may be a case of "let's just document it properly", i.e. not a blocking concern | 16:27 |
| dtantsur | that all being said, I'm not feeling well today and have already run out of spoons by this moment. I'll keep your patch in my queue if nobody beats me to it | 16:28 |
| cardoe | So I'm just describing my understanding of the Claude output... There's no PUT /api/runbook/<uuid>/step/BLAH endpoint which atomically adds a step. It's entirely client side. You do a PATCH on /api/runbook/<uuid> which then returns a new 'last_updated' time. | 16:31 |
| cardoe | But there is a PUT /api/runbook/<uuid>/trait/CUSTOM_BAZ and that does not alter the last_updated time. | 16:32 |
| dtantsur | oh, I quite dislike the latter btw (not changing last_updated) | 16:32 |
| cardoe | Well that's how traits work on nodes today as well | 16:33 |
| dtantsur | but yeah, I see where you're going with it | 16:33 |
| cardoe | Any time it's a separate table. | 16:33 |
| dtantsur | The confusing part will be that we accept traits on creation and when showing runbooks, but not when updating. But I also recognize that we have similar patterns all over the API. | 16:34 |
| cardoe | I'll add it back but I just want a reconcile between you to so I don't have a -1 from one of you. | 16:35 |
| cardoe | Nodes don't allow you to create them with traits and I'm happy to remove creating runbooks with traits and requiring follow up calls to add them. | 16:36 |
| cardoe | I'm gonna make the python-ironicclient just magic that away by making the calls. | 16:36 |
| dtantsur | Hmm. I'm not sure it's a good way out too: now you can create unusable runbooks if you neither name them with CUSTOM_ nor provide traits. Right? | 16:37 |
| cardoe | Correct. But that's how the existing API works today. Nothing forces me to create a runbook with CUSTOM_ as the prefix so it's unusable. | 16:38 |
| dtantsur | cardoe: I think I'me fine with what you have now. Perfect is enemy of good, and so on. I just need more energy for the final review pass, and I don't have it now. | 16:39 |
| cardoe | I think stripping off creating a runbook with traits is totally cool with me. It'll make the PATCH schema the same as the POST schema. | 16:40 |
| dtantsur | Right. So it will keep the name-based approach the default mode, and the trait-based one becomes an advanced option? I mean, logically. | 16:40 |
| * dtantsur will check back on Monday | 16:46 | |
| opendevreview | Julia Kreger proposed openstack/sushy master: Fix verify option usage with tls version settings https://review.opendev.org/c/openstack/sushy/+/984070 | 16:46 |
| opendevreview | Julia Kreger proposed openstack/sushy master: tls: Short circuit retries on hard tls errors https://review.opendev.org/c/openstack/sushy/+/984071 | 16:46 |
| cardoe | dtantsur: yes. | 16:46 |
| TheJulia | So, I gave the tls version knob a spin and hit some minor things, but idrac 9's *do* support tls 1.2. They don't support 1.3 ;) | 16:48 |
| cardoe | of course they don't | 17:19 |
| opendevreview | Julia Kreger proposed openstack/ironic-python-agent master: Add functional test for TLS version enforcement https://review.opendev.org/c/openstack/ironic-python-agent/+/984055 | 18:01 |
| opendevreview | Julia Kreger proposed openstack/sushy master: Update hacking to 7.0.0 https://review.opendev.org/c/openstack/sushy/+/984093 | 18:04 |
| opendevreview | Merged openstack/networking-generic-switch stable/2025.2: CI: Temporary setuptools pin https://review.opendev.org/c/openstack/networking-generic-switch/+/983277 | 19:30 |
| opendevreview | Merged openstack/ironic-python-agent master: ci: yet another test race https://review.opendev.org/c/openstack/ironic-python-agent/+/983948 | 19:31 |
| opendevreview | Verification of a change to openstack/ironic master failed: gracefully handle plugging the port for a test node https://review.opendev.org/c/openstack/ironic/+/983714 | 19:34 |
| opendevreview | Verification of a change to openstack/ironic master failed: devstack: fix qrouter used in iptables calls https://review.opendev.org/c/openstack/ironic/+/983715 | 19:34 |
| opendevreview | Verification of a change to openstack/ironic master failed: fix ip route call to be idempotent https://review.opendev.org/c/openstack/ironic/+/983716 | 19:34 |
| opendevreview | Pierre Riteau proposed openstack/networking-generic-switch stable/2025.1: CI: Temporary setuptools pin https://review.opendev.org/c/openstack/networking-generic-switch/+/984114 | 19:39 |
| opendevreview | Merged openstack/ironic master: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983731 | 19:52 |
| *** denver is now known as denver_ba | 21:11 | |
| cardoe | https://bugs.launchpad.net/ironic/+bug/2148051 I've seen that race more than once so I logged it. | 22:13 |
| TheJulia | ++ | 22:20 |
| opendevreview | Verification of a change to openstack/ironic master failed: gracefully handle plugging the port for a test node https://review.opendev.org/c/openstack/ironic/+/983714 | 22:39 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2026.1: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983732 | 22:46 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2025.2: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983733 | 22:47 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2025.2: devstack: Drop dead reference to pyghmi https://review.opendev.org/c/openstack/ironic/+/983733 | 22:48 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!