| opendevreview | JayGue Lee proposed openstack/networking-baremetal master: router_ha_binding: Skip networks without external ports https://review.opendev.org/c/openstack/networking-baremetal/+/996726 | 00:32 |
|---|---|---|
| dtantsur | Has anyone seen anything like this? https://aae15366fccb3e5d9342-63681721353a54dab1064b012b97b3cb.ssl.cf5.rackcdn.com/openstack/09d0dd6ce04949c0839597f971be2a56/logs/testvm1_console.log | 07:43 |
| rpittau | dtantsur: unfortunately yes, did we change ovmf package recently? that looks like an issue with the internal networking driver | 09:03 |
| dtantsur | *we* don't change packages, but OS do.. | 10:08 |
| rpittau | yeah, I mean if the pkg was updated recently :D | 10:10 |
| opendevreview | Esther Domfeh proposed openstack/ironic master: feat: add state, target_provision_state, and duration_seconds to node history https://review.opendev.org/c/openstack/ironic/+/989994 | 10:18 |
| dtantsur | TheJulia: happy to talk about EVPN, especially if you don't expect me to understand what I'm proposing really well :-P | 10:27 |
| opendevreview | Esther Domfeh proposed openstack/ironic master: feat: populate node_history state fields https://review.opendev.org/c/openstack/ironic/+/993208 | 10:55 |
| opendevreview | Esther Domfeh proposed openstack/ironic master: Add request context user tracking to node history records https://review.opendev.org/c/openstack/ironic/+/993901 | 10:55 |
| opendevreview | Esther Domfeh proposed openstack/ironic master: Add power tracking telemetry in node history https://review.opendev.org/c/openstack/ironic/+/996347 | 10:55 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Soft power off before ejecting virtual media after inspection, regardless of CONF.inspector.power_off. Do not soft power off if PXE boot is enabled. https://review.opendev.org/c/openstack/ironic/+/996692 | 12:27 |
| TheJulia | good morning | 13:23 |
| dtantsur | morning TheJulia | 13:48 |
| TheJulia | good morning | 14:29 |
| cardoe | any reason the driver_validate_interfaces RPC call skips the vendor interface? https://opendev.org/openstack/ironic/src/commit/ad36138432598a37b5b59fca2167889135f2ec4b/ironic/conductor/manager.py#L2251 | 14:55 |
| * dtantsur has no chances of remembering | 14:57 | |
| TheJulia | if there was, we've all forgotten it | 14:57 |
| * TheJulia slides whiskey over to dtantsur | 14:57 | |
| dtantsur | \o/ | 14:57 |
| dtantsur | 5pm on Friday, about the right time | 14:58 |
| TheJulia | woot | 15:01 |
| cardoe | blerg I see why | 15:18 |
| cardoe | naming sucks here | 15:18 |
| TheJulia | is the root of all evil that names exist? | 15:19 |
| cardoe | so all validate interfaces EXCEPT vendor have the same API | 15:22 |
| cardoe | validate takes the data in driver_info and just makes sure the interface will work | 15:23 |
| cardoe | While vendor takes the whole operation as a payload as well and decides. | 15:24 |
| cardoe | So that call needs to be renamed cause it'll never type check that it conforms to BaseInterface | 15:24 |
| opendevreview | Merged openstack/ironic unmaintained/2023.1: CVE-2026-44918: Prevent rehoming resources to nodes with different owner https://review.opendev.org/c/openstack/ironic/+/996529 | 15:45 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: When using virtual media, soft power off before ejecting virtual media after inspection, regardless of CONF.inspector.power_off. Do not soft power off if PXE boot is enabled. https://review.opendev.org/c/openstack/ironic/+/996692 | 16:19 |
| cardoe | This is really turning into a pile of if / else? | 16:25 |
| opendevreview | Will Szumski proposed openstack/tenks master: Revert back to master upper constraints https://review.opendev.org/c/openstack/tenks/+/994295 | 16:32 |
| TheJulia | I'd likely create methods and hide logic inside of them or just attempt to cleanup regardless but in a non-failing way. | 17:00 |
| Mahnoor | Yep, its a lot of ifs, true | 18:49 |
| cardoe | I swear every time I decide to try to tackle something small. | 18:49 |
| cardoe | The yak train shows up. | 18:49 |
| TheJulia | Well, it snowballs | 18:50 |
| TheJulia | just like ifs ;) | 18:50 |
| Mahnoor | :) | 18:50 |
| TheJulia | The difference is "do we need to, or must we refactor" and "is it good enough, or perfect" | 18:50 |
| Mahnoor | TheJulia do you reckon I should create a bug for ironic upstream or is making the commit message + single release note better okay? | 18:51 |
| TheJulia | I, more so, ask just about a bug to try to understand the "why" | 18:51 |
| Mahnoor | Makes sense | 18:52 |
| cardoe | okay so lemme know if you agree here cause I'm just gonna make a todo with a whole lot of details for a future LLM to tackle. It'll probably end up being a bug. | 18:52 |
| TheJulia | it *sounds* like there might be a bug there, but need to delineate it | 18:52 |
| Mahnoor | are we all talking about the same thing | 18:52 |
| TheJulia | cardoe: a "TODO" file? | 18:52 |
| cardoe | So the hardware_type / driver interfaces of Ironic is what I'm talking about. | 18:52 |
| TheJulia | Mahnoor: yes, no, maybe? | 18:52 |
| Mahnoor | alrightie, cardoe | 18:52 |
| cardoe | I know we're also talking about the virtual media / power off stuff that Mahnoor is looking at. | 18:53 |
| cardoe | But I'm trying to left shark TheJulia here. | 18:53 |
| TheJulia | squirrel! | 18:53 |
| cardoe | My name is Doug... I am the dog in Up. | 18:53 |
| TheJulia | my brain just halted | 18:53 |
| TheJulia | congrats! | 18:53 |
| cardoe | So hardware_type is a class that just expresses what interfaces are supported. It's not what we actually load as the "driver" | 18:54 |
| cardoe | I originally hated the conflated naming but realize now they're different | 18:54 |
| TheJulia | correct, the "driver" is a composed composition | 18:54 |
| cardoe | Yes. | 18:54 |
| TheJulia | its way better now than it once was | 18:55 |
| TheJulia | ... trust. me. | 18:55 |
| cardoe | So we have "core_interfaces" which must not be None (but # TODO(someone_i_dont_recognize): somehow management was None here? | 18:55 |
| cardoe | But technically an alternate implementation can override core_interfaces but there's none in tree that do. | 18:56 |
| cardoe | Then we have "optional_interfaces" which are allowed to be None | 18:56 |
| TheJulia | I'm not sure I exactly follow | 18:56 |
| cardoe | This is to create the composed "driver" | 18:56 |
| cardoe | So we load the node and we load the node's "driver" field and then it's various interfaces fields to create the composed thing. | 18:57 |
| cardoe | They round trip through the hardware_type which matches the "driver" field to identify the supported ones. | 18:57 |
| cardoe | I wish we were in the same room. It'd be easier with a white board. | 18:57 |
| TheJulia | aye, yes | 18:58 |
| cardoe | https://meetpad.opendev.org/ironic-driver-interfaces | 18:58 |
| Mahnoor | So do I triage my own bug :) | 19:13 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Soft power off before virtual media ejection on inspection cleanup https://review.opendev.org/c/openstack/ironic/+/996692 | 19:22 |
| Mahnoor | Have a good weekend, see you Monday o/ | 19:25 |
| TheJulia | Mahnoor: you can :) | 19:53 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add deferred actions data model, DB API, and versioned object https://review.opendev.org/c/openstack/ironic/+/989224 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add two-step deferred actions cleanup DB methods https://review.opendev.org/c/openstack/ironic/+/994948 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add config options, reschedule exception, and action creation helper https://review.opendev.org/c/openstack/ironic/+/989225 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add deferred action launcher periodic and executor https://review.opendev.org/c/openstack/ironic/+/989226 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add deferred action cleanup periodic and stuck recovery https://review.opendev.org/c/openstack/ironic/+/989227 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add notifications for deferred action terminal states https://review.opendev.org/c/openstack/ironic/+/989228 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add metrics gauges and enhanced logging for deferred actions https://review.opendev.org/c/openstack/ironic/+/989229 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Add upgrade check for deferred action backlog https://review.opendev.org/c/openstack/ironic/+/989230 | 21:07 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Decompose redfish firmware stability validation into deferred actions https://review.opendev.org/c/openstack/ironic/+/989231 | 21:07 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!