| opendevreview | Verification of a change to openstack/ironic master failed: api: Add schema validation framework https://review.opendev.org/c/openstack/ironic/+/928920 | 02:11 |
|---|---|---|
| opendevreview | Adam McArthur proposed openstack/ironic-tempest-plugin master: Testing bad microversions on v1/allocations https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/937213 | 02:23 |
| opendevreview | Steve Baker proposed openstack/ironic master: Utility functions for graphical console drivers https://review.opendev.org/c/openstack/ironic/+/939505 | 02:47 |
| opendevreview | Steve Baker proposed openstack/ironic master: Add ironic-novncproxy service https://review.opendev.org/c/openstack/ironic/+/939191 | 02:47 |
| opendevreview | Steve Baker proposed openstack/ironic master: Add VNC auth type to novnc-proxy https://review.opendev.org/c/openstack/ironic/+/939192 | 02:47 |
| opendevreview | Steve Baker proposed openstack/ironic master: Create idrac graphical console driver https://review.opendev.org/c/openstack/ironic/+/939193 | 02:47 |
| cardoe | stevebaker[m]: you were making driver_info_internal hidden entirely in that series? | 03:27 |
| stevebaker[m] | cardoe: just the keys which match the hidden patterns, as for driver_info and instance_info. Check out strutils.mask_dict_password for the implementation. It catches anything containing | 03:28 |
| stevebaker[m] | 'token', 'password', 'secret' for example | 03:29 |
| cardoe | Good deal. I was fixing up the node cleaning docs and it says to parse the internal info to know what step it’s on. Which feels awkward but then seeing you post that series made me remember that. | 03:30 |
| stevebaker[m] | hmm, you might want to confirm those keys are not affected. Most will be unmasked I think | 03:33 |
| cardoe | TheJulia, keekz, cid, JayF: https://etherpad.opendev.org/p/ironic-cardoe-inspect-hooks-and-rules first swag. | 04:40 |
| opendevreview | Merged openstack/ironic master: api: Add schema validation framework https://review.opendev.org/c/openstack/ironic/+/928920 | 05:13 |
| janders | Hey Ironic'ers. I think I found a bug in bifrost which I am happy to propose a fix for but I first wanted to confirm with you if it's indeed a defect (as opposed to an user error) | 06:46 |
| janders | I tried deploying with a command like this: ./bifrost-cli deploy -e @baremetal-install-env.json --image $URL --image-checksum $IMG_MD5 --configdrive '{"meta_data": {"public_keys": {"0": "'"$(cat ~/.ssh/id_rsa.pub)"'"}}}' | 06:47 |
| janders | (trying to use bifrost for image management in a small lab, drinking own champagne so to speak) | 06:47 |
| janders | I hit this: https://paste.opendev.org/show/bUA79JmSBwHo3HqIo5vt/ it seems like we | 06:47 |
| janders | are looking for uuid in https://opendev.org/openstack/bifrost/src/branch/master/playbooks/roles/bifrost-deploy-nodes-dynamic/tasks/main.yml#L41 | 06:48 |
| janders | but I tried to debug-output node_info and there is only "id" instead: | 06:48 |
| janders | https://paste.opendev.org/show/bWS60flSG37cz0ykzg7V/ (see L60) | 06:49 |
| janders | is this likely unnoticed regression in some rarely-used codepath (it works if deploy is called with no params) or is it more complicated than that? | 06:49 |
| janders | In case of the former I am happy to push a trivial patch | 06:49 |
| janders | (while on the topic https://docs.openstack.org/bifrost/latest/user/howto.html#command-line-parameters has an example of --config-drive CLI parameter while we only have --configdrive - once I get into fixing mode I can push a trivial fix to that too) | 06:51 |
| rpittau | good morning ironic! o/ | 07:44 |
| janders | hey rpittau o/ | 07:44 |
| arne_wiebalck | Good morning, Ironic! | 08:01 |
| arne_wiebalck | I was about to ask about bootc, but now I see https://review.opendev.org/c/openstack/ironic-python-agent/+/940178 and https://review.opendev.org/c/openstack/ironic/+/937897, wow! | 08:08 |
| frickler | JayF: TheJulia: cid: I followed the advice on the lp bug create page and found https://storyboard.openstack.org/#!/story/2011154 , which exactly looks like my issue. so a great chance to make even more people happy ;-D | 08:17 |
| frickler | while we're here, I have two more questions related to node validation: a) why do I have to specify a cleaning_network even if automated_clean is false? I did end up just adding "public", but this feels wrong | 08:29 |
| cid | Sounding like a bug | 08:32 |
| cid | frickler, re: <,,, on the lp bug create page... found ...> Great spot, and the bug is recent too! Fix should be up in a bit. | 08:32 |
| frickler | cid: cool, thx | 08:35 |
| frickler | issue b): the redfish_password option is marked optional, but treated as required in https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/redfish/utils.py#L215-L218 leading to something like ironic.common.exception.RedfishError: Redfish exception occurred. Error: 'NoneType' object has no attribute 'encode' | 08:36 |
| frickler | should the option be required or does the session cache code need fixing? | 08:36 |
| frickler | (I only noticed this because I typoed as rdfish_password, didn't spot that, and went on a long deep dive into the code to see what was happening, since in contrast to the license issue, the logs in this case are pretty minimal) | 08:38 |
| rpittau | frickler: I think that's another bug, the cache mechanism needs some adjustment as the password is indeed optional | 08:45 |
| opendevreview | Dr. Jens Harbott proposed openstack/ironic master: Fix redfish session cache on missing password https://review.opendev.org/c/openstack/ironic/+/940431 | 09:52 |
| frickler | thx for confirming, ^^ may be a bit clumsy, but fixes the issue for me, feel free to amend if needed | 09:53 |
| opendevreview | cid proposed openstack/ironic master: Log secure boot access failures at INFO level https://review.opendev.org/c/openstack/ironic/+/940433 | 09:58 |
| rpittau | thanks frickler! would you mind also opening a bug in launchpad for that? we will also need a release note | 10:06 |
| frickler | rpittau: actually I do mind, does the ironic community not have a policy that would allow for an exemption for almost-trivial bug fixes? and if it doesn't, is that intentional | 10:35 |
| opendevreview | cid proposed openstack/ironic master: Log secure boot access failures at INFO level https://review.opendev.org/c/openstack/ironic/+/940433 | 11:01 |
| cid | frickler, kindly take a loot at ^ when you can. | 11:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!