| *** yland has joined #openstack-jjb | 00:23 | |
| waynr | I think there's only one or two more patches blocking the 2.0 release, isn't there? | 00:53 |
|---|---|---|
| *** larainema has quit IRC | 00:58 | |
| *** yland has quit IRC | 01:04 | |
| zxiiro | Yeah. We're very close. Hopefully Darragh will have time to push the last ones through | 02:27 |
| *** larainema has joined #openstack-jjb | 02:55 | |
| *** larainema has quit IRC | 08:47 | |
| *** smyers has quit IRC | 08:47 | |
| *** jeblair has quit IRC | 08:47 | |
| *** waynr has quit IRC | 08:47 | |
| *** zxiiro has quit IRC | 08:47 | |
| *** zaro has quit IRC | 08:47 | |
| *** fungi has quit IRC | 08:47 | |
| *** Odd_Bloke has quit IRC | 08:47 | |
| *** openstackgerrit has quit IRC | 08:47 | |
| *** openstack has joined #openstack-jjb | 13:55 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add !include-jinja2 for rendering templates with Jinja2 https://review.openstack.org/489414 | 14:11 |
| Odd_Bloke | waynr: Thanks for your review! Updated ^ to cover Darragh's comments. | 14:16 |
| waynr | Odd_Bloke: cool, gave my +2 again | 14:54 |
| Odd_Bloke | Thanks! :) | 15:19 |
| waynr | thank you for the patch! | 15:24 |
| ssbarnea | electrofelix: https://review.openstack.org/#/c/463729/ | 15:54 |
| openstackgerrit | Sorin Sbârnea proposed openstack-infra/jenkins-job-builder master: use alphanum sorting for jobs and views https://review.openstack.org/463729 | 16:51 |
| ssbarnea | electrofelix: regarding jobs in folders, I am not sure how we should sort this now, especially because we have multiple patches open in parallel. https://review.openstack.org/#/c/463706/ | 16:57 |
| ssbarnea | electrofelix: i would say that maybe is better to merge it as its now and address the path issue later, after we get the support for folders in jjb. This feature is not enabled by default so I see no risks on introducing a regression. | 16:58 |
| electrofelix | ssbarnea: so there is some support for folders in there already and comments on the other change suggests that people are already using it by embedding '/' in the job name, and then this change then will result in invalid URLs for those users | 17:19 |
| *** electrofelix has quit IRC | 17:57 | |
| *** yland has joined #openstack-jjb | 18:13 | |
| *** yland is now known as Guest41157 | 18:13 | |
| Odd_Bloke | People here might be interested in a side project I've been working on over the last week: https://github.com/OddBloke/jenkins-job-linter | 18:18 |
| Odd_Bloke | It adds a `jenkins-jobs lint` command and does some basic checking that jobs are configured in a particular way (current checks are: jobs have timestamps enabled, no shebangs that will result in silent failures, no empty shell builders) | 18:19 |
| *** Guest41157 is now known as yland | 18:22 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add default columns to list views https://review.openstack.org/492221 | 18:39 |
| zxiiro | yland: what are you working on this week? | 18:39 |
| yland | zxiiro: I am currently adding support for jira-trigger plugin | 19:00 |
| yland | I am just about to sent in a draft patch | 19:01 |
| zxiiro | yland: cool. no updates this week? | 19:01 |
| yland | zxiiro: I would work on that, I just forgot to do so after the meeting yesterday, since I was experiencing some power failure. | 19:04 |
| yland | zxiiro: I tried pushing the draft but I am getting the error "(draft workflow is disabled) | 20:14 |
| yland | error: failed to push some refs to 'ssh://yland@review.openstack.org:29418/openstack-infra/jenkins-job-builder.git'" | 20:14 |
| yland | I am currently trying to resolve the issue | 20:14 |
| zxiiro | yland: yeah openstack's gerrit doesn't allow drafts as it turns out. | 20:14 |
| zxiiro | yland: OpenDaylight's does that's why I thought it worked. | 20:14 |
| zxiiro | yland: the workflow with openstack is you should -1 workflow if it's a work in progress patch | 20:15 |
| zxiiro | so you push then set -1 workflow which will tell other reviewers the patch is not yet ready to be reviewed | 20:15 |
| yland | zxiiro: Thanks for letting me know, I could have ended up spending much time trying to resolve the error. I would just work with you suggestions. | 20:18 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Add support for JIRA Trigger Plugin https://review.openstack.org/492266 | 20:26 |
| zxiiro | yland: cool after you send you status update. Can you work on responding to feedback on your existing patches? it would be good if we can drive your patches through to be merged. | 20:32 |
| zxiiro | yland: all patches that have outstanding comments should be addressed | 20:32 |
| yland | zxiiro: looking at some of the patches such as https://review.openstack.org/#/c/479990/ which were just 1 liners and thus not necessary to be changed, should I just tag them as abandon? | 20:42 |
| zxiiro | yland: yeah you can abandon that one | 20:50 |
| zxiiro | ssbarnea: I think your update patch for the alphanum patch cancelled the merge | 21:41 |
| zxiiro | ssbarnea: oh nevermind i didn't realize jenkins failed the merge | 21:42 |
| zxiiro | yland: What I would do in the future is send your update before the meeting. That way you can reference your update during the meeting and you won't forget to do it :) | 21:43 |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Add support for view-templates https://review.openstack.org/395716 | 21:47 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: use alphanum sorting for jobs and views https://review.openstack.org/463729 | 21:47 |
| yland | zxiiro: That's a great suggestion. I would be doing that subsequently. | 22:00 |
| *** smyers has quit IRC | 22:13 | |
| *** smyers has joined #openstack-jjb | 22:24 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Add support for JIRA Trigger Plugin https://review.openstack.org/492266 | 22:55 |
| *** yland has quit IRC | 23:12 | |
| *** yland has joined #openstack-jjb | 23:34 | |
| *** yland is now known as Guest73525 | 23:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!