| *** yland has quit IRC | 00:46 | |
| *** yland has joined #openstack-jjb | 07:44 | |
| *** yland is now known as Guest10457 | 07:45 | |
| *** Guest10457 has quit IRC | 07:53 | |
| *** openstackgerrit has joined #openstack-jjb | 08:50 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Add support for JIRA Trigger Plugin https://review.openstack.org/492266 | 08:50 |
|---|---|---|
| *** electrofelix has joined #openstack-jjb | 08:53 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Add support for JIRA Trigger Plugin https://review.openstack.org/492266 | 09:38 |
| zxiiro | electrofelix: are we meeting today? | 13:43 |
| electrofelix | we can try | 14:00 |
| zxiiro | cool waynr around? | 14:01 |
| zxiiro | I guess the only thing I want to discuss is what's outstanding for 2.0 release. | 14:01 |
| zxiiro | I think ssbarnea is interested too. | 14:02 |
| zxiiro | Also do we want to follow through with the changes proposed by? https://review.openstack.org/#/q/status:open+project:openstack-infra/jenkins-job-builder+branch:master+topic:2.0-config-format | 14:02 |
| zxiiro | I recall this was one of the patches that were outstanding https://review.openstack.org/333076 | 14:04 |
| electrofelix | so are we switching to the meeting channel? | 14:06 |
| zxiiro | electrofelix: I think it'd be easier to use this channel for meetings since we're all here anyway. | 14:08 |
| zxiiro | plus I think meetbot is here now too? | 14:08 |
| zxiiro | #startmeeting test | 14:08 |
| openstack | Meeting started Fri Aug 11 14:08:29 2017 UTC and is due to finish in 60 minutes. The chair is zxiiro. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:08 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:08 |
| openstack | The meeting name has been set to 'test' | 14:08 |
| zxiiro | #endmeeting | 14:08 |
| openstack | Meeting ended Fri Aug 11 14:08:33 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:08 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/test/2017/test.2017-08-11-14.08.html | 14:08 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/test/2017/test.2017-08-11-14.08.txt | 14:08 |
| zxiiro | yeah | 14:08 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/test/2017/test.2017-08-11-14.08.log.html | 14:08 |
| electrofelix | interesting | 14:08 |
| electrofelix | maybe we can update the meeting to state we'll use the dedicated channel | 14:09 |
| zxiiro | yeah that's a good idea | 14:09 |
| zxiiro | #startmeeting jjb | 14:09 |
| openstack | Meeting started Fri Aug 11 14:09:42 2017 UTC and is due to finish in 60 minutes. The chair is zxiiro. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:09 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:09 |
| openstack | The meeting name has been set to 'jjb' | 14:09 |
| zxiiro | #chair electrofelix waynr | 14:09 |
| openstack | Current chairs: electrofelix waynr zxiiro | 14:09 |
| zxiiro | #topic General | 14:10 |
| zxiiro | #info electrofelix says we should update meeting to state that we'll use dedicated channel | 14:10 |
| zxiiro | electrofelix: you want to take action to do that? | 14:10 |
| electrofelix | will do | 14:15 |
| zxiiro | #action electrofelix to update meeting details to state that we'll use #openstack-jjb for meetings | 14:15 |
| zxiiro | #topic jjb-2.0 | 14:15 |
| zxiiro | #info Need to understand what is outstanding for a jjb 2.0 release. | 14:16 |
| zxiiro | #info waynr's patch https://review.openstack.org/333076 has been replied to | 14:16 |
| zxiiro | is there any action items on that patch? or just someone needs to review it? | 14:17 |
| zxiiro | Also what other patches do we need to keep track of related to jjb 2.0 work? | 14:17 |
| zxiiro | #info zxiiro asks if we want to move forward with the proposal in the set of patches from https://review.openstack.org/#/q/status:open+project:openstack-infra/jenkins-job-builder+branch:master+topic:2.0-config-format | 14:18 |
| electrofelix | I'll look at reviewing that change so | 14:18 |
| zxiiro | ok | 14:18 |
| zxiiro | #action electrofelix to review waynr's patch https://review.openstack.org/333076 | 14:18 |
| zxiiro | electrofelix: any other patches I didn't list that we should be looking at to push 2.0 through? | 14:19 |
| electrofelix | update to only pass the config namespace related to the object around | 14:19 |
| ssbarnea | zxiiro: yes, very interested about 2.0 release | 14:20 |
| zxiiro | electrofelix: ok do we have a patch or bug for that (or something we can link to?) | 14:21 |
| zxiiro | #info electrofelix says only other change needed is a patch to pass only the config namespace related to object around | 14:21 |
| electrofelix | no storyboard entry, only mentioned in the etherpad | 14:22 |
| electrofelix | see https://etherpad.openstack.org/p/jjb_api_v2.0 | 14:22 |
| zxiiro | #link https://etherpad.openstack.org/p/jjb_api_v2.0 EtherPad details on JJB 2.0 work | 14:24 |
| zxiiro | electrofelix: Cool I assume you will be working on that patch? | 14:25 |
| electrofelix | zxiiro: yes, set aside time around the meeting to start work on it properly | 14:26 |
| zxiiro | Ok so I think there are 3 things to land then, waynr's YAMLParser patch, electrofelix's namespace-config patch and to decide whether or not we want to land the set of patches that changes the default config preference to newest version of plugin | 14:26 |
| zxiiro | #action electrofelix to work on config namespace patch | 14:26 |
| zxiiro | cool that's all I got | 14:27 |
| zxiiro | anyone else want to raise anything? ssbarnea? waynr? | 14:27 |
| electrofelix | zxiiro: I'm ok with landing to switch to the newest version of each plugin, just need a good way to start letting people know? | 14:27 |
| ssbarnea | zxiiro: i don't have anything in particular, my only "desire" is to release v2 (tag + pypi) so we can start consuming it officially. I have being using v2 outside CI for 6+ months without real problems so I doubt it would introduce any regressions for us. | 14:28 |
| zxiiro | electrofelix: release notes is probably the best place? and maybe docs? | 14:29 |
| zxiiro | electrofelix: I'll action myself to take a stab at putting it in the docs somewhere | 14:30 |
| zxiiro | #action zxiiro to propose a patch to document that plugin configuration in 2.0 will default to the latest release of the plugin rather than oldest supported. | 14:30 |
| zxiiro | ssbarnea: sounds good | 14:31 |
| zxiiro | #endmeeting | 14:31 |
| openstack | Meeting ended Fri Aug 11 14:31:48 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:31 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/jjb/2017/jjb.2017-08-11-14.09.html | 14:31 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/jjb/2017/jjb.2017-08-11-14.09.txt | 14:31 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/jjb/2017/jjb.2017-08-11-14.09.log.html | 14:31 |
| zxiiro | ssbarnea: electrofelix: thanks! Have a good weeked. I'll try to propose a patch for the docs sometime this afternoon. | 14:32 |
| ssbarnea | thanks! | 14:32 |
| waynr | whoops forgot about the meeting :( | 15:15 |
| waynr | zxiiro: was it once every two weeks? | 15:17 |
| zxiiro | waynr: yeah it's bi-weekly | 15:18 |
| waynr | i'll put it on my calendar for reals this time | 15:18 |
| zxiiro | waynr: next one is in 2 weeks | 15:18 |
| waynr | okay it's on my calendar | 15:19 |
| waynr | i was definitely awake an hour ago, just prioritizing non computer things | 15:20 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update class Pipeline to use convert_mapping_to_xml() https://review.openstack.org/479524 | 15:28 |
| *** electrofelix has quit IRC | 17:30 | |
| *** yland has joined #openstack-jjb | 17:35 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Document JJB 2.0 plugin config default behaviour https://review.openstack.org/493095 | 17:41 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update cvs to make use of convert_mapping_to_xml() https://review.openstack.org/479632 | 18:14 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update cvs to make use of convert_mapping_to_xml() https://review.openstack.org/479632 | 18:18 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update cvs to use convert_mapping_to_xml() https://review.openstack.org/479632 | 18:44 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update class Pipeline to use convert_mapping_to_xml() https://review.openstack.org/479524 | 19:17 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update build_keeper to use convert_mapping_to_xml() https://review.openstack.org/479987 | 20:12 |
| yland | Hello, I am working on this patch https://review.openstack.org/#/c/479632/ and I keep getting pep8 error, but when I look at the console log, all I see is https://gist.github.com/yland/e88ca0fe065bf37c9326f233d2f1bf71. I have tried searching for the word "error" in the file and I also ran "tox -e pep8" locally but I haven't found any error. | 20:54 |
| waynr | yland: hmm is that the complete output? looks like it's cut off at the bottom | 21:11 |
| waynr | yland: in http://logs.openstack.org/32/479632/4/check/gate-jenkins-job-builder-pep8-ubuntu-xenial/8d26267/console.html i see '2017-08-11 18:50:52.193953 | ./jenkins_jobs/modules/scm.py:44:1: F401 'MissingAttributeError' imported but unused' | 21:12 |
| yland | waynr: Thanks for helping me identify the issue. This is the second time I am having this issue. I have tried reloading the console log page and even using another browser but I still don't get the complete output. | 21:20 |
| waynr | hmmm interesting | 21:21 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update cvs to use convert_mapping_to_xml() https://review.openstack.org/479632 | 21:31 |
| yland | waynr: the branch I was pushing from was not upto date and it still had 'MissingAttributeError' being used in the code, that is why I could not see the error locally and maybe that was why I could not see the error online too. | 21:38 |
| zxiiro | yland: you can run the tests locally as well. | 22:09 |
| zxiiro | yland: tox -e <test> for example `tox -e pep8` should run the pep8 tests | 22:09 |
| zxiiro | yland: you need python-tox installed on your system | 22:09 |
| zxiiro | yland: It's good practice to always do a "git pull --rebase" before you push. This ensures that you're always working with the latest code. | 22:10 |
| yland | zxiiro: thanks, I just forgot to update the branch :). I was not aware of "git pull --rebase" so I usually use "git fetch" and then "git rebase" | 22:20 |
| zxiiro | yland: both methods do the same thing | 22:20 |
| yland | zxiiro: Yes, I would prefer to use "git pull --rebase" since it is more compact. | 22:22 |
| waynr | i do the opposite usually, go for more verbose series of commands ;) | 22:33 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update cloudformation_stack to use convert_xml() https://review.openstack.org/481875 | 22:50 |
| yland | waynr: why do you think it would be better to go for more verbose series of commands. | 22:51 |
| waynr | i don't necessarily think it's better, i just fall into habitual approaches to things that end up being more verbose | 22:53 |
| waynr | i don't even use 'git pull' for example | 22:53 |
| waynr | almost always 'git fetch' followed by rebasing or merging depending on the situation | 22:54 |
| waynr | also i often track multiple remotes depending on the projects i'm working on...my personal projects often have remotes pointing at different compuers in my personal network, a gitolite server on my vps, or different hosted copies of the git repo | 22:55 |
| waynr | and there are some cases where learning the more verbose form of a command can promote better understanding | 22:57 |
| waynr | git rebase is one of those, specifically the 'git rebase --onto ...' form | 22:57 |
| yland | waynr: good to know your own point of view | 23:02 |
| waynr | thanks for asking :) | 23:15 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update build_keeper to use convert_mapping_to_xml() https://review.openstack.org/479987 | 23:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!