| *** hashar has joined #openstack-jjb | 06:01 | |
| *** electrofelix has joined #openstack-jjb | 08:36 | |
| *** openstackgerrit has joined #openstack-jjb | 09:24 | |
| openstackgerrit | zhangyangyang proposed openstack-infra/jenkins-job-builder master: change assert(Not)Equals to assert(Not)Equal https://review.openstack.org/503575 | 09:24 |
|---|---|---|
| *** hashar is now known as hasharAway | 09:45 | |
| *** hasharAway has quit IRC | 13:49 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add support for {% include %} in Jinja2 templates https://review.openstack.org/493694 | 15:35 |
| Odd_Bloke | The macro expansion change appears to have broken the use of macros in the conditional-step builder: https://gist.github.com/OddBloke/5f903bf2c523e990469012789eb606bc | 16:12 |
| Odd_Bloke | A brief examination of the code suggests the change required is moderately involved, as the builder doesn't (I think) have a good way of getting to the MacroRegistry. | 16:18 |
| *** electrofelix has quit IRC | 17:41 | |
| waynr | Odd_Bloke: looking at that now | 17:43 |
| Odd_Bloke | waynr: Thanks! | 17:43 |
| waynr | i don't think that the macro registry is what's needed here | 17:43 |
| waynr | i vaguely recall looking into how to dispatch the macro registry during yaml parsing at different points in any given yaml block rather than just at the top level | 17:44 |
| waynr | i'll throw together a test case to reproduce the bug you've found and see if i can figure out what i was thinking a few months ago | 17:48 |
| waynr | oh i just remembered how to do it yay | 17:49 |
| Odd_Bloke | \o/ | 17:52 |
| openstackgerrit | Wayne Warren proposed openstack-infra/jenkins-job-builder master: Fix macro expansion in conditional step builder. https://review.openstack.org/503771 | 18:20 |
| waynr | not quite fixed yet | 18:21 |
| waynr | but there's the reproduction test case | 18:21 |
| waynr | working on a fix now | 18:22 |
| Odd_Bloke | LGTM as a reproducer. | 18:23 |
| *** hashar has joined #openstack-jjb | 18:57 | |
| *** hashar has quit IRC | 19:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!