| *** hashar has joined #openstack-jjb | 08:01 | |
| *** electrofelix has joined #openstack-jjb | 09:03 | |
| Odd_Bloke | Hey all, just wanted to drop a reminder of reviews that I currently have open. | 14:07 |
|---|---|---|
| Odd_Bloke | https://review.openstack.org/#/c/493694/ adds support for {% include %} in Jinja2 templates. | 14:07 |
| Odd_Bloke | https://review.openstack.org/#/c/492221/ changes list views to have some useful columns by default. | 14:07 |
| Odd_Bloke | https://review.openstack.org/#/c/498848/ improves the error message when a view is configured with an unsupported view type. | 14:08 |
| *** hashar has quit IRC | 14:08 | |
| *** hashar has joined #openstack-jjb | 14:08 | |
| Odd_Bloke | And https://review.openstack.org/#/c/489690/ updates tox to match the tests that are run in CI. | 14:08 |
| zxiiro | electrofelix: waynr: we meeting today? | 14:14 |
| zxiiro | Odd_Bloke: sorry for the slowness I've been travelling the past 2 weeks. I'll see if I can review them today. | 14:25 |
| zxiiro | electrofelix: I think we should get this patch into JJB 2.0 too https://review.openstack.org/326722 | 14:27 |
| zxiiro | electrofelix: it will help us with the plugin version stuff to allow overriding | 14:27 |
| Odd_Bloke | zxiiro: If my IRC<->RL name mapping is correct, I think you may have already reviewed them all. :) | 14:28 |
| zxiiro | Odd_Bloke: oh ok. I haven't checked my JJB queue in 2 weeks so didn't know if there were any new one | 14:28 |
| Odd_Bloke | Nope, these have all been sitting for a while. | 14:29 |
| zxiiro | electrofelix: I think the only other action item is the plugin config feature you've been working on. any updates there? | 14:29 |
| Odd_Bloke | It's not a problem, just thought I'd bring them up in case it prompted anyone to have a look. :) | 14:29 |
| zxiiro | Odd_Bloke: np, it's the best thing to do here. | 14:30 |
| zxiiro | Odd_Bloke: I'm trying to focus on getting JJB 2.0 released. My org really wants to switch over to it but we will not use 'master' | 14:30 |
| Odd_Bloke | We switched to master for Jinja2, but we've had to pin at the commit before the macro expansion refactoring. | 14:33 |
| Odd_Bloke | We'd definitely prefer to be on a release, of course. | 14:34 |
| electrofelix | zxiiro: there is, I got the code working but didn't upload the patch as I needed to adjust some tests | 14:56 |
| electrofelix | just overloaded with planning a conference | 14:57 |
| zxiiro | electrofelix: ok sounds good. I just got back from 2 conferences myself. | 14:57 |
| zxiiro | electrofelix: which one are you working on? | 14:57 |
| electrofelix | DevOpsDays Galway | 14:59 |
| zxiiro | ah sounds great. I plan on joining the online one that's coming up | 14:59 |
| waynr | zxiiro: ah, sorry...got a late start today | 15:19 |
| zxiiro | no worries I dont' think there's much to talk about today | 15:21 |
| *** hashar is now known as hasharAway | 15:31 | |
| *** openstackgerrit has joined #openstack-jjb | 15:32 | |
| openstackgerrit | Darragh Bailey proposed openstack-infra/jenkins-job-builder master: Switch param order from yaml conf to plugin specific https://review.openstack.org/506691 | 15:32 |
| electrofelix | finally, I get it up | 15:32 |
| zxiiro | great thanks | 15:33 |
| openstackgerrit | Darragh Bailey proposed openstack-infra/jenkins-job-builder master: Switch param order from yaml conf to plugin specific https://review.openstack.org/506691 | 15:34 |
| electrofelix | ah, spotted some small left overs from debugging | 15:34 |
| electrofelix | update patch ;-) | 15:35 |
| zxiiro | thanks for the quick fix | 15:35 |
| electrofelix | that removes the last piece that blocks namespacing the config objects, but of course namespacing the plugin one is not exactly the most straight forward.... | 15:59 |
| electrofelix | what I think might work best is to create a plugins defaultdict and populate it with any config options based on 'plugin "<name>"' falling back thing named '<name>' that's not in the already known sections with the assumption that in the future we'll remove that second piece? | 16:00 |
| *** electrofelix has quit IRC | 16:43 | |
| *** hasharAway is now known as hashar | 20:04 | |
| *** hashar has quit IRC | 21:33 | |
| *** larainema has quit IRC | 22:16 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!