| waynr | that sounds like it could be similar to the problem Odd_Bloke reported | 00:00 |
|---|---|---|
| zxiiro | i think it also breaks using macros inside of other macros too | 00:01 |
| waynr | hmm no tests for macros inside of macros? | 00:02 |
| zxiiro | I guess not. but I use it extensively in my project | 00:02 |
| zxiiro | let me see if i can come up with a minimal test or something | 00:02 |
| zxiiro | https://www.irccloud.com/pastebin/MKtJl60r/ | 00:07 |
| zxiiro | waynr: ^ ok confirmed it's actually when you use a macro inside of a publisher that calls the postbuildscript. And when you call a macro from a maven project's prebuild and postbuild steps | 00:08 |
| zxiiro | they may be all the same situation.... | 00:08 |
| zxiiro | I guess calling a macro from a different section or something. | 00:09 |
| zxiiro | waynr: I think we should revert? unless you know a solution? since this seems to break jjb in a pretty major way imo. | 00:10 |
| waynr | oh i do know a solution, let me find the patch i submitted | 00:57 |
| waynr | https://review.openstack.org/503771 | 00:58 |
| waynr | that fixes a very similar issue in the conditional-step plugin | 00:59 |
| waynr | fixing it for additional plugins will require updating this method: https://review.openstack.org/#/c/503771/2/jenkins_jobs/registry.py@165 | 01:01 |
| waynr | Odd_Bloke: had an alternative solution that is less complex but requires tangling the yaml parser up with the module registry again | 01:03 |
| waynr | http://paste.ubuntu.com/25540520/ <- Odd_Bloke's solution | 01:03 |
| zxiiro | ah ok I'll take a closer look at it in the morning | 01:23 |
| *** abelur has quit IRC | 04:29 | |
| *** abelur has joined #openstack-jjb | 04:30 | |
| *** hashar has joined #openstack-jjb | 06:33 | |
| *** hashar has quit IRC | 07:58 | |
| *** hashar has joined #openstack-jjb | 08:04 | |
| *** electrofelix has joined #openstack-jjb | 09:15 | |
| *** electrofelix has quit IRC | 09:46 | |
| *** hashar is now known as hasharAway | 09:50 | |
| *** electrofelix has joined #openstack-jjb | 15:39 | |
| *** electrofelix has quit IRC | 17:47 | |
| *** hasharAway is now known as hashar | 19:09 | |
| *** hashar has quit IRC | 22:00 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!