| *** hashar has joined #openstack-jjb | 07:09 | |
| *** electrofelix has joined #openstack-jjb | 07:18 | |
| *** hashar has quit IRC | 08:02 | |
| *** hashar has joined #openstack-jjb | 08:02 | |
| mnencia | electrofelix: I've did some tests with folders and I've discover an issue in python-jenkins: If a folder name contains a space it breaks any get_all_jobs call that includes it. | 13:41 |
|---|---|---|
| mnencia | beside that I've rebased the https://review.openstack.org/#/c/134307/12 on top of https://review.openstack.org/#/c/189697/ and everything seems to work correctly if i avoid using folders with spaces in the name. | 13:52 |
| electrofelix | mnencia: I guess I didn't think about it, if you can get a fix up, I'm help get it through | 13:52 |
| mnencia | the issue is that we need to urlencode the name before passing it to self.get_info | 13:53 |
| mnencia | moreover i noticed that python-jenkins get_version calls fails miserably because it doesn't use self.jenkins_open to create teh request object, so it fails to autenticate. | 13:56 |
| mnencia | but it's a different bug | 13:56 |
| mnencia | electrofelix the patch is trivial | 14:07 |
| mnencia | should i open a request in gerrit? | 14:07 |
| mnencia | https://pastebin.com/p1ZeSPgk | 14:08 |
| electrofelix | mnencia: do zaro and myself should be able to help get it through review | 14:22 |
| electrofelix | mnencia: so there was definitely a reason not to use jenkins_open when using get_version | 14:24 |
| mnencia | electrofelix i don't know. but with the current code it fails on my setup. If you want i can prepare a patch also for that | 14:25 |
| electrofelix | it certainly didn't require auth previously, but maybe something has changed, so would be good to elaborate | 14:25 |
| mnencia | electrofelix maybe it depens of the kind of the auth requirements | 14:26 |
| electrofelix | mnencia: that would make sense, is your jenkins behind something else doing the auth and you can't even see the main info page without a username/password or can you visit the home page without auth and then login to access more info? | 14:28 |
| mnencia | this is my test https://pastebin.com/pj0RzeBs | 14:30 |
| mnencia | and this is just after, adding the auth https://pastebin.com/NfgR0JMQ | 14:32 |
| mnencia | my conf is: enable security, Login with google, role-based authorization strategy | 14:33 |
| mnencia | nothing else | 14:34 |
| electrofelix | so if you are not authenticated and you attempt to go to the main jenkins page, what happens? do you get redirected to auth with google? | 14:35 |
| mnencia | yes | 14:35 |
| electrofelix | hmm, that's probably the source of this then. I presume you can't do a HEAD request without getting redirected either? | 14:36 |
| electrofelix | though, tbh, I'm not sure I'm seeing a good reason not to switch the 'get_version()' call to use jenkins_open() as well | 14:38 |
| mnencia | curl -I says 403 forbidden | 14:38 |
| mnencia | electrofelix it doesn't look important to me, but at least it should be documented. I used get_version() to check if my connection was working and it took a bit to me to understand that was a get_version() error instead | 14:41 |
| electrofelix | I think I see why, 'wait_for_normal_op()' was intended to work without trying to go through the auth code, but assuming it's possible to have that work as expected with auth on get_version() it would make things easier for users | 14:42 |
| mnencia | electrofelix i've found this https://review.openstack.org/#/c/504536/ | 14:46 |
| mnencia | someone already create the fix for the space-in-folder-name issue | 14:47 |
| mnencia | I've add my +1 to his patch. | 14:51 |
| mnencia | electrofelix What should I do with https://review.openstack.org/#/c/134307/12 ? I've the rebased code, but I don't know how to contribute it | 14:52 |
| electrofelix | mnencia: I would suggest rebasing it just against master, and then run 'git-review' and it should upload the amended patch | 14:57 |
| openstackgerrit | Marco Nenciarini proposed openstack-infra/jenkins-job-builder master: Basic folder support https://review.openstack.org/134307 | 15:01 |
| mnencia | electrofelix do you have idea on why zuul is complaining about the patch? It looks like a network error to me (at least for the pep8 part) | 16:21 |
| *** hashar has quit IRC | 16:35 | |
| electrofelix | mnencia: some suggestion in #openstack-infra that it's fallout due to high load | 16:48 |
| electrofelix | I'll trigger a recheck on it tomorrow assuming everything is hunky dory then | 16:50 |
| *** electrofelix has quit IRC | 17:56 | |
| *** hashar has joined #openstack-jjb | 19:27 | |
| openstackgerrit | Jacqueline Haefke proposed openstack-infra/jenkins-job-builder master: Add Support for a list of additional-credentials in the SVN-plugin https://review.openstack.org/494307 | 19:50 |
| *** hashar has quit IRC | 20:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!