| *** caphrim007 has quit IRC | 01:03 | |
| *** caphrim007 has joined #openstack-jjb | 01:04 | |
| *** caphrim007 has quit IRC | 01:09 | |
| *** caphrim007 has joined #openstack-jjb | 02:20 | |
| *** caphrim007 has quit IRC | 02:25 | |
| *** caphrim007 has joined #openstack-jjb | 06:01 | |
| *** caphrim007 has quit IRC | 06:05 | |
| *** hashar has joined #openstack-jjb | 08:21 | |
| *** caphrim007 has joined #openstack-jjb | 10:01 | |
| *** caphrim007 has quit IRC | 10:05 | |
| electrofelix | zxiiro: I think it is, but we've postponed doing any of it until after the 2.0 release | 10:59 |
|---|---|---|
| electrofelix | good grief, we started discussing that back in 2015?!!! | 10:59 |
| *** caphrim007 has joined #openstack-jjb | 13:01 | |
| *** caphrim007 has quit IRC | 13:06 | |
| zxiiro | morning! | 13:56 |
| zxiiro | electrofelix: Cool I think I'd like to see the defaults precedence fixed too. I think the current structure doesn't make any sense. | 13:57 |
| zxiiro | waynr: electrofelix: ssbarnea Odd_Bloke: I think the only thing to discuss for today's meeting is if we want to go ahead with the official jjb 2.0 release? | 13:58 |
| zxiiro | I've been using it and it seems fine for me | 13:58 |
| zxiiro | There's only 1 new patch merged since last week and it's the one to enable universal wheels | 13:59 |
| ssbarnea | zxiiro: +1 from me. we are already using the 2.x on production | 14:00 |
| electrofelix | zxiiro: https://review.openstack.org/528281? it's blocking https://review.openstack.org/528284 | 14:01 |
| zxiiro | electrofelix: I'm good with those. I guess we just need waynr to +2 them | 14:03 |
| zxiiro | or if someone else +1s it I'm willing to accept that has enough reviews. electrofelix what do you think? | 14:04 |
| zxiiro | ssbarnea: you got some time to take a look at the 2 patches? ^ they are pretty small. | 14:07 |
| ssbarnea | zxiiro: i am in MTG, just after | 14:08 |
| zxiiro | ok | 14:08 |
| *** hashar is now known as Camembert | 14:11 | |
| electrofelix | zxiiro: might be good to case an eye over the config object as we left that to tidy up after the API rework was complete | 14:14 |
| ssbarnea | zxiiro: what is the reason for deprecating stidin input? | 14:21 |
| ssbarnea | zxiiro: i am not currently using it, but I wanted to be able to use because I could make a job.xml file executable and use the shebang trick to make to run it | 14:21 |
| ssbarnea | electrofelix: ^^ | 14:22 |
| electrofelix | ssbarnea: are you referring to https://review.openstack.org/528284? | 14:22 |
| ssbarnea | electrofelix: yes. | 14:22 |
| zxiiro | ssbarnea: I believe it's not deprecating the input. it's preventing stdin input from sending a deprecation warning.which might confuse people | 14:22 |
| electrofelix | what zxiiro said ;-) | 14:23 |
| ssbarnea | ok. i hope in the future i will be able to start adding shebangs to the xml files. it would make easier to apply a single job. | 14:23 |
| ssbarnea | now I am prevented from doing this because we have some include paths needed to be added to the CLI. | 14:24 |
| electrofelix | ssbarnea: can you elaborate as to how this was working before? | 14:27 |
| ssbarnea | electrofelix: never got it working in my setup. no need to worry now. I already +1 both reviews. | 14:27 |
| ssbarnea | electrofelix: i don't have time to start working on jjb shebang stuff. it may even be working as designed. | 14:28 |
| ssbarnea | when I will have time, i will look and if I find a bug, I will raise a CR to fix it. | 14:29 |
| ssbarnea | i wonder what is the overall folder support status on jjb 2.x. any known limitations? | 14:29 |
| openstackgerrit | Darragh Bailey proposed openstack-infra/jenkins-job-builder master: Tidy up config object https://review.openstack.org/533194 | 14:29 |
| zxiiro | not sure what you mean but I've been able to add shebangs to all of my shell scripts with jjb | 14:30 |
| zxiiro | we use that feature extensively in our scripts | 14:30 |
| ssbarnea | zxiiro: yep, I did the same, but only on self contained job definitions. we use a LOT of templating around, storing the templates in multiple folders, jobs also stored in different folders, ... I was not able to make it work for all when I tried. Again, is likely because lack of time or knowledge, not jjb itself. | 14:31 |
| ssbarnea | nobody around here knows about the shebang trick, so nobody is missing the feature :D | 14:32 |
| openstackgerrit | Darragh Bailey proposed openstack-infra/jenkins-job-builder master: Tidy up config object https://review.openstack.org/533194 | 14:32 |
| zxiiro | hehe | 14:32 |
| zxiiro | I got burned a couple times when i thought shell should be bash but it's not always so I formed a habit of making sure everything has the shebang line | 14:32 |
| electrofelix | ah, yes, that's the old jenkins runs shell scripts via '/bin/sh' by default easter egg (or booby trap depending on your perspective) | 14:34 |
| electrofelix | zxiiro: I think the above patch cleans up most of the last remaining class members that might suggest people could set them directly on the config object and have an effect | 14:35 |
| electrofelix | the last remaining two are listed at https://git.openstack.org/cgit/openstack-infra/jenkins-job-builder/tree/jenkins_jobs/config.py?id=424ec8b3401ef4298e05c52e2e4d71877299212c#n258 but I'm not sure where to namespace them to? | 14:35 |
| zxiiro | electrofelix: can we hold that off? | 14:35 |
| zxiiro | electrofelix: I'm kind of worried about sneaking in more fixes since we already testeed what's in master | 14:36 |
| zxiiro | I think we can start doing more regular releases once we get 2.0 out the door so maybe we can get on a regular release schedule. | 14:36 |
| electrofelix | zxiiro: I think they are needed before we bump to the 2.0 api as otherwise we're kind of breaking the api as soon as we release to make changes that remove attributes | 14:37 |
| zxiiro | electrofelix: ok let's get that in then I'll run a quick test it to make sure it still works. | 14:37 |
| zxiiro | ssbarnea: this patch look ok to you? https://review.openstack.org/533194 | 14:43 |
| *** hashar has joined #openstack-jjb | 14:44 | |
| ssbarnea | zxiiro: done. | 14:52 |
| zxiiro | electrofelix: alright. I think we're ready to release? | 14:53 |
| zxiiro | waynr: thanks for reviewing too! | 14:53 |
| ssbarnea | zxiiro: electrofelix : how about https://review.openstack.org/#/c/451992/ ? | 14:53 |
| waynr | zxiiro: i'm +1 on 2.0 release | 14:53 |
| ssbarnea | now that you started me, maybe I can review some of the old ones. but there is no req to do them before the release, can be after. | 14:54 |
| zxiiro | ssbarnea: that seems pretty minor let's get that in after we release? | 14:54 |
| electrofelix | ssbarnea: is that not for a different project? | 14:54 |
| electrofelix | wrong link maybe? | 14:54 |
| ssbarnea | haha, right. | 14:54 |
| zxiiro | ah totally didn't see that it's not the jjb project ;) | 14:55 |
| zxiiro | I guess just waiting for zuul now :) | 14:55 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: No warn on old plugin conf format not in use https://review.openstack.org/528281 | 14:56 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Prevent deprecation warning using test with stdin https://review.openstack.org/528284 | 14:56 |
| electrofelix | zxiiro: going for an rc1? and then tag the same commit mid next week if no issues found? | 14:57 |
| zxiiro | electrofelix: I was just going to release. we had a beta last week (which maybe should have been rc1) | 14:57 |
| zxiiro | electrofelix: or do you think we really need to hold off for those 3 patches? | 14:58 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Added option to print job names as urls https://review.openstack.org/463706 | 14:58 |
| zxiiro | electrofelix: I say let's just get it out and release a 2.0.1 if we have to fix something. | 14:58 |
| electrofelix | cool | 14:58 |
| zxiiro | There's a lot of folks on my back about getting this out so it would help us significantly to finally get it out the door :) | 15:00 |
| waynr | ++ to using patch level for bug fixes after releasing 2.0 | 15:01 |
| *** hashar is now known as hasharELATER | 15:38 | |
| ssbarnea | electrofelix: I want to address your comment on https://review.openstack.org/#/c/463706/ -- but I don't know how. | 16:01 |
| ssbarnea | electrofelix: mainly I have a job name that can look like 'foo/bar' I need to translate it to an url. I could do it in dirty way using split and join. | 16:02 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Added option to print job names as urls https://review.openstack.org/463706 | 16:13 |
| ssbarnea | well, did it the ugly split/join way, looks like working well to me. | 16:15 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Simplified logging format to include only level and message https://review.openstack.org/463712 | 16:16 |
| electrofelix | ssbarnea: jobs named folder1/job1 sent to python-jenkins will be translated to a folder1/jobs/job1, and the current url would be <jenkins-url>/jobs/folder1/jobs/job1, but your code would result in <jenkins-url>/jobs/folder1/job1, which would be incorrect | 16:18 |
| ssbarnea | electrofelix: i made a fix already, check latest version. | 16:20 |
| ssbarnea | electrofelix: i tested with `foo/bar` and ended up with valid url. | 16:20 |
| ssbarnea | electrofelix: where valid url = $JENKINS_URL/job/foo/job/bar -- run on production, click the link on the console, opened the job. | 16:21 |
| zxiiro | huh pep8 failure on that tidy up patch | 16:36 |
| zxiiro | F841 local variable 'config' is assigned to but never used | 16:36 |
| zxiiro | electrofelix: safe to remove line 294 from the patch? | 16:37 |
| zxiiro | seems like it doesn't like us declaring that config variable and not using it. | 16:37 |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Tidy up config object https://review.openstack.org/533194 | 16:49 |
| *** caphrim007 has joined #openstack-jjb | 17:13 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Tidy up config object https://review.openstack.org/533194 | 17:22 |
| electrofelix | zxiiro: ah, I missed that with the second update to remove the temporary code | 17:23 |
| zxiiro | electrofelix: all good it's fixed and merged now | 17:23 |
| zxiiro | electrofelix: i'll spin a release now :) | 17:24 |
| zxiiro | electrofelix: ssbarnea Odd_Bloke waynr: 2.0.0 release tag pushed. We should see a release once the release jobs trigger. | 17:25 |
| zxiiro | Thanks everyone for hitting this milestone :) | 17:26 |
| ssbarnea | zxiiro++ | 17:26 |
| waynr | zxiiro++ | 17:38 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Simplified logging format to include only level and message https://review.openstack.org/463712 | 18:06 |
| ssbarnea | So now I decided to fix my old pending CRs, so they would fix the next release. | 18:07 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: fixed tests https://review.openstack.org/475059 | 18:11 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: bump python-jenkins version https://review.openstack.org/533258 | 18:19 |
| *** electrofelix has quit IRC | 19:07 | |
| *** hasharELATER is now known as hashar | 20:03 | |
| Odd_Bloke | zxiiro: \o/ \o/ \o/ | 20:30 |
| *** openstack has joined #openstack-jjb | 20:50 | |
| *** ChanServ sets mode: +o openstack | 20:50 | |
| *** hashar has quit IRC | 22:07 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Simplified logging format to include only level and message https://review.openstack.org/463712 | 22:27 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!