| *** hashar has joined #openstack-jjb | 08:13 | |
| *** electrofelix has joined #openstack-jjb | 11:06 | |
| ssbarnea | electrofelix: hi! here is a simple one https://review.openstack.org/#/c/533430/ | 13:14 |
|---|---|---|
| *** openstackgerrit has quit IRC | 13:18 | |
| electrofelix | just a few questions, think need an example to grok the difference to the test output the change makes | 13:38 |
| *** openstackgerrit has joined #openstack-jjb | 13:54 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Update artifactory_maven to make use of convert_mapping_to_xml() https://review.openstack.org/479525 | 13:54 |
| *** larainema has joined #openstack-jjb | 15:32 | |
| *** caphrim007_ has quit IRC | 15:33 | |
| *** caphrim007 has joined #openstack-jjb | 16:46 | |
| *** caphrim007_ has joined #openstack-jjb | 18:21 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Improve test resiliency https://review.openstack.org/533430 | 18:23 |
| *** caphrim007_ has quit IRC | 18:23 | |
| *** caphrim007_ has joined #openstack-jjb | 18:24 | |
| *** caphrim007 has quit IRC | 18:24 | |
| ssbarnea | hi! i just discovered something that looks like a serious problem due how the config files are generated. | 18:59 |
| ssbarnea | it seems that the fact that we do not put file extension to those files prevents us from using folders. | 18:59 |
| ssbarnea | i have a job that creates a folder `foo`. | 19:00 |
| ssbarnea | this means that i will not be able to build jobs that are inside the foo folder because jjb will be unable to create this folder, as a file already exists. | 19:04 |
| ssbarnea | we need to put file extensions to the output folder. | 19:04 |
| electrofelix | nuts | 19:12 |
| ssbarnea | electrofelix: in fact there is an option that may safe me, --config-xml testing it now | 19:13 |
| ssbarnea | but without it, is impossible to build folders | 19:13 |
| ssbarnea | because the folder itself would produce a file. | 19:14 |
| electrofelix | probably meant we should have ensured folders were written out to be '<folder>/_' by default or something similar | 19:14 |
| ssbarnea | electrofelix: i would do something else instead, I will just assure we add the .xml to generated files. | 19:14 |
| ssbarnea | also good to have fileformat extension included for editors. | 19:15 |
| ssbarnea | nothing else should be needed. | 19:15 |
| ssbarnea | electrofelix: in fact --config-xml did sort my problem. | 19:15 |
| electrofelix | We deliberately kept the existing behaviour and put the extension into the option, but should have made it the default before releasing v2, not sure if we should change that default now without noting it's a breaking behaviour | 19:16 |
| electrofelix | so be inclined to do something fudgy for folders and writing we need to change the default for v3? | 19:17 |
| electrofelix | will think about it over night | 19:17 |
| *** electrofelix has quit IRC | 19:17 | |
| ssbarnea | with the --config-xml workaround, we have no pressure. still, it would be better to have working defaults. | 19:22 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Improve test resiliency https://review.openstack.org/533430 | 20:27 |
| ssbarnea | that is one boring change that implements no feature, but hopefully addressed the unexpected test results on various machines. | 20:49 |
| *** caphrim007 has joined #openstack-jjb | 21:27 | |
| *** caphrim007_ has quit IRC | 21:31 | |
| *** caphrim007 has quit IRC | 22:11 | |
| *** caphrim007 has joined #openstack-jjb | 22:12 | |
| *** hashar has quit IRC | 22:18 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!