| *** caphrim007_ has joined #openstack-jjb | 00:13 | |
| *** caphrim007_ has quit IRC | 00:13 | |
| *** caphrim007 has quit IRC | 00:16 | |
| *** larainema has joined #openstack-jjb | 00:29 | |
| *** caphrim007 has joined #openstack-jjb | 02:04 | |
| *** caphrim007 has quit IRC | 02:08 | |
| *** caphrim007 has joined #openstack-jjb | 02:54 | |
| *** electrofelix has joined #openstack-jjb | 09:53 | |
| zxiiro | electrofelix: waynr: ssbarnea I'm thinking JJB 2.0.1 release today. any patches we want to get in? | 13:42 |
|---|---|---|
| ssbarnea | zxiiro: let me check. | 13:43 |
| zxiiro | We should get this docs fix in https://review.openstack.org/535111 if someone wants to review it. | 13:47 |
| ssbarnea | zxiiro: yes I do, i am rebasing it now. | 13:53 |
| ssbarnea | zxiiro: i hope you will make warns as errors for docs. | 13:55 |
| zxiiro | ssbarnea: I don't get it. Is that a patch? | 13:57 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Update artifactory_maven to make use of convert_mapping_to_xml() https://review.openstack.org/479525 | 13:57 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Added option to print job names as urls https://review.openstack.org/463706 | 14:02 |
| ssbarnea | zxiiro: never mind, I will make a patch to fix warnings on docs. check the one above with urls ^ | 14:03 |
| zxiiro | ssbarnea: looks good to me. I think it's just missing documentation | 14:06 |
| ssbarnea | adding it now | 14:06 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Added option to print job names as urls https://review.openstack.org/463706 | 14:14 |
| ssbarnea | zxiiro: added docs for ^^. quick question, do we have a strong reason for using sphinx < 1.5 ? | 14:16 |
| ssbarnea | i was considering improving the docs build process but I also need to upgrade sphinx. | 14:17 |
| zxiiro | ssbarnea: I don't have any reason for it. I know if you use something like rstcheck though it pins sphinx to < 1.5. I don't think we use that in jjb though | 14:21 |
| ssbarnea | zxiiro: ok, thanks for the hint. expect a new patch that deal with that. i am on it. | 14:21 |
| ssbarnea | zxiiro: i got good progress on the docs, is just that sphinx became more picky about syntax. lots of small reindentations. | 14:45 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Update sauce_ondemand to use convert_xml() https://review.openstack.org/479899 | 14:45 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Update _groovy_common_scriptSource to use convert_xml() https://review.openstack.org/479639 | 15:02 |
| ssbarnea | zxiiro: can we merge https://review.openstack.org/#/c/535111/ ? --- i don't want to re-fix it in my wip docs patch ;) | 15:14 |
| zxiiro | ssbarnea: done | 15:15 |
| zxiiro | we'll well need to wait for Zuul | 15:15 |
| ssbarnea | zxiiro: thanks, also https://review.openstack.org/#/c/463706/ is ready for +Workflow | 15:19 |
| zxiiro | ssbarnea: let's see if electrofelix has some time to look at it since he left comments before. | 15:20 |
| electrofelix | zxiiro: sorry, bit consumed today, just getting to it | 15:22 |
| zxiiro | no worries | 15:24 |
| zxiiro | electrofelix: I'll release a 2.0.1 release with whatever patches make it into JJB by end of day. | 15:24 |
| zxiiro | I figure we should probably do regular releases now. I'll try to do it on days we used to have the weekly meetings on. | 15:25 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Fix view definition documentation https://review.openstack.org/535111 | 15:34 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Added option to print job names as urls https://review.openstack.org/463706 | 15:43 |
| *** caphrim007 has quit IRC | 16:21 | |
| ssbarnea | zxiiro: often releases is a great idea, let me know which days/hours to add to my calendar. | 16:39 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: docs: sphinx upgrade and warnings as erros https://review.openstack.org/538301 | 16:39 |
| zxiiro | ssbarnea: we've been doing a bi-weekly meeting for the JJB 2.0 for awhile now. I don't think we need it anymore but I decided to keep that time on my schedule reserved so was thinking of using it for biweekly releases. (Today would have been a biweekly meeting day if we continued doing it). | 16:40 |
| zxiiro | ssbarnea: so next one in 2 weeks from now | 16:40 |
| ssbarnea | zxiiro: done, added to calendar. | 16:42 |
| ssbarnea | zxiiro: ^^ look at the docs CR above, should fix the docs warnigns and upgrade sphinx. | 16:43 |
| ssbarnea | zxiiro: electrofelix Have you used topy for spellchecking before? I think it would be a good addition. | 16:45 |
| zxiiro | ssbarnea: I have not. that a python linter we can install? | 16:46 |
| zxiiro | ssbarnea: I've tried spellcheckers in the past but often find that they trip over code segments | 16:46 |
| zxiiro | we use coala for our projects which has a lot of nice plugins | 16:46 |
| ssbarnea | zxiiro: yep, very easy to use. https://pypi.python.org/pypi/topy | 16:47 |
| ssbarnea | `git ls-files| xargs topy` | 16:47 |
| ssbarnea | i added it recently to one project after being recommended by a colleague. | 16:49 |
| zxiiro | I'd be fine with introducing it | 16:50 |
| zxiiro | I see it's MIT license too so compatible with the license. | 16:50 |
| zxiiro | ssbarnea: I think your patch is ok. I'm just not comfortable with pinning it to the absolute latest version since not every system might have updated to it. | 16:51 |
| ssbarnea | zxiiro: probably it would work with older, let me try lowering the version a little bit. | 16:51 |
| zxiiro | yeah 1.6.6 was released only 2 weeks ago. I know for a fact RTD servers do not yet have it. | 16:52 |
| ssbarnea | 1.6.x would be ok? | 16:53 |
| ssbarnea | or 1.5.x? | 16:53 |
| zxiiro | Yeah I think 1.6 is fine | 16:53 |
| zxiiro | if we do >=1.6.0 then it'll get the latest of that stream that's available to the mirror | 16:53 |
| ssbarnea | i tested with 1.5.0 and it also worked. | 16:53 |
| zxiiro | ssbarnea: if that's so let's keep it at 1.5.0 then | 16:54 |
| zxiiro | ssbarnea: I'd rather keep things on the safer side | 16:54 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: docs: sphinx upgrade and warnings as erros https://review.openstack.org/538301 | 16:54 |
| zxiiro | ssbarnea: there's at +2. just find another person to do the same :) | 16:55 |
| ssbarnea | one of the probs with jjb, lack of people | 16:55 |
| zxiiro | ssbarnea: I'd say you're on track to become a committer. I've been thinking of nominating you considering the work you've done for us. | 16:56 |
| zxiiro | https://review.openstack.org/#/q/owner:ssbarnea%2540redhat.com | 16:57 |
| ssbarnea | zxiiro: thanks, i may speed things in the future a little bit. | 16:57 |
| ssbarnea | this weekend I plan to raise the multibranch CR | 16:57 |
| zxiiro | electrofelix: waynr would you guys be open to nominating ssbarnea as a committer? https://review.openstack.org/#/q/owner:ssbarnea%2540redhat.com | 16:57 |
| zxiiro | we need all the help we can get | 16:57 |
| *** caphrim007 has joined #openstack-jjb | 17:32 | |
| *** caphrim007 has quit IRC | 17:35 | |
| *** caphrim007 has joined #openstack-jjb | 17:35 | |
| *** caphrim007_ has joined #openstack-jjb | 18:27 | |
| *** caphrim007_ has quit IRC | 18:28 | |
| *** caphrim00_ has joined #openstack-jjb | 18:28 | |
| *** electrofelix has quit IRC | 18:30 | |
| *** caphrim007 has quit IRC | 18:30 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Assure test execution is not affected by local jjb config https://review.openstack.org/475059 | 18:40 |
| *** caphrim00_ has quit IRC | 19:06 | |
| *** caphrim007 has joined #openstack-jjb | 19:06 | |
| zxiiro | Alright I'm gonna tag 2.0.1. Anything that didn't make it in let's try to get it in next week. | 19:34 |
| zxiiro | err | 19:34 |
| zxiiro | 2 weeks from now | 19:34 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: docs: sphinx upgrade and warnings as erros https://review.openstack.org/538301 | 23:47 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: docs: sphinx upgrade and warnings as erros https://review.openstack.org/538301 | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!