| *** abelur_ has joined #openstack-jjb | 00:28 | |
| *** abelur_ has quit IRC | 00:30 | |
| *** caphrim007_ has quit IRC | 01:03 | |
| *** caphrim007 has joined #openstack-jjb | 01:07 | |
| *** caphrim007_ has joined #openstack-jjb | 01:08 | |
| *** caphrim007 has quit IRC | 01:11 | |
| *** caphrim007_ has quit IRC | 01:12 | |
| *** caphrim007 has joined #openstack-jjb | 02:27 | |
| *** caphrim007 has quit IRC | 02:32 | |
| *** caphrim007 has joined #openstack-jjb | 03:26 | |
| *** caphrim007 has quit IRC | 05:31 | |
| *** zxiiro has quit IRC | 07:30 | |
| *** zxiiro has joined #openstack-jjb | 07:57 | |
| *** zxiiro has quit IRC | 08:11 | |
| *** hashar has joined #openstack-jjb | 08:12 | |
| *** zxiiro has joined #openstack-jjb | 08:33 | |
| ssbarnea | zaro_: waynr : hi! question regarding deprecation of different features: how to prevent JJB from adding them? | 10:35 |
|---|---|---|
| ssbarnea | my 2.89 jenkins complains about deprecated "keepDependencies" option in newly generated job. I can't just remove it from jjb as some users are using older jenkins versions. | 10:36 |
| ssbarnea | is there a way to change behaviour based on target version? | 10:36 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 11:16 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: tox: enable multiple py3x versions https://review.openstack.org/547377 | 11:19 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 11:27 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 13:46 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 14:48 |
| zxiiro | Got some fires to take care of at work today. Might not have time to do a release. if not I'll try to poke at it on the weekend. | 14:53 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 15:11 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 15:31 |
| ssbarnea | zxiiro: change is ready for review. sorry for so many changes to it. i declared implementation "experimental" until the next major release. | 16:16 |
| ssbarnea | this should allow us (me?) to improve it without risks of breaking current users. | 16:17 |
| zxiiro | ssbarnea: ok if you can get some +2s before I do a release it will be in the next release. Otherwise we my have to wait 2 weeks. | 16:18 |
| zxiiro | unfortunately I'm stuck on some high priority work items today so I won't have time to do code reviews. | 16:18 |
| ssbarnea | zxiiro: in am trying now because is kinda key for me. I have presentation on March 4th in Brno where I need it... and I prefer to have it merged before that. | 16:19 |
| Odd_Bloke | Is there a regular JJB status meeting? | 16:19 |
| zxiiro | ssbarnea: ok well I don't need to release JJB today so we can hold off the release until that patch get's merged if that's fine with you? | 16:20 |
| ssbarnea | in fact i am less worried about having it released now than having it reviewed and merged. | 16:20 |
| ssbarnea | zxiiro: yep, no problem with that | 16:20 |
| zxiiro | ssbarnea: then you have more time to get reviews in. I don't want to rush something in without it getting proper reviews first. | 16:20 |
| Odd_Bloke | (I know I've been around when one was happening, but I didn't know if they were scheduled or if they're ad hoc.) | 16:20 |
| zxiiro | ssbarnea: ok cool let's pin the next release to this patch then. | 16:20 |
| zxiiro | Odd_Bloke: We used to have when for JJB 2.0 release but now that it's out we don't have one. I've been using the bi-weekly meeting as an excuse to do regular releases though assuming there's patches merged. | 16:21 |
| zxiiro | Odd_Bloke: folks are usually around though so if you need something reviewed just ping | 16:21 |
| zxiiro | cool now I don't have to stress about getting a JJB release this weekend. | 16:22 |
| zxiiro | alright need to go back to focusing on some work items. | 16:23 |
| ssbarnea | no worries, I will try to review all open CRs, but I will not merge any without someone else having a look (+2 or 2x +1). | 16:25 |
| Odd_Bloke | zxiiro: Yeah, I'd like to get involved in JJB in a more structured way (potentially with a view to becoming a core developer), so I was thinking that at least showing up to regular meetings would be a good starting point for that. :p | 16:27 |
| ssbarnea | Odd_Bloke: Friday is usually the time we meet here and review, merge and eventually make a new release. Usually every other week, no exact time as far as I know. | 16:30 |
| Odd_Bloke | Understood. | 16:31 |
| Odd_Bloke | Thanks! | 16:31 |
| ssbarnea | Odd_Bloke: I got my +2 right only one week ago. The best way towards this is to perform reviews, even fixing ones that were not originally raised by you. | 16:31 |
| Odd_Bloke | Cool, I'll try to set aside some time to regularly do some reviews. | 16:33 |
| *** openstackgerrit has quit IRC | 16:33 | |
| ssbarnea | Odd_Bloke: Also, feel welcome to ping us here if you want more attention with specific reviews. | 16:35 |
| ssbarnea | somehow I found that not doing this will likely prolong the time needed for getting a change reviewed and merged. | 16:35 |
| *** openstackgerrit has joined #openstack-jjb | 16:36 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: re-raise the original Exception instead of raising a new one https://review.openstack.org/517979 | 16:36 |
| Odd_Bloke | Yeah, I have done that in the past when I've had MPs that are urgent for our purposes. | 16:36 |
| Odd_Bloke | Most of the J2 reviews I have open ATM are either bug fixes for cases we don't hit or nice-to-have features that we'll start utilising once they're available. | 16:37 |
| Odd_Bloke | Well, actually, that describes all two of them, as you've just workflow +1'd one of them. :p | 16:37 |
| Odd_Bloke | Thanks for that, BTW! | 16:37 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add !j2 directive to allow inline Jinja2 templates https://review.openstack.org/546838 | 16:37 |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add support for {% include %} in Jinja2 templates https://review.openstack.org/493694 | 16:40 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add support for plugin column views https://review.openstack.org/538848 | 16:43 |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Always deep format Jinja2 templates https://review.openstack.org/546835 | 16:43 |
| Odd_Bloke | ssbarnea: Incidentally, when you mention "even fixing ones that were not originally raised by you", what's the workflow for that? If I pull down the appropriate commit/branch locally and run `git review` will it/gerrit DTRT? | 16:46 |
| ssbarnea | Odd_Bloke: if you download any review (git review -d 123) you will be able to update it (git review) even if it was not raised by you. | 16:47 |
| Odd_Bloke | OK, cool, good to know. | 16:48 |
| ssbarnea | something very useful for fixing orphan CRs | 16:48 |
| ssbarnea | you will not be able to abandon them, but I can. that's a perk, I guess. | 16:48 |
| Odd_Bloke | :) | 16:48 |
| *** caphrim007 has joined #openstack-jjb | 16:53 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add tox to test-requirements.txt https://review.openstack.org/484905 | 16:54 |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add tox to test-requirements.txt https://review.openstack.org/484905 | 16:55 |
| Odd_Bloke | Yep, confirmed that WFM. :) | 16:55 |
| Odd_Bloke | One question, though: I did modify the patch (to bump the tox version to what's currently used in zuul) and commit message (to reflect that change) but `git blame` will still show waynr as the author of the line; should I add something to the commit message to indicate that he's not the sole author? | 16:56 |
| zxiiro | Odd_Bloke: you can use Co-Authored-By: field in the footer of your commit message. Documentation on that is here https://wiki.openstack.org/wiki/GitCommitMessages | 16:59 |
| zxiiro | Odd_Bloke: Author should always be the primary author (or if you changed the most lines of code). so git blame will always show that but at least co-authored-by will show to people who look at the messages t hat more than one person worked on it | 16:59 |
| *** hashar is now known as hasharAway | 17:03 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add support for {% include %} in Jinja2 templates https://review.openstack.org/493694 | 17:07 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add support for build duration Job Filter plugin https://review.openstack.org/544352 | 17:50 |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Add tox to test-requirements.txt https://review.openstack.org/484905 | 19:05 |
| Odd_Bloke | ssbarnea: ^ addresses your review comment | 19:06 |
| *** caphrim007_ has joined #openstack-jjb | 20:25 | |
| *** caphrim007_ has quit IRC | 20:26 | |
| *** caphrim007 has quit IRC | 20:29 | |
| *** caphrim007 has joined #openstack-jjb | 20:33 | |
| *** caphrim007 has quit IRC | 20:34 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add support for {% include %} in Jinja2 templates https://review.openstack.org/493694 | 21:25 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add views and jobs only options for update https://review.openstack.org/537680 | 21:25 |
| Odd_Bloke | \o/ | 21:26 |
| Odd_Bloke | ssbarnea: Thanks for your reviews today. :) | 21:26 |
| *** hasharAway has quit IRC | 21:54 | |
| *** caphrim007 has joined #openstack-jjb | 22:08 | |
| *** caphrim007 has quit IRC | 22:11 | |
| *** caphrim007 has joined #openstack-jjb | 22:11 | |
| *** caphrim007_ has joined #openstack-jjb | 22:17 | |
| *** caphrim007 has quit IRC | 22:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!