*** caphrim007_ has joined #openstack-jjb | 00:32 | |
*** caphrim007 has quit IRC | 00:33 | |
*** caphrim007_ has quit IRC | 00:37 | |
*** caphrim007 has joined #openstack-jjb | 00:38 | |
*** caphrim007 has quit IRC | 00:42 | |
*** caphrim007 has joined #openstack-jjb | 00:43 | |
*** caphrim007 has quit IRC | 00:48 | |
*** caphrim007 has joined #openstack-jjb | 00:49 | |
*** caphrim007 has quit IRC | 00:54 | |
*** caphrim007 has joined #openstack-jjb | 00:55 | |
*** caphrim007 has quit IRC | 00:59 | |
*** caphrim007 has joined #openstack-jjb | 03:11 | |
*** caphrim007 has quit IRC | 03:15 | |
*** caphrim007 has joined #openstack-jjb | 03:34 | |
*** caphrim007_ has joined #openstack-jjb | 04:21 | |
*** caphrim007 has quit IRC | 04:24 | |
*** caphrim007_ has quit IRC | 05:24 | |
*** hashar has joined #openstack-jjb | 06:13 | |
*** electrofelix has joined #openstack-jjb | 07:39 | |
*** Odd_Bloke has quit IRC | 10:15 | |
*** Odd_Bloke has joined #openstack-jjb | 10:17 | |
*** hashar is now known as hasharAway | 13:25 | |
*** caphrim007 has joined #openstack-jjb | 13:55 | |
*** caphrim007 has quit IRC | 13:55 | |
*** caphrim007 has joined #openstack-jjb | 14:11 | |
*** caphrim007_ has joined #openstack-jjb | 14:12 | |
*** caphrim007 has quit IRC | 14:16 | |
zxiiro | I'm back in the office starting today. I need to catch up on emails but we should probably discuss the python-jenkins situation at some point this week. | 15:32 |
---|---|---|
zxiiro | ssbarnea, electrofelix, waynr: I believe we're all python-jenkins committers now but if someone is not and would like to be please let me know and I can add you. | 15:33 |
ssbarnea | zxiiro: nice to see you back. | 15:50 |
ssbarnea | zxiiro: lets start with https://review.openstack.org/#/c/205637/ | 15:50 |
ssbarnea | is a big change but better to do it before the others, so we have enough time to test it before release. | 15:51 |
ssbarnea | i guess there is no need to sell/reason "requests" adoption to you :D | 15:51 |
zxiiro | I like requests | 15:52 |
zxiiro | and I see it's electrofelix's patch so he's probably on board too | 15:52 |
ssbarnea | i can add the +1 workflow myself, but better to get you review too. | 15:52 |
zxiiro | ssbarnea: cool I'll look at it after I get through my emails. Probably and easy merge at first glance. | 15:53 |
waynr | requests++ | 15:54 |
electrofelix | zxiiro ssbarnea: I'll almost get nostalgic when that patch lands, it's been with me for nearly 3 years... | 16:21 |
*** openstackgerrit has joined #openstack-jjb | 17:29 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Enable cross testing with python-jenkins https://review.openstack.org/550087 | 17:29 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Enable cross testing with python-jenkins https://review.openstack.org/550087 | 17:31 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Enable cross testing with python-jenkins https://review.openstack.org/550087 | 17:33 |
*** electrofelix has quit IRC | 17:47 | |
ssbarnea | zxiiro: https://review.openstack.org/#/c/556813/ -- already got a +2 | 17:53 |
zxiiro | ssbarnea: looks good. merged. | 17:57 |
zxiiro | or approved. I guess technically only Zuul can merge. | 17:57 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add 'existing-only' argument for update subcommand https://review.openstack.org/491621 | 18:05 |
ssbarnea | old testrepository gives me some headaches, considering switchign to stestr. see https://github.com/testing-cabal/testrepository/issues/33 | 18:06 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Allows params to be specified via environment variables https://review.openstack.org/556813 | 18:06 |
zxiiro | ssbarnea: sounds like a similar project. I guess it has more active community? | 18:07 |
ssbarnea | zxiiro: not really, in fact i just found this which should explain few things https://openstack.nimeyo.com/119685/openstack-dev-recent-changes-in-testr-and-migrating-stestr | 18:11 |
ssbarnea | so we have testrepository (tests), os-testr and stestr (fork of the first). | 18:11 |
ssbarnea | clearly we do not lack variants | 18:12 |
zxiiro | oh joy | 18:12 |
ssbarnea | mainly i don't like the idea ok forking, especially as I got some positive feedback on https://github.com/testing-cabal/testrepository/issues/35 | 18:14 |
ssbarnea | we need to ask why he forked it, also I find it curious/strange that the fork was not done using github, avoiding to display that is a fork. | 18:15 |
ssbarnea | one thing is sure, the project was not maintained. | 18:16 |
zxiiro | same here. and I feel like openstack folks tend to fork a lot. | 18:16 |
zxiiro | I usually try to work with upstream and if it's a dead project ask the maintainer to pass it on. | 18:17 |
*** hasharAway is now known as hashar | 19:07 | |
zxiiro | ssbarnea: approved that jenkins-python requests patch. | 20:19 |
zxiiro | ssbarnea: apparently it depends on another patch though | 20:19 |
zxiiro | https://review.openstack.org/#/c/474952/3 | 20:19 |
zxiiro | ssbarnea: I'll leave you to give hte final +2 and approval since you have hte power now. | 20:20 |
ssbarnea | zxiiro: going to test it first, and merge if is ok. | 20:20 |
ssbarnea | i was working on a patch to ditch testr in favour of sterst | 20:22 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Replace testr with stestr https://review.openstack.org/558917 | 20:22 |
ssbarnea | zxiiro: better to merge this first, for safety: https://review.openstack.org/#/c/550087/ | 20:24 |
ssbarnea | it will add a new gate which tests tips of both jjb and python-jenkins, exactly what we need now. | 20:24 |
zxiiro | ssbarnea: done | 20:25 |
ssbarnea | zxiiro: thanks. this should prevent us from adding some breaking changes to python-jenkins that break jjb. | 20:26 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Enable cross testing with python-jenkins https://review.openstack.org/550087 | 20:33 |
*** hashar has quit IRC | 20:48 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Replace testr with stestr https://review.openstack.org/558917 | 21:01 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Replace testr with stestr https://review.openstack.org/558917 | 21:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!