| *** Lashuk has quit IRC | 04:20 | |
| *** ssbarnea has quit IRC | 04:29 | |
| *** ssbarnea has joined #openstack-jjb | 04:32 | |
| *** ssbarnea_ has joined #openstack-jjb | 07:29 | |
| *** ssbarnea_ has quit IRC | 07:31 | |
| *** ssbarnea_ has joined #openstack-jjb | 07:45 | |
| *** electrofelix has joined #openstack-jjb | 07:57 | |
| *** Lashuk has joined #openstack-jjb | 09:37 | |
| *** Lashuk has quit IRC | 13:41 | |
| *** ssbarnea_ has quit IRC | 13:59 | |
| *** fellow has joined #openstack-jjb | 14:09 | |
| fellow | quit | 14:09 |
|---|---|---|
| *** fellow has quit IRC | 14:09 | |
| *** lashuk has joined #openstack-jjb | 14:21 | |
| lashuk | While installing jenkins-job-builder, I found that code submission must be be pep8 and pyflakes clean. So, when I did "pip list", the pep8 version used for jjb is 1.5.7 but the current version is 1.7.1. And hacking 0.12.0 requires pep8 1.5.7. | 15:17 |
| lashuk | The question I want to ask: Is there anyway we can use pep8 1.7.1 in jjb without changing hacking 0.12.0 | 15:18 |
| Odd_Bloke | lashuk: Any reason to not upgrade hacking? | 15:21 |
| lashuk | Odd_Bloke: Sir, we can also do so. I was thinking of upgrading both the packages. | 15:23 |
| Odd_Bloke | I don't see why not, unless there would be a lot of pain making the code base compliant with the more recent versions. | 15:24 |
| lashuk | The current version which we have for hacking == 1.0.0 and pep8 == 1.7.1. So, we can actually upgrade both the packages. | 15:24 |
| lashuk | Well, I'm new to Jenkins & Jenkins-Job-Builder and would like to have in-depth knowledge about it so that I can contribute to the organization. | 15:26 |
| Odd_Bloke | That's good to hear, I think the community would be glad to have another interested contributor. :) | 15:27 |
| lashuk | Right now, I'm going through the documentation given on "https://docs.openstack.org/infra/jenkins-job-builder/". | 15:27 |
| lashuk | Odd_Bloke: Thank You for the encouragement. | 15:28 |
| lashuk | May I know how can we upgrade both pep8 and hacking packages in Jenkins-Job-Builder, because the "test-requirements.txt" clearly states that "hacking<0.13,>=0.12.0", so changing it might cause problem on other packages as well. | 15:38 |
| *** ssbarnea_ has joined #openstack-jjb | 15:43 | |
| lashuk | With this issue, I wanted to ask, May I work on the "test-requirements.txt" file to update it? | 16:06 |
| zxiiro | lashuk: no need to ask for permission. Just submit a patch and people will comment. | 16:12 |
| zxiiro | lashuk: I would edit the file they way you think it should be done, and then reviewers will comment on your patch when they see it. | 16:13 |
| lashuk | zxiiro: Thank You for lettimg me know. I would work on it. And submit the patch. Thank all. | 16:17 |
| lashuk | I wanted to ask as the "test-requirements.txt" file only consists of 11 packages but as they are inter-dependent on each other. So, should I include all the packages with the latest version which are compatible with each other or should I just include only those 11 packages for upgrading? | 17:02 |
| *** ssbarnea_ has quit IRC | 17:14 | |
| *** hashar has joined #openstack-jjb | 19:04 | |
| *** ssbarnea_ has joined #openstack-jjb | 19:29 | |
| *** ssbarnea_ has quit IRC | 19:54 | |
| *** ssbarnea_ has joined #openstack-jjb | 19:55 | |
| lashuk | whois lashuk | 20:47 |
| *** lashuk has quit IRC | 20:48 | |
| ssbarnea | lashuk: do not try to upgrade all packages to latest, in fact this latest should be avoided unless there are special cases. | 21:09 |
| ssbarnea | but bumping hacking is a good idea, hacking is a meta-package, safe to bump as long gates are still passing. | 21:10 |
| *** hashar has quit IRC | 22:08 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!