| *** kien-ha has joined #openstack-jjb | 00:14 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Fixes delete-all command when no option is provided https://review.openstack.org/505642 | 00:24 |
|---|---|---|
| *** kien-ha has quit IRC | 03:35 | |
| *** zxiiro has quit IRC | 03:44 | |
| *** hashar has joined #openstack-jjb | 06:30 | |
| *** zxiiro has joined #openstack-jjb | 07:47 | |
| *** ssbarnea_ has joined #openstack-jjb | 07:56 | |
| *** electrofelix has joined #openstack-jjb | 08:37 | |
| openstackgerrit | Jan Hruban proposed openstack/python-jenkins master: Disable requests_kerberos in tests https://review.openstack.org/571658 | 08:52 |
| openstackgerrit | Darragh Bailey proposed openstack/python-jenkins master: Ensure timeout exceptions are re-raised during auth attempts https://review.openstack.org/571678 | 09:49 |
| *** ssbarnea_ has quit IRC | 10:25 | |
| openstackgerrit | Darragh Bailey proposed openstack/python-jenkins master: Selectively mock requests_kerberos import https://review.openstack.org/571739 | 14:11 |
| zxiiro | electrofelix: ssbarnea anything we need to get merged before I cut a release today? | 14:45 |
| electrofelix | not that I can think of, the above two patches just help around the tests in python-jenkins | 14:47 |
| *** ckonstanski has joined #openstack-jjb | 15:11 | |
| ssbarnea | the pypy broken gates annoys me a little. i wonder if we can fix it. | 15:15 |
| zxiiro | ssbarnea: can you push that tag you tried to push a week ago? | 15:19 |
| zxiiro | ssbarnea: i'll make my tag for today a number after that one | 15:19 |
| ssbarnea | yeah, let me try. | 15:19 |
| ssbarnea | i tried to push python-jenkins, didn't work. | 15:21 |
| zxiiro | ssbarnea: does jjb work? | 15:22 |
| zxiiro | ssbarnea: I think you've pushed python-jenkins before no? | 15:22 |
| ssbarnea | nope | 15:22 |
| zxiiro | ssbarnea: https://github.com/openstack/python-jenkins/releases/tag/1.0.0 | 15:23 |
| zxiiro | you tagged it last time | 15:23 |
| zxiiro | ssbarnea: as far as I can tell you have all of the permissions you need to push.... what's the error you're getting? | 15:24 |
| ssbarnea | hmm, maybe something changed locally. | 15:24 |
| ssbarnea | https://gist.github.com/ssbarnea/2060624d84028be1570b3869f649a207 | 15:25 |
| ssbarnea | sadly gerrit had the bad habbit of not explaining the reason | 15:27 |
| ssbarnea | found. needs to be signed. i need to find option to make it the default | 15:29 |
| ssbarnea | yep, this was the issue on both. | 15:32 |
| ssbarnea | i just pushed tags on both. | 15:32 |
| zxiiro | ssbarnea: great! | 15:42 |
| zxiiro | ssbarnea: ah looks like you retagged against today. that's fine I guess I don't have to do it now :) | 15:43 |
| zxiiro | ssbarnea: can you sound out the release email? | 15:43 |
| zxiiro | send* | 15:43 |
| ssbarnea | do I have to? | 15:44 |
| zxiiro | ssbarnea: I can do it too... | 15:44 |
| zxiiro | ssbarnea: it's usually good practice to announce releases I think | 15:44 |
| ssbarnea | i will read and and learn how to structure it for the next one. | 15:45 |
| ssbarnea | https://stackoverflow.com/questions/50646927/how-to-i-configure-git-to-always-sign-tags -- maybe someone find a solution for this. | 15:45 |
| ssbarnea | i find really annoying to remember the "-s", part. | 15:45 |
| zxiiro | ssbarnea: yeah add it to your .gitconfig | 15:45 |
| ssbarnea | i tried, no effect | 15:45 |
| zxiiro | [commit] | 15:45 |
| zxiiro | gpgsign = true | 15:45 |
| zxiiro | ssbarnea: ah just realized you did push 2.0.8 too I'll make release notes for both | 15:51 |
| ssbarnea | this is for commits, does not not affect tags, but i am trying now using [tag] one. | 15:52 |
| ssbarnea | i found something interesting, that sign also requires a message to be present to work. | 15:54 |
| zxiiro | ah yeah I dunno if there's a config option for sign, let me know if you find it htough | 15:54 |
| zxiiro | I usually use "git tag -asm message v1.0.0" | 15:54 |
| ssbarnea | https://github.com/zestsoftware/zest.releaser/issues/152#issuecomment-324394861 | 15:55 |
| ssbarnea | if this is true, it means git can be configured only to auto-sign commits, not tags. | 15:55 |
| ssbarnea | and based on wha Linus said at some point, signing commits is pretty useless. | 15:56 |
| zxiiro | it's useless because there's no real use for it. If you a sign a tag you're effectively signing everything within that tag already so it's kinda redundant | 15:58 |
| zxiiro | at least with a tag you might verify you're downloading something someone tagged. but with commits, not one ever checks it anyway | 15:58 |
| ssbarnea | exactly | 16:01 |
| *** caphrim007 has joined #openstack-jjb | 16:01 | |
| zxiiro | ssbarnea: alright release emails sent. Basically all I do is call `git log --no-merges --pretty=format:"%h%x09%an%x09%s" 1.0.0..1.0.1` and then send the output of that in an email. | 16:02 |
| zxiiro | any more than that and it's too much work | 16:02 |
| zxiiro | lol | 16:02 |
| ssbarnea | hmm... this calls for a release script that automates this, only thing missing is where to get the email from. | 16:03 |
| ssbarnea | the nice part is that I could include this information in the tag message itself. | 16:03 |
| zxiiro | we could probably add it to the release job somehow | 16:04 |
| zxiiro | then it will do the email sending for us and all we have to do is tag | 16:04 |
| ssbarnea | i could find useful to just do "git release 1.2.3" which would do that. | 16:04 |
| *** ckonstanski has quit IRC | 16:21 | |
| *** ckonstanski has joined #openstack-jjb | 16:23 | |
| *** kien-ha has joined #openstack-jjb | 16:23 | |
| *** electrofelix has quit IRC | 16:55 | |
| *** electrofelix has joined #openstack-jjb | 16:55 | |
| *** electrofelix has quit IRC | 17:01 | |
| *** hashar is now known as hasharAway | 17:45 | |
| *** ckonstanski has quit IRC | 18:41 | |
| *** kien-ha has quit IRC | 18:43 | |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** caphrim007_ has joined #openstack-jjb | 19:08 | |
| *** caphrim007 has quit IRC | 19:10 | |
| *** hasharAway is now known as hashar | 20:18 | |
| *** openstackgerrit has joined #openstack-jjb | 20:29 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: [WIP] Implement a Jinja2 extension to include JJB templates https://review.openstack.org/568021 | 20:29 |
| *** hashar is now known as hasharZzz | 21:09 | |
| *** caphrim007 has joined #openstack-jjb | 21:55 | |
| *** caphrim007_ has quit IRC | 21:59 | |
| *** caphrim007 has quit IRC | 23:16 | |
| *** caphrim007 has joined #openstack-jjb | 23:16 | |
| *** hasharZzz has quit IRC | 23:27 | |
| *** caphrim007_ has joined #openstack-jjb | 23:45 | |
| *** caphrim007_ has quit IRC | 23:45 | |
| *** caphrim007_ has joined #openstack-jjb | 23:46 | |
| *** caphrim007_ has quit IRC | 23:47 | |
| *** caphrim007 has quit IRC | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!