| *** caphrim007 has joined #openstack-jjb | 01:20 | |
| *** caphrim007_ has joined #openstack-jjb | 01:27 | |
| *** caphrim007 has quit IRC | 01:30 | |
| *** abelur has quit IRC | 07:03 | |
| *** abelur has joined #openstack-jjb | 07:09 | |
| *** electrofelix has joined #openstack-jjb | 07:59 | |
| *** hashar has joined #openstack-jjb | 08:20 | |
| openstackgerrit | Tan Heng Yeow proposed openstack-infra/jenkins-job-builder master: Improve support for nodelabelparameter https://review.openstack.org/570659 | 14:06 |
|---|---|---|
| *** caphrim007_ is now known as caphrim007 | 16:28 | |
| *** raopajay has joined #openstack-jjb | 16:36 | |
| *** zaro__ is now known as zaro | 17:08 | |
| Odd_Bloke | ssbarnea: Regarding that refactoring, this isn't refactoring any of the way that the actual XML generation happens, it's just refactoring the paths by which the view or job specific gen_xml functions are called. | 17:17 |
| Odd_Bloke | So the fact that there is a lot of different code there makes little difference; they share the gen_xml interface. | 17:17 |
| ssbarnea | Odd_Bloke: I wonder if it addeses this https://review.openstack.org/#/c/553956/ | 17:18 |
| ssbarnea | i observed that we put a lot of garbage inside views xml due to the shared model, something that is not visible during testing but is clearly visible when you upload them to jenkins. | 17:19 |
| ssbarnea | in most cases jenkins drops the garbage, but in few cases it can endup with an exception. | 17:19 |
| Odd_Bloke | It does not, it's a strict refactoring retaining the current behaviour (modulo the error message change that's reflected in the tests). | 17:19 |
| ssbarnea | i even had one bug that was rendering folders impossible to use. | 17:19 |
| ssbarnea | ok, any deduplication is welcomed | 17:20 |
| Odd_Bloke | (And it doesn't close the door to disabling gen_xml for views, that subclass could just implement it as a noop.) | 17:20 |
| *** caphrim007 has quit IRC | 17:25 | |
| ssbarnea | Odd_Bloke: do a review on https://review.openstack.org/#/c/576878/ | 17:26 |
| *** caphrim007 has joined #openstack-jjb | 17:26 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Improve support for nodelabelparameter https://review.openstack.org/570659 | 17:30 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: multibranch-bitbucket: Configure server address https://review.openstack.org/576146 | 17:30 |
| zxiiro | ssbarnea: I'm not sure flake8 is running properly with your pre-commit patch. if i purposely break a pep8 rule and run `tox -e pep8` it passes | 17:34 |
| zxiiro | ssbarnea: and I suspect it's not reading any of the config out of that setup.cfg file | 17:34 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add groovy-script-file option to extended parameters https://review.openstack.org/477003 | 17:35 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Update hipchat example for new syntax https://review.openstack.org/571514 | 17:35 |
| ssbarnea | zxiiro: i am going to test today, give me half an hour. | 17:35 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add support for new option in config_file_provider_builder https://review.openstack.org/486444 | 17:35 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Refactor duplicated code in xml_config.py https://review.openstack.org/576950 | 17:36 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add support for AccuRev as SCM Provider https://review.openstack.org/575990 | 17:36 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: multibranch: Configurable script-path https://review.openstack.org/576128 | 17:36 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add publishers related to GitLab Plugin https://review.openstack.org/518618 | 17:40 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Update BuildResultTrigger plugin https://review.openstack.org/321619 | 17:40 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: add pipeline template using nested stage command https://review.openstack.org/569639 | 17:42 |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: [WIP] Allow generation of jobs/views to be suppressed https://review.openstack.org/577242 | 17:44 |
| Odd_Bloke | Would be interested to hear what people think of ^ before I spend more time on it. | 17:44 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 18:29 |
| ssbarnea | i also want to rename the pep8 job to lint but I am not sure how easy/hard it is. | 18:29 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 18:41 |
| ssbarnea | this is going to be fun as i am also trying to rename the pep8 to linters, as it will do more than that. | 18:42 |
| ssbarnea | i am not sure if https://review.openstack.org/#/c/577250/ will be enough | 18:43 |
| ssbarnea | zxiiro: you were right, flake8 was not using the file because it missed to remove the old section from tox.ini, now is removed and it will be loaded in all cases | 18:44 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 18:51 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 19:09 |
| openstackgerrit | Randy Coulman proposed openstack-infra/jenkins-job-builder master: Access priority sorter plugin info via short name https://review.openstack.org/577271 | 19:12 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 20:05 |
| *** hashar has quit IRC | 22:12 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Access priority sorter plugin info via short name https://review.openstack.org/577271 | 22:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!