| *** r-mibu has joined #openstack-jjb | 00:13 | |
| *** bkorren has joined #openstack-jjb | 05:07 | |
| *** hashar has joined #openstack-jjb | 07:13 | |
| *** hashar is now known as hasharAway | 07:13 | |
| *** bkorren has quit IRC | 08:14 | |
| *** bkorren has joined #openstack-jjb | 08:30 | |
| *** electrofelix has joined #openstack-jjb | 08:33 | |
| *** beiske has joined #openstack-jjb | 08:51 | |
| *** bkorren has quit IRC | 09:25 | |
| *** bkorren has joined #openstack-jjb | 09:35 | |
| *** bkorren has quit IRC | 10:03 | |
| *** bkorren has joined #openstack-jjb | 10:16 | |
| *** bkorren has quit IRC | 11:06 | |
| *** bkorren has joined #openstack-jjb | 11:06 | |
| *** r-mibu has quit IRC | 11:21 | |
| *** hasharAway is now known as hashar | 13:01 | |
| *** openstack has joined #openstack-jjb | 13:05 | |
| *** ChanServ sets mode: +o openstack | 13:05 | |
| *** tanhengyeow has joined #openstack-jjb | 14:09 | |
| *** bkorren has quit IRC | 14:56 | |
| openstackgerrit | Tan Heng Yeow proposed openstack-infra/jenkins-job-builder master: Refactor builders.py https://review.openstack.org/581776 | 15:18 |
|---|---|---|
| ssbarnea | electrofelix: zxiiro https://review.openstack.org/#/c/580228/ | 16:21 |
| zxiiro | ssbarnea: I'm not sure what you want me to do with that. I'm not a committer on that project. | 16:21 |
| ssbarnea | i know but you can review too, i guess ;) | 16:22 |
| zxiiro | ssbarnea: I did but I guess I can put an explicit +1 | 16:22 |
| zxiiro | ssbarnea: have you had any issues with pre-commit so far? | 16:23 |
| zxiiro | ssbarnea: I've had to back it out of some of my projects because it broke things. | 16:23 |
| zxiiro | well some of it is JJB's fault but yeah... | 16:23 |
| ssbarnea | zxiiro: a few, but not on default set of tests, only while trying to enable new projects. | 16:24 |
| ssbarnea | so far I didn't find problem in pre-commit itself. | 16:24 |
| ssbarnea | i am curios which kind of issue you found | 16:24 |
| zxiiro | I think it's mostly JJB's fault. several of my projects are jjb library projects and they are consumed by "git submodule add" into a jjb repo that wants to use the library. | 16:25 |
| zxiiro | Unfortunately JJB's include / exclude system sucks so I can't tell it to ignore the .pre-commit.yaml file from JJB parsing | 16:26 |
| zxiiro | so JJB tries to read it as a JJB config. | 16:26 |
| zxiiro | makes it difficult to deploy anything into this project that uses .yaml extension for config | 16:26 |
| openstackgerrit | Merged openstack/python-jenkins master: Fix run_script method. https://review.openstack.org/581332 | 16:34 |
| *** tanhengyeow has quit IRC | 17:02 | |
| electrofelix | zxiiro: does '--exclude .pre-commit.yaml' not work with JJB? | 17:27 |
| zxiiro | electrofelix: it does but then I have to tell 100 developers to update their cli calls everytime we want to make a change like this. | 17:28 |
| electrofelix | are you all using the same jenkins_jobs.ini file? | 17:29 |
| zxiiro | I need a solution that doesn't cause our devs to be impacted everytime either by editing a config file or passing a cli command. | 17:29 |
| zxiiro | electrofelix: yeah jenkins_jobs.ini is a solution but we have to keep our ini files in sync | 17:29 |
| zxiiro | I wonder if if maybe jjb should be default ignore .dirs | 17:30 |
| zxiiro | and / or files | 17:30 |
| electrofelix | zxiiro: sounds like allowing for in-tree configuration support? and probably yes, should default to ignoring files/dirs starting with '.', that's really a bug | 17:30 |
| zxiiro | electrofelix: oh yeah one of the issues I have with the include/exclude system in JJB is it's re-evaluated on every recursive iteration. | 17:31 |
| zxiiro | electrofelix: so if I say --include ".jjb-test" it will re-evaluate that when it walks through the the tree | 17:31 |
| zxiiro | using absolute paths might get around that but then I have to start assuming everyone who clones our repos clones it to the same path. | 17:32 |
| electrofelix | I think if you prefix with './' it should prevent that | 17:32 |
| zxiiro | hmm.. i haven't tried that... | 17:32 |
| electrofelix | '--include "./.jjb-test"' should only get evaluated at the top level | 17:33 |
| electrofelix | the rule is, if no path separator in the string, treat as a pattern, if it starts with the path separator treat as absolute, and otherwise assume relative path | 17:33 |
| zxiiro | ah ok, yeah maybe I'll try that next time and see if it works. | 17:34 |
| zxiiro | if that works it might allow me to add that .pre-commit back with minimal heartburn for my devs. | 17:34 |
| electrofelix | yay! | 17:34 |
| electrofelix | still, would be a good idea to exclude hidden files/dirs by default | 17:35 |
| *** electrofelix has quit IRC | 17:35 | |
| *** beiske has quit IRC | 17:44 | |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: detect and respect http redirects https://review.openstack.org/575817 | 19:01 |
| *** hashar has quit IRC | 21:04 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Refactor builders.py https://review.openstack.org/581776 | 21:40 |
| zxiiro | What's the syntax to tell requirements.txt to install a different version of a dependency in python 3 vs 2? | 22:07 |
| zxiiro | Or am I imagining this feature exists? | 22:08 |
| zxiiro | ah environment markers, that's what i'm looking for | 22:15 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!