| openstackgerrit | Dariusz Lisiak proposed openstack-infra/jenkins-job-builder master: Add support for filtering by name in git source https://review.openstack.org/582452 | 06:06 |
|---|---|---|
| *** electrofelix has joined #openstack-jjb | 07:37 | |
| *** SotK has joined #openstack-jjb | 09:21 | |
| ssbarnea | electrofelix: zxiiro hi! are you here today? | 09:54 |
| electrofelix | ssbarnea: I'm around, just been snowed under with work | 09:58 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: adopt pre-commit hooks https://review.openstack.org/576598 | 10:08 |
| *** abelur has quit IRC | 11:15 | |
| *** abelur has joined #openstack-jjb | 11:16 | |
| *** abelur has quit IRC | 11:16 | |
| *** abelur has joined #openstack-jjb | 11:17 | |
| *** yashagrawal3 has joined #openstack-jjb | 12:14 | |
| *** yashagrawal3 has quit IRC | 12:27 | |
| *** yashagrawal3 has joined #openstack-jjb | 13:24 | |
| *** yashagrawal3 has quit IRC | 13:51 | |
| *** tanhengyeow has joined #openstack-jjb | 14:12 | |
| tanhengyeow | Anyone able to approve this patch? :) https://review.openstack.org/#/c/580839/ | 14:12 |
| zxiiro | ssbarnea: electrofelix good morning, it's release day, any release items we want to get in for release? | 14:13 |
| zxiiro | ssbarnea: do you want to release python-jenkins today? | 14:13 |
| zxiiro | I think I'm going to take a new position with releases. I will bump the middle number, and we'll reserve the last number in case we need hotfixes | 14:14 |
| ssbarnea | no personal need | 14:14 |
| zxiiro | ssbarnea: ok so I will release python-jenkins 1.1.0 today and jjb 2.1.0 today. | 14:14 |
| zxiiro | We keep adding new features to releases so bumping the last number isn't semver. | 14:15 |
| ssbarnea | ok, no problem with that approach. is a good idea for avoiding the need to create x.y.z.w for a hotfix. | 14:15 |
| openstackgerrit | Tan Heng Yeow proposed openstack-infra/jenkins-job-builder master: Refactor clone_workspace function in publishers.py to utilize convert_mapping_to_xml https://review.openstack.org/582269 | 14:17 |
| electrofelix | zxiiro: that sounds like a good idea, new features/plugins supported = middle number | 14:19 |
| zxiiro | tanhengyeow: fyi I don't know if your mentor shared this with you but I'd highly recommend following this best practice https://chris.beams.io/posts/git-commit/ | 14:34 |
| zxiiro | tanhengyeow: it's a little long but it's worth reading once in awhile. I go over it myself every few months to make sure I remember :) | 14:35 |
| tanhengyeow | zxiiro: Thanks for the resource :) I briefly looked through it. Was there a bad habit I'm adopting in the recent patches I am submitting that can be improved? | 14:39 |
| zxiiro | tanhengyeow: your summary lines are too long | 14:40 |
| zxiiro | tanhengyeow: basically tools like github and git shortlog will trim the summary line if it's over 50 characters long. | 14:40 |
| zxiiro | tanhengyeow: but in general I'd read the whole thing it's a really good resource. (I know folks don't like to read but... :) | 14:41 |
| zxiiro | tanhengyeow: in general though your commit messages have been pretty good. I'm not complaining, just want to make sure you're learning :) | 14:41 |
| tanhengyeow | zxiiro: Ah right, I always end up typing alot more than necessary >< I'll keep that in mind and read this resource every now and then to let it sink :p | 14:41 |
| tanhengyeow | zxiiro: Np! I'm always open to constructive feedback so that I can improve :) | 14:42 |
| zxiiro | tanhengyeow: I also run weekly office hours around this time for the community where they can join and ask me random questions on a Google Hangouts. You're welcome to jump in anytime if you have questions for me. | 14:47 |
| zxiiro | tanhengyeow: it's every Friday starting from 1 hr ago and runs for 5 hrs. give or take, I do it very casually so cannot guarentee I'll always be available in it :) | 14:47 |
| zxiiro | https://plus.google.com/hangouts/_/linuxfoundation.org/zxiiro | 14:47 |
| zxiiro | ssbarnea: can you give me admin access to the jjb google group? | 14:50 |
| zxiiro | ssbarnea: I think some of my emails are getting moderated | 14:51 |
| zxiiro | I don't see my last few release emails to the list available in archives hmm... | 14:51 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Refactor ivy function in triggers.py to utilize convert_mapping_to_xml https://review.openstack.org/580839 | 14:51 |
| zxiiro | oh wait i do see them, they are just threaded for some reason | 14:52 |
| zxiiro | huh | 14:52 |
| zxiiro | alright nevermind :) | 14:52 |
| zxiiro | tanhengyeow: this is the reason commit message summary's are so important. We use them for releases so if you have a bad summary line, you can't tell what is being added to a release from reading the summary line https://groups.google.com/d/msg/jenkins-job-builder/bomkpJBLHBM/P33W0JNPBwAJ | 14:53 |
| tanhengyeow | zxiiro: I see, thanks for the heads up :) | 14:55 |
| tanhengyeow | zxiiro: I don't think I have any burning questions to ask or clarify but is the weekly hangouts link available somewhere if I need to access it someday? | 14:56 |
| zxiiro | tanhengyeow: I can add you to the calendar invite if you'd like | 14:56 |
| openstackgerrit | Tan Heng Yeow proposed openstack-infra/jenkins-job-builder master: Refactor clone_workspace function to use convert_mapping_to_xml https://review.openstack.org/582269 | 14:56 |
| zxiiro | tanhengyeow: otherwise just know that you can jump on, on Fridays | 14:56 |
| tanhengyeow | Alright, I'll probably look out for it on Fridays, unless it becomes a frequent thing then I'll hope to get the calendar invite :) | 14:58 |
| zxiiro | no worries, it's purely community service I'm doing here. hah | 14:59 |
| tanhengyeow | Appreciate that :)) | 14:59 |
| zxiiro | electrofelix: ssbarnea there seems to be someone squatting the jenkins-python name in pypi https://github.com/armata/jenkins-python | 15:40 |
| zxiiro | the code doesn't even have anythign to do with jenkins as far as i can tell | 15:40 |
| zxiiro | oh the stackoverflow link seems to say it's a jenkins hash imlpementation in python | 15:41 |
| zxiiro | I wonder if we should contact them to rename their project more appropriately. | 15:41 |
| ssbarnea | i think this was done on purpose | 15:44 |
| ssbarnea | have a look at https://github.com/lgastako/jenkins/issues | 15:45 |
| ssbarnea | this is about "jenkins" package on pypi, i asked to get it but didn't get an answer. | 15:46 |
| ssbarnea | feel free to comment on it, he is clearly active on github but not on that ticket. | 15:47 |
| ssbarnea | i could try to ask pypi to takeover the project without him but I am not sure is the best approach. | 15:48 |
| ssbarnea | i had success in the past doing this with "jira" package and now the project has a nice and simple package name. | 15:48 |
| ssbarnea | thus is why i made myself a rule to always assure that module name = package name and to get hold of it as soon as possible, to avoid more or less "accidents". | 15:49 |
| zxiiro | oh wow another one | 15:58 |
| zxiiro | ok yeah this is confusing to users | 15:58 |
| ssbarnea | zxiiro: i am going to raise a takeover request for both now, just to avoid accidents. I will ask to have them assigned to openstack foundation account not personal, right? | 16:00 |
| zxiiro | ssbarnea: I don't think openstack foundation will care about it. Just ask for personal and you can add me to it too. | 16:00 |
| ssbarnea | your github account is the same as username here right? | 16:01 |
| zxiiro | ssbarnea: yes | 16:04 |
| ssbarnea | zxiiro: https://github.com/pypa/warehouse/issues/4294 | 16:16 |
| ssbarnea | we may need some support on this. | 16:16 |
| zxiiro | ssbarnea: thanks | 16:17 |
| zxiiro | I subscribed I'll leave a comment later. busy on some work stuff right now. | 16:18 |
| ssbarnea | i liked issues on trackers of both culprit packages. | 16:21 |
| ssbarnea | i read a bit more that was not made on purpose, there is a real "jenkins hash" thing. | 16:21 |
| *** yashagrawal3 has joined #openstack-jjb | 16:28 | |
| *** electrofelix has quit IRC | 16:57 | |
| *** tanhengyeow has quit IRC | 18:12 | |
| *** yashagrawal3_ has joined #openstack-jjb | 19:13 | |
| *** yashagrawal3_ has quit IRC | 19:40 | |
| *** yashagrawal3 has quit IRC | 19:40 | |
| *** yashagrawal3_ has joined #openstack-jjb | 19:40 | |
| *** yashagrawal3 has joined #openstack-jjb | 19:40 | |
| *** yashagrawal3_ has quit IRC | 22:21 | |
| *** yashagrawal3 has quit IRC | 22:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!