| *** ktdreyer has quit IRC | 00:14 | |
| *** ktdreyer has joined #openstack-jjb | 00:15 | |
| *** larainema has quit IRC | 01:51 | |
| *** larainema has joined #openstack-jjb | 02:44 | |
| *** bkorren has joined #openstack-jjb | 05:35 | |
| *** hashar has joined #openstack-jjb | 07:00 | |
| *** ssbarnea1 has joined #openstack-jjb | 08:46 | |
| *** electrofelix has joined #openstack-jjb | 09:14 | |
| *** electrofelix has quit IRC | 09:59 | |
| *** electrofelix has joined #openstack-jjb | 10:11 | |
| *** rakkaus_ has joined #openstack-jjb | 10:19 | |
| *** electrofelix has quit IRC | 10:34 | |
| openstackgerrit | Olivier Bierlaire proposed openstack-infra/jenkins-job-builder master: Add support for Basic Branch Build Strategies Plugin https://review.openstack.org/580163 | 10:52 |
|---|---|---|
| *** electrofelix has joined #openstack-jjb | 11:23 | |
| *** tanhengyeow has joined #openstack-jjb | 12:38 | |
| *** electrofelix has quit IRC | 13:07 | |
| SotK | is it possible to change the triggers section of a job template based on a parameter from a project? | 13:19 |
| SotK | for example, if I have a project which creates three jobs from the same template, and I want one of them to trigger on a gerrit patchset-created-event and the other two on a change-merged-event | 13:21 |
| zxiiro | SotK: Yes, use {obj:variable_name} to define your trigger variable | 13:28 |
| zxiiro | SotK: here's an example: https://github.com/lfit/releng-global-jjb/blob/master/jjb/lf-maven-jobs.yaml#L974 | 13:29 |
| zxiiro | SotK: and this is how you can define a default for that variable in your template https://github.com/lfit/releng-global-jjb/blob/master/jjb/lf-maven-jobs.yaml#L912-L919 | 13:30 |
| zxiiro | SotK: in the job that's different, you will override that variable and list All of the triggers you want the special job to trigger on. the sections are not merged together, the project specific will will completely override the default. | 13:30 |
| zxiiro | SotK: which means you will have to "redeclare" any triggers in the project override if you want them to still trigger. | 13:31 |
| SotK | zxiiro: great, thanks | 13:34 |
| zxiiro | tanhengyeow: looking over your timeline, you only plan to work on 1-2 plugins per week? does this take into account the size and scope of plugins and that fact that you will get better at your job overtime thus needing less time to work on a plugin? | 13:41 |
| zxiiro | tanhengyeow: I think you are being paid to work 20 hrs per week right? | 13:41 |
| tanhengyeow | zxiiro: That's the rough timeline I've set prior to the internship, so I'll adjust it accordingly as I progress :) | 14:03 |
| *** rakkaus_ has quit IRC | 14:04 | |
| *** openstackgerrit has quit IRC | 14:04 | |
| *** rakkaus_ has joined #openstack-jjb | 14:04 | |
| zxiiro | tanhengyeow: It's up to you, I'm not your mentor so don't have much say in what you should or shouldn't do. But there's 2 routes you can take at this. 1. do the minimum amount of work and just pass the internship, or 2. work hard and try to become a maintainer on the project | 14:06 |
| zxiiro | tanhengyeow: personally as an employer, imo for career growth the ability to state that you are an active maintainer on any open source projects improves your resume quite a bit. :) | 14:07 |
| zxiiro | It's much easier for me to hire people who I can see their active work histories in Git and see that they are "active" on the projects they work on (shows passion), then it is to hire someone who just has a resume that says "I worked on x and y" :) | 14:08 |
| tanhengyeow | zxiiro: Working towards being a maintainer definitely sounds interesting to me :) Are there other advice you recommend on top of the timeline I've set? I believe you mentioned about review contributions and I've started following patches more often now :) | 14:10 |
| zxiiro | tanhengyeow: Use this link https://review.openstack.org/#/q/project:openstack-infra/jenkins-job-builder+status:open | 14:12 |
| zxiiro | tanhengyeow: and see if you can review, and / or help update older patches to get them into a mergeable state. | 14:12 |
| zxiiro | tanhengyeow: staying ontop of reviews is important and not just leavign "+1/-1" comments but actually applying things you've learned from your own code reviews. | 14:13 |
| zxiiro | tanhengyeow: a review that always just +1's and agrees with everyone else's comments is not as meaningful as reviews that have knowledge to share. | 14:14 |
| zxiiro | tanhengyeow: but obviously that comes with experience, you'll get better at spotting performance things, and tweaks that you can suggest to other contributors as you spend more time doing code review. | 14:14 |
| zxiiro | tanhengyeow: you're doing a good job with the weekly updates. Believe me it might feel like you are talking to yourself a lot of the time but I assure you people do appreciate and read them :) | 14:16 |
| tanhengyeow | zxiiro: Thanks for sharing how else I can better contribute to the project :) Appreciate it | 14:16 |
| zxiiro | tanhengyeow: I don't know if you keep track of your work hours, but you should, just in case your employer asks you for a work log. It's good practice too if you ever decide to go into contracting where you have to bill your employer for the hours you work. Internships are great times to learn these good life skills because you have lower responsibility. | 14:18 |
| tanhengyeow | zxiiro: As for updating older patches to get them into mergeable state, I believe i don't have the write access to update them, am I right? | 14:19 |
| zxiiro | tanhengyeow: you should be able to. I think anyone can update any other persons' patches? | 14:19 |
| zxiiro | most projects I work on allow that. | 14:19 |
| tanhengyeow | I see, shall look into that ;p | 14:20 |
| zxiiro | tanhengyeow: let me know if you can't, I can poke the openstack-infra guys to add it. I know at least for core reviewers we can. | 14:20 |
| tanhengyeow | Alright :) | 14:20 |
| zxiiro | tanhengyeow: I don't know how long it takes you to do the convert_mapping_to_xml changes but changes like this https://review.openstack.org/#/c/582797/1/jenkins_jobs/modules/notifications.py would take me about 1 minute to do. That's why I was trying to clarify how many hours you are expected to work. | 14:23 |
| zxiiro | tanhengyeow: if we gave you 5 minutes for that change, I'd expect 240 patches of that size and complexity for a 20 hr work week ;) | 14:24 |
| tanhengyeow | zxiiro: Ah yes, for 6 months is 20h per week but most of my time was spent identifying plugins that can be updated, so there arent concrete patches for those that I didn't manage to find anything to update for | 14:24 |
| zxiiro | tanhengyeow: yep, that's why I wanted to check your work log / schedule. Since you mentioned you plan to only do 1-2 plugins a week. If that's the size of work we should be expecting every week then I would think you don't have enough to do. | 14:26 |
| zxiiro | tanhengyeow: you should include things like research in your work log too | 14:27 |
| zxiiro | tanhengyeow: since they count as work items. | 14:27 |
| tanhengyeow | zxiiro: Ah right, the 1-2 plugins I meant were more of like concrete updates | 14:27 |
| tanhengyeow | zxiiro: I shall include research too in the next update | 14:27 |
| zxiiro | tanhengyeow: your week 2 update should have a statement that says "10 hrs of this week was spent identifying plugins that need updatnig" | 14:28 |
| zxiiro | tanhengyeow: basically if it takes you more than 5 minutes to work on, you should have a statement in your weekly log about it. otherwise folks won't know you spent time on it. | 14:28 |
| tanhengyeow | zxiiro: Gotcha :) | 14:29 |
| zxiiro | tanhengyeow: your google doc is a living document so update it as you go. You don't have to wait until next week to update it again. | 14:29 |
| zxiiro | tanhengyeow: like this week once you start working on your week 3 items, immediately start adding it to your work log. that way you wont' forget what you did. | 14:29 |
| tanhengyeow | alright ! :) | 14:30 |
| *** bkorren has quit IRC | 14:38 | |
| *** openstackgerrit has joined #openstack-jjb | 14:49 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Add support for few of Extra Columns plugin' extra columns for ListView generator https://review.openstack.org/579631 | 14:49 |
| *** rakkaus_ has quit IRC | 15:32 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Simplified logging format to include only level and message https://review.openstack.org/463712 | 15:33 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: remove support of old plugin config format https://review.openstack.org/582981 | 15:37 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Allow dashes in variable key names https://review.openstack.org/564243 | 16:43 |
| zxiiro | I'm curious now who these people who are just going around blindly applying python3 "fixes" to all openstack projects. | 16:55 |
| zxiiro | students? | 16:56 |
| zxiiro | they don't have much of a commit history in most cases | 16:56 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: detect and respect http redirects https://review.openstack.org/575817 | 16:56 |
| *** tanhengyeow has quit IRC | 16:57 | |
| *** hashar is now known as hasharAway | 17:04 | |
| *** khanchi97[m] has left #openstack-jjb | 17:50 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Allow dashes in variable key names https://review.openstack.org/564243 | 18:33 |
| *** hasharAway has quit IRC | 20:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!