| *** harlowja has quit IRC | 01:02 | |
| *** austinsun[m]1 has joined #openstack-jjb | 02:10 | |
| *** harlowja has joined #openstack-jjb | 04:32 | |
| *** harlowja has quit IRC | 06:24 | |
| *** hashar has joined #openstack-jjb | 07:09 | |
| *** ssbarnea|bkp has joined #openstack-jjb | 07:28 | |
| *** hashar is now known as hasharAway | 12:21 | |
| openstackgerrit | Thanh Ha (zxiiro) proposed openstack-infra/jenkins-job-builder master: Fix options.update is not 'all' if no config https://review.openstack.org/603803 | 13:48 |
|---|---|---|
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add config options --jobs-only and --views-only https://review.openstack.org/584583 | 14:29 |
| *** hasharAway is now known as hashar | 15:30 | |
| openstackgerrit | STEPHEN S BUSSETTI proposed openstack-infra/jenkins-job-builder master: same as existing bitbucket checkout-over-ssh, ssh-checkout for github must needs the option for a user to specify the id of the secret containing the ssh credentials to be used for checkout. https://review.openstack.org/603838 | 16:03 |
| *** bmwiedemann1 has quit IRC | 17:01 | |
| *** ssbarnea has joined #openstack-jjb | 17:17 | |
| ssbarnea | zxiiro: do you still consider -1 on https://review.openstack.org/587211 needed? | 17:18 |
| zxiiro | ssbarnea: yes we cannot merge that one until we have a solution for the problem it causes. I think https://review.openstack.org/587227 is a proposed solution but electrofelix & zuul have a -1 on it. | 17:47 |
| zxiiro | ssbarnea: I wonder if we should rebase the test patch in the middle and merge it though because I think that patch catches the issue. | 17:47 |
| ssbarnea|bkp | zxiiro yep, better to make it a single patch. | 17:48 |
| zxiiro | ssbarnea: yeah let me rebase this one https://review.openstack.org/587226 and we can try to merge it first | 17:48 |
| openstackgerrit | Thanh Ha (zxiiro) proposed openstack-infra/jenkins-job-builder master: Test dashes in variable key names https://review.openstack.org/587226 | 17:50 |
| Liskni_si | testing dashes without allowing them? | 17:50 |
| zxiiro | Liskni_si: will that patch fail? | 17:50 |
| Liskni_si | sure it will :-) | 17:51 |
| zxiiro | oh | 17:51 |
| zxiiro | I may have made a mistake here | 17:51 |
| zxiiro | ssbarnea|bkp: Liskni_si so we need a solution to merge all 3 patches at the same time. | 17:52 |
| zxiiro | but the last patch in the chain is currently not passing verify | 17:52 |
| zxiiro | maybe just needs a rebase? | 17:52 |
| ssbarnea|bkp | zxiiro just manually cherry pick it on the master one and abandon the other. | 17:52 |
| ssbarnea|bkp | that's is why i asked, i found these dependencies confusing and in the end, there is no need to make changes in different patches. they affect one repo and is about the same feature. | 17:53 |
| zxiiro | right yeah that makes sense. let me squash them up to the first patch | 17:54 |
| zxiiro | so we can discuss it as a single thing | 17:54 |
| Liskni_si | yeah, I think the proposed solution was to go through all of jjb and ensure everything's converted to string before being put into xml | 17:55 |
| Liskni_si | and, of course, documenting that '{x}' behaves as '{obj:x}' | 17:56 |
| openstackgerrit | Thanh Ha (zxiiro) proposed openstack-infra/jenkins-job-builder master: Allow dashes in variable key names https://review.openstack.org/587211 | 17:56 |
| zxiiro | Liskni_si: ssbarnea|bkp ok I've squashed the 3 commits and merged their commit messages (and added Liskni_si as a co-author). | 17:57 |
| zxiiro | I don't know if the commit message still makes sense so feel free to update. | 17:58 |
| zxiiro | but yeah my requirement for merging this patch is that "jenkins-jobs test" passes against the opendaylight releng/builder repo https://github.com/opendaylight/releng-builder | 17:59 |
| zxiiro | as long as it keeps failing there I will keep my -1 | 17:59 |
| Liskni_si | well I have no strong opinion, I think we should wait for electrofelix as he seemed to have one | 18:05 |
| Liskni_si | and I currently don't have time to do the str-xml code sweep | 18:06 |
| zxiiro | Ok I just ran `jenkins-jobs test` against the new squashed commit and it seems to work so I'll +1 the patch now and we'll wait for followup feedback from electrofelix | 18:06 |
| ssbarnea|bkp | zxiiro on that patch I will wait for the full "trinity" to vote ;) | 18:17 |
| zxiiro | hah | 18:18 |
| openstackgerrit | STEPHEN S BUSSETTI proposed openstack-infra/jenkins-job-builder master: same as existing bitbucket checkout-over-ssh ssh-checkout for github must needs the option for a user to specify the id of the secret containing the ssh credentials to be used for checkout. https://review.openstack.org/603838 | 21:02 |
| *** hashar has quit IRC | 21:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!