| *** larainema has joined #openstack-jjb | 02:37 | |
| openstackgerrit | Thanh Ha (zxiiro) proposed openstack-infra/jenkins-job-builder master: Evaluate default against is not None https://review.openstack.org/622869 | 07:49 |
|---|---|---|
| zxiiro | ssbarnea|rover: Liskni_si just found another specific case regarding that defaults behaviour ^ | 07:50 |
| zxiiro | I think the code change does what one would expect passing 0 to do. | 07:50 |
| zxiiro | if you guys agree I'll do a patch release of JJB because it's something my project needs. | 07:51 |
| Liskni_si | zxiiro: Yeah, that looks fine. Can we add a test for this? Oh and the previous change (sorry I didn't get to it during the weekend) should get a test, too, something like https://review.openstack.org/#/c/587211/2/tests/yamlparser/fixtures/variable_default_values.yaml (not the dashes, just the removal of quotes). | 08:51 |
| zxiiro | Liskni_si: good idea. Let me add a test for that. | 09:02 |
| openstackgerrit | Thanh Ha (zxiiro) proposed openstack-infra/jenkins-job-builder master: Evaluate default against is not None https://review.openstack.org/622869 | 09:22 |
| zxiiro | Liskni_si: patch is updated with 2 tests for the previous patch as well as this patch | 09:22 |
| ssbarnea|rover | zxiiro: i was thinking about a major change in jjb for the future: replacing it with an ansible module. mainly relying on ansible templating and making the jjb codebase much smaller and easier to user/test. how crazy does this sound? | 09:31 |
| zxiiro | ssbarnea|rover: We're using more and more ansible in our org so doesn't sound too crazy to me. | 09:33 |
| zxiiro | ssbarnea|rover: I've been starting to think that jobs should be a bunch of Ansible playbooks. In my view using ansible basically frees you up to using any CI system you want since Ansible in theory can run anywhere. | 09:35 |
| ssbarnea|rover | zxiiro: i do no have time to work on this right now but i wanted to check with all cores to see if this would be desired. if we get enough buy in, we could start looking for it | 09:35 |
| openstackgerrit | Tomas Janousek proposed openstack-infra/jenkins-job-builder master: Evaluate default against is not None https://review.openstack.org/622869 | 09:35 |
| Liskni_si | zxiiro: I simplified the test, it produces the same result and fails when either of those two fixes are reverted, so I guess it's okay | 09:36 |
| zxiiro | Liskni_si: cool was just about to ask. Thanks for checking! | 09:36 |
| Liskni_si | zxiiro: pls take a look at the comment on commit message and I'll be happy to add +whatever :-) | 09:36 |
| zxiiro | Liskni_si: I thought it only happened when you defined a macro but guess not :) | 09:36 |
| Liskni_si | re ansible: I think you're underestimating the value of Jenkins UI :-) | 09:38 |
| Liskni_si | we've been trying to move from using Jenkins plugins towards a bash-based DSL for jobs, which made testing job contents really easy, but the UX suffers a bit | 09:39 |
| *** larainema has quit IRC | 09:47 | |
| Liskni_si | and we still keep using the SCM plugin, as replacing that would break triggers and changelogs and e-mail notifications and ... | 09:47 |
| openstackgerrit | Thanh Ha (zxiiro) proposed openstack-infra/jenkins-job-builder master: Fix default '0' being ignored https://review.openstack.org/622869 | 10:00 |
| zxiiro | Liskni_si: sounds good to me, thanks! | 10:00 |
| Liskni_si | zxiiro: ok, so what do I do now? +1, +2, something else? | 10:43 |
| zxiiro | Liskni_si: +2 if you're good for it | 10:43 |
| zxiiro | Liskni_si: ideally ssbarnea|rover will also +2 it then we can merge it :) | 10:43 |
| Liskni_si | and he just did | 10:45 |
| Liskni_si | beat me to it :-) | 10:45 |
| zxiiro | thanks guys. I'll do a JJB patch release soon | 10:47 |
| Liskni_si | shall I workflow +1 or you can do that yourself? | 10:47 |
| zxiiro | Liskni_si: doesn't matter. I just did it | 10:47 |
| zxiiro | Liskni_si: usually the 2nd person to +2 CR will also +1 W | 10:48 |
| Liskni_si | ok | 10:48 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Fix default '0' being ignored https://review.openstack.org/622869 | 11:02 |
| openstackgerrit | Tan Heng Yeow proposed openstack-infra/jenkins-job-builder master: git: Utilize convert_mapping_to_xml https://review.openstack.org/600463 | 16:00 |
| *** harlowja has joined #openstack-jjb | 18:52 | |
| openstackgerrit | rohan proposed openstack/python-jenkins master: I am using python jenkins api for automation purpose. following is sample code snippet. server=jenkins.Jenkins('http://127.0.0.1', username='admin', password='admin') https://review.openstack.org/623053 | 19:31 |
| openstackgerrit | rohan proposed openstack/python-jenkins master: Closes-Bug: install_plugin api throwing array index out of bound exception https://review.openstack.org/623055 | 19:37 |
| *** larainema has joined #openstack-jjb | 23:15 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!