| openstackgerrit | Jeff Schroeder proposed jjb/python-jenkins master: Fix Jenkins.reconfig_credential() to send the xml https://review.opendev.org/675239 | 02:26 |
|---|---|---|
| *** SEJeff has joined #openstack-jjb | 02:36 | |
| SEJeff | I just found your nice little python library for automating jenkins and found it super useful | 02:37 |
| SEJeff | I also found a bug and went through the steps to setup a gerrit account and send you a patch + tests to fix it | 02:37 |
| SEJeff | I'm not super familiar with the openstack dev process, but am not sure who to assign this to as a reviewer: https://review.opendev.org/#/c/675239 | 02:37 |
| *** SEJeff has quit IRC | 02:39 | |
| *** SEJeff has joined #openstack-jjb | 02:41 | |
| zxiiro | SEJeff: you don't need to "assign" to anyone core-reviewers will get notified by email and review at their own leisure. | 03:07 |
| SEJeff | Ah thanks @zxiiro I appreciate it. | 03:21 |
| SEJeff | Sorry I didn't know | 03:21 |
| SEJeff | I confirmed the existing code is broken via tcpdump -i lo -A port 8080 on my jenkins server | 03:23 |
| SEJeff | The request before the change has a `Content-Length` of 0 and no data | 03:23 |
| SEJeff | So jenkins throws a bit traceback about unable to parse the xml. Look at all of the other reconfig_* methods, where they correctly do the same thing. This one was just omitted accidentally. | 03:23 |
| *** lennyb has quit IRC | 05:26 | |
| *** lennyb has joined #openstack-jjb | 06:27 | |
| openstackgerrit | Achim Leitner proposed jjb/jenkins-job-builder master: Fix encoding error in builder.py https://review.opendev.org/675268 | 08:18 |
| openstackgerrit | Achim Leitner proposed jjb/jenkins-job-builder master: Fix encoding error in builder.py https://review.opendev.org/675268 | 08:23 |
| *** electrofelix has joined #openstack-jjb | 09:12 | |
| openstackgerrit | Phil Roche proposed jjb/jenkins-job-builder master: Add support for rendering jinja template as yaml https://review.opendev.org/675285 | 10:20 |
| *** electrofelix has quit IRC | 13:57 | |
| openstackgerrit | Merged jjb/jenkins-job-builder master: Fix encoding error in builder.py https://review.opendev.org/675268 | 16:13 |
| zxiiro | So since Jenkins 2.89.4. Unset XML is now reset in Jenkins (old behaviour was to leave the setting as is). We built code in JJB to specifically handle that bug which is now fixed for quite some time. I'm wondering if we should maybe clean that up considering the bug is now fixed. | 20:21 |
| zxiiro | That would mean JJB would require a Jenkins that's 2.89.4 or newer though | 20:21 |
| zxiiro | sorry I should say version 2.107.1 is more correct | 20:22 |
| Odd_Bloke | zxiiro: Of the Jenkins instances in Canonical that I'm aware use JJB, I believe that would be fine for us. | 21:39 |
| *** SEJeff has quit IRC | 22:42 | |
| *** SEJeff has joined #openstack-jjb | 22:50 | |
| *** SEJeff has joined #openstack-jjb | 22:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!