| *** larainema has joined #openstack-jjb | 04:41 | |
| openstackgerrit | Thomas Bechtold proposed jjb/jenkins-job-builder master: Fix repository location in README.rst https://review.opendev.org/692955 | 08:29 |
|---|---|---|
| *** zbr|ooo is now known as zbr | 08:38 | |
| *** paride has joined #openstack-jjb | 12:03 | |
| paride | Hi. I think I found a bug in JJB, but I could be very well missing something obvious. When I try to `jenkins-jobs test` this yaml: http://paste.openstack.org/show/785802/ | 12:07 |
| paride | jjb fails to construct the job 'description', as it can't find the parameter {testvar} | 12:07 |
| paride | which is defined right above. Now the strange this is that if I delete the default description (i.e. comment out the "description" line under "defaults"), it works! | 12:08 |
| paride | and it works as expected. I tested this with JJB 2.0.3 and 3.0.2. | 12:09 |
| *** larainema has quit IRC | 12:32 | |
| *** hashar has joined #openstack-jjb | 12:58 | |
| *** hashar has quit IRC | 13:24 | |
| openstackgerrit | Merged jjb/jenkins-job-builder master: Fix repository location in README.rst https://review.opendev.org/692955 | 14:02 |
| zxiiro | paride: yeah looks like description doesn't parse default variables listed in job-template sections. I can reproduce it. | 14:38 |
| zxiiro | seems like a bug to me | 14:40 |
| paride | zxiiro, actually it can be reproduced with any variable | 14:40 |
| paride | it doesn't need to be 'description' | 14:40 |
| zxiiro | paride: ah ok, strange | 14:54 |
| zxiiro | What's the use case here? because you can't use the same variable in "defaults" and "job-templates" at the same time since job-templates version has higher priority so always wins. | 14:55 |
| paride | zxiiro, I discovered the issue by accident when trying to override the default 'description' in a job template. But I think more general use case could be: having some job templates using the default, and others overriding it | 14:57 |
| decimuscorvinus | A couple of months ago I created a couple of patches to address and point out some issues with jinja2 templates. I created a story for them here: https://storyboard.openstack.org/#!/story/2006431 | 19:33 |
| decimuscorvinus | Other than rebasing the first patch, is there anything I need to do to get it merged? | 19:34 |
| decimuscorvinus | The short of it is: jinja2 templates are not deep copyable so they cannot be declared as part of defaults in their current implementation. | 19:35 |
| decimuscorvinus | The concept for addressing it is just to wait until we actually apply the template the first time to create the jinja2 template: https://review.opendev.org/678089 | 19:36 |
| decimuscorvinus | The second issue has to deal with the fact that we can’t resolve a jinja2 template string to the name of a macro correctly. For that one I only have a failing test case and could use some help understanding how do do that. | 19:38 |
| decimuscorvinus | This patch contains the failing test I was referring to: https://review.opendev.org/678089 | 19:38 |
| zxiiro | decimuscorvinus: looks like the patch is stuck in "Cannot Merge" state, if you rebase it and get it to pass Zuul I can merge it. | 19:39 |
| decimuscorvinus | I’ll get the first one rebase it requires manual merging | 19:40 |
| zxiiro | decimuscorvinus: sorry that you're not getting much feedback. The sad fate of JJB today is there's no active maintainers on this project anymore. I just periodically +2 and merge patches. This one is difficult for me since I don't use Jinja2 so I won't be able to give any insight but if it works I'm happy to just merge it. | 19:40 |
| decimuscorvinus | Zx | 19:41 |
| decimuscorvinus | Whoops | 19:41 |
| zxiiro | JJB's effectively in maintenance mode at this point unless some folks interested in it steps up to help with reviews and managing the project. All I really have time for these days is to just +2 and merge any patches that come in. | 19:41 |
| decimuscorvinus | zxiiro: that makes sense, I wish we could move to Zuul but we are stuck with a Jenkins architecture at my place of business. | 19:42 |
| *** hashar has joined #openstack-jjb | 20:04 | |
| *** zbr is now known as zbr|ooo | 20:29 | |
| *** hashar has quit IRC | 21:06 | |
| *** zbr|ooo has quit IRC | 23:00 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!