| toabctl | vsevolod, the current JJB version doesn't deploy all available jobs anymore. 923718 should fix this. would be cool to get this merged & a 6.4.1 release on pypi ... | 13:44 |
|---|---|---|
| vsevolod | toabctl: Can you add a test to review, which can demonstrate problem? | 13:47 |
| vsevolod | And also add more details into commit message. Current one is not descriptive - one reading it won't understand what this commit fixes. | 13:49 |
| toabctl | well - commit 8bffa4d520edd1559d25c0fc7e2635f60e504d56 also has no description and I think that commit is the root cause . maybe we should just revert it? | 13:49 |
| vsevolod | It can be done. | 13:50 |
| toabctl | I'll try to prep a test case showing the failures... | 13:50 |
| vsevolod | So, should I wait for tests then? | 13:50 |
| toabctl | @ankushpathak, do you have cycles to create a test for this? or would you suggest to just revert 8bffa4d520edd1559d25c0fc7e2635f60e504d56 ? | 14:09 |
| ankushpathak | @toabctl @vsevolod I propose reverting 8bffa4d520edd1559d25c0fc7e2635f60e504d56 now to unblock. I can then work on tests without urgency and propose them if changes under commit 8bffa4d520edd1559d25c0fc7e2635f60e504d56 continue to be desirable. | 14:16 |
| opendevreview | Ankush Pathak proposed jjb/jenkins-job-builder master: Revert "allow disabled to remain the last setting" https://review.opendev.org/c/jjb/jenkins-job-builder/+/923856 | 14:22 |
| toabctl | vsevolod, does that work for you? ^^ | 14:24 |
| vsevolod | Yep, already approved. Waiting for zuul. | 14:30 |
| vsevolod | Should I stamp release 6.4.1 for this revert? | 14:30 |
| toabctl | yes, please | 14:30 |
| vsevolod | ok, np | 14:30 |
| toabctl | thanks a lot for the quick response vsevolod ! | 14:31 |
| vsevolod | :thumbup: ) | 14:31 |
| ankushpathak | Thanks vsevolod | 14:38 |
| opendevreview | Merged jjb/jenkins-job-builder master: Revert "allow disabled to remain the last setting" https://review.opendev.org/c/jjb/jenkins-job-builder/+/923856 | 14:50 |
| opendevreview | Vsevolod Fedorov proposed jjb/jenkins-job-builder master: Update changelog for release 6.4.1 https://review.opendev.org/c/jjb/jenkins-job-builder/+/923862 | 15:00 |
| opendevreview | Vsevolod Fedorov proposed jjb/jenkins-job-builder master: Update changelog for release 6.4.1 https://review.opendev.org/c/jjb/jenkins-job-builder/+/923862 | 15:01 |
| opendevreview | Merged jjb/jenkins-job-builder master: Update changelog for release 6.4.1 https://review.opendev.org/c/jjb/jenkins-job-builder/+/923862 | 15:31 |
| vsevolod | 6.4.1 was released | 16:03 |
| ankushpathak | 🎉 | 16:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!