Wednesday, 2016-11-09

« Tuesday, 2016-11-08 Index Thursday, 2016-11-10 »
*** yizhihui has joined #openstack-karbor00:45
*** zhangshuai has joined #openstack-karbor00:47
*** zhangshuai has quit IRC00:57
*** zengchen has quit IRC01:02
*** zengyingzhe has joined #openstack-karbor01:31
*** zhurong has joined #openstack-karbor01:31
*** zhangshuai has joined #openstack-karbor01:32
*** c00281451 has joined #openstack-karbor01:37
*** zhangshuai has quit IRC01:39
lichunyu_ping xiangxinyong01:39
chenyinghi lichunyu_01:45
lichunyu_hi , morning01:45
lichunyu_can you help check https://review.openstack.org/#/c/394743/ ,why this failed in python2701:46
lichunyu_it seems not a abclient problem to me01:46
*** leon_wang has quit IRC01:53
xiangxinyonglichunyu: sorry for late. I will check it.01:59
lichunyu_thanks02:00
lichunyu_:)\02:00
xiangxinyong:)02:01
xiangxinyonglichunyu_: it will take sometime to build local environment. please wait a monment.02:10
lichunyu_ok02:12
xiangxinyongthank your understanding02:13
openstackgerritzengchen proposed openstack/karbor: Add update interface for scheduled operation  https://review.openstack.org/34986902:14
xiangxinyonglichunyu_: please take a look at this link: https://etherpad.openstack.org/p/lichunyu02:31
lichunyu_ok02:32
xiangxinyongI guess this is the reason02:32
lichunyu_but why this failed in python2702:35
xiangxinyongyeah. it is a question02:36
xiangxinyongbut we could solve it one by one02:37
lichunyu_It failed in python34,because abclient in u-c haven't update to 0.2.302:37
xiangxinyongu-c?02:38
lichunyu_in ablcient 0.2.1, abclient use module 'urllib2'02:38
lichunyu_upper-constrain02:38
lichunyu_we remove it in 0.2.302:38
lichunyu_but urllib2 is availiable in python2702:39
lichunyu_so, it confused me that this patch fail in py2702:40
xiangxinyongok02:40
xiangxinyongdo you want to submit a new patch to update abclient to 0.2.3 in the openstack/requirements?02:41
lichunyu_yes,i should. abclient 0.2.1 is not python3 compatible02:43
lichunyu_but i think same problem may still exsit in py27 environment02:44
xiangxinyongok. you know even if gate-karbor-python27-ubuntu-xenial is passed, but py34 will be failed, and the jenkins will also get -102:45
xiangxinyongand I will continue to see why py27 is failed02:46
lichunyu_ok, thanks :)02:46
xiangxinyongyou are welcome02:47
lichunyu_i will submmit a new patch to openstac-requirments02:47
xiangxinyonggreat02:47
xiangxinyongin fact the requirement.txt in karbor is better to keep consistent with the openstack/requirements02:48
xiangxinyongI have ever came across some problems when the requirement.txt in karbor is different form openstack/requirements02:49
lichunyu_do you mean I can update karbor-requirements without update global-requirements?02:53
xiangxinyongno. we should keep the some with global-requirements02:58
xiangxinyongsome->same02:59
lichunyu_i see03:04
openstackgerritzengchen proposed openstack/karbor: Add update interface for scheduled operation  https://review.openstack.org/34986903:29
*** sparkyee has joined #openstack-karbor03:59
*** yizhihui has quit IRC04:02
openstackgerritOpenStack Proposal Bot proposed openstack/karbor: Updated from global requirements  https://review.openstack.org/39517604:16
openstackgerritOpenStack Proposal Bot proposed openstack/karbor-dashboard: Updated from global requirements  https://review.openstack.org/39532004:16
*** sparkyee has quit IRC04:22
openstackgerritOpenStack Proposal Bot proposed openstack/python-karborclient: Updated from global requirements  https://review.openstack.org/38832404:23
xiangxinyonglichunyu_: hello06:04
lichunyu_hi~06:04
xiangxinyongI found when i removed karbor/tests/unit/clients/test_eisoo.py Line 50~5606:05
xiangxinyongPy27 is passed06:05
lichunyu_I think i know why this faild in py2706:06
xiangxinyonggreat06:06
lichunyu_thanks:) that's help a lot06:07
xiangxinyongyou are welcome06:07
xiangxinyong        utils.find_config = mock.MagicMock(return_value='/etc/provider.d')06:08
xiangxinyongthis line is the source reason06:08
xiangxinyongI guess06:08
lichunyu_yeah. May be I have to rewrite this UT another way...06:10
xiangxinyonggood06:13
lichunyu_or just add tearDown().I'm not sure.I will try it06:14
xiangxinyonggreate06:32
*** zhurong has quit IRC06:35
*** zhurong has joined #openstack-karbor06:37
*** lichunyu_ has quit IRC06:40
*** lichunyu has joined #openstack-karbor06:50
*** TommyLikeHu has quit IRC07:06
*** TommyLikeHu has joined #openstack-karbor07:07
*** Jeffrey4l has joined #openstack-karbor07:09
*** saggi has joined #openstack-karbor07:44
*** dimak has joined #openstack-karbor08:21
*** yuval has joined #openstack-karbor08:21
chenyinghi yuval08:24
yuvalhey chenying08:25
chenyingyuval  about the patch initialize heat client using current login tenant . I think we only need use the token of tenant to init the client of heat. Admin user is not needed.08:26
yuvalchenying: have you tested it with a non admin user?08:27
chenyingyuval  Yes I have test it. May be we can consider adding a fullstack with a non admin user.08:28
chenyingyuval adding a fullstack test with a non admin user.08:29
openstackgerritzhangshuai proposed openstack/karbor: Support relative path  https://review.openstack.org/39545908:29
yuvalchenying: +108:30
yuvalzhangshuai here??08:32
openstackgerritzhangshuai proposed openstack/karbor: Support relative path  https://review.openstack.org/39545908:33
chenyingyuval: https://review.openstack.org/#/c/391944/ Enable translations  about this patch. Do you have time to see it? I am not sure that i18n is needed in the help string of config08:33
chenyingoptions.08:33
yuvalchenying: I can't see the harm in it, but seems like no other project has this08:38
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-karbor08:49
openstackgerritMerged openstack/python-karborclient: Make method import_versioned_module work  https://review.openstack.org/39256008:49
chenyingyuval: I find that a patch about this have been merged.  https://review.openstack.org/#/c/390467/08:51
openstackgerritMerged openstack/karbor: Optimize time trigger: remove the interval variable '_next_run_time'  https://review.openstack.org/37209108:51
yuvalping chenzeng08:56
chenyingall  Hi, the patches about integrating karbor to kolla have been submitted to the gerrit. https://review.openstack.org/#/c/395022/  https://review.openstack.org/#/c/395022/08:58
c00281451yuval:ping09:08
*** c00281451 is now known as zengchen09:08
zengchenyuval:how are you09:08
*** lichunyu has quit IRC09:08
yuvalzengchen: hey :)09:09
*** lihi has joined #openstack-karbor09:10
yuvaljust posted some comments in https://review.openstack.org/#/c/37219109:10
zengchenyuval:i am reading.09:10
zengchenyuval:you can see the bug report to get the backgroud. https://bugs.launchpad.net/karbor/+bug/161123209:17
openstackLaunchpad bug 1611232 in Karbor "Re-implement 'update_trigger_property' of TimeTrigger" [Undecided,Fix released] - Assigned to zengchen (chenzeng2)09:17
yuvalzengchen: yeah, I understand09:18
yuvalzengchen: but I don't understand why it is crucial to hold the old greenthread in a variable09:18
openstackgerritSaggi Mizrahi proposed openstack/karbor: Implement Neutron Restoration  https://review.openstack.org/31919609:20
zengchenyuval:because the old green thread will not be killed by the python's garbage collection.09:20
zengchenyuval:if i hold it in old_green_thread when i restart the thread.09:20
zengchenyuval:simply to say, old_green_thread hold the previous thread which can be run nomally, and the variable self._green_thread hold the new thread which will be run some time lator.09:22
*** zhurong has quit IRC09:32
*** oshidoshi has joined #openstack-karbor09:33
yuvalzengchen: imo no need to keep the old greenthread. gc will not kill it since it ref count will reach zero only once _run and _on_done are resolved09:35
*** zhurong has joined #openstack-karbor09:35
zengchenyuval: when 'self._green_thread' is set to the new thread, the reference count of old thread reaches 0. It is safe to keep the old thread in the 'self._old_green_thread'. Besides, the 'self._old_green_thread' is used at method 'update_trigger_property' to avoid update trigger too frequently.09:39
zengchenyuval:i will leave the office soon, give me comments please.09:51
zengchenyuval:thanks.09:52
yuvalzengchen: the old greenthread will not be garbage collected09:52
zengchenyuval:ok, but it is still be used at ''update_trigger_property''09:53
yuvalzengchen: I have to go, I will leave comments + explanation later09:53
zengchenyuval:ok.09:54
yuvalzengchen: if we do not keep the old greenthread there will be no need for it in update_trigger_property09:54
zengchenyuval:how to avoid update trigger too frequently.?09:54
yuvalwhy not update it frequently?09:55
zengchenyuval:user's choice.09:55
*** zhurong has quit IRC10:01
*** gouthamr has joined #openstack-karbor10:19
*** gouthamr has quit IRC10:42
*** gouthamr has joined #openstack-karbor10:45
openstackgerritchenying proposed openstack/karbor: Restore: initialize heat client using current login tenant by default  https://review.openstack.org/38537411:17
*** oshidoshi has quit IRC11:39
openstackgerritMerged openstack/karbor: Updated from global requirements  https://review.openstack.org/39517612:04
openstackgerritMerged openstack/karbor-dashboard: Updated from global requirements  https://review.openstack.org/39532012:05
openstackgerritMerged openstack/python-karborclient: Updated from global requirements  https://review.openstack.org/38832412:05
*** zhurong has joined #openstack-karbor12:49
*** zhurong has quit IRC13:01
*** zhurong has joined #openstack-karbor13:06
openstackgerritSaggi Mizrahi proposed openstack/karbor: Set local for tox  https://review.openstack.org/39558913:26
openstackgerritSaggi Mizrahi proposed openstack/karbor: Enable translations  https://review.openstack.org/39194413:44
openstackgerritSaggi Mizrahi proposed openstack/karbor: Fix minor indentation errors  https://review.openstack.org/39559913:44
*** oshidoshi has joined #openstack-karbor13:52
*** yuval has quit IRC14:08
*** lihi has quit IRC14:10
*** saggi has quit IRC14:12
openstackgerritWei Cao proposed openstack/karbor: Update usage.rst  https://review.openstack.org/39444114:42
*** zhurong has quit IRC15:03
*** dimak has quit IRC15:17
*** gouthamr has quit IRC15:38
*** gouthamr has joined #openstack-karbor15:39
*** oshidoshi has quit IRC15:51
*** gouthamr has quit IRC16:56
*** gouthamr has joined #openstack-karbor16:56
*** gouthamr has quit IRC17:10
*** gouthamr has joined #openstack-karbor17:10
*** gouthamr has quit IRC17:11
*** gouthamr has joined #openstack-karbor17:11
*** gouthamr has quit IRC17:35
*** gouthamr has joined #openstack-karbor17:37
*** gouthamr has quit IRC17:41
*** gouthamr has joined #openstack-karbor17:42
*** gouthamr has quit IRC17:50
*** gouthamr has joined #openstack-karbor17:52
*** gouthamr has quit IRC18:00
*** gouthamr has joined #openstack-karbor18:06
*** gouthamr has quit IRC18:15
*** gouthamr has joined #openstack-karbor18:16
*** gouthamr_ has joined #openstack-karbor18:23
*** gouthamr has quit IRC18:23
*** gouthamr_ is now known as gouthamr18:30
*** gouthamr has quit IRC18:44
*** gouthamr has joined #openstack-karbor18:45
*** gouthamr has quit IRC18:49
*** gouthamr has joined #openstack-karbor18:49
*** gouthamr has quit IRC19:09
*** gouthamr has joined #openstack-karbor19:15
*** gouthamr has quit IRC21:24
*** gouthamr has joined #openstack-karbor21:31
*** Jeffrey4l has quit IRC21:34
*** gouthamr has quit IRC22:03
*** gouthamr has joined #openstack-karbor22:18
*** Jeffrey4l has joined #openstack-karbor23:31
*** Jeffrey4l has quit IRC23:32
*** Jeffrey4l has joined #openstack-karbor23:32
*** Jeffrey4l has quit IRC23:33
*** Jeffrey4l has joined #openstack-karbor23:34
« Tuesday, 2016-11-08 Index Thursday, 2016-11-10 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!