| *** tommylikehu_ has joined #openstack-karbor | 00:10 | |
| *** tommylikehu_ has quit IRC | 00:16 | |
| *** zhurong has joined #openstack-karbor | 00:48 | |
| openstackgerrit | Merged openstack/karbor: Checkpoint list bug https://review.openstack.org/423797 | 01:32 |
|---|---|---|
| openstackgerrit | Merged openstack/python-karborclient: Uniform parameter split character https://review.openstack.org/424041 | 01:33 |
| openstackgerrit | Merged openstack/python-karborclient: Remove support for py33 https://review.openstack.org/423897 | 01:33 |
| *** wujiajun has joined #openstack-karbor | 01:41 | |
| openstackgerrit | Merged openstack/karbor: Updated from global requirements https://review.openstack.org/415964 | 01:44 |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/karbor: Fix typo https://review.openstack.org/424407 | 02:03 |
| *** wujiajun has quit IRC | 02:26 | |
| *** wujiajun has joined #openstack-karbor | 02:26 | |
| *** c00281451_ has joined #openstack-karbor | 03:05 | |
| *** zengchen has quit IRC | 03:09 | |
| openstackgerrit | zengchen proposed openstack/karbor: Fix token expire wich may happen in using clients https://review.openstack.org/408382 | 03:14 |
| *** zhurong has quit IRC | 03:40 | |
| *** tommylikehu_ has joined #openstack-karbor | 05:07 | |
| *** tommylikehu_ has quit IRC | 05:11 | |
| *** tommylikehu1 has joined #openstack-karbor | 05:20 | |
| *** tommylikehu has quit IRC | 05:20 | |
| *** tommylikehu1 is now known as tommylikehu | 05:20 | |
| openstackgerrit | chenying proposed openstack/karbor: Update the nova backup protection plugin https://review.openstack.org/417873 | 06:32 |
| *** wujiajun has quit IRC | 06:34 | |
| *** dimak has quit IRC | 07:16 | |
| *** saggi has quit IRC | 07:16 | |
| *** yuvalb has quit IRC | 07:16 | |
| *** lihi has quit IRC | 07:16 | |
| *** yuvalb has joined #openstack-karbor | 07:17 | |
| *** saggi has joined #openstack-karbor | 07:17 | |
| *** lihi has joined #openstack-karbor | 07:17 | |
| *** yuvalb has quit IRC | 07:31 | |
| *** yuvalb has joined #openstack-karbor | 07:32 | |
| *** yamamoto has quit IRC | 07:33 | |
| *** yuval has joined #openstack-karbor | 08:01 | |
| openstackgerrit | wu proposed openstack/karbor: Make checkpoint info precisely https://review.openstack.org/424491 | 08:01 |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** dimak has joined #openstack-karbor | 08:08 | |
| yuval | ping zhangshuai | 08:15 |
| zhangshuai | pong | 08:21 |
| zhangshuai | pong yuval | 08:21 |
| yuval | zhangshuai: hey :) | 08:21 |
| *** zengyingzhe has quit IRC | 08:21 | |
| yuval | zhangshuai: not sure I understand your comment in https://review.openstack.org/#/c/423848/1/karbor_dashboard/protectionplans/tables.py | 08:21 |
| zhangshuai | You add provider_name into plan page, I means that you can add a link to jump to the detail page of the provider of this plan. | 08:23 |
| yuval | zhangshuai: I see | 08:24 |
| zhangshuai | yuval :) | 08:27 |
| zhangshuai | :) | 08:27 |
| yuval | zhangshuai: good idea | 08:28 |
| *** wujiajun has joined #openstack-karbor | 08:28 | |
| *** yamamoto has joined #openstack-karbor | 08:35 | |
| chenying | yuval: Hi Do you have any time to discuss the hook's task order? | 08:35 |
| yuval | chenying: yeo | 08:35 |
| yuval | chenying: yep | 08:35 |
| *** openstackgerrit has joined #openstack-karbor | 08:40 | |
| openstackgerrit | chenying proposed openstack/karbor: Update the glance backup protection plugin https://review.openstack.org/416824 | 08:40 |
| chenying | yuval As your opinion, the on_main hook task of resource and its sub resources can be executed concurrently. The on_main hook of resource don't need wait that the sub resources's on_mian hooks have been finished. Is it right? | 08:43 |
| chenying | yuval: example: a resource server, its sub resource are a volume and a image. | 08:43 |
| chenying | yuval you can see this trace log: | 08:46 |
| chenying | ==========The Task [protect_on_main_OS::Glance::Image_e9e2888b-ec43-4209-ae9e-98cd79b01d62] OldState[PENDING] changed to State[RUNNING]: ========== | 08:46 |
| chenying | ==========The Task [protect_on_main_OS::Cinder::Volume_d5010ea5-973d-4293-960f-ba5a95729284] OldState[PENDING] changed to State[RUNNING]: ========== | 08:46 |
| chenying | ==========The Task [protect_on_main_OS::Nova::Server_50bc04d6-3b9e-4fc6-b350-3b1f254a0411] OldState[PENDING] changed to State[RUNNING]: ========== | 08:46 |
| chenying | ==========The Task [protect_on_main_OS::Nova::Server_50bc04d6-3b9e-4fc6-b350-3b1f254a0411] OldState[RUNNING] changed to State[SUCCESS]: ========== | 08:46 |
| chenying | ==========The Task [protect_on_main_OS::Glance::Image_e9e2888b-ec43-4209-ae9e-98cd79b01d62] OldState[RUNNING] changed to State[SUCCESS]: ========== | 08:46 |
| chenying | ==========The Task [protect_on_main_OS::Cinder::Volume_d5010ea5-973d-4293-960f-ba5a95729284] OldState[RUNNING] changed to State[SUCCESS]: ========== | 08:46 |
| yuval | chenying: correct | 08:47 |
| chenying | yuval: protect action now may have not a problom. But restore action, I am testing the nova plugin, the on_main hook of server need the restoted image and volume to restore a server. | 08:49 |
| yuval | chenying: if the server requires the main hook of the image to be finished, then write the code in on_complete | 08:50 |
| chenying | but when the on_main hook of server has started, but the volume and image 's on_mian hook have not finished. server's on_mian hook will fail, can not find the restored image and volume. | 08:51 |
| yuval | on_complete is for code that runs after the child resources finished their operation | 08:51 |
| yuval | chenying: move that code to on_complete | 08:51 |
| chenying | yuval: Why? I don't understand why resouce and sub resource 's on_mian hook can be executed concurrently. | 08:52 |
| yuval | chenying: because that is the definition of the on_main hook | 08:53 |
| yuval | chenying: from the spec https://github.com/openstack/karbor/blob/master/doc/source/specs/pluggable_protection_provider.rst | 08:54 |
| yuval | chenying: Main hook: invoked after the resource prepare hooks are complete. For tasks that do heavy lifting and can run in parallel to dependent or dependee resources main hooks | 08:55 |
| yuval | chenying: Complete hook: invoked once the resource's main hook is complete, and the dependent resources' complete hooks are complete For tasks that require that the dependent resource's operations are complete, and finalize the operation on the resource. | 08:55 |
| chenying | yuval: I see. | 08:57 |
| chenying | yuval: As my understanding, the on_complete hook will do something after the resource has been restored. But now the server's main restore processing in the on_complete hook. Nothing can be done in the on_main hook. | 09:00 |
| yuval | chenying: technically, since we still use heat, some resources might not be fully restored after on_complete | 09:01 |
| chenying | yuval: let take restore server as a example, if we don't user heat, we restore a server with a image and a volume, before that, the image and the volume must have been restored finished. | 09:04 |
| chenying | yuval: Restore the server also be executed in the on_complete hook. If the server don't have any sub resoureces, the main restore processing in the on_complete hook, it is alos not reasonable. | 09:06 |
| yuval | chenying: I don't understand what you are trying to say | 09:08 |
| yuval | if server needs image/volume for part of the restore, the part that needs these resources must be in on_complete | 09:09 |
| chenying | yuval: if some processing need be done after the resource has been restored, it is also should be done in thie on_complete hook? | 09:12 |
| yuval | chenying: on_complete runs after the child resources completion | 09:14 |
| chenying | chenying: yes I have known that. The processing after the server have been restored will also be done in the on_complete in this design. | 09:16 |
| chenying | In a literal sense, I thought that on_complete hook only do the processing after the resource has been restored. Maybe I have a wrong understanding about the hooks name. | 09:17 |
| zhangshuai | 192.168.98.122:10000 | 09:23 |
| *** xinyanzhang has joined #openstack-karbor | 09:24 | |
| yuval | chenying: maybe it is confusing, do you think we should update documentation about it? | 09:27 |
| *** yamamoto has quit IRC | 09:29 | |
| chenying | yuval: If I have read the spec carefully, I am not confusing about it. :D | 09:29 |
| yuval | chenying: :) | 09:29 |
| openstackgerrit | chenying proposed openstack/karbor: Update the glance backup protection plugin https://review.openstack.org/416824 | 09:34 |
| openstackgerrit | Yuval Brik proposed openstack/karbor-dashboard: plans: add provider name to plans table https://review.openstack.org/423848 | 09:43 |
| yuval | chenying: we will have an issue with the cinder protection plugin. Currently the backup is restored by using heat, but we need to change it, and have it restore in one of the hooks | 09:45 |
| yuval | otherwise the server protection plugin can not use it in the on_complete hook | 09:45 |
| chenying | chenying now It seem Ok, Maybe the heat template can solve this dependency. | 09:52 |
| chenying | yuval: http://paste.openstack.org/show/596203/ | 09:55 |
| chenying | yuval: You can see this heat template, restore a server with a image and volume, the volume is also stored useing heat, heat know the dependency. | 09:56 |
| chenying | yuval: get_resource may mean that get this resource with this id after it has been created. | 09:58 |
| chenying | yuval: D | 09:58 |
| openstackgerrit | chenying proposed openstack/karbor: Update the nova backup protection plugin https://review.openstack.org/417873 | 09:59 |
| openstackgerrit | chenying proposed openstack/karbor: Update the nova backup protection plugin https://review.openstack.org/417873 | 10:01 |
| *** yamamoto has joined #openstack-karbor | 10:20 | |
| *** yamamoto has quit IRC | 10:21 | |
| *** tommylikehu_ has joined #openstack-karbor | 10:52 | |
| yuval | chenying: looking good, but the server may boot from volume and not image as well | 11:25 |
| chenying | chening: I am working on the situation about server boot from a bootable voulme. | 11:26 |
| chenying | yuval: I am working on the situation about server boot from a bootable voulme. | 11:27 |
| chenying | :D | 11:27 |
| yuval | chenying: the template looks very good | 11:27 |
| openstackgerrit | Merged openstack/karbor-dashboard: plans: add provider name to plans table https://review.openstack.org/423848 | 11:33 |
| yuval | chenying: boot from volume should use block_device_mapping_v2 property of OS::Nova::Server | 11:34 |
| chenying | yuval: about this patch:https://review.openstack.org/#/c/411603/ you can see the endpoint of karbor from here. http://paste.openstack.org/show/596223/ | 11:47 |
| chenying | | 16f600a9d8ee454eb82d72c0b4d19617 | NULL | public | 54ef44312a204b2aaffe099d22b9aedf | http://10.229.47.230:8799/v1/$(tenant_id)s | {} | 1 | RegionOne | | 11:48 |
| chenying | only karbor project use the parameter tenant_id)s . | 11:49 |
| openstackgerrit | Merged openstack/karbor: Replace 'tenant_id' to 'project_id' for Karbor's endpoints https://review.openstack.org/411603 | 11:52 |
| openstackgerrit | Merged openstack/karbor: Add 'Restore Resources Status' spec https://review.openstack.org/423790 | 12:03 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor: Updated from global requirements https://review.openstack.org/424613 | 12:10 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor-dashboard: Updated from global requirements https://review.openstack.org/415409 | 12:10 |
| *** gouthamr has joined #openstack-karbor | 12:13 | |
| *** yamamoto has joined #openstack-karbor | 12:20 | |
| *** yamamoto has quit IRC | 13:04 | |
| *** yamamoto has joined #openstack-karbor | 13:25 | |
| *** yamamoto has quit IRC | 13:25 | |
| *** tommylikehu_ has quit IRC | 13:26 | |
| *** gouthamr has quit IRC | 13:32 | |
| *** Jeffrey4l_ is now known as Jeffrey4l | 13:42 | |
| yuval | chenying: ping | 13:56 |
| *** lihiwish has joined #openstack-karbor | 13:58 | |
| *** lihiwish has left #openstack-karbor | 13:58 | |
| *** tommylikehu_ has joined #openstack-karbor | 13:59 | |
| *** tommylikehu_ has quit IRC | 13:59 | |
| *** tommylikehu_ has joined #openstack-karbor | 13:59 | |
| *** lihi has quit IRC | 14:03 | |
| *** gouthamr has joined #openstack-karbor | 14:16 | |
| *** chenying__ has joined #openstack-karbor | 14:31 | |
| *** zhangshuai has quit IRC | 14:32 | |
| *** zhangshuai has joined #openstack-karbor | 14:32 | |
| *** gouthamr_ has joined #openstack-karbor | 14:49 | |
| *** gouthamr has quit IRC | 14:50 | |
| *** gouthamr_ is now known as gouthamr | 14:51 | |
| *** tommylikehu_ has quit IRC | 15:09 | |
| *** tommylikehu_ has joined #openstack-karbor | 15:11 | |
| *** gouthamr has quit IRC | 15:13 | |
| *** chenying__ has quit IRC | 15:16 | |
| *** yuval has quit IRC | 15:45 | |
| *** tommylikehu_ has quit IRC | 15:46 | |
| *** lihi has joined #openstack-karbor | 16:10 | |
| *** lihi has quit IRC | 18:21 | |
| *** yamamoto has joined #openstack-karbor | 21:08 | |
| *** yamamoto has quit IRC | 21:12 | |
| *** Jeffrey4l_ has joined #openstack-karbor | 21:34 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** yamamoto has joined #openstack-karbor | 22:17 | |
| *** tommylikehu_ has joined #openstack-karbor | 23:23 | |
| *** tommylikehu_ has quit IRC | 23:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!