| *** gouthamr has joined #openstack-karbor | 00:03 | |
| *** zhurong has joined #openstack-karbor | 00:32 | |
| *** jiaopengju has joined #openstack-karbor | 01:02 | |
| *** jiaopeng_ has joined #openstack-karbor | 01:03 | |
| *** jiaopengju has quit IRC | 01:06 | |
| *** zengyingzhe has joined #openstack-karbor | 01:09 | |
| *** zengyingzhe has quit IRC | 02:21 | |
| *** zengyingzhe has joined #openstack-karbor | 02:21 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add deploying karbor-api with mod-wsgi https://review.openstack.org/453705 | 03:52 |
|---|---|---|
| *** zengyingzhe_ has joined #openstack-karbor | 04:01 | |
| *** zengyingzhe has quit IRC | 04:10 | |
| *** x00350071_ has quit IRC | 04:34 | |
| *** x00350071_ has joined #openstack-karbor | 04:34 | |
| *** gouthamr has quit IRC | 04:47 | |
| openstackgerrit | zhangshuai proposed openstack/karbor master: Add database_bank fullstack https://review.openstack.org/452085 | 05:02 |
| *** dimak_ has joined #openstack-karbor | 06:58 | |
| *** dimak_ has quit IRC | 07:01 | |
| openstackgerrit | Lingyong Xu proposed openstack/karbor master: Use HostAddressOpt for opts that accept IP and hostname https://review.openstack.org/454007 | 07:09 |
| *** dimak_ has joined #openstack-karbor | 07:27 | |
| yuval | ping chenying_ | 07:31 |
| *** yamamoto has quit IRC | 07:33 | |
| *** yamamoto has joined #openstack-karbor | 07:34 | |
| openstackgerrit | Lingyong Xu proposed openstack/karbor master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/454016 | 07:37 |
| chenying_ | hi yuval | 07:39 |
| chenying_ | Good morning. | 07:39 |
| yuval | chenying_: good afternoon | 07:44 |
| chenying_ | yuval The patches about bp 'instances-extra-info' have been updated according to your comments. https://review.openstack.org/388593 https://review.openstack.org/390613 If you have some time, Could you please review them first? | 07:46 |
| yuval | chenying_: I'll try, but I'm working on specs (multi tenant isolation) | 07:47 |
| yuval | chenying_: since I'll be off since tomorrow until later in April (holiday), I'll make effort to review them today | 07:47 |
| chenying_ | yuval Lots of patches need be reviewed from you. Most of patches have been reviewed by the other guys. | 07:51 |
| chenying_ | yuval I suggest that the small patches about fix or optimization could be reviewed and merged ASAP. We don't need so much time(over a month) about these patches. | 08:01 |
| yuval | chenying_: most patches need to be reviewed by everyone | 08:06 |
| yuval | chenying_: the extra_info patches have no +1 from anyone right now | 08:07 |
| yuval | chenying_: the small patches can wait, we are in the beginning of the cycle. Specs are the highest priority right now | 08:07 |
| chenying_ | yuval The patch has been updated. The +1 about this patches have been brushed off. | 08:09 |
| chenying_ | yuval the small patches can wait, we are in the beginning of the cycle. Specs are the highest priority right now: IMO I think that it is not conflicting. | 08:10 |
| *** c00281451 has joined #openstack-karbor | 08:13 | |
| *** c00281451 is now known as zengchen | 08:13 | |
| yuval | chenying_: never said it is conflicting. When I choose what to dedicate my time on - I start on specs. If I have more time - I review small patches | 08:16 |
| yuval | chenying_: didn't understand your answer in line 53-56 in https://review.openstack.org/#/c/388593/20/karbor/services/protection/flows/protect.py | 08:23 |
| yuval | chenying_: never mind, was looking at an older version | 08:24 |
| *** zengchen has quit IRC | 08:43 | |
| *** zengchen has joined #openstack-karbor | 08:44 | |
| *** yamamoto has quit IRC | 08:48 | |
| *** yamamoto has joined #openstack-karbor | 08:48 | |
| openstackgerrit | Merged openstack/karbor master: Add extra_info field to the response of instances API https://review.openstack.org/388593 | 08:57 |
| zengchen | yuval: ping | 09:01 |
| yuval | zengchen: hey | 09:02 |
| zengchen | yuval:how are you? thanks for reviewing my patches. I am sorry for not quite understanding this comments. could you please explain it again. | 09:03 |
| yuval | zengchen: which? | 09:03 |
| zengchen | yuval:https://review.openstack.org/#/c/450694/3/karbor/services/protection/resource_flow.py | 09:03 |
| yuval | zengchen: this adds "restore" argument as mandatory for all operations | 09:03 |
| yuval | zengchen: why did you add it? | 09:04 |
| zengchen | yuval:not for all operation. just for restore. | 09:04 |
| zengchen | yuval:if the operation is not 'restore', OPERATION_EXTRA_ARGS.get(self.operation_type, []) will return [] | 09:05 |
| yuval | zengchen: you are correct | 09:06 |
| yuval | zengchen: anyway, other comments still apply | 09:06 |
| yuval | zengchen: and tests needs some love | 09:06 |
| yuval | zengchen: will be back later | 09:06 |
| zengchen | yuval:IMO, 'utils.udpate_resource_restore_result' is needed. because this function will be invoked at several different places and different protect plugins. I don't want to write repeat codes. | 09:09 |
| zengchen | yuval:what do you mean for 'and tests needs some love'. sorry. | 09:10 |
| openstackgerrit | chenying proposed openstack/karbor master: Add extra_info field to the resource database table of plan API https://review.openstack.org/390613 | 09:55 |
| *** yamamoto has quit IRC | 09:57 | |
| *** yamamoto has joined #openstack-karbor | 09:57 | |
| *** yamamoto has quit IRC | 10:13 | |
| *** yamamoto has joined #openstack-karbor | 10:15 | |
| *** saggi has quit IRC | 10:25 | |
| *** saggi has joined #openstack-karbor | 10:27 | |
| *** jiaopeng_ has quit IRC | 10:32 | |
| yuval | zengchen: but why do we need that function? | 11:08 |
| yuval | zengchen: "tests need some love" = currently the tests fail | 11:09 |
| zengchen | yuval: you can see that function did some other work, such as save db and write log if failed. | 11:14 |
| *** x00350071_ has quit IRC | 11:24 | |
| *** x00350071_ has joined #openstack-karbor | 11:25 | |
| openstackgerrit | Lingyong Xu proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/454118 | 11:34 |
| openstackgerrit | Merged openstack/karbor master: Add extra_info field to the resource database table of plan API https://review.openstack.org/390613 | 11:35 |
| yuval | zengchen: but we already have a method for the restore object for saving in the db, why do we need to wrap it? | 11:40 |
| zengchen | yuval:because we have to invoke two methonds to update fileds of restore and we should write some log if it fails. The codes will be cleaner if I just invoke the wrapped function. | 11:53 |
| yuval | zengchen: sorry, I don't see it. Either log in the invoker, or add logs in the restore object method | 11:54 |
| zengchen | yuval:ok. so, I don't need to modify it, right? | 11:56 |
| *** x00350071_ is now known as edisonxiang | 12:00 | |
| yuval | zengchen: modify what? | 12:07 |
| zengchen | yvual: use the wrapped function to update fileds of restore object. | 12:08 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/453880 | 12:18 |
| openstackgerrit | zengchen proposed openstack/karbor master: Refactor resource.py/Resource https://review.openstack.org/454150 | 12:22 |
| openstackgerrit | Merged openstack/karbor master: Get rid of timezone info for all time fields of versioned objects https://review.openstack.org/441770 | 12:28 |
| zengchen | yuval:could you please take a look at these tow patch. thanks. | 12:34 |
| zengchen | https://review.openstack.org/#/c/454150 https://review.openstack.org/#/c/450689/ | 12:34 |
| *** gouthamr has joined #openstack-karbor | 12:37 | |
| *** zhurong has quit IRC | 12:42 | |
| *** jiaopengju has joined #openstack-karbor | 12:57 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add a check about the range of the parameter 'offset' https://review.openstack.org/454189 | 13:39 |
| *** zengyingzhe_ has quit IRC | 13:43 | |
| *** zengyingzhe_ has joined #openstack-karbor | 13:44 | |
| openstackgerrit | Merged openstack/karbor master: Fix the configuration name about base URL of karbor api https://review.openstack.org/451447 | 13:47 |
| *** jiaopengju02 has joined #openstack-karbor | 14:30 | |
| *** dimak_ has quit IRC | 14:46 | |
| *** tommylikehu_ has joined #openstack-karbor | 14:55 | |
| *** tommylikehu_ has quit IRC | 15:00 | |
| openstackgerrit | chenying proposed openstack/karbor master: Don't use default=None for config options https://review.openstack.org/454229 | 15:12 |
| *** zengchen has quit IRC | 15:16 | |
| *** zengchen has joined #openstack-karbor | 15:16 | |
| *** jiaopengju has quit IRC | 15:19 | |
| *** jiaopengju02 has quit IRC | 15:20 | |
| *** zhurong has joined #openstack-karbor | 15:47 | |
| *** zhurong has quit IRC | 15:49 | |
| *** dimak_ has joined #openstack-karbor | 17:31 | |
| *** chenying_ has quit IRC | 18:11 | |
| *** chenying_ has joined #openstack-karbor | 18:12 | |
| *** zengchen has quit IRC | 18:19 | |
| *** openstack has joined #openstack-karbor | 19:47 | |
| *** chenying_ has quit IRC | 20:03 | |
| *** chenying_ has joined #openstack-karbor | 20:04 | |
| *** dimak_ has quit IRC | 20:27 | |
| *** openstackgerrit has quit IRC | 21:07 | |
| *** gouthamr has quit IRC | 21:11 | |
| *** gouthamr has joined #openstack-karbor | 21:35 | |
| *** openstack has joined #openstack-karbor | 22:03 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!