| *** jiaopengju02 has joined #openstack-karbor | 00:42 | |
| openstackgerrit | Merged openstack/karbor master: Fix fullstack test errors about authorization https://review.openstack.org/457887 | 01:49 |
|---|---|---|
| *** zhurong has joined #openstack-karbor | 02:10 | |
| openstackgerrit | yfzhao proposed openstack/karbor-dashboard master: Drop py34 target in tox.ini and setup.cfg https://review.openstack.org/458304 | 02:32 |
| *** gouthamr has joined #openstack-karbor | 02:45 | |
| *** zhurong has quit IRC | 03:21 | |
| *** zhurong has joined #openstack-karbor | 03:27 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila client for karbor https://review.openstack.org/449664 | 03:29 |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protectable plugin for karbor https://review.openstack.org/452111 | 03:29 |
| openstackgerrit | chenying proposed openstack/karbor master: Add fullstack test for share protectable plugin https://review.openstack.org/452123 | 03:29 |
| *** zhurong has quit IRC | 03:31 | |
| *** zhurong has joined #openstack-karbor | 04:31 | |
| *** gouthamr has quit IRC | 05:54 | |
| *** zhurong has quit IRC | 06:12 | |
| *** dimak_ has joined #openstack-karbor | 06:46 | |
| *** zhurong has joined #openstack-karbor | 07:12 | |
| yuval | Hello everyone! | 07:23 |
| jiaopengju02 | hi | 07:26 |
| xiangxinyong | hello | 07:29 |
| *** zhurong has quit IRC | 10:19 | |
| *** jiaopengju02 has quit IRC | 10:20 | |
| openstackgerrit | Merged openstack/karbor master: Add default password modification in devstack https://review.openstack.org/450565 | 11:08 |
| *** zhurong has joined #openstack-karbor | 11:17 | |
| chenying_ | hi | 11:28 |
| openstackgerrit | Merged openstack/karbor master: Removing unnecessary config definition https://review.openstack.org/454433 | 11:32 |
| *** openstackgerrit has quit IRC | 11:32 | |
| *** c00281451 has joined #openstack-karbor | 11:40 | |
| *** jiaopengju has joined #openstack-karbor | 11:41 | |
| c00281451 | ping yuval | 11:41 |
| c00281451 | nick zengchen | 11:41 |
| *** c00281451 has quit IRC | 11:42 | |
| zengchen | ping yuval | 11:42 |
| yuval | ping zengchen | 11:55 |
| zengchen | yuval:about this patch. sorry, I don't understand your idea. https://review.openstack.org/#/c/450689 | 12:07 |
| yuval | zengchen: instead of making a case for each exception type, make KarborException behave like any other Exception | 12:08 |
| yuval | zengchen: (that is, proper casting to string. Maybe it is already like that) | 12:09 |
| zengchen | yuval:if timeout, then an exception of TimeOut will be raised which is not KarborException. How to do it? | 12:10 |
| yuval | zengchen: you are catching all exceptions anyhow in line 426 | 12:11 |
| yuval | zengchen: why do you have two cases, one in 423-424, and one in 426-428 | 12:11 |
| zengchen | yuval:yes. one kind of exception is KarborExcetion, and other is not KarborException. | 12:13 |
| yuval | zengchen: KarborException is a subclass of Exception | 12:13 |
| yuval | zengchen: https://github.com/openstack/karbor/blob/master/karbor/exception.py#L75 | 12:13 |
| zengchen | yuval:TimeOut is another kind of Exception. | 12:13 |
| yuval | zengchen: does it inherit from Exception? | 12:14 |
| zengchen | yuval:TimeOut and KarborException are both inherited from Exception. | 12:14 |
| yuval | zengchen: so just do 'except Exception as ex', it will catch all of these | 12:14 |
| zengchen | yuval:My thought is that. | 12:15 |
| yuval | zengchen: ? | 12:20 |
| zengchen | yuval:I mean that was my thought. | 12:22 |
| zengchen | yuval:https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/exceptions.py#L22-L27 | 12:24 |
| zengchen | yuval:according to tests, some kinds of exceptions are raised from module of oslo_message | 12:26 |
| yuval | zengchen: ok, what's the problem with that? | 12:26 |
| zengchen | yuval: My updates can just fix that problem. | 12:27 |
| zengchen | yuval:https://review.openstack.org/#/c/450689 | 12:28 |
| *** openstackgerrit has joined #openstack-karbor | 12:28 | |
| openstackgerrit | chenying proposed openstack/karbor master: Updata the api doc about the extra_info filed of protectable API https://review.openstack.org/457161 | 12:28 |
| yuval | zengchen: your update fixes that, but there is redundant code over there | 12:28 |
| yuval | zengchen: no need to catch two different kinds of exceptions | 12:28 |
| yuval | zengchen: you can catch Exception, which will catch both types | 12:28 |
| yuval | ping chenying_ | 12:29 |
| yuval | chenying_: https://review.openstack.org/#/c/452111/4/karbor/services/protection/protectable_plugins/share.py | 12:30 |
| yuval | chenying_: line 24: what about other statuses? | 12:30 |
| zengchen | yuval:how to get message of different exception | 12:30 |
| yuval | chenying_: as listed in https://developer.openstack.org/api-ref/shared-file-systems/ | 12:30 |
| yuval | zengchen: all exceptions should have a proper casting to string | 12:30 |
| zengchen | yuval:It seems that KarborExceptino can not be casted. | 12:31 |
| zengchen | yuval:I will update KarborException if needed. | 12:32 |
| yuval | zengchen: yep | 12:32 |
| zengchen | yuval:got it. thanks. | 12:33 |
| yuval | zengchen: I'm actually pretty sure it can be casted, but you need to check that | 12:37 |
| zengchen | yuval:ok | 12:38 |
| chenying_ | yuval I will adressed the comments soon. | 12:43 |
| yuval | chenying_: thanks :) | 12:43 |
| openstackgerrit | Merged openstack/karbor master: Use wsgi module from oslo.service https://review.openstack.org/453655 | 12:44 |
| openstackgerrit | zengchen proposed openstack/karbor master: Refactor resource.py/Resource https://review.openstack.org/454150 | 12:54 |
| openstackgerrit | zengchen proposed openstack/karbor master: Fix: reference an undefined attribute of 'msg' of Exception https://review.openstack.org/458494 | 13:01 |
| *** jiaopengju has quit IRC | 13:04 | |
| openstackgerrit | zengchen proposed openstack/karbor master: Fix: reference an undefined attribute of 'msg' of Exception https://review.openstack.org/450689 | 13:05 |
| *** jiaopengju has joined #openstack-karbor | 13:07 | |
| *** jiaopeng_ has joined #openstack-karbor | 13:07 | |
| *** jiaopeng_ has quit IRC | 13:27 | |
| *** jiaopengju has quit IRC | 13:27 | |
| *** jiaopengju has joined #openstack-karbor | 13:28 | |
| *** gouthamr has joined #openstack-karbor | 14:19 | |
| *** Jeffrey4l has quit IRC | 14:19 | |
| openstackgerrit | Merged openstack/karbor master: Add deploying karbor-api with mod-wsgi https://review.openstack.org/453705 | 14:36 |
| openstackgerrit | chenying proposed openstack/karbor master: Add a fullstack test protecting a server which boots from a volume https://review.openstack.org/456188 | 14:55 |
| *** dimak_ has quit IRC | 15:03 | |
| *** jiaopengju has quit IRC | 15:11 | |
| openstackgerrit | Merged openstack/karbor master: Enable coverage report when testing coverage https://review.openstack.org/457654 | 15:24 |
| *** Jeffrey4l has joined #openstack-karbor | 15:31 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add fullstack test for share protectable plugin https://review.openstack.org/452123 | 15:41 |
| openstackgerrit | Merged openstack/karbor master: Support file system based bank implementation https://review.openstack.org/355956 | 15:48 |
| *** zhurong has quit IRC | 16:11 | |
| openstackgerrit | Merged openstack/karbor master: Add karbor-api WSGI support in devstack https://review.openstack.org/455734 | 16:13 |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protection plugin for karbor https://review.openstack.org/458582 | 16:26 |
| openstackgerrit | Merged openstack/karbor master: Add the process about the schema parameter of the cinder plugin https://review.openstack.org/457456 | 16:30 |
| openstackgerrit | Merged openstack/karbor master: Remove usage of parameter enforce_type https://review.openstack.org/457260 | 16:32 |
| openstackgerrit | Merged openstack/karbor master: Add manila client for karbor https://review.openstack.org/449664 | 16:37 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/458593 | 17:03 |
| *** zhonghua2 has quit IRC | 19:22 | |
| *** zhonghua has joined #openstack-karbor | 19:23 | |
| *** jhamhader has joined #openstack-karbor | 19:54 | |
| *** jhamhader has quit IRC | 19:58 | |
| *** gouthamr has quit IRC | 21:57 | |
| *** gouthamr has joined #openstack-karbor | 23:33 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!