| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/458593 | 00:29 |
|---|---|---|
| *** dixiaoli has joined #openstack-karbor | 01:05 | |
| *** liujiong has joined #openstack-karbor | 01:46 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protection plugin for karbor https://review.openstack.org/458582 | 01:51 |
| openstackgerrit | Merged openstack/karbor master: Make several configuration property as secret https://review.openstack.org/459193 | 01:56 |
| *** zhurong has joined #openstack-karbor | 02:33 | |
| openstackgerrit | yfzhao proposed openstack/python-karborclient master: Replace http with https https://review.openstack.org/459915 | 02:37 |
| openstackgerrit | Merged openstack/karbor master: Add a fullstack test protecting a server which boots from a volume https://review.openstack.org/456188 | 02:46 |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protectable plugin for karbor https://review.openstack.org/452111 | 03:09 |
| *** zhurong has quit IRC | 03:15 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add fullstack test for share protectable plugin https://review.openstack.org/452123 | 03:19 |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protection plugin for karbor https://review.openstack.org/458582 | 03:28 |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protection plugin for karbor https://review.openstack.org/458582 | 03:56 |
| *** gouthamr has quit IRC | 04:02 | |
| *** zhurong has joined #openstack-karbor | 05:07 | |
| *** gouthamr has joined #openstack-karbor | 05:36 | |
| *** zhurong has quit IRC | 05:52 | |
| *** dixiaoli_ has joined #openstack-karbor | 05:59 | |
| *** dixiaoli_ has quit IRC | 06:00 | |
| *** dixiaoli has quit IRC | 06:00 | |
| *** dixiaoli has joined #openstack-karbor | 06:01 | |
| *** chenying_ has quit IRC | 06:16 | |
| *** chenying_ has joined #openstack-karbor | 06:16 | |
| chenying_ | ping yuval | 06:17 |
| *** zhurong has joined #openstack-karbor | 06:26 | |
| *** zhurong has quit IRC | 06:33 | |
| *** dimak_ has joined #openstack-karbor | 07:00 | |
| openstackgerrit | Rajat Sharma proposed openstack/karbor master: Add 'rm -f .testrepository/times.dbm' command in testenv https://review.openstack.org/459969 | 07:03 |
| openstackgerrit | chenying proposed openstack/karbor master: Add fullstack test for share protectable plugin https://review.openstack.org/452123 | 07:06 |
| *** zhurong has joined #openstack-karbor | 07:28 | |
| yuval | chenying_: https://review.openstack.org/#/c/459688 https://review.openstack.org/#/c/459689 | 07:30 |
| chenying_ | yuval This solution looks good for manila. | 07:38 |
| *** gouthamr has quit IRC | 07:47 | |
| *** zhurong has quit IRC | 08:08 | |
| zengchen | ying yuval | 08:32 |
| zengchen | ping yuval | 08:32 |
| zengchen | yuval:please take a look at these two patches, thanks. https://review.openstack.org/#/c/454150 https://review.openstack.org/#/c/450070 | 08:33 |
| yuval | hey zengchen | 08:37 |
| zengchen | yuval:hi, how are you | 08:37 |
| yuval | zengchen: very well, youself? | 08:38 |
| yuval | *yourself | 08:38 |
| zengchen | yuval:good | 08:38 |
| zengchen | yuval:if you have time, take a look at my patch, and we can discuss them if you have different idea. | 08:39 |
| yuval | zengchen: in the first patch the fullstack tests fail | 08:39 |
| yuval | zengchen: in the second one: I don't think you should remove checkpoints from the requires | 08:40 |
| yuval | zengchen: you can asks from reviews from Chengdu guys as well | 08:40 |
| yuval | *ask | 08:40 |
| zengchen | yuval:I will check for the first one. Do you have any thought for it? | 08:41 |
| zengchen | yuval: I will ask them to review. | 08:41 |
| zengchen | yuval:let's talk about second one. why do you think it is not good to remove 'checkpoint'? | 08:42 |
| yuval | zengchen: regarding the first one: fix the fullstack tests first | 08:43 |
| yuval | zengchen: second one: why do you think we should remove it? | 08:43 |
| zengchen | yuval:if user don't use checkpoint in their method, it will be no effect even if you add it to the requirment. | 08:45 |
| yuval | zengchen: why did you remove just 'checkpoint' then and not the other requires as well? | 08:46 |
| *** x00350071_ has joined #openstack-karbor | 08:49 | |
| zengchen | yuval: because each task has different value for other 3 parameters. | 08:50 |
| zengchen | yuval:but for checkpoint, there is only one. | 08:50 |
| yuval | zengchen: how does that mean that they are required? | 08:52 |
| *** xiangxinyong has quit IRC | 08:52 | |
| zengchen | yuval:sorry, where did I say 'they are required'. | 08:55 |
| yuval | zengchen: I asked why do you suggest to remove 'checkpoint' and not the other requires | 08:55 |
| yuval | zengchen: https://review.openstack.org/#/c/450070/3/karbor/services/protection/resource_flow.py | 08:56 |
| yuval | zengchen: line 101 | 08:56 |
| zengchen | yuval: because each task has different value for other 3 parameters.but for checkpoint, there is only one. | 08:56 |
| yuval | zengchen: hows does that mean that they are required? | 08:56 |
| yuval | zengchen: will be back later | 08:58 |
| zengchen | yvual:you can see the codes of TaskFlow, it will parse the all required parameter automatically. If you specify the 'requires' parameter, then it will add it to the last required parameter. | 08:59 |
| zengchen | yuval:please see https://github.com/openstack/taskflow/blob/master/taskflow/atom.py#L253 | 09:01 |
| zengchen | yuval: and https://github.com/openstack/taskflow/blob/master/taskflow/atom.py#L269-L274 | 09:02 |
| *** dixiaoli has quit IRC | 09:19 | |
| *** zhurong has joined #openstack-karbor | 09:21 | |
| zengchen | yuval: in a word, to my understanding, the 'requires' of Atom.__init__ is used to specify the parameters which are not declare in 'execute' function of task. just as we do when construct restore task where we set the 'heat_template' in 'requires'. heat_template is not declared in method of base class 'Operation'. | 09:21 |
| zengchen | yuval:I will delete other 3 parameter of 'requires'. | 09:22 |
| zengchen | yuval: I will delete other 3 parameter of 'requires' like 'checkpoint'. | 09:22 |
| *** dixiaoli has joined #openstack-karbor | 09:25 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add fullstack test for share protectable plugin https://review.openstack.org/452123 | 09:32 |
| *** zhurong has quit IRC | 09:37 | |
| openstackgerrit | zengchen proposed openstack/karbor master: Update way of retrieving parameters when using TaskFlow https://review.openstack.org/450070 | 09:39 |
| *** dixiaoli_ has joined #openstack-karbor | 09:40 | |
| *** dixiaoli_ has quit IRC | 09:42 | |
| *** dixiaoli has quit IRC | 09:44 | |
| *** liujiong has quit IRC | 10:26 | |
| yuval | zengchen: it used to define which parameters are required, and if not found, it raises an exception about it | 11:32 |
| yuval | *it is | 11:32 |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Test systemd in gate https://review.openstack.org/460082 | 12:10 |
| openstackgerrit | chenying proposed openstack/karbor master: Add manila share protection plugin for karbor https://review.openstack.org/458582 | 13:09 |
| *** gouthamr has joined #openstack-karbor | 13:22 | |
| openstackgerrit | chenying proposed openstack/karbor master: Fix updating the status metadata of checkpoint in volume plugin https://review.openstack.org/460116 | 13:54 |
| *** dimak_ has quit IRC | 15:17 | |
| *** wangfeng has joined #openstack-karbor | 15:48 | |
| wangfeng | \list | 15:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/458593 | 18:11 |
| *** dimak_ has joined #openstack-karbor | 18:58 | |
| *** saggi- has joined #openstack-karbor | 20:12 | |
| *** saggi has quit IRC | 20:13 | |
| *** saggi- is now known as saggi | 20:13 | |
| *** dixiaoli has joined #openstack-karbor | 20:43 | |
| *** dixiaoli has quit IRC | 20:47 | |
| *** gouthamr has quit IRC | 21:59 | |
| *** dimak_ has quit IRC | 23:10 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!