| *** liujiong has joined #openstack-karbor | 01:59 | |
| openstackgerrit | Merged openstack/python-karborclient master: Optimize the link address https://review.openstack.org/455552 | 02:18 |
|---|---|---|
| *** jiaopengju has joined #openstack-karbor | 02:38 | |
| openstackgerrit | chenying proposed openstack/karbor master: Set WSGI_MODE to uwsgi in devstack(test) https://review.openstack.org/469725 | 02:47 |
| openstackgerrit | chenying proposed openstack/karbor master: Add a verification about restore's parameter https://review.openstack.org/460604 | 02:54 |
| *** yamamoto_ has joined #openstack-karbor | 02:58 | |
| *** yamamoto_ has joined #openstack-karbor | 02:58 | |
| openstackgerrit | zengchen proposed openstack/karbor master: Update way of retrieving parameters when using TaskFlow https://review.openstack.org/450070 | 03:02 |
| openstackgerrit | chenying proposed openstack/karbor master: Add Cinder snapshot plugin implementation for karbor https://review.openstack.org/465948 | 03:22 |
| *** zhurong has joined #openstack-karbor | 03:27 | |
| *** zhurong has quit IRC | 04:27 | |
| *** zhurong has joined #openstack-karbor | 04:36 | |
| *** yamamoto_ has quit IRC | 04:48 | |
| *** gouthamr has quit IRC | 04:55 | |
| *** zhurong has quit IRC | 05:16 | |
| *** zhurong has joined #openstack-karbor | 05:17 | |
| *** yamamoto_ has joined #openstack-karbor | 05:35 | |
| *** liujiong has quit IRC | 05:40 | |
| chenying | ping yuval | 06:06 |
| *** liujiong has joined #openstack-karbor | 06:32 | |
| *** dimak_ has joined #openstack-karbor | 06:40 | |
| yuval | hey chenying | 08:00 |
| chenying | hi yuval Good morning. | 08:06 |
| *** liujiong has quit IRC | 08:18 | |
| *** jiaopengju has quit IRC | 08:19 | |
| *** zhurong has quit IRC | 08:29 | |
| *** liujiong has joined #openstack-karbor | 08:33 | |
| *** liujiong has quit IRC | 08:40 | |
| *** liujiong has joined #openstack-karbor | 08:40 | |
| yuval | chenying: hey, good afternoon | 08:44 |
| openstackgerrit | chenying proposed openstack/karbor master: Add Cinder snapshot plugin implementation for karbor https://review.openstack.org/465948 | 09:02 |
| chenying | yuval: It seems that this patch will fix the jinkens gate failure https://review.openstack.org/#/c/469810/ | 09:20 |
| chenying | yuva: Hi about this patch : https://review.openstack.org/#/c/469725/ Do we need change the karbor-api to uwsgi mode in devstack by default? | 09:21 |
| openstackgerrit | chenying proposed openstack/karbor master: Add spec for operation log RESTfull API https://review.openstack.org/446315 | 09:29 |
| *** liujiong_lj has joined #openstack-karbor | 09:29 | |
| *** liujiong has quit IRC | 09:30 | |
| yuval | chenying: I don't think we need to explicitly set WSGI_MODE, currently it is set in stackrc in devstack | 10:33 |
| *** zhurong has joined #openstack-karbor | 10:35 | |
| *** yamamoto_ has quit IRC | 10:47 | |
| chenying | yuval: OK I see. I will abandon this one. | 11:02 |
| chenying | yuval: Hi could you please review the patches about bp localfs-bank and database bank? | 11:05 |
| yuval | chenying: what about the list by prefix issue? (fs bank) | 11:06 |
| yuval | chenying: also, fs bank fullstack failed | 11:07 |
| chenying | yuval: https://review.openstack.org/#/c/441841/ fsbank | 11:08 |
| chenying | yuval: The fullstack jinkins is OK. | 11:09 |
| yuval | chenying: that patch includes no fullstack tests for the fs bank | 11:09 |
| yuval | chenying: this one: https://review.openstack.org/#/c/448442 has, but it fails | 11:09 |
| chenying | yuval: https://review.openstack.org/#/c/448442/ I will recheck it. As I mention last time, it hit the issue about cinder-back (rpc exception causes the volume restore failed) | 11:12 |
| yuval | chenying: same with db bank: https://review.openstack.org/#/c/452085 | 11:12 |
| yuval | chenying: I think it could help to put the fullstack tests inside the implementation patch | 11:13 |
| chenying | yuval: the list by prefix in bank, I have addressed the comments, now in the abstract class of bank and the defualt implementment of swift bank, the list with prefix have not been used in karbor protection service. | 11:14 |
| yuval | chenying: if it is the contract of the bank plugin, each plugin needs to support it | 11:15 |
| yuval | chenying: maybe we can change that | 11:15 |
| chenying | yuval: OK I will recheck to let it OK. | 11:16 |
| chenying | yuval: if it is the contract of the bank plugin,NO I don't think so. Karbor protect service will not use a bank list call with prefix. You can see the comments:now the prefix parameter of bank's list_objects in checkpoint module is a actual a directory for swift bank. | 11:18 |
| chenying | yuval: is a actual a directory for swift bank, It is a exact match not a fuzzy matching. | 11:20 |
| yuval | chenying: in swift it works by actually querying prefix | 11:20 |
| yuval | chenying: but we can easily solve that, I think | 11:22 |
| chenying | yuval: bank list is called by checkpint and checkpoint_section, and in these usecases the prefix parameter is used for a actual a directory. | 11:24 |
| *** liujiong_lj has quit IRC | 11:25 | |
| chenying | yuval: We have not find a usecase that using a bank list call with a prefix fuzzy matching. | 11:26 |
| yuval | chenying: there is, in glance protection plugin | 11:26 |
| yuval | chenying: but I just noticed that instead of querying by prefix, it queries all bank objects and filter them by prefix | 11:26 |
| *** yamamoto has joined #openstack-karbor | 11:29 | |
| *** yamamoto_ has joined #openstack-karbor | 11:29 | |
| chenying | yuval: a prefix fuzzy matching in bank is not a good idea. That's my point. I know swift bank can support. It doesn't mean we must use it. | 11:32 |
| chenying | yuval: So what's your oppion about it? | 11:32 |
| *** yamamoto has quit IRC | 11:33 | |
| yuval | chenying: it is also currently used for checkpoint indexing | 11:34 |
| yuval | chenying: see comment here: https://review.openstack.org/#/c/441841 | 11:34 |
| *** yamamoto_ has quit IRC | 11:35 | |
| chenying | yuval: I see, it seem good. But I worry about how to support prefix in database plugin, it's module is relational database table, not a path. | 11:38 |
| openstackgerrit | chenying proposed openstack/karbor master: The file system based bank implementation https://review.openstack.org/441841 | 11:58 |
| chenying | yuval: https://review.openstack.org/441841 The file system based bank implementation | 11:58 |
| chenying | This patch has been updated as your suggestion. Can you see it? | 11:58 |
| openstackgerrit | chenying proposed openstack/karbor master: Add a fullstack test for the file system based bank https://review.openstack.org/448442 | 12:06 |
| *** yamamoto has joined #openstack-karbor | 12:09 | |
| chenying | yuval: about the database bank plugin:https://review.openstack.org/#/c/438267/ The fullstack is OK. Could you please review it? | 12:09 |
| yuval | chenying: would you mind check the actual value and not just the length in the test_list_objects here: https://review.openstack.org/#/c/441841/28/karbor/tests/unit/protection/test_file_system_bank_plugin.py | 12:10 |
| yuval | chenying: already commented there | 12:10 |
| *** zhurong has quit IRC | 12:16 | |
| chenying | yuval: https://review.openstack.org/#/c/441841/ This patch has been updated about the unit test. | 12:41 |
| openstackgerrit | chenying proposed openstack/karbor master: The file system based bank implementation https://review.openstack.org/441841 | 12:41 |
| chenying | yuval https://review.openstack.org/#/c/438267/ I have adressed you comments. | 12:48 |
| *** gouthamr has joined #openstack-karbor | 13:01 | |
| *** yamamoto has quit IRC | 13:02 | |
| *** yamamoto has joined #openstack-karbor | 13:21 | |
| *** yamamoto has quit IRC | 13:43 | |
| *** yamamoto has joined #openstack-karbor | 13:45 | |
| *** yamamoto has quit IRC | 13:45 | |
| *** yamamoto has joined #openstack-karbor | 14:07 | |
| *** openstackgerrit has quit IRC | 14:34 | |
| *** dimak_ has quit IRC | 14:38 | |
| *** openstackgerrit has joined #openstack-karbor | 14:58 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add spec for operation log RESTfull API https://review.openstack.org/446315 | 14:58 |
| *** openstackgerrit has quit IRC | 15:33 | |
| *** yamamoto has quit IRC | 15:51 | |
| *** openstackgerrit has joined #openstack-karbor | 15:52 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add database_bank fullstack https://review.openstack.org/452085 | 15:52 |
| *** yamamoto has joined #openstack-karbor | 15:52 | |
| *** yamamoto has quit IRC | 15:58 | |
| *** yamamoto has joined #openstack-karbor | 16:55 | |
| *** yamamoto has quit IRC | 17:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-karborclient master: Updated from global requirements https://review.openstack.org/467196 | 18:00 |
| *** dimak_ has joined #openstack-karbor | 18:04 | |
| *** dimak_ has quit IRC | 18:34 | |
| *** gouthamr has quit IRC | 22:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/469566 | 22:11 |
| *** gouthamr has joined #openstack-karbor | 22:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!