| *** liujiong has joined #openstack-karbor | 01:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/484552 | 01:47 |
|---|---|---|
| *** jiaopengju has joined #openstack-karbor | 02:13 | |
| *** liujiong has quit IRC | 02:19 | |
| openstackgerrit | Merged openstack/karbor-dashboard master: Drop MANIFEST.in - it's not needed by pbr https://review.openstack.org/480366 | 02:20 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/karbor master: Indicating the location tests directory in oslo_debug_helper https://review.openstack.org/443484 | 02:29 |
| *** yamamoto has joined #openstack-karbor | 02:41 | |
| *** liujiong has joined #openstack-karbor | 03:02 | |
| openstackgerrit | Pengju Jiao proposed openstack/karbor master: Increase s3 bank plugin https://review.openstack.org/482060 | 03:55 |
| openstackgerrit | Pengju Jiao proposed openstack/karbor master: Increase s3 bank plugin https://review.openstack.org/482060 | 04:14 |
| *** liujiong has quit IRC | 04:39 | |
| *** gouthamr has quit IRC | 05:25 | |
| openstackgerrit | Pengju Jiao proposed openstack/karbor master: Increase s3 bank plugin https://review.openstack.org/482060 | 05:52 |
| *** liujiong has joined #openstack-karbor | 05:56 | |
| *** liujiong has quit IRC | 06:26 | |
| openstackgerrit | Merged openstack/karbor master: Add choices field in config definition https://review.openstack.org/484292 | 07:07 |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Operation Engine: Trigger Multi Node Support (WIP) https://review.openstack.org/481106 | 07:16 |
| openstackgerrit | Pengju Jiao proposed openstack/karbor master: [WIP] Use full listing in bank plugin https://review.openstack.org/484319 | 07:26 |
| chenying | ping yuval | 07:44 |
| openstackgerrit | chenying proposed openstack/python-karborclient master: Add operation log API cmd to karborclient https://review.openstack.org/484653 | 07:44 |
| yuval | hey chenying | 07:44 |
| chenying | hi yuval Good morning. | 07:44 |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Operation Engine: Trigger Multi Node Support (WIP) https://review.openstack.org/481106 | 07:44 |
| yuval | chenying: good afternoon | 07:44 |
| chenying | hi yuval Could you help review the patches about spec operation log API? https://review.openstack.org/#/c/477075/ https://review.openstack.org/#/c/478459/ | 07:46 |
| yuval | chenying: yes | 07:46 |
| chenying | yuval The patch about operation log API for karborclient , I have submitted it. | 07:46 |
| yuval | chenying: saw that | 07:46 |
| chenying | yuval Thanks. | 07:47 |
| chenying | yuval Yestoday, the bug jiaobengju post, all the protectable plugins must be loaded when karbor protection service starting. we may need fix it. What's your oppion about it? | 07:49 |
| chenying | ping jiaopengju | 07:50 |
| jiaopengju | hi chenying | 07:50 |
| yuval | chenying: two options: let the user choose which plugins to load, and/or: try to load all of them, pass on failed plugins | 07:50 |
| jiaopengju | yuval chenying : IMO, let the user choose which plugins to load may be better | 07:51 |
| yuval | jiaopengju: elaborate? | 07:51 |
| chenying | yuval 'let the user choose' It mean that user or admin also need configure the protectable plugins which need be loaded in provider config file? | 07:52 |
| yuval | chenying: yes | 07:52 |
| chenying | yuval jiaopengju In the provider file, we also set the protection plugins. SO IMO, we only need load the protectable plugins which protection plugins support. Add another configureation about protecable plugins may be complicated. | 07:55 |
| yuval | chenying: the original idea was the other way around: if we notice a protectable without a matching protection plugin - the provider is invalid | 07:56 |
| jiaopengju | yuval: in the devstack environment, karbor do not require users install manila; in some of our openstack environments, we do no use manila. So I think it is a little convenient to let the users config what they need. | 07:57 |
| yuval | jiaopengju: just to make sure: you think we should let users choose by config, or try to load all plugins and just ignore failed ones? | 07:58 |
| chenying | yuval jiaopengju So maybe 'try to load all of them, pass on failed plugins' may be better. | 07:59 |
| chenying | yuval jiaopengju 'load all of them and ignore failed ones' means that karbor try to load all the plugins about available protectable resources. (when the service is enable, the protectable resources about this service will be loaded.) | 08:01 |
| jiaopengju | yuval chenying: ignore the failed ones and give some hint in the log to let users know. | 08:01 |
| jiaopengju | yuval chenying: as your explain, 'ignore' may be better | 08:02 |
| chenying | jiaopengju yes The logs will show the available and ignored protectable plugins. | 08:03 |
| yuval | chenying: jiaopengju: seems pretty straight forward: https://github.com/openstack/karbor/blob/master/karbor/services/protection/protectable_registry.py#L41-L44 | 08:03 |
| yuval | chenying: jiaopengju: can be useful to log all the protectables that we loaded successfully, and the failed ones | 08:04 |
| chenying | yuval agree. | 08:05 |
| jiaopengju | + | 08:06 |
| yuval | I'll back in about 15 minutes | 08:06 |
| jiaopengju | chenying: According to your suggestion yesterday, I removed the 'plugin=karbor-share-protection-plugin' from configuration file, the dashboard works well now. | 08:07 |
| chenying | jiaopengju So admin need know what services have installed, then he only need configure the available or needed protection plugins to provider config file. | 08:15 |
| chenying | jiaopengju Most of time admin aslo need choose which provider file need be loaded. Most of time, we don't need load all provider file that karbor provided. | 08:17 |
| jiaopengju | chenying agree | 08:17 |
| openstackgerrit | Merged openstack/karbor master: Fix warning in doc generating https://review.openstack.org/484268 | 08:23 |
| openstackgerrit | Pengju Jiao proposed openstack/karbor master: [WIP] Use full listing in bank plugin https://review.openstack.org/484319 | 08:24 |
| yuval | no need to choose provider files | 08:25 |
| yuval | we can add an "enabled" attributes to provider config | 08:25 |
| chenying | yuval jiaopengju : sound a good idea. add an "enabled" attributes | 08:27 |
| *** yamamoto has quit IRC | 08:36 | |
| *** yamamoto has joined #openstack-karbor | 09:01 | |
| *** yamamoto has quit IRC | 09:02 | |
| yuval | chenying: meeting? | 09:02 |
| chenying | yuval: OK | 09:03 |
| *** yamamoto has joined #openstack-karbor | 09:04 | |
| *** NatanBro has joined #openstack-karbor | 10:08 | |
| *** yamamoto has quit IRC | 10:18 | |
| *** yamamoto has joined #openstack-karbor | 10:28 | |
| *** yamamoto has quit IRC | 10:38 | |
| *** yamamoto has joined #openstack-karbor | 11:33 | |
| *** yamamoto has quit IRC | 12:04 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Operation Engine: Trigger Multi Node Support (WIP) https://review.openstack.org/481106 | 12:11 |
| *** yamamoto has joined #openstack-karbor | 12:19 | |
| *** gouthamr has joined #openstack-karbor | 13:57 | |
| *** NatanBro has quit IRC | 14:00 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Operation Engine: Trigger Multi Node Support (WIP) https://review.openstack.org/481106 | 14:08 |
| *** yamamoto has quit IRC | 15:17 | |
| *** yamamoto has joined #openstack-karbor | 15:21 | |
| openstackgerrit | Pengju Jiao proposed openstack/karbor master: Use full listing in bank plugin https://review.openstack.org/484319 | 15:28 |
| *** yamamoto has quit IRC | 15:29 | |
| *** jiaopengju has quit IRC | 15:32 | |
| *** yamamoto has joined #openstack-karbor | 16:29 | |
| *** yamamoto has quit IRC | 16:37 | |
| *** yamamoto has joined #openstack-karbor | 17:07 | |
| *** yamamoto has quit IRC | 17:12 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Operation Engine: Trigger Multi Node Support (WIP) https://review.openstack.org/481106 | 17:28 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/484552 | 19:35 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor-dashboard master: Updated from global requirements https://review.openstack.org/477943 | 19:35 |
| *** gouthamr has quit IRC | 21:53 | |
| *** gouthamr has joined #openstack-karbor | 22:29 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!