| *** jiaopengju has joined #openstack-karbor | 00:46 | |
| *** zengchen has quit IRC | 01:43 | |
| *** zengchen has joined #openstack-karbor | 01:44 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add operation_log API for karbor https://review.openstack.org/478459 | 02:04 |
|---|---|---|
| *** liujiong has joined #openstack-karbor | 02:09 | |
| *** liujiong has quit IRC | 02:18 | |
| *** liujiong has joined #openstack-karbor | 02:20 | |
| *** liujiong has quit IRC | 02:25 | |
| *** liujiong has joined #openstack-karbor | 02:28 | |
| *** liujiong has quit IRC | 02:33 | |
| *** gouthamr has quit IRC | 02:46 | |
| *** yushb has joined #openstack-karbor | 03:07 | |
| *** yushb has quit IRC | 03:25 | |
| *** yushb has joined #openstack-karbor | 03:26 | |
| *** yushb has quit IRC | 03:30 | |
| *** jiaopengju has quit IRC | 03:35 | |
| *** jiaopengju has joined #openstack-karbor | 03:38 | |
| *** yamamoto has quit IRC | 03:45 | |
| *** yamamoto has joined #openstack-karbor | 04:00 | |
| *** liujiong has joined #openstack-karbor | 06:30 | |
| jiaopengju | hi, please help to review this patch https://review.openstack.org/#/c/484319/ | 06:37 |
| jiaopengju | thank you | 06:41 |
| *** yamamoto has quit IRC | 08:33 | |
| *** yamamoto has joined #openstack-karbor | 08:46 | |
| *** yamamoto has quit IRC | 08:50 | |
| *** yamamoto has joined #openstack-karbor | 08:57 | |
| *** yamamoto has quit IRC | 09:05 | |
| openstackgerrit | Merged openstack/karbor master: FS Bank: raise correct exceptions https://review.openstack.org/486615 | 09:07 |
| openstackgerrit | Merged openstack/karbor master: FS Bank: change umask to 022 https://review.openstack.org/486592 | 09:07 |
| *** yamamoto has joined #openstack-karbor | 09:11 | |
| *** yamamoto has quit IRC | 09:28 | |
| *** yamamoto has joined #openstack-karbor | 09:36 | |
| *** yamamoto has quit IRC | 09:40 | |
| *** yamamoto has joined #openstack-karbor | 09:44 | |
| *** yamamoto has quit IRC | 09:48 | |
| *** jiaopengju has quit IRC | 10:01 | |
| *** liujiong has quit IRC | 10:08 | |
| *** yamamoto has joined #openstack-karbor | 10:13 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** openstackgerrit has joined #openstack-karbor | 12:13 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Docs: enable warning-is-error, fix errors https://review.openstack.org/487027 | 12:13 |
| *** yamamoto has quit IRC | 12:18 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Docs: enable warning-is-error, fix errors https://review.openstack.org/487027 | 12:23 |
| *** gouthamr has joined #openstack-karbor | 12:26 | |
| *** yamamoto has joined #openstack-karbor | 12:36 | |
| *** yamamoto has quit IRC | 13:12 | |
| *** c00281451_ has joined #openstack-karbor | 13:32 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Docs: Arrange Install Guide https://review.openstack.org/487056 | 13:33 |
| *** zengchen has quit IRC | 13:35 | |
| *** jiaopengju has joined #openstack-karbor | 13:59 | |
| jiaopengju | ping yuval | 13:59 |
| yuval | hey jiaopengju | 14:00 |
| jiaopengju | hi yuval, I saw your comments | 14:00 |
| yuval | jiaopengju: yep | 14:00 |
| jiaopengju | you mean we could remove the pagination? | 14:00 |
| yuval | For checkpoints no. For banks - maybe | 14:01 |
| yuval | The two options for banks - remove pagination, or let bank plugin manage that, even if the backend doesn't support natively | 14:02 |
| jiaopengju | I think 'let bank plugin manage that' may be better, it bring a little change to the present | 14:03 |
| jiaopengju | In that patch, use full_listing is reference to python-swiftclient and boto3(botocore do not have this) | 14:05 |
| jiaopengju | IMO, it may not be a good way to implement 'get all objects' in image_protection_plugin. | 14:08 |
| jiaopengju | yuval what do you think about it? | 14:09 |
| yuval | jiaopengju: the questions is - are there bank back ends which will run into problems while implementing marker, limit, sort, etc | 14:09 |
| jiaopengju | yuval: May be not. The implementing is in the bank, not back ends. For now, swift supports all parameters, s3 and filedo not support sort_dir(only dictionary order) | 14:13 |
| yuval | jiaopengju: that means that the bank plugin is supposed to handle that | 14:13 |
| yuval | jiaopengju: or remove the sort params | 14:14 |
| jiaopengju | yuval: yes. I think we can remove sort_dir and retain other parameters | 14:14 |
| jiaopengju | yuval: yes | 14:14 |
| yuval | jiaopengju: so, no full_listing? | 14:14 |
| jiaopengju | yuval: IMO, full_listing is usefull | 14:15 |
| yuval | jiaopengju: how about make full_listing the default, unless someone uses the limit param? | 14:15 |
| jiaopengju | yuval: yes. My idea is like yours, maybe my implementation has some problems. By default, I set full_listing 'True' | 14:17 |
| *** yamamoto has joined #openstack-karbor | 14:17 | |
| yuval | jiaopengju: if limit=None -> do a full listing. if limit is a number, use limit. How about that? | 14:18 |
| jiaopengju | If the caller set limit to 2000(bigger than s3 default), the bank_plugin return 2000 objects? | 14:19 |
| jiaopengju | or set to 10001 (bigger than swift default value) | 14:20 |
| jiaopengju | or we can use limit as this: if limit is a number, we use it as the back ends use it? If the limit is bigger than s3 or swift default, just use the swift or s3 default value? | 14:24 |
| jiaopengju | yuval: I agree with you of 'if limit=None -> do a full listing.' | 14:25 |
| *** yamamoto has quit IRC | 14:25 | |
| yuval | jiaopengju: yes | 14:26 |
| jiaopengju | yuval: ok. I will change my patch soon | 14:27 |
| yuval | jiaopengju: thanks :) | 14:28 |
| jiaopengju | yuval: thanks for your suggestion and review. | 14:28 |
| yuval | jiaopengju: you are doing great work, much appreciated :) | 14:29 |
| jiaopengju | yuval :) | 14:29 |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Docs: Arrange Configuration Guide https://review.openstack.org/487109 | 14:36 |
| *** jiaopengju has quit IRC | 15:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/484552 | 15:34 |
| *** yuval has quit IRC | 16:10 | |
| *** yuval has joined #openstack-karbor | 16:12 | |
| openstackgerrit | Yuval Brik proposed openstack/karbor master: Docs: Arrange Configuration Guide https://review.openstack.org/487109 | 16:14 |
| *** gouthamr has quit IRC | 21:01 | |
| *** yamamoto_ has joined #openstack-karbor | 21:07 | |
| *** gouthamr has joined #openstack-karbor | 21:23 | |
| *** gouthamr has quit IRC | 21:58 | |
| *** yamamoto_ has quit IRC | 22:05 | |
| *** yamamoto has joined #openstack-karbor | 22:09 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!