| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/517475 | 00:47 |
|---|---|---|
| *** jiaopengju has joined #openstack-karbor | 00:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/517475 | 00:52 |
| *** zhurong has joined #openstack-karbor | 00:55 | |
| *** zengyingzhe has joined #openstack-karbor | 00:58 | |
| *** yamamoto has quit IRC | 01:04 | |
| *** gouthamr has quit IRC | 01:08 | |
| *** liujiong has joined #openstack-karbor | 01:34 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add API controller for the quotas of Karbor https://review.openstack.org/517198 | 01:38 |
| *** yamamoto has joined #openstack-karbor | 01:53 | |
| *** yamamoto has quit IRC | 01:54 | |
| *** yamamoto has joined #openstack-karbor | 01:56 | |
| *** yamamoto has quit IRC | 02:02 | |
| *** gengchc2_ has joined #openstack-karbor | 02:15 | |
| gengchc2_ | ping chenying | 02:16 |
| gengchc2_ | ping jiaopengju | 02:17 |
| jiaopengju | hi gengchc2_ | 02:17 |
| gengchc2_ | I remove retention_protect from common/constants.py | 02:18 |
| gengchc2_ | and add retention_operation.py ? | 02:19 |
| gengchc2_ | Can I merge retention_operation.py and test_retention_operation.py to 501611 ? | 02:21 |
| jiaopengju | As chenying wrote in the comments, patch 501611 will be abandoned | 02:25 |
| gengchc2_ | ok | 02:25 |
| openstackgerrit | gengchc2 proposed openstack/karbor master: adding more protection parameters retention period(add retention_protect) https://review.openstack.org/517155 | 02:26 |
| *** Jeffrey4l has quit IRC | 02:26 | |
| chenying | hi gengchc2 | 02:27 |
| *** yamamoto has joined #openstack-karbor | 02:27 | |
| *** Jeffrey4l has joined #openstack-karbor | 02:29 | |
| *** zhurong has quit IRC | 02:30 | |
| gengchc2_ | Will patch 501611 be abandoned? or Can I merge retention_operation.py and test_retention_operation.py to 501611 ? | 02:32 |
| *** zhurong has joined #openstack-karbor | 02:40 | |
| chenying | hi gengchc2_ What the relationship between these two patch? | 03:00 |
| chenying | If the the patch about retention_operation also need the change in the patch 501611? you may need merge. | 03:02 |
| chenying | hi jiaopengju Could you please review this patch? https://review.openstack.org/#/c/517198/ The py35 job has passed. | 03:03 |
| jiaopengju | hi chengying: I am reviewing it, but not finished | 03:05 |
| gengchc2_ | 501611 is old without retention_protect, I want to abandon it. 517155 is new with retention_protect. | 03:13 |
| chenying | gengchc2_: I see. | 03:36 |
| *** yamamoto has quit IRC | 03:40 | |
| openstackgerrit | chenying proposed openstack/karbor master: Add API controller for the quotas of Karbor https://review.openstack.org/517198 | 03:51 |
| *** yamamoto has joined #openstack-karbor | 04:35 | |
| *** zhurong has quit IRC | 04:43 | |
| *** yamamoto has quit IRC | 05:25 | |
| *** yamamoto has joined #openstack-karbor | 05:28 | |
| *** lihi has quit IRC | 05:33 | |
| *** yamamoto has quit IRC | 05:33 | |
| *** lihi has joined #openstack-karbor | 05:34 | |
| *** zhurong has joined #openstack-karbor | 05:55 | |
| *** yamamoto has joined #openstack-karbor | 06:34 | |
| *** yamamoto has quit IRC | 06:53 | |
| openstackgerrit | gengchc2 proposed openstack/karbor master: adding more protection parameters retention period(add retention_protect) https://review.openstack.org/517155 | 07:14 |
| *** zhurong has quit IRC | 07:36 | |
| jiaopengju | ping chenying gengchc2_ | 08:37 |
| *** gengchc2_ has quit IRC | 08:38 | |
| openstackgerrit | Merged openstack/karbor master: Add API controller for the quotas of Karbor https://review.openstack.org/517198 | 08:44 |
| *** dims has quit IRC | 08:46 | |
| *** dims has joined #openstack-karbor | 08:48 | |
| openstackgerrit | gengchc2 proposed openstack/karbor master: adding more protection parameters retention period https://review.openstack.org/517155 | 08:49 |
| chenying | hi jiaopengju | 09:50 |
| jiaopengju | hi chenying, do you see my comments in this patch: https://review.openstack.org/#/c/501611/ | 09:51 |
| jiaopengju | https://review.openstack.org/#/c/501611/5/karbor/services/operationengine/operations/protect_operation.py@111 | 09:52 |
| jiaopengju | chenying: created_at in karbor is a date, not a time, so if users have more than one checkpoints, this may delete the checkpoint that users do not want to delete. | 09:53 |
| jiaopengju | for example: | 09:53 |
| jiaopengju | User A created 3 checkpoints in day1, 2 checkpoints in day2, day1 < day2. | 09:53 |
| jiaopengju | When he want to make max_backups = 4, which one of the 3 checkpoints in day1 will be deleted? | 09:53 |
| jiaopengju | created_at in karbor is a date, '%Y-%m-%d, not a time. so we can not know which checkpoint was created earlier in day1. | 09:53 |
| chenying | jiaopengju: gengchc2 said that he will abandon this one. So we can review the new one. we can discuss it in the new patch. | 09:54 |
| jiaopengju | chenying: the new patch is same with the old one | 09:55 |
| chenying | jiaopengju: Let me see. | 09:55 |
| jiaopengju | chenying: ok | 09:55 |
| chenying | created_at in karbor is a date, not a time you mean that created_at only show the year month day? It not show the hour about the time? | 09:57 |
| jiaopengju | chenying: yes | 09:59 |
| jiaopengju | chenying: so we have no way to know which one is older in one day | 09:59 |
| chenying | jiaoengju: The checkpoints have been sorted by the date. So the limited checkpoints will be deleted by the order. | 10:03 |
| jiaopengju | chenying: I mean in one day, multi checkpoints. | 10:04 |
| chenying | jiaopengju: I will leave the office now. So we can discuss it next time. | 10:04 |
| jiaopengju | chenying: ok | 10:04 |
| jiaopengju | chenying: see you | 10:05 |
| *** jiaopengju has quit IRC | 10:06 | |
| *** liujiong has quit IRC | 10:06 | |
| *** jemmy has quit IRC | 10:14 | |
| *** jemmy has joined #openstack-karbor | 10:16 | |
| *** yamamoto has joined #openstack-karbor | 12:37 | |
| *** yamamoto has quit IRC | 13:13 | |
| *** yamamoto has joined #openstack-karbor | 13:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/517475 | 13:42 |
| *** yamamoto has quit IRC | 16:19 | |
| *** gouthamr has joined #openstack-karbor | 17:18 | |
| *** yamamoto has joined #openstack-karbor | 17:20 | |
| *** gouthamr_ has joined #openstack-karbor | 17:24 | |
| *** gouthamr has quit IRC | 17:27 | |
| *** yamamoto has quit IRC | 17:28 | |
| *** gouthamr_ is now known as gouthamr | 17:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/517475 | 17:47 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/karbor master: Updated from global requirements https://review.openstack.org/517475 | 17:51 |
| *** gouthamr has quit IRC | 23:40 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!