| AJaeger | jiaopengju: there's no need to rebase changes like 672091, Zuul always rebases before running tests ;) | 05:27 |
|---|---|---|
| AJaeger | jiaopengju: could you help merging 672091 , please? | 05:27 |
| jiaopengju | AJaeger: the fullstack test failed. BTW, I think this is not a urgent patch. I will merge it after the fullstack pass | 05:50 |
| openstackgerrit | Jiao Pengju proposed openstack/karbor master: Dropping the py35 testing https://review.opendev.org/652390 | 05:55 |
| openstackgerrit | Merged openstack/karbor-dashboard master: Sync Sphinx requirement https://review.opendev.org/662664 | 06:00 |
| jiaopengju | hi, anyone here? | 09:18 |
| *** liushuai has joined #openstack-karbor | 09:24 | |
| jiaopengju | hi liushuai | 09:25 |
| liushuai | hi pengju | 09:25 |
| jiaopengju | let's start meeting | 09:26 |
| jiaopengju | #startmeeting karbor | 09:26 |
| openstack | Meeting started Tue Jul 30 09:26:08 2019 UTC and is due to finish in 60 minutes. The chair is jiaopengju. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:26 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:26 |
| *** openstack changes topic to " (Meeting topic: karbor)" | 09:26 | |
| openstack | The meeting name has been set to 'karbor' | 09:26 |
| jiaopengju | #topic code review | 09:26 |
| *** openstack changes topic to "code review (Meeting topic: karbor)" | 09:26 | |
| jiaopengju | The spec file of bp 'Add support for image boot server backup with data' has been merged | 09:26 |
| jiaopengju | And the implement patch is ready, you can review it. https://review.opendev.org/#/c/673157/ | 09:27 |
| liushuai | I will review as soon as possible. | 09:28 |
| jiaopengju | After this patch been merged, we should do some refactor of the method get_xxx_status | 09:29 |
| jiaopengju | in multi plugins, it have the related function. it's better to move them together, so that we can reduce the duplicate code | 09:30 |
| jiaopengju | def get_server_status(nova_client, server_id): | 09:31 |
| jiaopengju | LOG.debug('Polling server (server_id: %s)', server_id) | 09:31 |
| jiaopengju | try: | 09:31 |
| jiaopengju | server = nova_client.servers.get(server_id) | 09:31 |
| jiaopengju | status = server.status | 09:31 |
| jiaopengju | except exception.NotFound: | 09:31 |
| jiaopengju | status = 'not-found' | 09:32 |
| jiaopengju | LOG.debug('Polled server (server_id: %s) status: %s', server_id, status) | 09:32 |
| jiaopengju | return status | 09:32 |
| jiaopengju | for example | 09:32 |
| jiaopengju | do you agree? liushuai :) | 09:33 |
| liushuai | i agree | 09:33 |
| jiaopengju | haha | 09:33 |
| jiaopengju | it's good | 09:33 |
| jiaopengju | so go on next | 09:34 |
| jiaopengju | #topic Not particularly important patches | 09:35 |
| *** openstack changes topic to "Not particularly important patches (Meeting topic: karbor)" | 09:35 | |
| jiaopengju | Recently, I review many patches about spelling errors, web link errors etc, it's very confused, but it seems we can not avoid them | 09:36 |
| jiaopengju | I think we should tell the 'contributor' do more work about these in one patch, not in multi patches. Do you have any suggestions? | 09:38 |
| *** liushuai has quit IRC | 09:40 | |
| *** liushuai has joined #openstack-karbor | 09:40 | |
| liushuai | sorry for disconnect | 09:41 |
| jiaopengju | it's ok | 09:41 |
| liushuai | The network is not stable | 09:41 |
| jiaopengju | repeat my words: Recently, I review many patches about spelling errors, web link errors etc, it's very confused, but it seems we can not avoid them | 09:42 |
| jiaopengju | I think we should tell the 'contributor' do more work about these in one patch, not in multi patches. Do you have any suggestions? | 09:42 |
| liushuai | yes, one type of error should in one patch | 09:43 |
| jiaopengju | ok, please let the contributors know if you review any of these patch. | 09:45 |
| jiaopengju | do you have any topics to share or disscuss? | 09:45 |
| liushuai | i do not hav | 09:45 |
| liushuai | have | 09:46 |
| jiaopengju | #endmeeting | 09:46 |
| *** openstack changes topic to " (Meeting topic: karbor)" | 09:46 | |
| openstack | Meeting ended Tue Jul 30 09:46:10 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:46 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/karbor/2019/karbor.2019-07-30-09.26.html | 09:46 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/karbor/2019/karbor.2019-07-30-09.26.txt | 09:46 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/karbor/2019/karbor.2019-07-30-09.26.log.html | 09:46 |
| *** liushuai has quit IRC | 09:53 | |
| *** goldyfruit has joined #openstack-karbor | 13:24 | |
| *** goldyfruit has quit IRC | 16:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!