*** leseb has joined #openstack-keystone | 00:16 | |
*** lnxnut has joined #openstack-keystone | 00:35 | |
*** lnxnut has quit IRC | 00:40 | |
*** morganfainberg_Z is now known as morganfainberg | 00:47 | |
*** dolphm_503 is now known as dolphm | 00:50 | |
*** dolphm is now known as dolphm_503 | 01:00 | |
*** dolphm_503 is now known as dolphm | 01:01 | |
*** dolphm is now known as dolphm_503 | 01:11 | |
*** rwsu has joined #openstack-keystone | 01:20 | |
*** lnxnut has joined #openstack-keystone | 01:35 | |
*** lnxnut has quit IRC | 01:41 | |
*** dolphm_503 is now known as dolphm | 02:02 | |
*** dolphm is now known as dolphm_503 | 02:12 | |
*** leseb has quit IRC | 02:20 | |
*** quarkGluonPlasma has joined #openstack-keystone | 02:31 | |
*** lnxnut has joined #openstack-keystone | 02:35 | |
*** lnxnut has quit IRC | 02:40 | |
*** dolphm_503 is now known as dolphm | 03:02 | |
*** rwsu has quit IRC | 03:06 | |
*** dolphm is now known as dolphm_503 | 03:14 | |
*** leseb has joined #openstack-keystone | 03:31 | |
*** lnxnut has joined #openstack-keystone | 03:35 | |
*** leseb has quit IRC | 03:36 | |
*** thedodd has joined #openstack-keystone | 03:36 | |
*** thedodd has quit IRC | 03:37 | |
*** lnxnut has quit IRC | 03:40 | |
*** lnxnut has joined #openstack-keystone | 03:57 | |
*** sudorandom has quit IRC | 03:59 | |
*** sudorandom has joined #openstack-keystone | 04:00 | |
*** dolphm_503 is now known as dolphm | 04:05 | |
*** dolphm is now known as dolphm_503 | 04:15 | |
*** bvandenh has joined #openstack-keystone | 04:22 | |
*** dstanek has quit IRC | 04:32 | |
*** bvandenh has quit IRC | 04:41 | |
*** mspreitz has joined #openstack-keystone | 04:58 | |
*** lnxnut has quit IRC | 04:59 | |
*** stevemar has joined #openstack-keystone | 05:02 | |
*** ChanServ sets mode: +v stevemar | 05:02 | |
*** dolphm_503 is now known as dolphm | 05:06 | |
*** david_lyle_ has quit IRC | 05:11 | |
*** david_lyle_ has joined #openstack-keystone | 05:12 | |
*** david_lyle_ is now known as david-lyle | 05:13 | |
*** dolphm is now known as dolphm_503 | 05:15 | |
*** thedodd has joined #openstack-keystone | 05:22 | |
*** dolphm_503 is now known as dolphm | 06:07 | |
*** lari_ has left #openstack-keystone | 06:11 | |
*** dolphm is now known as dolphm_503 | 06:16 | |
*** gokrokve has quit IRC | 06:21 | |
*** gokrokve has joined #openstack-keystone | 06:28 | |
morganfainberg | stevemar you here? | 06:32 |
---|---|---|
stevemar | morganfainberg, ahoy hoy | 06:54 |
morganfainberg | stevemar, i think i figured it out | 06:54 |
morganfainberg | but... | 06:54 |
morganfainberg | wow | 06:54 |
morganfainberg | you know we have config options defined that are _only_ used for test purposes? | 06:54 |
stevemar | morganfainberg, oh? | 06:55 |
morganfainberg | sec | 06:55 |
morganfainberg | https://review.openstack.org/77401 | 06:56 |
morganfainberg | stevemar, ^ | 06:57 |
stevemar | morganfainberg, taking a look at it now, this one seems like it could be refactored https://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample#L302 | 06:57 |
*** gokrokve has quit IRC | 06:57 | |
morganfainberg | stevemar, probably | 06:57 |
stevemar | wow | 06:58 |
morganfainberg | trying to add the last of the help strings... | 06:58 |
morganfainberg | and ... i was like "WAIT WHAT THE ...." | 06:58 |
*** dolphm_503 is now known as dolphm | 07:08 | |
stevemar | morganfainberg, i'm out for the night | 07:11 |
stevemar | morganfainberg, see ya later | 07:11 |
morganfainberg | see ya | 07:11 |
*** stevemar has quit IRC | 07:17 | |
*** dolphm is now known as dolphm_503 | 07:17 | |
*** thedodd has quit IRC | 07:18 | |
*** gokrokve has joined #openstack-keystone | 07:28 | |
*** gokrokve has quit IRC | 07:33 | |
*** david-lyle has quit IRC | 07:36 | |
*** amerine has quit IRC | 07:47 | |
*** bvandenh has joined #openstack-keystone | 07:50 | |
*** mspreitz has left #openstack-keystone | 07:56 | |
*** dolphm_503 is now known as dolphm | 08:08 | |
*** dolphm is now known as dolphm_503 | 08:18 | |
*** gokrokve has joined #openstack-keystone | 08:29 | |
*** gokrokve has quit IRC | 08:34 | |
*** dolphm_503 is now known as dolphm | 09:09 | |
*** morganfainberg is now known as morganfainberg_Z | 09:15 | |
*** dolphm is now known as dolphm_503 | 09:19 | |
*** gokrokve has joined #openstack-keystone | 09:30 | |
*** gokrokve has quit IRC | 09:35 | |
*** dolphm_503 is now known as dolphm | 10:10 | |
*** dolphm is now known as dolphm_503 | 10:19 | |
*** gokrokve has joined #openstack-keystone | 10:29 | |
*** gokrokve_ has joined #openstack-keystone | 10:31 | |
*** gokrokve has quit IRC | 10:34 | |
*** gokrokve_ has quit IRC | 10:35 | |
*** dolphm_503 is now known as dolphm | 11:10 | |
*** dolphm is now known as dolphm_503 | 11:20 | |
*** gokrokve has joined #openstack-keystone | 11:28 | |
*** gokrokve has quit IRC | 11:33 | |
*** dolphm_503 is now known as dolphm | 12:11 | |
*** dolphm is now known as dolphm_503 | 12:21 | |
*** gokrokve has joined #openstack-keystone | 12:28 | |
*** gokrokve has quit IRC | 12:33 | |
*** dolphm_503 is now known as dolphm | 13:12 | |
*** dolphm is now known as dolphm_503 | 13:22 | |
*** bvandenh has quit IRC | 13:28 | |
*** gokrokve has joined #openstack-keystone | 13:28 | |
*** achampion has quit IRC | 13:32 | |
*** gokrokve has quit IRC | 13:33 | |
*** david-lyle has joined #openstack-keystone | 13:33 | |
*** leseb has joined #openstack-keystone | 13:34 | |
*** david-lyle has quit IRC | 13:38 | |
*** achampion has joined #openstack-keystone | 13:59 | |
*** achampion has quit IRC | 14:06 | |
*** dolphm_503 is now known as dolphm | 14:13 | |
*** dolphm is now known as dolphm_503 | 14:22 | |
*** gokrokve has joined #openstack-keystone | 14:28 | |
*** achampion has joined #openstack-keystone | 14:31 | |
*** gokrokve has quit IRC | 14:33 | |
*** achampion has quit IRC | 14:36 | |
*** leseb has quit IRC | 14:47 | |
*** leseb has joined #openstack-keystone | 14:48 | |
*** leseb has quit IRC | 14:52 | |
*** achampion has joined #openstack-keystone | 15:07 | |
*** dolphm_503 is now known as dolphm | 15:13 | |
*** leseb has joined #openstack-keystone | 15:18 | |
*** dolphm is now known as dolphm_503 | 15:23 | |
*** gokrokve has joined #openstack-keystone | 15:28 | |
*** gokrokve has quit IRC | 15:33 | |
*** leseb has quit IRC | 16:02 | |
*** dstanek has joined #openstack-keystone | 16:04 | |
*** ChanServ sets mode: +v dstanek | 16:04 | |
*** dolphm_503 is now known as dolphm | 16:14 | |
*** dolphm is now known as dolphm_503 | 16:24 | |
*** gokrokve has joined #openstack-keystone | 16:28 | |
*** gokrokve has quit IRC | 16:33 | |
*** leseb has joined #openstack-keystone | 16:59 | |
*** leseb has quit IRC | 17:04 | |
*** dolphm_503 is now known as dolphm | 17:15 | |
*** dolphm is now known as dolphm_503 | 17:25 | |
*** leseb has joined #openstack-keystone | 17:27 | |
*** gokrokve has joined #openstack-keystone | 17:28 | |
*** leseb has quit IRC | 17:29 | |
*** leseb has joined #openstack-keystone | 17:29 | |
*** gokrokve has quit IRC | 17:33 | |
*** leseb has quit IRC | 17:34 | |
*** gokrokve has joined #openstack-keystone | 17:52 | |
*** lbragstad has quit IRC | 17:59 | |
*** wchrisj has joined #openstack-keystone | 18:14 | |
*** lbragstad has joined #openstack-keystone | 18:14 | |
*** dolphm_503 is now known as dolphm | 18:16 | |
*** dolphm is now known as dolphm_503 | 18:25 | |
*** wchrisj has quit IRC | 18:58 | |
*** dolphm_503 is now known as dolphm | 19:16 | |
*** leseb has joined #openstack-keystone | 19:17 | |
*** david-lyle has joined #openstack-keystone | 19:21 | |
*** leseb has quit IRC | 19:22 | |
*** gokrokve has quit IRC | 19:22 | |
*** dolphm is now known as dolphm_503 | 19:26 | |
*** gokrokve has joined #openstack-keystone | 19:38 | |
*** dolphm_503 is now known as dolphm | 20:17 | |
*** gokrokve has quit IRC | 20:21 | |
*** gokrokve_ has joined #openstack-keystone | 20:23 | |
*** dolphm is now known as dolphm_503 | 20:27 | |
*** leseb has joined #openstack-keystone | 20:28 | |
*** gokrokve_ has quit IRC | 20:31 | |
*** leseb has quit IRC | 20:32 | |
*** morganfainberg_Z is now known as morganfainberg | 20:33 | |
morganfainberg | dstanek, https://review.openstack.org/#/c/77404/ (that and the patch before it) last of the warnings for config sample generation will be gone | 20:35 |
*** wchrisj has joined #openstack-keystone | 20:59 | |
*** dolphm_503 is now known as dolphm | 21:18 | |
*** wchrisj has quit IRC | 21:22 | |
*** gokrokve has joined #openstack-keystone | 21:31 | |
*** gokrokve has quit IRC | 21:36 | |
*** wchrisj has joined #openstack-keystone | 21:41 | |
*** amerine has joined #openstack-keystone | 21:45 | |
*** leseb has joined #openstack-keystone | 22:04 | |
*** wchrisj has quit IRC | 22:06 | |
*** gokrokve has joined #openstack-keystone | 22:23 | |
*** gokrokve has quit IRC | 22:27 | |
ayoung | morganfainberg, could you take a look at the caching/locking portion of the latest version of the revoke patch https://review.openstack.org/#/c/55908/71/keystone/contrib/revoke/core.py | 22:29 |
ayoung | line 65 | 22:29 |
morganfainberg | ayoung, sure. looking now. | 22:29 |
ayoung | thanks | 22:29 |
ayoung | I'm just using the KVS backend as a lock, not to store any data | 22:29 |
morganfainberg | ayoung, ah | 22:30 |
*** tellesnobrega has quit IRC | 22:31 | |
morganfainberg | yeah locking looks ok. let me check 1 thing reaaaaally quickly, though i don't think it matters | 22:31 |
morganfainberg | ayoung, that _should_ work | 22:32 |
morganfainberg | i haven't done extensive testing on the threading.lock stuff | 22:33 |
morganfainberg | ayoung, but as long as threading.lock is patched as expected, you should have no issues | 22:33 |
morganfainberg | i am going to guess if threading.lock didn't patch, we'd have massive other issues | 22:33 |
morganfainberg | and across multiple processes, it doesn't really matter if you're sharing state. | 22:34 |
ayoung | Heh, yeah. I could potentially stick the tree object in the cache, and always "get" it for the memcached use case... | 22:36 |
ayoung | no need to do that for in memory, though | 22:36 |
morganfainberg | yep | 22:42 |
morganfainberg | and memcache would cause pickle of the tree... is there a real benefit to that? | 22:42 |
morganfainberg | or hinderance in that case | 22:42 |
morganfainberg | i think thats a good middleground to have. | 22:43 |
morganfainberg | (what you've implemented) | 22:43 |
morganfainberg | ayoung, i'm working on collapsing our SQL migrations (main migrate repo) down | 22:45 |
morganfainberg | ayoung, any reason we shouldn't do the same thing as nova? | 22:45 |
morganfainberg | ayoung, icehouse assumes you start at havana ? | 22:45 |
ayoung | that is good, but can be donbe post I3, right? | 22:46 |
ayoung | memcached might be a decen performacne tune for apache, but that can wait | 22:46 |
ayoung | gonna make a packy run as the call it here in Mass...wine for dinner. Back in a few | 22:47 |
morganfainberg | ayoung, aye | 22:47 |
morganfainberg | ayoung, i don't want to do it pre I3 | 22:48 |
*** stevemar has joined #openstack-keystone | 23:00 | |
*** ChanServ sets mode: +v stevemar | 23:00 | |
ayoung | morganfainberg, one other difference in the patch which might be subtle: this change tests revocations on the v2 api https://review.openstack.org/#/c/55908/71/keystone/tests/test_content_types.py | 23:05 |
ayoung | I moved all of the token "scraping" in to model.py as well...It turns out I had missed defaulting the oauth values for v2 | 23:05 |
ayoung | caught that in a tempest run, though | 23:06 |
ayoung | https://review.openstack.org/#/c/55908/71/keystone/contrib/revoke/model.py line 207 on down. I'll probably end up moving all of that code into the client so Auth Token middleware can use it, but it will have to start off with a duplication. | 23:07 |
*** morganfainberg is now known as morganfainberg_Z | 23:09 | |
*** jamielennox|away is now known as jamielennox | 23:18 | |
*** ayoung has quit IRC | 23:20 | |
*** ayoung has joined #openstack-keystone | 23:25 | |
ayoung | jamielennox, I'd greatly appreciate it if you could take a swipe at https://review.openstack.org/#/c/55908/ as I want to get it in for Tuesday. | 23:26 |
*** dolphm is now known as dolphm_503 | 23:27 | |
*** david-lyle has quit IRC | 23:29 | |
*** topol has joined #openstack-keystone | 23:32 | |
*** david-lyle has joined #openstack-keystone | 23:34 | |
*** leseb has quit IRC | 23:34 | |
jamielennox | ayoung: sure | 23:39 |
jamielennox | ayoung: wow, monster | 23:39 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!